scottk/wlan-cloud-rrm
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/wlan-cloud-rrm.git synced 2025-11-01 19:17:53 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

Fix several compile errors/warnings (#126)

Browse Source
This commit is contained in:
Jeffrey Han
2022-11-11 11:07:12 -08:00
committed by GitHub
parent c94c31cb63
commit 05c36a535f
4 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib-cloudsdk/src/main/java/com/facebook/openwifi/cloudsdk/AggregatedState.java
View File

@@ -12,6 +12,7 @@ import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.Objects; import java.util.Objects;
import com.facebook.openwifi.cloudsdk.models.ap.State;
import com.facebook.openwifi.cloudsdk.models.ap.State.Interface.Counters; import com.facebook.openwifi.cloudsdk.models.ap.State.Interface.Counters;
import com.facebook.openwifi.cloudsdk.models.ap.State.Interface.SSID.Association; import com.facebook.openwifi.cloudsdk.models.ap.State.Interface.SSID.Association;
import com.google.gson.JsonObject; import com.google.gson.JsonObject;

5
owrrm/src/main/java/com/facebook/openwifi/rrm/optimizers/clientsteering/SingleAPBandSteering.java
View File

@@ -15,6 +15,7 @@ import java.util.Map;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import com.facebook.openwifi.cloudsdk.StateInfo;
import com.facebook.openwifi.cloudsdk.UCentralConstants; import com.facebook.openwifi.cloudsdk.UCentralConstants;
import com.facebook.openwifi.cloudsdk.models.ap.Capabilities; import com.facebook.openwifi.cloudsdk.models.ap.Capabilities;
import com.facebook.openwifi.cloudsdk.models.ap.State; import com.facebook.openwifi.cloudsdk.models.ap.State;
@@ -132,13 +133,13 @@ public class SingleAPBandSteering extends ClientSteeringOptimizer {
Map<String, Map<String, String>> apClientActionMap = new HashMap<>(); Map<String, Map<String, String>> apClientActionMap = new HashMap<>();
// iterate through every AP // iterate through every AP
for ( for (
Map.Entry<String, List<State>> entry : model.latestStates Map.Entry<String, List<StateInfo>> entry : model.latestStates
.entrySet() .entrySet()
) { ) {
// get the latest state // get the latest state
// TODO window size (look at multiple states) // TODO window size (look at multiple states)
// TODO window percent (% of samples that must violate thresholds) // TODO window percent (% of samples that must violate thresholds)
List<State> states = entry.getValue(); List<? extends State> states = entry.getValue();
if (states == null || states.isEmpty()) { if (states == null || states.isEmpty()) {
continue; continue;
} }

7
owrrm/src/test/java/com/facebook/openwifi/rrm/modules/ModelerUtilsTest.java
View File

@@ -23,9 +23,8 @@ import java.util.Map;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import com.facebook.openwifi.cloudsdk.AggregatedState; import com.facebook.openwifi.cloudsdk.AggregatedState;
import com.facebook.openwifi.cloudsdk.WifiScanEntry;
import com.facebook.openwifi.cloudsdk.StateInfo; import com.facebook.openwifi.cloudsdk.StateInfo;
import com.facebook.openwifi.cloudsdk.models.ap.State; import com.facebook.openwifi.cloudsdk.WifiScanEntry;
import com.facebook.openwifi.rrm.aggregators.MeanAggregator; import com.facebook.openwifi.rrm.aggregators.MeanAggregator;
import com.facebook.openwifi.rrm.modules.Modeler.DataModel; import com.facebook.openwifi.rrm.modules.Modeler.DataModel;
import com.facebook.openwifi.rrm.optimizers.TestUtils; import com.facebook.openwifi.rrm.optimizers.TestUtils;
@@ -629,7 +628,7 @@ public class ModelerUtilsTest {
ModelerUtils ModelerUtils
.addStateToAggregation(bssidToAggregatedStates, toBeAggregated1); .addStateToAggregation(bssidToAggregatedStates, toBeAggregated1);
List rssiList = new ArrayList<>(); List<Integer> rssiList = new ArrayList<>();
for ( for (
AggregatedState.AssociationInfo associationInfo : bssidToAggregatedStates AggregatedState.AssociationInfo associationInfo : bssidToAggregatedStates
.get(ModelerUtils.getBssidStationKeyPair(bssidA, stationA1)) .get(ModelerUtils.getBssidStationKeyPair(bssidA, stationA1))
@@ -789,7 +788,7 @@ public class ModelerUtilsTest {
new AggregatedState.RadioConfig(1, 80, 10) new AggregatedState.RadioConfig(1, 80, 10)
); );
List rssiList = new ArrayList<>(); List<Integer> rssiList = new ArrayList<>();
for ( for (
AggregatedState.AssociationInfo associationInfo : aggregatedMap AggregatedState.AssociationInfo associationInfo : aggregatedMap
.get(serialNumberA) .get(serialNumberA)

1
owrrm/src/test/java/com/facebook/openwifi/rrm/modules/ProvMonitorTest.java
View File

@@ -24,6 +24,7 @@ public class ProvMonitorTest {
private DeviceDataManager deviceDataManager; private DeviceDataManager deviceDataManager;
/** Test provisioning monitor. */ /** Test provisioning monitor. */
@SuppressWarnings("unused")
private ProvMonitor provMonitor; private ProvMonitor provMonitor;
@BeforeEach @BeforeEach