From 212f3c45ca1c96f11cf1982b84950349bf700f18 Mon Sep 17 00:00:00 2001 From: Matthew Stidham Date: Wed, 24 Nov 2021 16:06:43 -0800 Subject: [PATCH] sta_connect2: Remove redundant and repetitive code Signed-off-by: Matthew Stidham --- py-scripts/sta_connect2.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/py-scripts/sta_connect2.py b/py-scripts/sta_connect2.py index e9fec541..e98d2ba1 100755 --- a/py-scripts/sta_connect2.py +++ b/py-scripts/sta_connect2.py @@ -134,7 +134,9 @@ class StaConnect2(LFCliBase): super().clear_test_results() # super(StaConnect, self).clear_test_results().test_results.clear() - def setup(self, extra_securities=[]): + def setup(self, extra_securities=None): + if extra_securities is None: + extra_securities = [] self.clear_test_results() self.check_connect() upstream_json = self.json_get("%s?fields=alias,phantom,down,port,ip" % self.get_upstream_url(), debug_=False) @@ -227,7 +229,7 @@ class StaConnect2(LFCliBase): self.station_profile.admin_up() LFUtils.waitUntilPortsAdminUp(self.resource, self.lfclient_url, self.station_names) - if self.influx_db is not None: + if self.influx_db: grapher = RecordInflux(_influx_host=self.influx_host, _influx_db=self.influx_db, _influx_user=self.influx_user, @@ -275,7 +277,7 @@ class StaConnect2(LFCliBase): "probe_flags": 1 } self.json_post("/cli-json/nc_show_ports", data) - if self.influx_db is not None: + if self.influx_db: grapher.getdata() LFUtils.wait_until_ports_appear()