From b7d42bce040515b39a4df1c70a11c4fe42e2fa0f Mon Sep 17 00:00:00 2001 From: Ben Greear Date: Wed, 2 Feb 2022 13:44:29 -0800 Subject: [PATCH] lfcli-base: consider test passed if there are no failures. Previous code also insisted that there was at least one success, but that means that code doing not pass/fail tests would fail. Signed-off-by: Ben Greear --- py-json/LANforge/lfcli_base.py | 2 +- py-scripts/test_generic.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/py-json/LANforge/lfcli_base.py b/py-json/LANforge/lfcli_base.py index 6e73817a..21ffef11 100644 --- a/py-json/LANforge/lfcli_base.py +++ b/py-json/LANforge/lfcli_base.py @@ -503,7 +503,7 @@ class LFCliBase: pass_counter += 1 else: fail_counter += 1 - if (fail_counter == 0) and (pass_counter > 0): + if (fail_counter == 0): return True return False diff --git a/py-scripts/test_generic.py b/py-scripts/test_generic.py index 4d50d216..876513eb 100755 --- a/py-scripts/test_generic.py +++ b/py-scripts/test_generic.py @@ -402,6 +402,7 @@ python3 ./test_generic.py if len(generic_test.generic_endps_profile.get_failed_result_list()) > 0: logger.warning("Test-Generic Monitor Failing results:\n%s" % "\n".join(generic_test.generic_endps_profile.get_failed_result_list())) + generic_test.generic_endps_profile.print_pass_fail() if generic_test.passes() and generic_test.generic_endps_profile.passes(): generic_test.exit_success() else: