Update Helm values to v2.3.0-RC1

Signed-off-by: Johann Hoffmann <johann.hoffmann@mailbox.org>

CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.13)
-project(owfms VERSION 2.4.0)
+project(owfms VERSION 2.3.0)
 
 set(CMAKE_CXX_STANDARD 17)
 
@@ -25,18 +25,8 @@ else()
     file(WRITE build ${BUILD_NUM})
 endif()
 
-find_package(Git QUIET)
-if(GIT_FOUND AND EXISTS "${PROJECT_SOURCE_DIR}/.git")
-    execute_process(COMMAND ${GIT_EXECUTABLE} describe --always --tags
-            WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-            RESULT_VARIABLE GIT_RESULT
-            OUTPUT_VARIABLE GIT_HASH)
-    if(NOT GIT_RESULT EQUAL "0")
-        message(FATAL_ERROR "git describe --always --tags failed with ${GIT_RESULT}")
-    endif()
-    string(REGEX REPLACE "\n$" "" GIT_HASH "${GIT_HASH}")
-endif()
-add_definitions(-DAWS_CUSTOM_MEMORY_MANAGEMENT)
+set(BUILD_SHARED_LIBS 1)
+add_definitions(-DAPP_VERSION="${CMAKE_PROJECT_VERSION}" -DBUILD_NUMBER="${BUILD_NUM}" -DAWS_CUSTOM_MEMORY_MANAGEMENT)
 
 set(Boost_USE_STATIC_LIBS OFF)
 set(Boost_USE_MULTITHREADED ON)
@@ -58,11 +48,8 @@ endif()
 
 include_directories(/usr/local/include  /usr/local/opt/openssl/include src include/kafka /usr/local/opt/mysql-client/include)
 
-configure_file(src/ow_version.h.in ${PROJECT_SOURCE_DIR}/src/ow_version.h @ONLY)
-
 add_executable( owfms
         build
-        src/ow_version.h.in
         src/framework/CountryCodes.h
         src/framework/KafkaTopics.h
         src/framework/MicroService.h

Dockerfile

@@ -11,8 +11,6 @@ RUN apk add --update --no-cache \
 
 RUN git clone https://github.com/stephb9959/poco /poco
 RUN git clone https://github.com/stephb9959/cppkafka /cppkafka
-RUN git clone https://github.com/nlohmann/json /json
-RUN git clone https://github.com/pboettch/json-schema-validator /json-schema-validator
 RUN git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp /aws-sdk-cpp
 
 WORKDIR /aws-sdk-cpp
@@ -39,24 +37,9 @@ RUN cmake ..
 RUN cmake --build . --config Release -j8
 RUN cmake --build . --target install
 
-WORKDIR /json
-RUN mkdir cmake-build
-WORKDIR cmake-build
-RUN cmake ..
-RUN make
-RUN make install
-
-WORKDIR /json-schema-validator
-RUN mkdir cmake-build
-WORKDIR cmake-build
-RUN cmake ..
-RUN make
-RUN make install
-
 ADD CMakeLists.txt build /owfms/
 ADD cmake /owfms/cmake
 ADD src /owfms/src
-ADD .git /owfms/.git
 
 WORKDIR /owfms
 RUN mkdir cmake-build
@@ -76,7 +59,7 @@ RUN addgroup -S "$OWFMS_USER" && \
 RUN mkdir /openwifi
 RUN mkdir -p "$OWFMS_ROOT" "$OWFMS_CONFIG" && \
     chown "$OWFMS_USER": "$OWFMS_ROOT" "$OWFMS_CONFIG"
-RUN apk add --update --no-cache librdkafka curl-dev mariadb-connector-c libpq unixodbc su-exec gettext ca-certificates bash jq curl postgresql-client
+RUN apk add --update --no-cache librdkafka curl-dev mariadb-connector-c libpq unixodbc su-exec gettext ca-certificates bash jq curl
 
 COPY --from=builder /owfms/cmake-build/owfms /openwifi/owfms
 COPY --from=builder /cppkafka/cmake-build/src/lib/* /lib/
@@ -86,7 +69,6 @@ COPY --from=builder /aws-sdk-cpp/cmake-build/aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so
 
 COPY owfms.properties.tmpl /
 COPY docker-entrypoint.sh /
-COPY wait-for-postgres.sh /
 RUN wget https://raw.githubusercontent.com/Telecominfraproject/wlan-cloud-ucentral-deploy/main/docker-compose/certs/restapi-ca.pem \
     -O /usr/local/share/ca-certificates/restapi-ca-selfsigned.pem
 

build

@@ -1 +1 @@
-32
+5

helm/.gitignore

@@ -1,3 +1 @@
 *.swp
-Chart.lock
-charts

helm/Chart.yaml

@@ -5,14 +5,14 @@ name: owfms
 version: 0.1.0
 dependencies:
 - name: postgresql
-  repository: https://tip.jfrog.io/artifactory/tip-wlan-cloud-ucentral-helm/
+  repository: https://charts.bitnami.com/bitnami
   version: 10.9.2
   condition: postgresql.enabled
 - name: mysql
-  repository: https://tip.jfrog.io/artifactory/tip-wlan-cloud-ucentral-helm/
+  repository: https://charts.bitnami.com/bitnami
   version: 8.8.3
   condition: mysql.enabled
 - name: mariadb
-  repository: https://tip.jfrog.io/artifactory/tip-wlan-cloud-ucentral-helm/
+  repository: https://charts.bitnami.com/bitnami
   version: 9.4.2
   condition: mariadb.enabled

helm/templates/deployment.yaml

@@ -24,9 +24,6 @@ spec:
     metadata:
       annotations:
         checksum/config: {{ include "owfms.config" . | sha256sum }}
-        {{- with .Values.podAnnotations }}
-        {{- toYaml . | nindent 8 }}
-        {{- end }}
       labels:
         app.kubernetes.io/name: {{ include "owfms.name" . }}
         app.kubernetes.io/instance: {{ .Release.Name }}

helm/values.yaml

@@ -8,7 +8,7 @@ fullnameOverride: ""
 images:
   owfms:
     repository: tip-tip-wlan-cloud-ucentral.jfrog.io/owfms
-    tag: v2.4.1
+    tag: v2.3.0-RC1
     pullPolicy: Always
 #    regcred:
 #      registry: tip-tip-wlan-cloud-ucentral.jfrog.io
@@ -93,8 +93,6 @@ tolerations: []
 
 affinity: {}
 
-podAnnotations: {}
-
 persistence:
   enabled: true
   # storageClassName: "-"

openapi/owfms.yaml

@@ -50,16 +50,6 @@ components:
             properties:
               ErrorCode:
                 type: integer
-                enum:
-                  - 0     # Success
-                  - 1     # PASSWORD_CHANGE_REQUIRED,
-                  - 2     # INVALID_CREDENTIALS,
-                  - 3     # PASSWORD_ALREADY_USED,
-                  - 4     # USERNAME_PENDING_VERIFICATION,
-                  - 5     # PASSWORD_INVALID,
-                  - 6     # INTERNAL_ERROR,
-                  - 7     # ACCESS_DENIED,
-                  - 8     # INVALID_TOKEN
               ErrorDetails:
                 type: string
               ErrorDescription:

src/AutoUpdater.cpp

@@ -9,6 +9,7 @@
 #include "StorageService.h"
 
 namespace OpenWifi {
+    class AutoUpdater * AutoUpdater::instance_ = nullptr;
 
     int AutoUpdater::Start() {
         Running_ = true;

src/AutoUpdater.h

@@ -20,7 +20,9 @@ class AutoUpdater : public SubSystemServer, Poco::Runnable {
         };
 
         static AutoUpdater *instance() {
-            static AutoUpdater *instance_ = new AutoUpdater;
+            if (instance_ == nullptr) {
+                instance_ = new AutoUpdater;
+            }
             return instance_;
         }
 
@@ -36,6 +38,7 @@ class AutoUpdater : public SubSystemServer, Poco::Runnable {
         void reinitialize(Poco::Util::Application &self) final;
 
     private:
+        static AutoUpdater 					            *instance_;
         std::atomic_bool                                Running_=false;
         Poco::Thread                                    Thr_;
         std::map<std::string,SerialCache>               Cache_;

src/DeviceCache.cpp

@@ -5,6 +5,7 @@
 #include "DeviceCache.h"
 
 namespace OpenWifi {
+    class DeviceCache *DeviceCache::instance_ = nullptr;
 
     int DeviceCache::Start() {
         return 0;

src/DeviceCache.h

@@ -20,7 +20,9 @@ namespace OpenWifi {
     class DeviceCache : public SubSystemServer {
     public:
         static DeviceCache *instance() {
-            static DeviceCache *instance_ = new DeviceCache;
+            if (instance_ == nullptr) {
+                instance_ = new DeviceCache;
+            }
             return instance_;
         }
 
@@ -32,6 +34,7 @@ namespace OpenWifi {
         bool GetDevice(const std::string &SerialNumber, DeviceCacheEntry & E);
 
     private:
+        static DeviceCache 	*instance_;
         std::atomic_bool    Running_=false;
         DeviceCacheMap      DeviceCache_;
         explicit DeviceCache() noexcept:

src/FirmwareCache.cpp

@@ -5,6 +5,7 @@
 #include "FirmwareCache.h"
 
 namespace OpenWifi {
+    class FirmwareCache *FirmwareCache::instance_ = nullptr;
 
     int FirmwareCache::Start() {
         return 0;

src/FirmwareCache.h

@@ -18,7 +18,9 @@ namespace OpenWifi {
     class FirmwareCache: public SubSystemServer {
     public:
         static FirmwareCache *instance() {
-            static FirmwareCache *instance_= new FirmwareCache;
+            if (instance_ == nullptr) {
+                instance_ = new FirmwareCache;
+            }
             return instance_;
         }
 
@@ -30,6 +32,7 @@ namespace OpenWifi {
 
 
     private:
+        static FirmwareCache 	*instance_;
         std::atomic_bool        Running_=false;
         FirmwareCacheMap        Cache_;
         explicit FirmwareCache() noexcept:

src/LatestFirmwareCache.cpp

@@ -6,6 +6,7 @@
 #include "StorageService.h"
 
 namespace OpenWifi {
+    class LatestFirmwareCache *LatestFirmwareCache::instance_ = nullptr;
 
     int LatestFirmwareCache::Start() {
         StorageService()->PopulateLatestFirmwareCache();

src/LatestFirmwareCache.h

@@ -25,7 +25,9 @@ namespace OpenWifi {
     class LatestFirmwareCache : public SubSystemServer {
     public:
         static LatestFirmwareCache *instance() {
-            static LatestFirmwareCache *instance_ = new LatestFirmwareCache;
+            if (instance_ == nullptr) {
+                instance_ = new LatestFirmwareCache;
+            }
             return instance_;
         }
 
@@ -40,6 +42,7 @@ namespace OpenWifi {
         bool IsLatest(const std::string &DeviceType, const std::string &Revision);
 
     private:
+        static LatestFirmwareCache 	*instance_;
         LatestFirmwareCacheMap      Cache_;
         Types::StringSet            RevisionSet_;
         Types::StringSet            DeviceSet_;

src/ManifestCreator.cpp

@@ -15,6 +15,7 @@
 #include "LatestFirmwareCache.h"
 
 namespace OpenWifi {
+    class ManifestCreator *ManifestCreator::instance_ = nullptr;
 
     void ManifestCreator::run() {
         Running_ = true;
@@ -93,11 +94,6 @@ namespace OpenWifi {
         for(auto &[Release,BucketEntry]:BucketContent) {
             FMSObjects::Firmware    F;
             auto R = Release;
-
-            // skip staging releases.
-            if(BucketEntry.URI.find("-staging-")!=std::string::npos)
-                continue;
-
             if(BucketEntry.Valid && !StorageService()->GetFirmwareByName(R,BucketEntry.Compatible,F)) {
                 F.id = MicroService::instance().CreateUUID();
                 F.release = Release;

src/ManifestCreator.h

@@ -31,7 +31,9 @@ namespace OpenWifi {
     class ManifestCreator : public SubSystemServer, Poco::Runnable {
     public:
         static ManifestCreator *instance() {
-            static ManifestCreator *instance_ = new ManifestCreator;
+            if (instance_ == nullptr) {
+                instance_ = new ManifestCreator;
+            }
             return instance_;
         }
 

src/NewConnectionHandler.cpp

@@ -20,6 +20,7 @@
 
 
 namespace OpenWifi {
+    class NewConnectionHandler *NewConnectionHandler::instance_ = nullptr;
 
     void NewConnectionHandler::run() {
         Running_ = true ;

src/NewConnectionHandler.h

@@ -15,7 +15,9 @@ namespace OpenWifi {
     public:
 
         static NewConnectionHandler *instance() {
-            static NewConnectionHandler *instance_ = new NewConnectionHandler;
+            if (instance_ == nullptr) {
+                instance_ = new NewConnectionHandler;
+            }
             return instance_;
         }
 
@@ -27,6 +29,7 @@ namespace OpenWifi {
         void ConnectionReceived( const std::string & Key, const std::string & Message);
 
     private:
+        static NewConnectionHandler      *instance_;
         Poco::Thread                Worker_;
         std::atomic_bool            Running_ = false;
         int                         ConnectionWatcherId_=0;

src/RESTObjects/RESTAPI_GWobjects.cpp

@@ -68,7 +68,7 @@ namespace OpenWifi::GWObjects {
 #endif
 	}
 
-	bool Device::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool Device::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"serialNumber",SerialNumber);
 			field_from_json(Obj,"deviceType",DeviceType);
@@ -147,7 +147,7 @@ namespace OpenWifi::GWObjects {
 		field_to_json(Obj,"attachFile", AttachDate);
 	}
 
-	bool DefaultConfiguration::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool DefaultConfiguration::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"name",Name);
 			field_from_json(Obj,"configuration",Configuration);
@@ -166,7 +166,7 @@ namespace OpenWifi::GWObjects {
 		field_to_json(Obj,"created", created);
 	}
 
-	bool BlackListedDevice::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool BlackListedDevice::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"serialNumber",serialNumber);
 			field_from_json(Obj,"author",author);

src/RESTObjects/RESTAPI_GWobjects.h

@@ -59,7 +59,7 @@ namespace OpenWifi::GWObjects {
 		std::string DevicePassword;
 		void to_json(Poco::JSON::Object &Obj) const;
 		void to_json_with_status(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 		void Print() const;
 	};
 
@@ -116,7 +116,7 @@ namespace OpenWifi::GWObjects {
 		uint64_t 	Created;
 		uint64_t 	LastModified;
 		void 		to_json(Poco::JSON::Object &Obj) const;
-		bool 		from_json(Poco::JSON::Object::Ptr &Obj);
+		bool 		from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
 	struct CommandDetails {
@@ -147,7 +147,7 @@ namespace OpenWifi::GWObjects {
 		std::string author;
 		uint64_t created;
 		void to_json(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
 	struct RttySessionDetails {

src/RESTObjects/RESTAPI_ProvObjects.cpp

@@ -10,30 +10,27 @@
 #include "RESTAPI_ProvObjects.h"
 #include "framework/MicroService.h"
 
-using OpenWifi::RESTAPI_utils::field_to_json;
-using OpenWifi::RESTAPI_utils::field_from_json;
-
 namespace OpenWifi::ProvObjects {
 
     void ObjectInfo::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj,"id",id);
-        field_to_json(Obj,"name",name);
-        field_to_json(Obj,"description",description);
-        field_to_json(Obj,"created",created);
-        field_to_json(Obj,"modified",modified);
-        field_to_json(Obj,"notes",notes);
-        field_to_json(Obj,"tags",tags);
+        RESTAPI_utils::field_to_json(Obj,"id",id);
+        RESTAPI_utils::field_to_json(Obj,"name",name);
+        RESTAPI_utils::field_to_json(Obj,"description",description);
+        RESTAPI_utils::field_to_json(Obj,"created",created);
+        RESTAPI_utils::field_to_json(Obj,"modified",modified);
+        RESTAPI_utils::field_to_json(Obj,"notes",notes);
+        RESTAPI_utils::field_to_json(Obj,"tags",tags);
     }
 
     bool ObjectInfo::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json(Obj,"id",id);
-            field_from_json(Obj,"name",name);
-            field_from_json(Obj,"description",description);
-            field_from_json(Obj,"created",created);
-            field_from_json(Obj,"modified",modified);
-            field_from_json(Obj,"notes",notes);
-            field_from_json(Obj,"tags",tags);
+            RESTAPI_utils::field_from_json(Obj,"id",id);
+            RESTAPI_utils::field_from_json(Obj,"name",name);
+            RESTAPI_utils::field_from_json(Obj,"description",description);
+            RESTAPI_utils::field_from_json(Obj,"created",created);
+            RESTAPI_utils::field_from_json(Obj,"modified",modified);
+            RESTAPI_utils::field_from_json(Obj,"notes",notes);
+            RESTAPI_utils::field_from_json(Obj,"tags",tags);
             return true;
         } catch(...) {
 
@@ -42,18 +39,18 @@ namespace OpenWifi::ProvObjects {
     }
 
     void ManagementPolicyEntry::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json( Obj,"users",users);
-        field_to_json( Obj,"resources",resources);
-        field_to_json( Obj,"access",access);
-        field_to_json( Obj,"policy",policy);
+        RESTAPI_utils::field_to_json( Obj,"users",users);
+        RESTAPI_utils::field_to_json( Obj,"resources",resources);
+        RESTAPI_utils::field_to_json( Obj,"access",access);
+        RESTAPI_utils::field_to_json( Obj,"policy",policy);
     }
 
     bool ManagementPolicyEntry::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"users",users);
-            field_from_json( Obj,"resources",resources);
-            field_from_json( Obj,"access",access);
-            field_from_json( Obj,"policy",policy);
+            RESTAPI_utils::field_from_json( Obj,"users",users);
+            RESTAPI_utils::field_from_json( Obj,"resources",resources);
+            RESTAPI_utils::field_from_json( Obj,"access",access);
+            RESTAPI_utils::field_from_json( Obj,"policy",policy);
             return true;
         } catch(...) {
 
@@ -63,17 +60,17 @@ namespace OpenWifi::ProvObjects {
 
     void ManagementPolicy::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json(Obj, "entries", entries);
-        field_to_json(Obj, "inUse", inUse);
-        field_to_json(Obj, "entity", entity);
+        RESTAPI_utils::field_to_json(Obj, "entries", entries);
+        RESTAPI_utils::field_to_json(Obj, "inUse", inUse);
+        RESTAPI_utils::field_to_json(Obj, "entity", entity);
     }
 
     bool ManagementPolicy::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json(Obj, "entries", entries);
-            field_from_json(Obj, "inUse", inUse);
-            field_from_json(Obj, "entity", entity);
+            RESTAPI_utils::field_from_json(Obj, "entries", entries);
+            RESTAPI_utils::field_from_json(Obj, "inUse", inUse);
+            RESTAPI_utils::field_from_json(Obj, "entity", entity);
             return true;
         } catch(...) {
 
@@ -83,31 +80,31 @@ namespace OpenWifi::ProvObjects {
 
     void Entity::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"parent",parent);
-        field_to_json( Obj,"venues",venues);
-        field_to_json( Obj,"children",children);
-        field_to_json( Obj,"contacts",contacts);
-        field_to_json( Obj,"locations",locations);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
-        field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
-        field_to_json( Obj,"devices",devices);
-        field_to_json( Obj,"rrm",rrm);
-        field_to_json( Obj,"sourceIP",sourceIP);
+        RESTAPI_utils::field_to_json( Obj,"parent",parent);
+        RESTAPI_utils::field_to_json( Obj,"venues",venues);
+        RESTAPI_utils::field_to_json( Obj,"children",children);
+        RESTAPI_utils::field_to_json( Obj,"contacts",contacts);
+        RESTAPI_utils::field_to_json( Obj,"locations",locations);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
+        RESTAPI_utils::field_to_json( Obj,"devices",devices);
+        RESTAPI_utils::field_to_json( Obj,"rrm",rrm);
+        RESTAPI_utils::field_to_json( Obj,"sourceIP",sourceIP);
     }
 
     bool Entity::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json( Obj,"parent",parent);
-            field_from_json( Obj,"venues",venues);
-            field_from_json( Obj,"children",children);
-            field_from_json( Obj,"contacts",contacts);
-            field_from_json( Obj,"locations",locations);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
-            field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
-            field_from_json( Obj,"devices",devices);
-            field_from_json( Obj,"rrm",rrm);
-            field_from_json( Obj,"sourceIP",sourceIP);
+            RESTAPI_utils::field_from_json( Obj,"parent",parent);
+            RESTAPI_utils::field_from_json( Obj,"venues",venues);
+            RESTAPI_utils::field_from_json( Obj,"children",children);
+            RESTAPI_utils::field_from_json( Obj,"contacts",contacts);
+            RESTAPI_utils::field_from_json( Obj,"locations",locations);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
+            RESTAPI_utils::field_from_json( Obj,"devices",devices);
+            RESTAPI_utils::field_from_json( Obj,"rrm",rrm);
+            RESTAPI_utils::field_from_json( Obj,"sourceIP",sourceIP);
             return true;
         } catch(...) {
 
@@ -116,14 +113,14 @@ namespace OpenWifi::ProvObjects {
     }
 
     void DiGraphEntry::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json( Obj,"parent",parent);
-        field_to_json( Obj,"child",child);
+        RESTAPI_utils::field_to_json( Obj,"parent",parent);
+        RESTAPI_utils::field_to_json( Obj,"child",child);
     }
 
     bool DiGraphEntry::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"parent",parent);
-            field_from_json( Obj,"child",child);
+            RESTAPI_utils::field_from_json( Obj,"parent",parent);
+            RESTAPI_utils::field_from_json( Obj,"child",child);
             return true;
         } catch (...) {
 
@@ -133,37 +130,37 @@ namespace OpenWifi::ProvObjects {
 
     void Venue::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"parent",parent);
-        field_to_json( Obj,"entity",entity);
-        field_to_json( Obj,"children",children);
-        field_to_json( Obj,"devices",devices);
-        field_to_json( Obj,"topology",topology);
-        field_to_json( Obj,"parent",parent);
-        field_to_json( Obj,"design",design);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
-        field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
-        field_to_json( Obj,"contact",contact);
-        field_to_json( Obj,"location",location);
-        field_to_json( Obj,"rrm",rrm);
-        field_to_json( Obj,"sourceIP",sourceIP);
+        RESTAPI_utils::field_to_json( Obj,"parent",parent);
+        RESTAPI_utils::field_to_json( Obj,"entity",entity);
+        RESTAPI_utils::field_to_json( Obj,"children",children);
+        RESTAPI_utils::field_to_json( Obj,"devices",devices);
+        RESTAPI_utils::field_to_json( Obj,"topology",topology);
+        RESTAPI_utils::field_to_json( Obj,"parent",parent);
+        RESTAPI_utils::field_to_json( Obj,"design",design);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
+        RESTAPI_utils::field_to_json( Obj,"contact",contact);
+        RESTAPI_utils::field_to_json( Obj,"location",location);
+        RESTAPI_utils::field_to_json( Obj,"rrm",rrm);
+        RESTAPI_utils::field_to_json( Obj,"sourceIP",sourceIP);
     }
 
     bool Venue::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json( Obj,"parent",parent);
-            field_from_json( Obj,"entity",entity);
-            field_from_json( Obj,"children",children);
-            field_from_json( Obj,"devices",devices);
-            field_from_json( Obj,"topology",topology);
-            field_from_json( Obj,"parent",parent);
-            field_from_json( Obj,"design",design);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
-            field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
-            field_from_json( Obj,"contact",contact);
-            field_from_json( Obj,"location",location);
-            field_from_json( Obj,"rrm",rrm);
-            field_from_json( Obj,"sourceIP",sourceIP);
+            RESTAPI_utils::field_from_json( Obj,"parent",parent);
+            RESTAPI_utils::field_from_json( Obj,"entity",entity);
+            RESTAPI_utils::field_from_json( Obj,"children",children);
+            RESTAPI_utils::field_from_json( Obj,"devices",devices);
+            RESTAPI_utils::field_from_json( Obj,"topology",topology);
+            RESTAPI_utils::field_from_json( Obj,"parent",parent);
+            RESTAPI_utils::field_from_json( Obj,"design",design);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
+            RESTAPI_utils::field_from_json( Obj,"contact",contact);
+            RESTAPI_utils::field_from_json( Obj,"location",location);
+            RESTAPI_utils::field_from_json( Obj,"rrm",rrm);
+            RESTAPI_utils::field_from_json( Obj,"sourceIP",sourceIP);
             return true;
         } catch (...) {
 
@@ -172,16 +169,16 @@ namespace OpenWifi::ProvObjects {
     }
 
     void UserInfoDigest::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json( Obj,"id",id);
-        field_to_json( Obj,"entity",loginId);
-        field_to_json( Obj,"children",userType);
+        RESTAPI_utils::field_to_json( Obj,"id",id);
+        RESTAPI_utils::field_to_json( Obj,"entity",loginId);
+        RESTAPI_utils::field_to_json( Obj,"children",userType);
     }
 
     bool UserInfoDigest::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"id",id);
-            field_from_json( Obj,"entity",loginId);
-            field_from_json( Obj,"children",userType);
+            RESTAPI_utils::field_from_json( Obj,"id",id);
+            RESTAPI_utils::field_from_json( Obj,"entity",loginId);
+            RESTAPI_utils::field_from_json( Obj,"children",userType);
             return true;
         } catch(...) {
         }
@@ -190,17 +187,17 @@ namespace OpenWifi::ProvObjects {
 
     void ManagementRole::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
-        field_to_json( Obj,"users",users);
-        field_to_json( Obj,"entity",entity);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"users",users);
+        RESTAPI_utils::field_to_json( Obj,"entity",entity);
     }
 
     bool ManagementRole::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
-            field_from_json( Obj,"users",users);
-            field_from_json( Obj,"entity",entity);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"users",users);
+            RESTAPI_utils::field_from_json( Obj,"entity",entity);
             return true;
         } catch(...) {
         }
@@ -209,39 +206,39 @@ namespace OpenWifi::ProvObjects {
 
     void Location::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"type",OpenWifi::ProvObjects::to_string(type));
-        field_to_json( Obj,"buildingName",buildingName);
-        field_to_json( Obj,"addressLines",addressLines);
-        field_to_json( Obj,"city",city);
-        field_to_json( Obj,"state",state);
-        field_to_json( Obj,"postal",postal);
-        field_to_json( Obj,"country",country);
-        field_to_json( Obj,"phones",phones);
-        field_to_json( Obj,"mobiles",mobiles);
-        field_to_json( Obj,"geoCode",geoCode);
-        field_to_json( Obj,"inUse",inUse);
-        field_to_json( Obj,"entity",entity);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"type",OpenWifi::ProvObjects::to_string(type));
+        RESTAPI_utils::field_to_json( Obj,"buildingName",buildingName);
+        RESTAPI_utils::field_to_json( Obj,"addressLines",addressLines);
+        RESTAPI_utils::field_to_json( Obj,"city",city);
+        RESTAPI_utils::field_to_json( Obj,"state",state);
+        RESTAPI_utils::field_to_json( Obj,"postal",postal);
+        RESTAPI_utils::field_to_json( Obj,"country",country);
+        RESTAPI_utils::field_to_json( Obj,"phones",phones);
+        RESTAPI_utils::field_to_json( Obj,"mobiles",mobiles);
+        RESTAPI_utils::field_to_json( Obj,"geoCode",geoCode);
+        RESTAPI_utils::field_to_json( Obj,"inUse",inUse);
+        RESTAPI_utils::field_to_json( Obj,"entity",entity);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
     }
 
     bool Location::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
             std::string tmp_type;
-            field_from_json( Obj,"type", tmp_type);
+            RESTAPI_utils::field_from_json( Obj,"type", tmp_type);
             type = location_from_string(tmp_type);
-            field_from_json( Obj,"buildingName",buildingName);
-            field_from_json( Obj,"addressLines",addressLines);
-            field_from_json( Obj,"city",city);
-            field_from_json( Obj,"state",state);
-            field_from_json( Obj,"postal",postal);
-            field_from_json( Obj,"country",country);
-            field_from_json( Obj,"phones",phones);
-            field_from_json( Obj,"mobiles",mobiles);
-            field_from_json( Obj,"geoCode",geoCode);
-            field_from_json( Obj,"inUse",inUse);
-            field_from_json( Obj,"entity",entity);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"buildingName",buildingName);
+            RESTAPI_utils::field_from_json( Obj,"addressLines",addressLines);
+            RESTAPI_utils::field_from_json( Obj,"city",city);
+            RESTAPI_utils::field_from_json( Obj,"state",state);
+            RESTAPI_utils::field_from_json( Obj,"postal",postal);
+            RESTAPI_utils::field_from_json( Obj,"country",country);
+            RESTAPI_utils::field_from_json( Obj,"phones",phones);
+            RESTAPI_utils::field_from_json( Obj,"mobiles",mobiles);
+            RESTAPI_utils::field_from_json( Obj,"geoCode",geoCode);
+            RESTAPI_utils::field_from_json( Obj,"inUse",inUse);
+            RESTAPI_utils::field_from_json( Obj,"entity",entity);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
             return true;
         } catch (...) {
 
@@ -251,43 +248,43 @@ namespace OpenWifi::ProvObjects {
 
     void Contact::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"type", to_string(type));
-        field_to_json( Obj,"title",title);
-        field_to_json( Obj,"salutation",salutation);
-        field_to_json( Obj,"firstname",firstname);
-        field_to_json( Obj,"lastname",lastname);
-        field_to_json( Obj,"initials",initials);
-        field_to_json( Obj,"visual",visual);
-        field_to_json( Obj,"mobiles",mobiles);
-        field_to_json( Obj,"phones",phones);
-        field_to_json( Obj,"primaryEmail",primaryEmail);
-        field_to_json( Obj,"secondaryEmail",secondaryEmail);
-        field_to_json( Obj,"accessPIN",accessPIN);
-        field_to_json( Obj,"inUse",inUse);
-        field_to_json( Obj,"entity",entity);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"type", to_string(type));
+        RESTAPI_utils::field_to_json( Obj,"title",title);
+        RESTAPI_utils::field_to_json( Obj,"salutation",salutation);
+        RESTAPI_utils::field_to_json( Obj,"firstname",firstname);
+        RESTAPI_utils::field_to_json( Obj,"lastname",lastname);
+        RESTAPI_utils::field_to_json( Obj,"initials",initials);
+        RESTAPI_utils::field_to_json( Obj,"visual",visual);
+        RESTAPI_utils::field_to_json( Obj,"mobiles",mobiles);
+        RESTAPI_utils::field_to_json( Obj,"phones",phones);
+        RESTAPI_utils::field_to_json( Obj,"primaryEmail",primaryEmail);
+        RESTAPI_utils::field_to_json( Obj,"secondaryEmail",secondaryEmail);
+        RESTAPI_utils::field_to_json( Obj,"accessPIN",accessPIN);
+        RESTAPI_utils::field_to_json( Obj,"inUse",inUse);
+        RESTAPI_utils::field_to_json( Obj,"entity",entity);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
     }
 
     bool Contact::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
             std::string tmp_type;
-            field_from_json( Obj,"type", tmp_type);
+            RESTAPI_utils::field_from_json( Obj,"type", tmp_type);
             type = contact_from_string(tmp_type);
-            field_from_json( Obj,"title",title);
-            field_from_json( Obj,"salutation",salutation);
-            field_from_json( Obj,"firstname",firstname);
-            field_from_json( Obj,"lastname",lastname);
-            field_from_json( Obj,"initials",initials);
-            field_from_json( Obj,"visual",visual);
-            field_from_json( Obj,"mobiles",mobiles);
-            field_from_json( Obj,"phones",phones);
-            field_from_json( Obj,"primaryEmail",primaryEmail);
-            field_from_json( Obj,"secondaryEmail",secondaryEmail);
-            field_from_json( Obj,"accessPIN",accessPIN);
-            field_from_json( Obj,"inUse",inUse);
-            field_from_json( Obj,"entity",entity);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"title",title);
+            RESTAPI_utils::field_from_json( Obj,"salutation",salutation);
+            RESTAPI_utils::field_from_json( Obj,"firstname",firstname);
+            RESTAPI_utils::field_from_json( Obj,"lastname",lastname);
+            RESTAPI_utils::field_from_json( Obj,"initials",initials);
+            RESTAPI_utils::field_from_json( Obj,"visual",visual);
+            RESTAPI_utils::field_from_json( Obj,"mobiles",mobiles);
+            RESTAPI_utils::field_from_json( Obj,"phones",phones);
+            RESTAPI_utils::field_from_json( Obj,"primaryEmail",primaryEmail);
+            RESTAPI_utils::field_from_json( Obj,"secondaryEmail",secondaryEmail);
+            RESTAPI_utils::field_from_json( Obj,"accessPIN",accessPIN);
+            RESTAPI_utils::field_from_json( Obj,"inUse",inUse);
+            RESTAPI_utils::field_from_json( Obj,"entity",entity);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
             return true;
         } catch (...) {
 
@@ -297,35 +294,35 @@ namespace OpenWifi::ProvObjects {
 
     void InventoryTag::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json(Obj, "serialNumber", serialNumber);
-        field_to_json(Obj, "venue", venue);
-        field_to_json(Obj, "entity", entity);
-        field_to_json(Obj, "subscriber", subscriber);
-        field_to_json(Obj, "deviceType", deviceType);
-        field_to_json(Obj, "qrCode", qrCode);
-        field_to_json(Obj, "geoCode", geoCode);
-        field_to_json(Obj, "location", location);
-        field_to_json(Obj, "contact", contact);
-        field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
-        field_to_json( Obj,"rrm",rrm);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json(Obj, "serialNumber", serialNumber);
+        RESTAPI_utils::field_to_json(Obj, "venue", venue);
+        RESTAPI_utils::field_to_json(Obj, "entity", entity);
+        RESTAPI_utils::field_to_json(Obj, "subscriber", subscriber);
+        RESTAPI_utils::field_to_json(Obj, "deviceType", deviceType);
+        RESTAPI_utils::field_to_json(Obj, "qrCode", qrCode);
+        RESTAPI_utils::field_to_json(Obj, "geoCode", geoCode);
+        RESTAPI_utils::field_to_json(Obj, "location", location);
+        RESTAPI_utils::field_to_json(Obj, "contact", contact);
+        RESTAPI_utils::field_to_json( Obj,"deviceConfiguration",deviceConfiguration);
+        RESTAPI_utils::field_to_json( Obj,"rrm",rrm);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
     }
 
     bool InventoryTag::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json( Obj,"serialNumber",serialNumber);
-            field_from_json( Obj,"venue",venue);
-            field_from_json( Obj,"entity",entity);
-            field_from_json( Obj,"subscriber",subscriber);
-            field_from_json( Obj,"deviceType",deviceType);
-            field_from_json(Obj, "qrCode", qrCode);
-            field_from_json( Obj,"geoCode",geoCode);
-            field_from_json( Obj,"location",location);
-            field_from_json( Obj,"contact",contact);
-            field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
-            field_from_json( Obj,"rrm",rrm);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"serialNumber",serialNumber);
+            RESTAPI_utils::field_from_json( Obj,"venue",venue);
+            RESTAPI_utils::field_from_json( Obj,"entity",entity);
+            RESTAPI_utils::field_from_json( Obj,"subscriber",subscriber);
+            RESTAPI_utils::field_from_json( Obj,"deviceType",deviceType);
+            RESTAPI_utils::field_from_json(Obj, "qrCode", qrCode);
+            RESTAPI_utils::field_from_json( Obj,"geoCode",geoCode);
+            RESTAPI_utils::field_from_json( Obj,"location",location);
+            RESTAPI_utils::field_from_json( Obj,"contact",contact);
+            RESTAPI_utils::field_from_json( Obj,"deviceConfiguration",deviceConfiguration);
+            RESTAPI_utils::field_from_json( Obj,"rrm",rrm);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
             return true;
         } catch(...) {
 
@@ -334,18 +331,18 @@ namespace OpenWifi::ProvObjects {
     }
 
     void DeviceConfigurationElement::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json( Obj,"name", name);
-        field_to_json( Obj,"description", description);
-        field_to_json( Obj,"weight", weight);
-        field_to_json( Obj,"configuration", configuration);
+        RESTAPI_utils::field_to_json( Obj,"name", name);
+        RESTAPI_utils::field_to_json( Obj,"description", description);
+        RESTAPI_utils::field_to_json( Obj,"weight", weight);
+        RESTAPI_utils::field_to_json( Obj,"configuration", configuration);
     }
 
     bool DeviceConfigurationElement::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"name",name);
-            field_from_json( Obj,"description",description);
-            field_from_json( Obj,"weight",weight);
-            field_from_json( Obj,"configuration",configuration);
+            RESTAPI_utils::field_from_json( Obj,"name",name);
+            RESTAPI_utils::field_from_json( Obj,"description",description);
+            RESTAPI_utils::field_from_json( Obj,"weight",weight);
+            RESTAPI_utils::field_from_json( Obj,"configuration",configuration);
             return true;
         } catch(...) {
 
@@ -355,27 +352,27 @@ namespace OpenWifi::ProvObjects {
 
     void DeviceConfiguration::to_json(Poco::JSON::Object &Obj) const {
         info.to_json(Obj);
-        field_to_json( Obj,"managementPolicy",managementPolicy);
-        field_to_json( Obj,"deviceTypes",deviceTypes);
-        field_to_json( Obj,"configuration",configuration);
-        field_to_json( Obj,"inUse",inUse);
-        field_to_json( Obj,"variables",variables);
-        field_to_json( Obj,"rrm",rrm);
-        field_to_json( Obj,"firmwareUpgrade",firmwareUpgrade);
-        field_to_json( Obj,"firmwareRCOnly",firmwareRCOnly);
+        RESTAPI_utils::field_to_json( Obj,"managementPolicy",managementPolicy);
+        RESTAPI_utils::field_to_json( Obj,"deviceTypes",deviceTypes);
+        RESTAPI_utils::field_to_json( Obj,"configuration",configuration);
+        RESTAPI_utils::field_to_json( Obj,"inUse",inUse);
+        RESTAPI_utils::field_to_json( Obj,"variables",variables);
+        RESTAPI_utils::field_to_json( Obj,"rrm",rrm);
+        RESTAPI_utils::field_to_json( Obj,"firmwareUpgrade",firmwareUpgrade);
+        RESTAPI_utils::field_to_json( Obj,"firmwareRCOnly",firmwareRCOnly);
     }
 
     bool DeviceConfiguration::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
             info.from_json(Obj);
-            field_from_json( Obj,"managementPolicy",managementPolicy);
-            field_from_json( Obj,"deviceTypes",deviceTypes);
-            field_from_json( Obj,"configuration",configuration);
-            field_from_json( Obj,"inUse",inUse);
-            field_from_json( Obj,"variables",variables);
-            field_from_json( Obj,"rrm",rrm);
-            field_from_json( Obj,"firmwareUpgrade",firmwareUpgrade);
-            field_from_json( Obj,"firmwareRCOnly",firmwareRCOnly);
+            RESTAPI_utils::field_from_json( Obj,"managementPolicy",managementPolicy);
+            RESTAPI_utils::field_from_json( Obj,"deviceTypes",deviceTypes);
+            RESTAPI_utils::field_from_json( Obj,"configuration",configuration);
+            RESTAPI_utils::field_from_json( Obj,"inUse",inUse);
+            RESTAPI_utils::field_from_json( Obj,"variables",variables);
+            RESTAPI_utils::field_from_json( Obj,"rrm",rrm);
+            RESTAPI_utils::field_from_json( Obj,"firmwareUpgrade",firmwareUpgrade);
+            RESTAPI_utils::field_from_json( Obj,"firmwareRCOnly",firmwareRCOnly);
             return true;
         } catch(...) {
 
@@ -384,8 +381,8 @@ namespace OpenWifi::ProvObjects {
     }
 
     void Report::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "snapshot", snapShot);
-        field_to_json(Obj, "devices", tenants);
+        RESTAPI_utils::field_to_json(Obj, "snapshot", snapShot);
+        RESTAPI_utils::field_to_json(Obj, "devices", tenants);
     };
 
     void Report::reset() {
@@ -393,16 +390,16 @@ namespace OpenWifi::ProvObjects {
     }
 
     void ExpandedUseEntry::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "uuid", uuid);
-        field_to_json(Obj, "name", name);
-        field_to_json(Obj, "description", description);
+        RESTAPI_utils::field_to_json(Obj, "uuid", uuid);
+        RESTAPI_utils::field_to_json(Obj, "name", name);
+        RESTAPI_utils::field_to_json(Obj, "description", description);
     }
 
     bool ExpandedUseEntry::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"uuid",uuid);
-            field_from_json( Obj,"name",name);
-            field_from_json( Obj,"description",description);
+            RESTAPI_utils::field_from_json( Obj,"uuid",uuid);
+            RESTAPI_utils::field_from_json( Obj,"name",name);
+            RESTAPI_utils::field_from_json( Obj,"description",description);
             return true;
         } catch(...) {
 
@@ -411,14 +408,14 @@ namespace OpenWifi::ProvObjects {
     }
 
     void ExpandedUseEntryList::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "type", type);
-        field_to_json(Obj, "entries", entries);
+        RESTAPI_utils::field_to_json(Obj, "type", type);
+        RESTAPI_utils::field_to_json(Obj, "entries", entries);
     }
 
     bool ExpandedUseEntryList::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"type",type);
-            field_from_json( Obj,"entries",entries);
+            RESTAPI_utils::field_from_json( Obj,"type",type);
+            RESTAPI_utils::field_from_json( Obj,"entries",entries);
             return true;
         } catch(...) {
 
@@ -427,94 +424,12 @@ namespace OpenWifi::ProvObjects {
     }
 
     void ExpandedUseEntryMapList::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "entries", entries);
+        RESTAPI_utils::field_to_json(Obj, "entries", entries);
     }
 
     bool ExpandedUseEntryMapList::from_json(const Poco::JSON::Object::Ptr &Obj) {
         try {
-            field_from_json( Obj,"entries",entries);
-            return true;
-        } catch(...) {
-
-        }
-        return false;
-    }
-
-    void UserList::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "list", list);
-    }
-
-    bool UserList::from_json(const Poco::JSON::Object::Ptr &Obj) {
-        try {
-            field_from_json(Obj, "list", list);
-            return true;
-        } catch(...) {
-
-        }
-        return false;
-    }
-
-    void ObjectACL::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "users", users);
-        field_to_json(Obj, "access", access);
-    }
-
-    bool ObjectACL::from_json(const Poco::JSON::Object::Ptr &Obj) {
-        try {
-            field_from_json(Obj, "users", users);
-            field_from_json(Obj, "access", access);
-            return true;
-        } catch(...) {
-
-        }
-        return false;
-    }
-    
-    void ObjectACLList::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json(Obj, "list", list);
-    }
-
-    bool ObjectACLList::from_json(const Poco::JSON::Object::Ptr &Obj) {
-        try {
-            field_from_json(Obj, "list", list);
-            return true;
-        } catch(...) {
-
-        }
-        return false;
-    }
-
-    void Map::to_json(Poco::JSON::Object &Obj) const {
-        info.to_json(Obj);
-        field_to_json( Obj,"data",data);
-        field_to_json( Obj,"entity",entity);
-        field_to_json( Obj,"creator",creator);
-        field_to_json( Obj,"visibility",visibility);
-        field_to_json( Obj,"access",access);
-    }
-
-    bool Map::from_json(const Poco::JSON::Object::Ptr &Obj) {
-        try {
-            info.from_json(Obj);
-            field_from_json( Obj,"data",data);
-            field_from_json( Obj,"entity",entity);
-            field_from_json( Obj,"creator",creator);
-            field_from_json( Obj,"visibility",visibility);
-            field_from_json( Obj,"access",access);
-            return true;
-        } catch(...) {
-
-        }
-        return false;
-    }
-
-    void MapList::to_json(Poco::JSON::Object &Obj) const {
-        field_to_json( Obj,"list",list);
-    }
-
-    bool MapList::from_json(const Poco::JSON::Object::Ptr &Obj) {
-        try {
-            field_from_json( Obj,"list",list);
+            RESTAPI_utils::field_from_json( Obj,"entries",entries);
             return true;
         } catch(...) {
 
@@ -523,47 +438,13 @@ namespace OpenWifi::ProvObjects {
     }
 
     bool UpdateObjectInfo(const Poco::JSON::Object::Ptr &O, const SecurityObjects::UserInfo &U, ObjectInfo &I) {
-        uint64_t Now = std::time(nullptr);
         if(O->has("name"))
             I.name = O->get("name").toString();
-
-        if(I.name.empty())
-            return false;
-
-       if(O->has("description"))
-            I.description = O->get("description").toString();
-        SecurityObjects::MergeNotes(O,U,I.notes);
-        SecurityObjects::NoteInfoVec N;
-        for(auto &i:I.notes) {
-            if(i.note.empty())
-                continue;
-            N.push_back(SecurityObjects::NoteInfo{.created=Now,.createdBy=U.email,.note=i.note});
-        }
-        I.modified = Now;
-        return true;
-    }
-
-    bool CreateObjectInfo(const Poco::JSON::Object::Ptr &O, const SecurityObjects::UserInfo &U, ObjectInfo &I) {
-        uint64_t Now = std::time(nullptr);
-        if(O->has("name"))
-            I.name = O->get("name").toString();
-
-        if(I.name.empty())
-            return false;
-
         if(O->has("description"))
             I.description = O->get("description").toString();
-
-        SecurityObjects::NoteInfoVec N;
-        for(auto &i:I.notes) {
-            if(i.note.empty())
-                continue;
-            N.push_back(SecurityObjects::NoteInfo{.created=Now,.createdBy=U.email,.note=i.note});
-        }
-        I.notes = N;
-        I.modified = I.created = Now;
-        I.id = MicroService::instance().CreateUUID();
-
+        SecurityObjects::MergeNotes(O,U,I.notes);
+        I.modified = std::time(nullptr);
         return true;
     }
+
 };

src/RESTObjects/RESTAPI_ProvObjects.h

@@ -15,13 +15,6 @@
 
 namespace OpenWifi::ProvObjects {
 
-    enum FIRMWARE_UPGRADE_RULES {
-        dont_upgrade,
-        upgrade_inherit,
-        upgrade_release_only,
-        upgrade_latest
-    };
-
     struct ObjectInfo {
         Types::UUID_t   id;
         std::string     name;
@@ -324,50 +317,7 @@ namespace OpenWifi::ProvObjects {
         bool from_json(const Poco::JSON::Object::Ptr &Obj);
     };
 
-    struct UserList {
-        std::vector<std::string>    list;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(const Poco::JSON::Object::Ptr &Obj);
-    };
-
-    struct ObjectACL {
-        UserList        users;
-        std::string     access;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(const Poco::JSON::Object::Ptr &Obj);
-    };
-
-    struct ObjectACLList {
-        std::vector<ObjectACL>  list;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(const Poco::JSON::Object::Ptr &Obj);
-    };
-
-    struct Map {
-        ObjectInfo          info;
-        std::string         data;
-        std::string         entity;
-        std::string         creator;
-        std::string         visibility;
-        ObjectACLList       access;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(const Poco::JSON::Object::Ptr &Obj);
-    };
-
-    struct MapList {
-        std::vector<Map>    list;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(const Poco::JSON::Object::Ptr &Obj);
-    };
-
     bool UpdateObjectInfo(const Poco::JSON::Object::Ptr &O, const SecurityObjects::UserInfo &U, ObjectInfo &I);
-    bool CreateObjectInfo(const Poco::JSON::Object::Ptr &O, const SecurityObjects::UserInfo &U, ObjectInfo &I);
-
 };
 
 

src/RESTObjects/RESTAPI_SecurityObjects.cpp

@@ -138,7 +138,7 @@ namespace OpenWifi::SecurityObjects {
 	    field_to_json(Obj,"primary", primary);
 	}
 
-	bool MobilePhoneNumber::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool MobilePhoneNumber::from_json(Poco::JSON::Object::Ptr Obj) {
 	    try {
 	        field_from_json(Obj,"number",number);
 	        field_from_json(Obj,"verified",verified);
@@ -155,7 +155,7 @@ namespace OpenWifi::SecurityObjects {
 	    field_to_json(Obj,"method", method);
 	}
 
-	bool MfaAuthInfo::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool MfaAuthInfo::from_json(Poco::JSON::Object::Ptr Obj) {
 	    try {
 	        field_from_json(Obj,"enabled",enabled);
 	        field_from_json(Obj,"method",method);
@@ -171,7 +171,7 @@ namespace OpenWifi::SecurityObjects {
 	    field_to_json(Obj, "mfa", mfa);
 	}
 
-	bool UserLoginLoginExtensions::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool UserLoginLoginExtensions::from_json(Poco::JSON::Object::Ptr Obj) {
 	    try {
 	        field_from_json(Obj,"mobiles",mobiles);
 	        field_from_json(Obj,"mfa",mfa);
@@ -189,7 +189,7 @@ namespace OpenWifi::SecurityObjects {
         field_to_json(Obj, "method", method);
     }
 
-    bool MFAChallengeRequest::from_json(Poco::JSON::Object::Ptr &Obj) {
+    bool MFAChallengeRequest::from_json(Poco::JSON::Object::Ptr Obj) {
 	    try {
 	        field_from_json(Obj,"uuid",uuid);
 	        field_from_json(Obj,"question",question);
@@ -208,7 +208,7 @@ namespace OpenWifi::SecurityObjects {
 
     }
 
-    bool MFAChallengeResponse::from_json(Poco::JSON::Object::Ptr &Obj) {
+    bool MFAChallengeResponse::from_json(Poco::JSON::Object::Ptr Obj) {
         try {
             field_from_json(Obj,"uuid",uuid);
             field_from_json(Obj,"answer",answer);
@@ -387,12 +387,11 @@ namespace OpenWifi::SecurityObjects {
 		field_to_json(Obj,"note", note);
 	}
 
-	bool NoteInfo::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool NoteInfo::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"created",created);
 			field_from_json(Obj,"createdBy",createdBy);
 			field_from_json(Obj,"note",note);
-			return true;
 		} catch(...) {
 
 		}
@@ -429,11 +428,10 @@ namespace OpenWifi::SecurityObjects {
 		field_to_json<ResourceAccessType>(Obj,"access", access, ResourceAccessTypeToString);
 	}
 
-	bool ProfileAction::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool ProfileAction::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"resource",resource);
 			field_from_json<ResourceAccessType>(Obj,"access",access,ResourceAccessTypeFromString );
-			return true;
 		} catch(...) {
 
 		}
@@ -449,7 +447,7 @@ namespace OpenWifi::SecurityObjects {
 		field_to_json(Obj,"notes", notes);
 	}
 
-	bool SecurityProfile::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool SecurityProfile::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"id",id);
 			field_from_json(Obj,"name",name);
@@ -457,7 +455,6 @@ namespace OpenWifi::SecurityObjects {
 			field_from_json(Obj,"policy",policy);
 			field_from_json(Obj,"role",role);
 			field_from_json(Obj,"notes",notes);
-			return true;
 		} catch(...) {
 
 		}
@@ -468,51 +465,13 @@ namespace OpenWifi::SecurityObjects {
 		field_to_json(Obj, "profiles", profiles);
 	}
 
-	bool SecurityProfileList::from_json(Poco::JSON::Object::Ptr &Obj) {
+	bool SecurityProfileList::from_json(Poco::JSON::Object::Ptr Obj) {
 		try {
 			field_from_json(Obj,"profiles",profiles);
-			return true;
 		} catch(...) {
 
 		}
 		return false;
 	}
-
-    void ActionLink::to_json(Poco::JSON::Object &Obj) const {
-	    field_to_json(Obj,"id",id);
-	    field_to_json(Obj,"action",action);
-	    field_to_json(Obj,"userId",userId);
-	    field_to_json(Obj,"actionTemplate",actionTemplate);
-	    field_to_json(Obj,"variables",variables);
-	    field_to_json(Obj,"locale",locale);
-	    field_to_json(Obj,"message",message);
-	    field_to_json(Obj,"sent",sent);
-	    field_to_json(Obj,"created",created);
-	    field_to_json(Obj,"expires",expires);
-	    field_to_json(Obj,"completed",completed);
-	    field_to_json(Obj,"canceled",canceled);
-
-	}
-
-    bool ActionLink::from_json(Poco::JSON::Object::Ptr &Obj) {
-	    try {
-	        field_from_json(Obj,"id",id);
-	        field_from_json(Obj,"action",action);
-	        field_from_json(Obj,"userId",userId);
-	        field_from_json(Obj,"actionTemplate",actionTemplate);
-	        field_from_json(Obj,"variables",variables);
-	        field_from_json(Obj,"locale",locale);
-	        field_from_json(Obj,"message",message);
-	        field_from_json(Obj,"sent",sent);
-	        field_from_json(Obj,"created",created);
-	        field_from_json(Obj,"expires",expires);
-	        field_from_json(Obj,"completed",completed);
-	        field_from_json(Obj,"canceled",canceled);
-	        return true;
-	    } catch(...) {
-
-	    }
-	    return false;
-	}
 }
 

src/RESTObjects/RESTAPI_SecurityObjects.h

@@ -10,7 +10,7 @@
 #define UCENTRAL_RESTAPI_SECURITYOBJECTS_H
 
 #include "Poco/JSON/Object.h"
-#include "framework/OpenWifiTypes.h"
+#include "../framework/OpenWifiTypes.h"
 
 namespace OpenWifi::SecurityObjects {
 
@@ -53,25 +53,25 @@ namespace OpenWifi::SecurityObjects {
 		std::string createdBy;
 		std::string note;
 		void to_json(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 	typedef std::vector<NoteInfo>	NoteInfoVec;
 
 	struct MobilePhoneNumber {
 	    std::string number;
-	    bool verified = false;
-	    bool primary = false;
+	    bool verified;
+	    bool primary;
 
 	    void to_json(Poco::JSON::Object &Obj) const;
-	    bool from_json(Poco::JSON::Object::Ptr &Obj);
+	    bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
 	struct MfaAuthInfo {
-	    bool enabled = false;
+	    bool enabled;
 	    std::string method;
 
 	    void to_json(Poco::JSON::Object &Obj) const;
-	    bool from_json(Poco::JSON::Object::Ptr &Obj);
+	    bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
 	struct UserLoginLoginExtensions {
@@ -79,17 +79,17 @@ namespace OpenWifi::SecurityObjects {
 	    struct MfaAuthInfo mfa;
 
 	    void to_json(Poco::JSON::Object &Obj) const;
-	    bool from_json(Poco::JSON::Object::Ptr &Obj);
+	    bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
 	struct MFAChallengeRequest {
 	    std::string uuid;
 	    std::string question;
 	    std::string method;
-	    uint64_t    created = std::time(nullptr);
+	    uint64_t    created;
 
 	    void to_json(Poco::JSON::Object &Obj) const;
-	    bool from_json(Poco::JSON::Object::Ptr &Obj);
+	    bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 
     struct MFAChallengeResponse {
@@ -97,7 +97,7 @@ namespace OpenWifi::SecurityObjects {
         std::string answer;
 
         void to_json(Poco::JSON::Object &Obj) const;
-        bool from_json(Poco::JSON::Object::Ptr &Obj);
+        bool from_json(Poco::JSON::Object::Ptr Obj);
     };
 
 	struct UserInfo {
@@ -200,7 +200,7 @@ namespace OpenWifi::SecurityObjects {
 		std::string resource;
 		ResourceAccessType access;
 		void to_json(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 	typedef std::vector<ProfileAction>	ProfileActionVec;
 
@@ -212,37 +212,14 @@ namespace OpenWifi::SecurityObjects {
 		std::string role;
 		NoteInfoVec notes;
 		void to_json(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 	typedef std::vector<SecurityProfile> SecurityProfileVec;
 
 	struct SecurityProfileList {
 		SecurityProfileVec profiles;
 		void to_json(Poco::JSON::Object &Obj) const;
-		bool from_json(Poco::JSON::Object::Ptr &Obj);
-	};
-
-	enum LinkActions {
-	    FORGOT_PASSWORD=1,
-	    VERIFY_EMAIL
-	};
-
-	struct ActionLink {
-	    std::string         id;
-	    uint64_t            action;
-	    std::string         userId;
-	    std::string         actionTemplate;
-	    Types::StringPairVec variables;
-	    std::string         locale;
-	    std::string         message;
-	    uint64_t            sent=0;
-	    uint64_t            created=std::time(nullptr);
-	    uint64_t            expires=0;
-	    uint64_t            completed=0;
-	    uint64_t            canceled=0;
-
-        void to_json(Poco::JSON::Object &Obj) const;
-	    bool from_json(Poco::JSON::Object::Ptr &Obj);
+		bool from_json(Poco::JSON::Object::Ptr Obj);
 	};
 }
 

src/StorageService.cpp

@@ -10,6 +10,8 @@
 
 namespace OpenWifi {
 
+    class Storage *Storage::instance_ = nullptr;
+
     int Storage::Start() {
         std::lock_guard		Guard(Mutex_);
 

src/StorageService.h

@@ -59,12 +59,14 @@ namespace OpenWifi {
         bool GenerateDeviceReport(FMSObjects::DeviceReport &Report);
         static std::string TrimRevision(const std::string &R);
         static Storage *instance() {
-            static Storage *instance_ = new Storage;
+            if (instance_ == nullptr) {
+                instance_ = new Storage;
+            }
             return instance_;
         }
 
 	  private:
-
+		static Storage      							    *instance_;
     };
 
     inline class Storage * StorageService() { return Storage::instance(); };

src/framework/ConfigurationValidator.h

@@ -1,46 +0,0 @@
-//
-// Created by stephane bourque on 2021-09-14.
-//
-
-#ifndef OWPROV_CONFIGURATIONVALIDATOR_H
-#define OWPROV_CONFIGURATIONVALIDATOR_H
-
-#include <nlohmann/json-schema.hpp>
-#include "framework/MicroService.h"
-
-using nlohmann::json;
-using nlohmann::json_schema::json_validator;
-
-namespace OpenWifi {
-    class ConfigurationValidator : public  SubSystemServer {
-    public:
-
-        static ConfigurationValidator *instance() {
-            if(instance_== nullptr)
-                instance_ = new ConfigurationValidator;
-            return instance_;
-        }
-
-        bool Validate(const std::string &C, std::string &Error);
-        static void my_format_checker(const std::string &format, const std::string &value);
-        int Start() override;
-        void Stop() override;
-        void reinitialize(Poco::Util::Application &self) override;
-
-    private:
-        static  ConfigurationValidator * instance_;
-        bool            Initialized_=false;
-        bool            Working_=false;
-        void            Init();
-        std::unique_ptr<json_validator>  Validator_=std::make_unique<json_validator>(nullptr, my_format_checker);
-
-        ConfigurationValidator():
-            SubSystemServer("configvalidator", "CFG-VALIDATOR", "config.validator") {
-        }
-    };
-
-    inline ConfigurationValidator * ConfigurationValidator() { return ConfigurationValidator::instance(); }
-    inline bool ValidateUCentralConfiguration(const std::string &C, std::string &Error) { return ConfigurationValidator::instance()->Validate(C, Error); }
-}
-
-#endif //OWPROV_CONFIGURATIONVALIDATOR_H

src/framework/RESTAPI_errors.h

@@ -47,19 +47,13 @@ namespace OpenWifi::RESTAPI::Errors {
     static const std::string IdMustBe0{"To create a user, you must set the ID to 0"};
     static const std::string InvalidUserRole{"Invalid userRole."};
     static const std::string InvalidEmailAddress{"Invalid email address."};
+    static const std::string InvalidPassword{"Invalid password."};
     static const std::string PasswordRejected{"Password was rejected. This maybe an old password."};
     static const std::string InvalidIPRanges{"Invalid IP range specifications."};
     static const std::string InvalidLOrderBy{"Invalid orderBy specification."};
     static const std::string NeedMobileNumber{"You must provide at least one validated phone number."};
     static const std::string BadMFAMethod{"MFA only supports sms or email."};
-    static const std::string InvalidCredentials{"Invalid credentials (username/password)."};
-    static const std::string InvalidPassword{"Password does not conform to basic password rules."};
-    static const std::string UserPendingVerification{"User access denied pending email verification."};
-    static const std::string PasswordMustBeChanged{"Password must be changed."};
-    static const std::string UnrecognizedRequest{"Ill-formed request. Please consult documentation."};
-    static const std::string MissingAuthenticationInformation{"Missing authentication information."};
-    static const std::string InsufficientAccessRights{"Insufficient access rights to complete the operation."};
-    static const std::string ExpiredToken{"Token has expired, user must login."};
+
 }
 
 #endif //OWPROV_RESTAPI_ERRORS_H

src/framework/StorageClass.h

@@ -2,7 +2,8 @@
 // Created by stephane bourque on 2021-10-06.
 //
 
-#pragma once
+#ifndef OPENWIFI_STORAGE_H
+#define OPENWIFI_STORAGE_H
 
 #include "Poco/Data/Session.h"
 #include "Poco/Data/SessionPool.h"
@@ -25,6 +26,13 @@ namespace OpenWifi {
 
     class StorageClass : public SubSystemServer {
     public:
+/*        static StorageClass *instance() {
+            if (instance_ == nullptr) {
+                instance_ = new StorageClass;
+            }
+            return instance_;
+        }
+*/
         StorageClass() noexcept:
             SubSystemServer("StorageClass", "STORAGE-SVR", "storage")
         {
@@ -48,18 +56,18 @@ namespace OpenWifi {
         }
 
         void Stop() override {
-            Pool_->shutdown();
+
         }
 
         [[nodiscard]] inline std::string ComputeRange(uint64_t From, uint64_t HowMany) {
             if(dbType_==sqlite) {
-                return " LIMIT " + std::to_string(From) + ", " + std::to_string(HowMany) + " ";
+                return " LIMIT " + std::to_string(From-1) + ", " + std::to_string(HowMany) + " ";
             } else if(dbType_==pgsql) {
-                return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From) + " ";
+                return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From-1) + " ";
             } else if(dbType_==mysql) {
-                return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From) + " ";
+                return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From-1) + " ";
             }
-            return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From) + " ";
+            return " LIMIT " + std::to_string(HowMany) + " OFFSET " + std::to_string(From-1) + " ";
         }
 
         inline std::string ConvertParams(const std::string & S) const {
@@ -88,13 +96,15 @@ namespace OpenWifi {
         inline int Setup_PostgreSQL();
 
     protected:
-    	Poco::SharedPtr<Poco::Data::SessionPool>    Pool_;
-        Poco::Data::SQLite::Connector  	            SQLiteConn_;
-        Poco::Data::PostgreSQL::Connector           PostgresConn_;
-        Poco::Data::MySQL::Connector                MySQLConn_;
-        DBType                                      dbType_ = sqlite;
+        std::unique_ptr<Poco::Data::SessionPool>        	Pool_;
+        std::unique_ptr<Poco::Data::SQLite::Connector>  	SQLiteConn_;
+        std::unique_ptr<Poco::Data::PostgreSQL::Connector>  PostgresConn_;
+        std::unique_ptr<Poco::Data::MySQL::Connector>       MySQLConn_;
+        DBType                                              dbType_ = sqlite;
     };
 
+//    inline StorageClass * Storage() { return StorageClass::instance(); }
+
 #ifdef	SMALL_BUILD
     int Service::Setup_MySQL() { Daemon()->exit(Poco::Util::Application::EXIT_CONFIG); return 0; }
     int Service::Setup_PostgreSQL() { Daemon()->exit(Poco::Util::Application::EXIT_CONFIG); return 0; }
@@ -106,8 +116,9 @@ namespace OpenWifi {
         auto DBName = MicroService::instance().DataDir() + "/" + MicroService::instance().ConfigGetString("storage.type.sqlite.db");
         auto NumSessions = MicroService::instance().ConfigGetInt("storage.type.sqlite.maxsessions", 64);
         auto IdleTime = MicroService::instance().ConfigGetInt("storage.type.sqlite.idletime", 60);
-        SQLiteConn_.registerConnector();
-        Pool_ = Poco::SharedPtr<Poco::Data::SessionPool>(new Poco::Data::SessionPool(SQLiteConn_.name(), DBName, 4, NumSessions, IdleTime));
+        SQLiteConn_ = std::make_unique<Poco::Data::SQLite::Connector>();
+        SQLiteConn_->registerConnector();
+        Pool_ = std::make_unique<Poco::Data::SessionPool>(SQLiteConn_->name(), DBName, 4, NumSessions, IdleTime);
         return 0;
     }
 
@@ -130,8 +141,9 @@ namespace OpenWifi {
                 ";port=" + Port +
                 ";compress=true;auto-reconnect=true";
 
-        MySQLConn_.registerConnector();
-        Pool_ = Poco::SharedPtr<Poco::Data::SessionPool>(new Poco::Data::SessionPool(MySQLConn_.name(), ConnectionStr, 4, NumSessions, IdleTime));
+        MySQLConn_ = std::make_unique<Poco::Data::MySQL::Connector>();
+        MySQLConn_->registerConnector();
+        Pool_ = std::make_unique<Poco::Data::SessionPool>(MySQLConn_->name(), ConnectionStr, 4, NumSessions, IdleTime);
 
         return 0;
     }
@@ -156,11 +168,14 @@ namespace OpenWifi {
                 " port=" + Port +
                 " connect_timeout=" + ConnectionTimeout;
 
-        PostgresConn_.registerConnector();
-        Pool_ = Poco::SharedPtr<Poco::Data::SessionPool>(new Poco::Data::SessionPool(PostgresConn_.name(), ConnectionStr, 4, NumSessions, IdleTime));
+        PostgresConn_ = std::make_unique<Poco::Data::PostgreSQL::Connector>();
+        PostgresConn_->registerConnector();
+        Pool_ = std::make_unique<Poco::Data::SessionPool>(PostgresConn_->name(), ConnectionStr, 4, NumSessions, IdleTime);
 
         return 0;
     }
 #endif
 
 }
+
+#endif //OPENWIFI_STORAGE_H

src/ow_version.h.in

@@ -1,13 +0,0 @@
-//
-// Created by stephane bourque on 2021-12-06.
-//
-
-#pragma once
-
-#include <string>
-
-namespace OW_VERSION {
-    inline static const std::string VERSION{"@CMAKE_PROJECT_VERSION@"};
-    inline static const std::string BUILD{"@BUILD_NUM@"};
-    inline static const std::string HASH{"@GIT_HASH@"};
-}

src/storage/storage_firmwares.cpp

@@ -61,11 +61,11 @@ namespace OpenWifi {
             Poco::Data::Statement   Insert(Sess);
 
             // find the older software and change to latest = 0
-            F.id = MicroService::CreateUUID();
+            F.id = MicroService::instance().CreateUUID();
             if(LatestFirmwareCache()->AddToCache(F.deviceType,F.revision,F.id,F.imageDate)) {
                 F.latest = true ;
                 Poco::Data::Statement   Update(Sess);
-                std::string st{"UPDATE " + DBNAME_FIRMWARES + " SET latest=false WHERE deviceType=? AND Latest=true"};
+                std::string st{"UPDATE " + DBNAME_FIRMWARES + " SET latest=0 WHERE deviceType=? AND Latest=1"};
                 Update <<   ConvertParams(st),
                             Poco::Data::Keywords::use(F.deviceType);
                 Update.execute();

src/storage/storage_firmwares.h

@@ -25,7 +25,7 @@ namespace OpenWifi {
             "location           varchar, "
             "uploader           varchar, "
             "digest             varchar, "
-            "latest             boolean,  "
+            "latest             int,  "
             "notes              text, "
             "created            bigint"
     };
@@ -88,7 +88,7 @@ namespace OpenWifi {
             std::string,
             std::string,
             std::string,
-            bool,
+            uint64_t,
             std::string,
             uint64_t> FirmwaresRecord;
     typedef std::vector<FirmwaresRecord> FirmwaresRecordList;

src/storage/storage_history.cpp

@@ -92,7 +92,7 @@ namespace OpenWifi {
 
     bool Storage::AddHistory( std::string & SerialNumber, std::string &DeviceType, std::string & PreviousRevision, std::string & NewVersion) {
             FMSObjects::RevisionHistoryEntry    History{
-                .id = MicroService::CreateUUID(),
+                .id = Daemon()->CreateUUID(),
                 .serialNumber = SerialNumber,
                 .fromRelease = PreviousRevision,
                 .toRelease = NewVersion,

wait-for-postgres.sh

@@ -1,26 +0,0 @@
-#!/bin/sh
-# wait-for-postgres.sh
-
-set -e
-  
-host="$1"
-shift
-
-export PGUSER=$(grep 'storage.type.postgresql.username' $OWFMS_CONFIG/owfms.properties | awk -F '= ' '{print $2}')
-export PGPASSWORD=$(grep 'storage.type.postgresql.password' $OWFMS_CONFIG/owfms.properties | awk -F '= ' '{print $2}')
-  
-until psql -h "$host" -c '\q'; do
-  >&2 echo "Postgres is unavailable - sleeping"
-  sleep 1
-done
-  
->&2 echo "Postgres is up - executing command"
-
-if [ "$1" = '/openwifi/owfms' -a "$(id -u)" = '0' ]; then
-    if [ "$RUN_CHOWN" = 'true' ]; then
-      chown -R "$OWFMS_USER": "$OWFMS_ROOT" "$OWFMS_CONFIG"
-    fi
-    exec su-exec "$OWFMS_USER" "$@"
-fi
-
-exec "$@"