Commit Graph

5162 Commits

Author SHA1 Message Date
Ben Greear
c5ddccbdfd generic-cx: code cleanup and return error checking.
Clean up monitor logic in gen_cx profile to remove useless sleeps
and rename a variable that indicated it was msec but which was actually
seconds.

test_generic gets better error checking and also fixes bugs in how it
monitors the connection.  More work yet is needed for making the
monitor do a good pass/fail logic.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
d532d7f8bf logging: Add set_json logic to lf_logger_config
This will be common code, put it in the helper class.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
2f3eb58c41 Add --log_level option to lfcli base class.
Let user specify the level of logging desired.
Test implementaiton in example_security_connection.py

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
24e75a8ab3 create_l4.py : changed prints to logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
0f1ffdd0ee l4_cxprofile.py : moved prints to logger
create_l4.py : moved prints to logger -needed for testing

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
f0fdc40cca l3_cxprofile.py : moved logger debug back behind if debug or if self.debug
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
90be6e8dfd py-json/station_profile.py : moved logger.debug back behind if self.debug
and if debug

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
c099c578b8 realm.py : changed prints to logger messages
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
793a215e2b Add logging to example_security_connection script.
And add some more error checking with potential to exit
early if requested.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
41f587e424 lfutils: wait_until_ports_disappear will return True or False
In all return paths.
And remove redundant check for being done removing ports or not.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
40bc34f04d LFUtils.py : changes prints to logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
4067621b40 gen_cxprofile.py : changed pprint to logger and pformat
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Logan Lipke
b8787de105 lf_webpage.py: Added multi resource compatibility, started logging implementation, still WIP 2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
eea68062c0 gen_cxprofile.py : changed prints to logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Scott Wedge
22a4473c7d http_profile.py: update def create() for resource-2 tests, add logging module
Signed-off-by: Scott Wedge <scott.wedge@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
2164d5fc16 l3_cxprofile.py : updated to use logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
ff56cdccfb test_l3_unicast_traffic_gen: Fix improper station creation in test_l3_unicast_traffic_gen
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
e824080c24 regression_test: Use eval so that commands with quotes are properly executed
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
ec3a09b60f LFUtils: When debug is on, clearly state all stations have appeared in success case
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
3426f22bcc test_l3.py : pep8 , white space changes
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
109d24e505 test_l3.py added exit(0) for pass , exit(1) for fail
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
1dc0a5c2ab py-json/station_profile.py : prints changed to logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
f4ecff6bb4 regression-test: Always produce an HTML report
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
56f8c0a820 regression_test: don't quote the command when not in an eval command
add test_l3 to regression_test

Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
ae78aee979 regression_test: Fix scenario.py method call
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
261b491b23 create_l3_stations: remove trailing semicolons and make argumentse explicit
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Ben Greear
615dd1c9c3 regression-test: check test script return code to detect failure.
Also:  merge stderr/stdout, add more specific help example,
allow configuring report dir, add safety check for missing 'jq'.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
57f8a83020 lf_logger_config_test.py : removed spacing from simple logger format, added filename
lf_logger_config_test.py : updated to show example of using lf_logger_config.json one directy up
lf_logger_config.json , lf_logger_config_example.json : updated with simple format

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
d697963cec create-cx: Add return code checking for cx and endp creation.
Check for false value in create_l3_stations and return error code
upon failure.

Add configurable timeout to waiting for cx/endp logic.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Ben Greear
4bb9cb4b82 l3-stations: error checking for station creation.
In station_profile create method, pay attention to result of
wait_until_ports_appear.  If it returns False, we know creation
has failed somehow, so we do not need to do the extra checking
that was in the create() method.

create_l3_stations adds logic to check return code of station
create logic, and exit with error code if it could not
create them as expected.

Signed-off-by: Ben Greear <greearb@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
12add4503a py-json/realm.py : moved back to using lists (original code from a couple
of days ago)

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
d3035aca57 test_l3_longevity.py : changed printed errors to raise ValueError so script
exits on mis configuration

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
4acd3beb29 realm.py : removed the len(endpoint) > 1
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
676bcab1d7 lfcli_base.check_connect: Replace while loop with for loop for additional security.
Add timeout argument

Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
a9e0189e8d Revert "realm.wait_until_ports_disappear: endp_list needs a length greater than 0, not 1"
This reverts commit 68fcf480818432a0926e8c7d1ccc621f52cfbb06.
2022-07-12 15:45:45 +05:30
Matthew Stidham
a9c6ab4f12 realm.wait_until_ports_disappear: endp_list needs a length greater than 0, not 1
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
629069cfad realm.wait_until_endps_appear: check to make sure there is a port in the endpoints list
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
d131abe916 realm.wait_until_endps_appear: Replace try: except: loop with if condition, so we don't potentially hide bugs
remove unnecessary variables

Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
282667b861 LFUtils: Use pythonic name for get_as_json
Replace all while loops with for loops, for security

Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
02dd8e41d5 sandbox/lf_logger_config_example.json : multiple loggers in one module test
sandbox/lf_sublogger_2.py : testing multiple loggers

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
e128a6aa5f LFUtils.wait_until_ports_appear: alert the user if a port is phantom
Use a for loop for increased stability
remove deprecated variables

Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
1ced503244 lf_logger_config.py : default root logger to info form warning
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
43e6b7ef09 test_generic: Switch from print statements to logger statements
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
7ad7f003c7 lfcli_base.py added --lf_logger_config_json to base args
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
944021855a station_profile: Timestamp printing needed an additional parentheses
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Matthew Stidham
df5879fc77 sta_connect.setup: check_exists should be used as an argument in rm_port, the existing code was probably from before we had the check_exists method
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
0c9215abb5 lf_logger_config_example.json : sandbox example for using logging config
lf_logger_config_test.py : example program
lf_sublogger.py : included module sample
lf_sublogger_2.py : included an inherited module same.

This code is for becomming familiar with the logging module
2022-07-12 15:45:45 +05:30
Matthew Stidham
b7236d5007 sta_connect2: wait_until_ports_appear needs list of ports
Signed-off-by: Matthew Stidham <stidmatt@gmail.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
a4eb0fceb9 lf_logger_config.json : the defaults in the file may need to be worked out,
or just that there will be custome configurations
test_l3.py : intial pass of using the logger functionality

Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30
Chuck SmileyRekiere
eb63792064 test_l3.py : updated to use logger
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
2022-07-12 15:45:45 +05:30