Compare commits

...

2 Commits

Author SHA1 Message Date
Lynn Shi
83e4f3613a WIFI-5424 Max Auto Cell Size in RF Profile should be non-configurable parameter 2021-11-02 11:56:37 -04:00
norm-traxler
aa77c4a2d5 Merge pull request #168 from Telecominfraproject/InventoryIdFix
Changing BE code to trim the name and inventoryId
2021-10-28 16:34:16 -04:00
2 changed files with 18 additions and 7 deletions

View File

@@ -327,17 +327,16 @@ public class RfElementConfiguration extends BaseJsonModel {
this.minAutoCellSize = minAutoCellSize;
}
//Always return default value
public Integer getMaxAutoCellSize() {
if (maxAutoCellSize == null) {
if (MAX_CELL_SIZE_MAP.containsKey(this.radioType)) {
return MAX_CELL_SIZE_MAP.get(this.radioType);
} else {
return MAX_CELL_SIZE_MAP.get(RadioType.is2dot4GHz);
}
if (MAX_CELL_SIZE_MAP.containsKey(this.radioType)) {
return MAX_CELL_SIZE_MAP.get(this.radioType);
} else {
return MAX_CELL_SIZE_MAP.get(RadioType.is2dot4GHz);
}
return maxAutoCellSize;
}
// not allow user to configure
public void setMaxAutoCellSize(Integer maxAutoCellSize) {
this.maxAutoCellSize = maxAutoCellSize;
}

View File

@@ -93,4 +93,16 @@ public class RfConfigurationTests {
assertEquals(Integer.valueOf(23), list2.get(2));
assertEquals(Integer.valueOf(45), list2.get(3));
}
@Test
public void testMaxAutoCellSize() {
RfElementConfiguration rfConfig = RfElementConfiguration.createWithDefaults(RadioType.is5GHz);
assertNotNull(rfConfig.getMaxAutoCellSize());
assertEquals(RfElementConfiguration.DEFAULT_MAX_CELL_SIZE_DB, rfConfig.getMaxAutoCellSize().intValue());
rfConfig.setMaxAutoCellSize(-93);
//getMaxAutoCellSize always return default MaxAutoCellSize
assertEquals(RfElementConfiguration.DEFAULT_MAX_CELL_SIZE_DB, rfConfig.getMaxAutoCellSize().intValue());
}
}