github-personal/debos
1
0
Fork 0
mirror of https://github.com/outbackdingo/debos.git synced 2026-01-27 10:18:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions: filesystem-deploy: Defer Close() call on file handles

Browse Source 
Make use of defer when closing file handles.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
This commit is contained in:
Christopher Obbard
2024-12-17 16:03:00 +00:00
parent 0159549e44
commit 8dc9cbce60
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
actions/filesystem_deploy_action.go
View File

@@ -68,6 +68,7 @@ func (fd *FilesystemDeployAction) setupFSTab(context *debos.DebosContext) error
fstab := path.Join(context.Rootdir, "etc/fstab")
f, err := os.OpenFile(fstab, os.O_RDWR|os.O_CREATE, 0755)
defer f.Close()
if err != nil {
return fmt.Errorf("Couldn't open /etc/fstab: %v", err)
@@ -78,7 +79,6 @@ func (fd *FilesystemDeployAction) setupFSTab(context *debos.DebosContext) error
if err != nil {
return fmt.Errorf("Couldn't write /etc/fstab: %v", err)
}
f.Close()
return nil
}
@@ -95,6 +95,7 @@ func (fd *FilesystemDeployAction) setupKernelCmdline(context *debos.DebosContext
path := path.Join(context.Rootdir, "etc/kernel/cmdline")
current, _ := ioutil.ReadFile(path)
f, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE, 0755)
defer f.Close()
if err != nil {
log.Fatalf("Couldn't open /etc/kernel/cmdline: %v", err)
@@ -112,7 +113,6 @@ func (fd *FilesystemDeployAction) setupKernelCmdline(context *debos.DebosContext
return fmt.Errorf("Couldn't write /etc/kernel/cmdline: %v", err)
}
f.Close()
return nil
}