github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 18:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): Only trigger Apple artifact uploads on workflow_dispatch trigger (#7611)

Browse Source 
Unfortunately Apple's API doesn't expect to be hit this frequently and
also doesn't respond with obvious errors when we ask too much of it.

Because of this, we move the App Store connect upload back to manual
trigger only, and update the standalone upload to GitHub releases to the
same because it needs to hit Apple's notary service API.
This commit is contained in:
Jamil
2024-12-30 11:26:45 -08:00
committed by GitHub
parent a1337d011c
commit 214da6153e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/_swift.yml vendored
View File

@@ -71,7 +71,7 @@ jobs:
API_KEY_ID: "${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY_ID }}"
API_KEY: "${{ secrets.APPLE_APP_STORE_CONNECT_API_KEY }}"
- run: ${{ matrix.upload-script }}
if: "${{ github.event_name == 'workflow_dispatch' || github.ref_name == 'main' }}"
if: "${{ github.event_name == 'workflow_dispatch' }}"
env:
ARTIFACT_PATH: "${{ runner.temp }}/${{ matrix.artifact-file }}"
ISSUER_ID: "${{ secrets.APPLE_APP_STORE_CONNECT_ISSUER_ID }}"