github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 18:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(portal): Allow .local for search_domains (#8472)

Browse Source 
This apparently is explicitly used by customers. See
https://firezonehq.slack.com/archives/C08FPHECLUF/p1742221580587719?thread_ts=1741639183.188459&cid=C08FPHECLUF
This commit is contained in:
Jamil
2025-03-17 15:18:51 -05:00
committed by GitHub
parent e642eefb35
commit 4ce2f160e3
2 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
elixir/apps/domain/lib/domain/accounts/config/changeset.ex
View File

@@ -31,9 +31,6 @@ defmodule Domain.Accounts.Config.Changeset do
String.starts_with?(domain, ".") ->
[search_domain: "must not start with a dot"]
String.ends_with?(domain, ".local") || String.ends_with?(domain, ".local.") ->
[search_domain: "must not end with .local"]
String.contains?(domain, "..") ->
[search_domain: "must not contain consecutive dots"]

12
elixir/apps/domain/test/domain/accounts_test.exs
View File

@@ -631,20 +631,16 @@ defmodule Domain.AccountsTest do
}
end
test "returns error when search_domain ends with .local", %{account: account} do
# Explicitly used by customers
test "allows search_domains that end with .local", %{account: account} do
attrs = %{
config: %{
search_domain: "test.local"
}
}
assert {:error, changeset} = update_account_by_id(account.id, attrs)
assert errors_on(changeset) == %{
config: %{
search_domain: ["must not end with .local"]
}
}
assert {:ok, account} = update_account_by_id(account.id, attrs)
assert account.config.search_domain == "test.local"
end
test "returns error when search_domain contains consecutive dots", %{account: account} do