mirror of
https://github.com/outbackdingo/firezone.git
synced 2026-01-27 10:18:54 +00:00
fix(connlib): ensure we don't mistake SYN-ACK for SYN (#8922)
This shouldn't matter because we are only using the `UniquePacketBuffer` on the client and not on the Gateway where SYN-ACK packets would be sent from. To be fully correct though, we need to also compare the ACK flag of the two packets.
This commit is contained in:
@@ -74,7 +74,9 @@ fn is_tcp_syn_retransmit(buffered: &IpPacket, new: &IpPacket) -> bool {
|
||||
};
|
||||
|
||||
buffered.syn()
|
||||
&& !buffered.ack()
|
||||
&& new.syn()
|
||||
&& !new.ack()
|
||||
&& buffered.source_port() == new.source_port()
|
||||
&& buffered.destination_port() == new.destination_port()
|
||||
&& buffered.sequence_number() == new.sequence_number()
|
||||
|
||||
Reference in New Issue
Block a user