refactor(apple/ios): Remove incorrect use of Task {} (#7700)

This code doesn't make sense:

 - In the Adapter, we are not running on the main UI thread
 - In this callback, we are running on the `workQueue` anyway
 - `Task` is not how to spawn a new thread in Swift strictly speaking
This commit is contained in:
Jamil
2025-01-08 10:02:34 -08:00
committed by GitHub
parent 99d77a84cd
commit 78d92036b4

View File

@@ -313,23 +313,20 @@ extension Adapter {
}
if shouldFetchSystemResolvers(path: path) {
// Spawn a new thread to avoid blocking the UI on iOS
Task {
let resolvers = getSystemDefaultResolvers(
interfaceName: path.availableInterfaces.first?.name)
let resolvers = getSystemDefaultResolvers(
interfaceName: path.availableInterfaces.first?.name)
if lastFetchedResolvers != resolvers,
let jsonResolvers = try? String(
decoding: JSONEncoder().encode(resolvers), as: UTF8.self
).intoRustString()
{
if lastFetchedResolvers != resolvers,
let jsonResolvers = try? String(
decoding: JSONEncoder().encode(resolvers), as: UTF8.self
).intoRustString()
{
// Update connlib DNS
session.setDns(jsonResolvers)
// Update connlib DNS
session.setDns(jsonResolvers)
// Update our state tracker
lastFetchedResolvers = resolvers
}
// Update our state tracker
lastFetchedResolvers = resolvers
}
}