github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(connlib): add message type to the no records found logs (#5641)

Browse Source 
Added for clarity when debugging, it used to look like:

```
2024-06-30T00:16:05.718337Z DEBUG firezone_tunnel::dns: No records for github.com, returning NXDOMAIN
```

And now looks like:

```
2024-06-30T00:16:05.718337Z DEBUG firezone_tunnel::dns: No MX records for github.com, returning NXDOMAIN
```
This commit is contained in:
Gabi
2024-07-01 20:15:44 -03:00
committed by GitHub
parent e046987a69
commit 79fd8f6063
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
rust/connlib/tunnel/src/dns.rs
View File

@@ -290,7 +290,8 @@ impl StubResolver {
tracing::trace!("Parsed packet as DNS query: '{question}'");
if let Some(records) = self.known_hosts.get_records(&question) {
let response = build_dns_with_answer(message, question.qname(), records)?;
let response =
build_dns_with_answer(message, question.qname(), question.qtype(), records)?;
return Some(ResolveStrategy::LocalResponse(build_response(
packet, response,
)));
@@ -306,7 +307,12 @@ impl StubResolver {
let resource_records = self.get_records(&question);
let response = build_dns_with_answer(message, question.qname(), resource_records)?;
let response = build_dns_with_answer(
message,
question.qname(),
question.qtype(),
resource_records,
)?;
Some(ResolveStrategy::LocalResponse(build_response(
packet, response,
)))
@@ -389,6 +395,7 @@ fn build_response(original_pkt: IpPacket<'_>, mut dns_answer: Vec<u8>) -> IpPack
fn build_dns_with_answer<N>(
message: &Message<[u8]>,
qname: &N,
qtype: Rtype,
records: Vec<RecordData<DomainName>>,
) -> Option<Vec<u8>>
where
@@ -400,7 +407,10 @@ where
);
if records.is_empty() {
tracing::debug!("No records for {}, returning NXDOMAIN", qname.to_vec());
tracing::debug!(
"No {qtype} records for {}, returning NXDOMAIN",
qname.to_vec()
);
return Some(
msg_builder
.start_answer(message, Rcode::NXDOMAIN)