github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(portal): Increase group name max length (#4128)

Browse Source 
Fixes
https://firezonehq.slack.com/archives/C05JUKPT83T/p1710324078226719
This commit is contained in:
Andrew Dryga
2024-03-13 12:38:09 -06:00
committed by GitHub
parent 52cde610e1
commit 7fd3d1a6b1
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
elixir/apps/domain/lib/domain/actors/group/changeset.ex
View File

@@ -57,7 +57,7 @@ defmodule Domain.Actors.Group.Changeset do
defp changeset(changeset) do
changeset
|> trim_change(:name)
|> validate_length(:name, min: 1, max: 64)
|> validate_length(:name, min: 1, max: 255)
|> unique_constraint(:name, name: :actor_groups_account_id_name_index)
end

12
elixir/apps/domain/test/domain/actors_test.exs
View File

@@ -1117,11 +1117,11 @@ defmodule Domain.ActorsTest do
end
test "returns error on invalid attrs", %{account: account} do
attrs = %{name: String.duplicate("A", 65)}
attrs = %{name: String.duplicate("A", 256)}
assert {:error, changeset} = create_managed_group(account, attrs)
assert errors_on(changeset) == %{
name: ["should be at most 64 character(s)"],
name: ["should be at most 255 character(s)"],
membership_rules: ["can't be blank"]
}
@@ -1178,11 +1178,11 @@ defmodule Domain.ActorsTest do
end
test "returns error on invalid attrs", %{account: account, subject: subject} do
attrs = %{name: String.duplicate("A", 65), type: :foo}
attrs = %{name: String.duplicate("A", 256), type: :foo}
assert {:error, changeset} = create_group(attrs, subject)
assert errors_on(changeset) == %{
name: ["should be at most 64 character(s)"],
name: ["should be at most 255 character(s)"],
type: ["is invalid"]
}
@@ -1315,9 +1315,9 @@ defmodule Domain.ActorsTest do
test "returns error on invalid attrs", %{account: account, subject: subject} do
group = Fixtures.Actors.create_group(account: account)
attrs = %{name: String.duplicate("A", 65)}
attrs = %{name: String.duplicate("A", 256)}
assert {:error, changeset} = update_group(group, attrs, subject)
assert errors_on(changeset) == %{name: ["should be at most 64 character(s)"]}
assert errors_on(changeset) == %{name: ["should be at most 255 character(s)"]}
Fixtures.Actors.create_group(account: account, name: "foo")
attrs = %{name: "foo"}

2
elixir/apps/web/test/web/live/groups/edit_test.exs
View File

@@ -126,7 +126,7 @@ defmodule Web.Live.Groups.EditTest do
|> form("form", group: attrs)
|> validate_change(%{group: %{name: String.duplicate("a", 256)}}, fn form, _html ->
assert form_validation_errors(form) == %{
"group[name]" => ["should be at most 64 character(s)"]
"group[name]" => ["should be at most 255 character(s)"]
}
end)
|> validate_change(%{group: %{name: ""}}, fn form, _html ->

2
elixir/apps/web/test/web/live/groups/new_test.exs
View File

@@ -78,7 +78,7 @@ defmodule Web.Live.Groups.NewTest do
|> form("form", group: attrs)
|> validate_change(%{group: %{name: String.duplicate("a", 256)}}, fn form, _html ->
assert form_validation_errors(form) == %{
"group[name]" => ["should be at most 64 character(s)"]
"group[name]" => ["should be at most 255 character(s)"]
}
end)
|> validate_change(%{group: %{name: ""}}, fn form, _html ->