github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 18:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(windows-client): remove spurious "Connected to Firezone" notifications (#4603)

Browse Source 
Closes #4385

```[tasklist]
### Manual test cases (f2c8f47b3 passed)
- [x] Given there is no token on disk, when you start the app, then there is no notification
- [x] Given there is a token on disk, when you start the app and it signs in, then there is 1 notification
- [x] Given the app is signed out, when you sign in, then there is 1 notification (test this in a sign-out-sign-in cycle)
- [x] Given the app is signed in, when you sign out, then there is no notification
- [x] Given the app is signed in, when you change Wi-Fi networks, then there is no notification
```

This will work on Linux once the Linux GUI comes up
This commit is contained in:
Reactor Scram
2024-04-15 17:44:23 -05:00
committed by GitHub
parent 42385fd565
commit 9036a9fcc5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
rust/gui-client/src-tauri/src/client/gui.rs
View File

@@ -646,13 +646,14 @@ impl Controller {
bail!("Impossible error: `Quit` should be handled before this")
}
Req::TunnelReady => {
if !self.tunnel_ready {
os::show_notification(
"Firezone connected",
"You are now signed in and able to access resources.",
)?;
}
self.tunnel_ready = true;
self.refresh_system_tray_menu()?;
os::show_notification(
"Firezone connected",
"You are now signed in and able to access resources.",
)?;
}
Req::UpdateAvailable(release) => {
let title = format!("Firezone {} available for download", release.tag_name);