github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(portal): Make DNS address validations more strict (#6991)

Browse Source 
Closes ##6981
This commit is contained in:
Andrew Dryga
2024-10-10 09:10:00 -06:00
committed by GitHub
parent 7c02c34d73
commit 945b5813a0
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
elixir/apps/domain/lib/domain/resources/resource/changeset.ex
View File

@@ -93,6 +93,9 @@ defmodule Domain.Resources.Resource.Changeset do
changeset
|> validate_length(:address, min: 1, max: 253)
|> validate_format(:address, ~r/^[\p{L}\*\?0-9-]{1,63}(\.[\p{L}\*\?0-9-]{1,63})*$/iu)
|> validate_format(:address, ~r/^[^\.]/, message: "must start with a letter or number")
|> validate_format(:address, ~r/[^\.]$/, message: "must end with a letter or number")
|> validate_format(:address, ~r/[\w]/iu, message: "must contain at least one letter")
|> validate_change(:address, fn field, dns_address ->
{tld, domain} =
dns_address

3
elixir/apps/domain/test/domain/resources/resource/changeset_test.exs
View File

@@ -88,6 +88,9 @@ defmodule Domain.Resources.Resource.ChangesetTest do
assert changeset.valid?
end
refute create(%{type: :dns, address: "1.1.1.1"}).valid?
refute create(%{type: :dns, address: ".example.com"}).valid?
refute create(%{type: :dns, address: "example.com."}).valid?
refute create(%{type: :dns, address: "exa&mple.com"}).valid?
refute create(%{type: :dns, address: ""}).valid?
refute create(%{type: :dns, address: "http://example.com/"}).valid?