github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(apple): Remove redundant category key from log files (#7614)

Browse Source 
This is redundant and makes logs unnecessarily more noisy / larger.

Fixes #7613
This commit is contained in:
Jamil
2024-12-31 11:44:00 -08:00
committed by GitHub
parent 1ddc2f5de6
commit b5eccf095a
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift
View File

@@ -21,7 +21,7 @@ public final class Log {
public init(category: Category, folderURL: URL?) {
self.logger = Logger(subsystem: "dev.firezone.firezone", category: category.rawValue)
self.logWriter = LogWriter(category: category, folderURL: folderURL, logger: self.logger)
self.logWriter = LogWriter(folderURL: folderURL, logger: self.logger)
}
public func log(_ message: String) {
@@ -107,20 +107,18 @@ private final class LogWriter {
struct LogEntry: Codable {
let time: String
let category: Log.Category
let severity: Severity
let message: String
}
// All log writes happen in the workQueue
private let workQueue: DispatchQueue
private let category: Log.Category
private let logger: Logger
private let handle: FileHandle
private let dateFormatter: ISO8601DateFormatter
private let jsonEncoder: JSONEncoder
init?(category: Log.Category, folderURL: URL?, logger: Logger) {
init?(folderURL: URL?, logger: Logger) {
let fileManager = FileManager.default
let dateFormatter = ISO8601DateFormatter()
let jsonEncoder = JSONEncoder()
@@ -130,7 +128,6 @@ private final class LogWriter {
self.dateFormatter = dateFormatter
self.jsonEncoder = jsonEncoder
self.logger = logger
self.category = category
// Create log dir if not exists
guard let folderURL = folderURL,
@@ -168,7 +165,6 @@ private final class LogWriter {
func write(severity: Severity, message: String) {
let logEntry = LogEntry(
time: dateFormatter.string(from: Date()),
category: category,
severity: severity,
message: message)