github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(connlib): move log into state (#10498)

Browse Source 
Instead of logging this inside the event-loop, it is better to move it
into the corresponding handler function to free up the event-loop from
as much "logic" as possible. It should ideally only be concerned with
linking the state machine with the IO components that actually cause the
side-effects.
This commit is contained in:
Thomas Eizinger
2025-10-01 04:16:41 +00:00
committed by GitHub
parent 2bc6fb2dea
commit cfbdc30123
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rust/connlib/tunnel/src/client.rs
View File

@@ -393,6 +393,10 @@ impl ClientState {
packet: IpPacket,
now: Instant,
) -> Option<snownet::Transmit> {
if packet.is_fz_p2p_control() {
tracing::warn!("Packet matches heuristics of FZ p2p control protocol");
}
let non_dns_packet = match self.try_handle_dns(packet, now) {
ControlFlow::Break(()) => return None,
ControlFlow::Continue(non_dns_packet) => non_dns_packet,

4
rust/connlib/tunnel/src/gateway.rs
View File

@@ -92,6 +92,10 @@ impl GatewayState {
packet: IpPacket,
now: Instant,
) -> Result<Option<snownet::Transmit>> {
if packet.is_fz_p2p_control() {
tracing::warn!("Packet matches heuristics of FZ p2p control protocol");
}
let dst = packet.destination();
if !crate::is_peer(dst) {

8
rust/connlib/tunnel/src/lib.rs
View File

@@ -222,10 +222,6 @@ impl ClientTunnel {
if let Some(packets) = device {
for packet in packets {
if packet.is_fz_p2p_control() {
tracing::warn!("Packet matches heuristics of FZ p2p control protocol");
}
let ecn = packet.ecn();
match self.role_state.handle_tun_input(packet, now) {
@@ -404,10 +400,6 @@ impl GatewayTunnel {
if let Some(packets) = device {
for packet in packets {
if packet.is_fz_p2p_control() {
tracing::warn!("Packet matches heuristics of FZ p2p control protocol");
}
let ecn = packet.ecn();
match self.role_state.handle_tun_input(packet, now) {