refactor(apple): Clean up MenuBar vars, function names (#8234)

Browse Source

The original MenuBar developer set a few anti-patterns that were
somewhat followed by subsequent developers. As of now, the entire file
is too large and woefully cluttered.

This PR takes a big step towards #7771 by first organizing the current
thing into a more comprehensible file:


- `private` is removed. These are not needed in Swift unless you
actually need to make something private. The default `internal` level is
appropriate for most cases.
- state change handlers are consistently named `handleX`
- functions are reorganized, and `MARK` comments used to group similar
functions together

...

This commit is contained in:

Jamil

2025-02-23 19:13:15 -08:00

committed by GitHub

parent 83b2c7a71a

commit d7ed8ac248

1 changed files with 436 additions and 426 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

862

swift/apple/FirezoneKit/Sources/FirezoneKit/Views/MenuBar.swift

File diff suppressed because it is too large Load Diff