github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-27 10:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(snownet): don't log missing attribute for binding requests (#7852)

Browse Source 
STUN binding requests & responses are not authenticated on purpose
because they are so easy to fulfill that having to perform the
computational work to check the authentication is more work than
actually just sending the request. With #7819, we send STUN binding
requests more often because they are used as keep-alives to the relay.
This spams the debug log because we see

> Message does not have a `MessageIntegrity` attribute

for every BINDING response. This information isn't interesting for
BINDING responses because those will never have a `MessageIntegrity`
attribute.
This commit is contained in:
Thomas Eizinger
2025-01-24 14:55:30 +11:00
committed by GitHub
parent 88c3e228ba
commit e78ef04e6c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rust/connlib/snownet/src/allocation.rs
View File

@@ -1103,7 +1103,9 @@ impl Allocation {
#[cfg(not(test))]
fn check_message_integrity(&self, message: &Message<Attribute>) -> bool {
let Some(mi) = message.get_attribute::<MessageIntegrity>() else {
tracing::debug!("Message does not have a `MessageIntegrity` attribute");
if message.method() != BINDING {
tracing::debug!("Message does not have a `MessageIntegrity` attribute");
}
return false;
};