github-personal/firezone
1
0
Fork 0
mirror of https://github.com/outbackdingo/firezone.git synced 2026-01-28 10:18:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(connlib): don't add routes for DNS sentinel servers (#6755)

Browse Source 
We reserve an IP range _within_ the CG-NAT range for the sentinel DNS
servers. It is unnecessary to explicitly add that one as a route because
it is already covered by the routing entry of the entire CG-NAT range.
This commit is contained in:
Thomas Eizinger
2024-09-18 19:47:08 -04:00
committed by GitHub
parent e73f3de7ee
commit efcf28b480
2 changed files with 7 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rust/connlib/tunnel/src/client.rs
View File

@@ -813,8 +813,6 @@ impl ClientState {
.map(|(ip, _)| ip)
.chain(iter::once(IPV4_RESOURCES.into()))
.chain(iter::once(IPV6_RESOURCES.into()))
.chain(iter::once(DNS_SENTINELS_V4.into()))
.chain(iter::once(DNS_SENTINELS_V6.into()))
.chain(
self.internet_resource
.map(|_| Ipv4Network::DEFAULT_ROUTE.into()),
@@ -1841,9 +1839,7 @@ mod proptests {
resource_routes
.into_iter()
.chain(iter::once(IPV4_RESOURCES.into()))
.chain(iter::once(IPV6_RESOURCES.into()))
.chain(iter::once(DNS_SENTINELS_V4.into()))
.chain(iter::once(DNS_SENTINELS_V6.into())),
.chain(iter::once(IPV6_RESOURCES.into())),
)
}

22
rust/connlib/tunnel/src/tests/sim_client.rs
View File

@@ -947,25 +947,15 @@ fn ref_client(
}
fn default_routes_v4() -> Vec<Ipv4Network> {
vec![
Ipv4Network::new(Ipv4Addr::new(100, 96, 0, 0), 11).unwrap(),
Ipv4Network::new(Ipv4Addr::new(100, 100, 111, 0), 24).unwrap(),
]
vec![Ipv4Network::new(Ipv4Addr::new(100, 96, 0, 0), 11).unwrap()]
}
fn default_routes_v6() -> Vec<Ipv6Network> {
vec![
Ipv6Network::new(
Ipv6Addr::new(0xfd00, 0x2021, 0x1111, 0x8000, 0, 0, 0, 0),
107,
)
.unwrap(),
Ipv6Network::new(
Ipv6Addr::new(0xfd00, 0x2021, 0x1111, 0x8000, 0x0100, 0x0100, 0x0111, 0),
120,
)
.unwrap(),
]
vec![Ipv6Network::new(
Ipv6Addr::new(0xfd00, 0x2021, 0x1111, 0x8000, 0, 0, 0, 0),
107,
)
.unwrap()]
}
fn known_hosts() -> impl Strategy<Value = BTreeMap<String, Vec<IpAddr>>> {