Andrew Dryga
d9eb2d18df
Deployment for the cloud version ( #1638 )
...
TODO:
- [x] Cluster formation for all API and web nodes
- [x] Injest Docker logs to Stackdriver
- [x] Fix assets building for prod
To finish later:
- [ ] Structured logging:
https://issuetracker.google.com/issues/285950891
- [ ] Better networking policy (eg. use public postmark ranges and deny
all unwanted egress)
- [ ] OpenTelemetry collector for Google Stackdriver
- [ ] LoggerJSON.Plug integration
---------
Signed-off-by: Andrew Dryga <andrew@dryga.com >
Co-authored-by: Jamil <jamilbk@users.noreply.github.com >
2023-06-06 15:03:26 -06:00
Thomas Eizinger
d27856a8f1
refactor(relay): introduce type-safe Server APIs ( #1630 )
...
We introduce dedicated types for each message that the `Server` can
handle. This allows us to make the functions public because the
type-system now guarantees that those are either parsed from bytes or
constructed with the correct data.
The latter will be useful to write tests against a richer API.
2023-05-31 15:18:20 +01:00
Andrew Dryga
37a2d7b7f5
Move elixir code to a subfolder ( #1631 )
2023-05-24 15:46:51 -06:00
Andrew Dryga
9e1669c333
Fix some of TODOs left from IAM PR ( #1627 )
2023-05-24 12:18:52 -06:00
Jamil
c30f571d73
Fix minor bugs and tidy up existing work on new views ( #1628 )
...
Just fixing some bugs and inconsistencies I found while going through
the new views.
2023-05-23 09:10:28 -07:00
Andrew Dryga
70a03d39e6
Implementing channels logic ( #1619 )
2023-05-22 19:49:50 -06:00
Thomas Eizinger
f5fdd56812
relay: create channel bindings and relay data ( #1618 )
...
Here is a short demo:
[Relay](https://github.com/firezone/firezone/assets/5486389/c0199294-70ca-47b4-90ae-2c96428bdb56 )
You can run this locally using the `./run_smoke_test.sh` shell-script.
It is not reliable enough yet to be used in CI but I used one if its
outputs to make a regression test.
---------
Co-authored-by: Jamil <jamilbk@users.noreply.github.com >
2023-05-22 17:25:16 -07:00
Jamil
0647eeebca
1.0 views (part 1) ( #1599 )
...
# Todo
- [x] Users
- [x] Groups
- [x] Devices
- [x] Gateways
2023-05-22 17:09:41 -07:00
Thomas Eizinger
9c120fb35a
fix(relay): use correct variable ( #1617 )
...
We had a semantic conflict here that resulted in a broken build. This PR
fixes that.
Co-authored-by: Jamil <jamilbk@users.noreply.github.com >
2023-05-17 09:36:32 -07:00
Jamil
5be87b97c2
Fix PR-labeler config ( #1623 )
...
Fix PR labeler config 🤞
2023-05-17 09:11:54 -07:00
Andrew Dryga
e992863ae5
IAM context ( #1577 )
...
Things I've left for later to IAM:
1. Subject session expiration (to prevent session extension attacks);
2. UserPass adapter;
3. Token adapter and removal of APITokens in favor of `api_client` actor
with a Token provider;
4. Cleanup of Configurations schema and table
5. SCIM
6. Groups and Actor Profile (name, email) Sync
7. Email delivery once Web app is done with the templates
8. We might also want to persist sessions to database, to then show list
of active sessions to the user and allow to terminate some of them from
UI
9. SAML?
10. Rename `unprivileged` role name to `end_user`
11. Add `first_` and `last_name`, and sync/edit blocking logic around
it.
12. Rename Clients to Devices?
2023-05-16 19:42:36 -06:00
Jamil
d5cfd6365d
Update workflows for cloud chaos ( #1615 )
...
Updating workflows to skip on PR and run on merges to `cloud`.
2023-05-16 13:50:17 -07:00
Thomas Eizinger
0d6e5986ae
ci: remove broken workflows ( #1614 )
...
These workflows are all red which is expected as far as I understand.
I'd suggest we remove them to reduce the noise when reviewing PRs.
In case we ever wanted to bring parts of it back, Git is our best
friend.
Feel free to close if you think differently.
2023-05-16 13:35:39 -07:00
Thomas Eizinger
52df0cbfb4
relay: remember allocations by port ( #1613 )
...
Instead of remembering the used ports separately, we store a reference
to each allocation by port.
2023-05-16 09:05:51 +02:00
Thomas Eizinger
5e74143ede
relay: don't repeat magic numbers througout the code ( #1612 )
...
A small refactoring to keep magic numbers only in one place.
2023-05-16 09:05:13 +02:00
Thomas Eizinger
675cb2dd54
relay: refresh allocations ( #1610 )
2023-05-16 07:21:02 +10:00
Thomas Eizinger
01f33ed4a0
relay: add basic README ( #1611 )
2023-05-16 05:39:28 +10:00
Thomas Eizinger
c0774523a8
relay: Parse and respond to allocation requests ( #1604 )
...
With this patch, the relay can parse and respond to allocation requests. I
ran some basics tests against https://icetest.info/ and implemented a
regression test as a result of the logged data.
In writing this, I also had to slightly change the design of `Server`
(as expected). Event handlers for incoming data now do not return a
message directly. Instead, the caller is responsible to drain `Command`s
from it.
When creating an allocation, we need to start listening on a new port.
This needs to happen outside the `Server` as I am going for a sans-IO
style. We emit a `Command` that instructs the main event loop to listen
on a new port. Any incoming data on that port will be forwarded to the
`Server`.
At the moment, this incoming data is just dropped. This is actually
standards-compliant because we cannot handle binding requests yet which
would allow this data to be forwarded to the client.
In some areas, the code is still a bit rough but I expect to iron those
things out as we go along.
2023-05-16 04:58:33 +10:00
Thomas Eizinger
24e4a1c052
Enforce no warnings in docs ( #1605 )
2023-05-12 11:28:21 -07:00
Thomas Eizinger
b090557e3d
Install Rust before computing cache keys ( #1606 )
2023-05-12 11:27:49 -07:00
Thomas Eizinger
70e6982e45
Implement basic STUN server ( #1603 )
...
This is an alternative to https://github.com/firezone/firezone/pull/1602
that implements the server using a library I've found called
`stun_codec`.
It already has support for parsing a variety of attributes.
The following is a nice website to test some of the functionality:
https://icetest.info/
The server is still listening on:
`ec2-3-89-112-240.compute-1.amazonaws.com:3478`.
2023-05-10 07:58:32 -07:00
Thomas Eizinger
0be094124b
Update .github/workflows/rust.yml
...
Signed-off-by: Thomas Eizinger <thomas@eizinger.io >
2023-05-08 19:06:34 -03:00
Thomas Eizinger
d7fab6b803
Add caching to CI
2023-05-08 19:06:34 -03:00
Thomas Eizinger
718e4da41a
Move rust-toolchain to workspace root
2023-05-08 19:06:34 -03:00
Thomas Eizinger
8db82445ba
Move gitignore and lockfile to workspace root
2023-05-08 19:06:34 -03:00
Thomas Eizinger
f9b6e96b5e
Move everything to a workspace
2023-05-08 19:06:34 -03:00
Thomas Eizinger
8e5c3bc225
Avoid concurrent jobs
2023-05-08 19:06:34 -03:00
Thomas Eizinger
8257108872
Install necessary components for toolchain
2023-05-08 19:06:34 -03:00
Thomas Eizinger
3446bf1981
Add minimal scaffholding for relay
2023-05-08 19:06:34 -03:00
Andrew Dryga
2027e09a3e
Remove unused docker-compose file
2023-04-27 14:19:25 -06:00
Andrew Dryga
3760c44522
Remove unused import
2023-04-27 14:19:25 -06:00
Andrew Dryga
92a7c505e3
Bring back browser/config.xml
2023-04-27 14:19:25 -06:00
Andrew Dryga
bcdeae3f9e
Re-enable SQL sandboxing for Phoenix apps
2023-04-27 14:19:25 -06:00
Andrew Dryga
a4022fcc42
Replace web app with a new one based on Tailwind and esbuild ( #1568 )
2023-04-20 17:31:37 -07:00
Andrew Dryga
58b8d5212f
Control channels for Clients, Relays and Gateways ( #1551 )
2023-04-20 11:34:56 -07:00
Andrew Dryga
0740d0fdba
Add primitive tests and more structure for API app
2023-04-04 14:52:19 -06:00
Andrew Dryga
d4e4d702ab
Drop REST API boilerplate for now
2023-04-04 11:50:07 -06:00
Andrew Dryga
9ffb741e96
Add client, gateway, relay boilerplate code
2023-04-04 11:49:21 -06:00
Andrew Dryga
6c75c1a5f6
Add skeleton of API app
2023-04-04 10:40:47 -06:00
Andrew Dryga
f5a23aab40
Fix priv/repo path
2023-04-04 10:07:53 -06:00
Andrew Dryga
b6a6382f45
Bring ecto.* helpers back to life
2023-04-04 10:01:31 -06:00
Andrew Dryga
6a9012c964
Remove omnibus install scripts
2023-04-04 09:53:21 -06:00
Andrew Dryga
9603aef011
Make sure that container can be built and run in PR CI step
2023-04-04 09:50:05 -06:00
Andrew Dryga
7fe685d072
Make all tests pass
...
I removed some of VPN/Wall settings (they are irrelevant once we move out gateway) along with port-based rules conditions (since we are moving to userspace wg).
2023-04-04 09:41:12 -06:00
Andrew Dryga
c5615060b4
Remove fz_vpn, fz_wall, Omnibus and start restructuring apps
2023-03-31 09:51:40 -06:00
Andrew Dryga
c9adae866c
Use correct case in codespell file
2023-03-30 10:18:24 -06:00
Andrew Dryga
34fd0d21f4
Make codespell happy about SSL value examples
2023-03-30 09:56:44 -06:00
Jamil
e0c237e67c
Set connectivity checks URL for prod to ping.firez.one ( #1533 )
...
Fixes leftover bug from refactoring
```
firezone-firezone-1 | 15:05:18.405 erl_level=error application=fz_http domain=elixir file=lib/fz_http/connectivity_checks/poller.ex function=check_connectivity/1 line=49 mfa=FzHttp.ConnectivityChecks.Poller.check_connectivity/1 module=FzHttp.ConnectivityChecks.Poller pid=<0.474.0> reason=%Mint.TransportError{reason: :nxdomain} url=https://ping-dev.firez.one:443/0.7.26 [error] An error occurred while performing a connectivity check
```
2023-03-29 14:09:14 -07:00
dependabot[bot]
aa2d1af396
Bump codespell from 2.2.2 to 2.2.4 ( #1507 )
...
Bumps [codespell](https://github.com/codespell-project/codespell ) from
2.2.2 to 2.2.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codespell-project/codespell/releases ">codespell's
releases</a>.</em></p>
<blockquote>
<h2>v2.2.4</h2>
<h2>What's Changed</h2>
<ul>
<li>BUG: Fix bug with toml triage by <a
href="https://github.com/larsoner "><code>@larsoner</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2774 ">codespell-project/codespell#2774</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codespell-project/codespell/compare/v2.2.3...v2.2.4 ">https://github.com/codespell-project/codespell/compare/v2.2.3...v2.2.4 </a></p>
<h2>v2.2.3</h2>
<h2>NOTE:</h2>
<p>This release is broken for Python < 3.11 without tomli installed
in the presence of <code>.toml</code> files (e.g.,
<code>pyproject.toml</code>), see <a
href="https://redirect.github.com/codespell-project/actions-codespell/issues/59 ">codespell-project/actions-codespell#59</a>
!</p>
<h2>What's Changed</h2>
<ul>
<li>Misspelling of sufficient, sufficiently by <a
href="https://github.com/vikivivi "><code>@vikivivi</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2531 ">codespell-project/codespell#2531</a></li>
<li>insuffient->insufficient by <a
href="https://github.com/tkoyama010 "><code>@tkoyama010</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2527 ">codespell-project/codespell#2527</a></li>
<li>add anayltic(s|al|ally) -> analytic(s|al|ally) by <a
href="https://github.com/robin-wayve "><code>@robin-wayve</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2507 ">codespell-project/codespell#2507</a></li>
<li>Ignore flake8 rule W503 by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2069 ">codespell-project/codespell#2069</a></li>
<li>Dead code found by vulture by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2101 ">codespell-project/codespell#2101</a></li>
<li>Move falsy and accreting to more appropriate files by <a
href="https://github.com/janosh "><code>@janosh</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2511 ">codespell-project/codespell#2511</a></li>
<li>Add subtrate->substrate by <a
href="https://github.com/janosh "><code>@janosh</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2525 ">codespell-project/codespell#2525</a></li>
<li>Add "subtask" by <a
href="https://github.com/int-y1 "><code>@int-y1</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2537 ">codespell-project/codespell#2537</a></li>
<li>Apply pyupgrade to project by <a
href="https://github.com/jdufresne "><code>@jdufresne</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2364 ">codespell-project/codespell#2364</a></li>
<li>{speherical,sperhical}->spherical by <a
href="https://github.com/janosh "><code>@janosh</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2540 ">codespell-project/codespell#2540</a></li>
<li>interepolation->interpolation by <a
href="https://github.com/tkoyama010 "><code>@tkoyama010</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2512 ">codespell-project/codespell#2512</a></li>
<li>Ignore .mypy_cache folder by <a
href="https://github.com/kianmeng "><code>@kianmeng</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2361 ">codespell-project/codespell#2361</a></li>
<li>Fix uncaught exception on unreadable files by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2196 ">codespell-project/codespell#2196</a></li>
<li>Add constrainst to dictionary by <a
href="https://github.com/jonathanberthias "><code>@jonathanberthias</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2546 ">codespell-project/codespell#2546</a></li>
<li>Add relative hidden directory and basic subdir tests by <a
href="https://github.com/peternewman "><code>@peternewman</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2542 ">codespell-project/codespell#2542</a></li>
<li>Add trignometric->trigonometric by <a
href="https://github.com/janosh "><code>@janosh</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2549 ">codespell-project/codespell#2549</a></li>
<li>Add virtualied->virtualized, virtualised and friends by <a
href="https://github.com/peternewman "><code>@peternewman</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2553 ">codespell-project/codespell#2553</a></li>
<li>Add several spelling corrections by <a
href="https://github.com/luzpaz "><code>@luzpaz</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2521 ">codespell-project/codespell#2521</a></li>
<li>Slightly simplify some boolean expressions by <a
href="https://github.com/jdufresne "><code>@jdufresne</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2556 ">codespell-project/codespell#2556</a></li>
<li>MAINT: Add CODEOWNERS by <a
href="https://github.com/larsoner "><code>@larsoner</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2535 ">codespell-project/codespell#2535</a></li>
<li>positivie->positive by <a
href="https://github.com/janosh "><code>@janosh</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2558 ">codespell-project/codespell#2558</a></li>
<li>DOC/ENH: Clarify usage or configuration files and log about it by <a
href="https://github.com/sappelhoff "><code>@sappelhoff</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2552 ">codespell-project/codespell#2552</a></li>
<li>Document required setuptools version by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2560 ">codespell-project/codespell#2560</a></li>
<li>Redundant wheel dependency in pyproject.toml by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2562 ">codespell-project/codespell#2562</a></li>
<li>Remove parameterizes->parametrizes by <a
href="https://github.com/int-y1 "><code>@int-y1</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2563 ">codespell-project/codespell#2563</a></li>
<li>Replace codecs.open with open by <a
href="https://github.com/jdufresne "><code>@jdufresne</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2378 ">codespell-project/codespell#2378</a></li>
<li>Update subprocess usage to use modern subprocess.run() by <a
href="https://github.com/jdufresne "><code>@jdufresne</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2565 ">codespell-project/codespell#2565</a></li>
<li>Fix produce typo by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2561 ">codespell-project/codespell#2561</a></li>
<li>Add a few corrections by <a
href="https://github.com/int-y1 "><code>@int-y1</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2566 ">codespell-project/codespell#2566</a></li>
<li>Migrate pytest config into pyproject.toml by <a
href="https://github.com/cclauss "><code>@cclauss</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2554 ">codespell-project/codespell#2554</a></li>
<li>Handle bad globs passed to if --skip/-S by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2159 ">codespell-project/codespell#2159</a></li>
<li>Isn't the mailing list obsolete? by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2090 ">codespell-project/codespell#2090</a></li>
<li>More CODEOWNERS by <a
href="https://github.com/peternewman "><code>@peternewman</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2569 ">codespell-project/codespell#2569</a></li>
<li>Remove unused attribute Misspelling.fixword by <a
href="https://github.com/jdufresne "><code>@jdufresne</code></a> in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2557 ">codespell-project/codespell#2557</a></li>
<li>Read config file without interpolation by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2545 ">codespell-project/codespell#2545</a></li>
<li>Add andriod->android and friends by <a
href="https://github.com/peternewman "><code>@peternewman</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2570 ">codespell-project/codespell#2570</a></li>
<li>Add total type GB to US by <a
href="https://github.com/peternewman "><code>@peternewman</code></a> in
<a
href="https://redirect.github.com/codespell-project/codespell/pull/2577 ">codespell-project/codespell#2577</a></li>
<li>Catch all cases of missing pytest by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/codespell-project/codespell/pull/2568 ">codespell-project/codespell#2568</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="ec0f41b957https://redirect.github.com/codespell-project/codespell/issues/2774 ">#2774</a>)</li>
<li><a
href="8fa416764chttps://redirect.github.com/codespell-project/codespell/issues/2625 ">#2625</a>)</li>
<li><a
href="892922e11ehttps://redirect.github.com/codespell-project/codespell/issues/2771 ">#2771</a>)</li>
<li><a
href="3601c9a8efhttps://redirect.github.com/codespell-project/codespell/issues/2769 ">#2769</a>)</li>
<li><a
href="41ed86a5d722ac85a4fehttps://redirect.github.com/codespell-project/codespell/issues/2751 ">#2751</a>)</li>
<li><a
href="0c347972ab5c9aeeb013https://redirect.github.com/codespell-project/codespell/issues/2760 ">#2760</a>)</li>
<li><a
href="bf8d70ce2e55fe25616bhttps://github.com/codespell-project/codespell/compare/v2.2.2...v2.2.4 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-29 09:16:33 -07:00
dependabot[bot]
723fc252f7
Bump rubocop from 1.46.0 to 1.48.1 ( #1519 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.46.0 to
1.48.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop/releases ">rubocop's
releases</a>.</em></p>
<blockquote>
<h2>RuboCop 1.48.1</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11673 ">#11673</a>:
Fix incorrect <code>Style/HashSyntax</code> autocorrection for
assignment methods. (<a
href="https://github.com/gsamokovarov "><code>@gsamokovarov</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11682 ">#11682</a>:
Fix a false positive for <code>Lint/UselessRescue</code> when using
<code>Thread#raise</code> in <code>rescue</code> clause. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11672 ">#11672</a>:
Fix an error for <code>Layout/BlockEndNewline</code> when multiline
block <code>}</code> is not on its own line and it is used as multiple
arguments. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11675 ">#11675</a>:
<code>Style/AccessorGrouping</code>: Fix sibling detection for methods
with type sigs. (<a
href="https://github.com/issyl0 "><code>@issyl0</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11658 ">#11658</a>:
Fix <code>Lint/Debugger</code> should not allow pry. (<a
href="https://github.com/ThHareau "><code>@ThHareau</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11689 ">#11689</a>:
Fix <code>Lint/Syntax</code> behavior when <code>Enabled: false</code>
of <code>Lint</code> department. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11677 ">#11677</a>:
Fix the severity for <code>Lint/Syntax</code>. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11691 ">#11691</a>:
Fix an error for <code>Gemspec/DependencyVersion</code> when method
called on gem name argument for <code>add_dependency</code>. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
</ul>
<h2>RuboCop 1.48</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11628 ">#11628</a>:
Add new <code>Style/DirEmpty</code> cop. (<a
href="https://github.com/ydah "><code>@ydah</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11629 ">#11629</a>:
Add new <code>Style/FileEmpty</code> cop. (<a
href="https://github.com/ydah "><code>@ydah</code></a>)</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11654 ">#11654</a>:
Fix a false positive for <code>Lint/MissingSuper</code> when no
<code>super</code> call and when defining some method. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11661 ">#11661</a>:
Fix an error for <code>Style/Documentation</code> when namespace is a
variable. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11647 ">#11647</a>:
Fix an error for <code>Style/IfWithBooleanLiteralBranches</code> when
using <code>()</code> as a condition. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11646 ">#11646</a>:
Fix an error for <code>Style/NegatedIfElseCondition</code> when using
<code>()</code> as a condition. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11659 ">#11659</a>:
Fix an incorrect autocorrect for
<code>Lint/OrAssignmentToConstant</code> when using or-assignment to a
constant in method definition. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11663 ">#11663</a>:
Fix an incorrect autocorrect for <code>Style/BlockDelimiters</code> when
multi-line blocks to <code>{</code> and <code>}</code> with arithmetic
operation method chain. (<a
href="https://github.com/koic "><code>@koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11638 ">#11638</a>:
Fix a false positive for <code>Lint/UselessAccessModifier</code> when
using same access modifier inside and outside the <code>included</code>
block. (<a href="https://github.com/ydah "><code>@ydah</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11164 ">#11164</a>:
Suppress server mode message with <code>-f json</code>. (<a
href="https://github.com/jasondoc3 "><code>@jasondoc3</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11643 ">#11643</a>:
Fix incorrect shorthand autocorrections in calls inside parentheses. (<a
href="https://github.com/gsamokovarov "><code>@gsamokovarov</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11650 ">#11650</a>:
<code>Style/AccessorGrouping</code>: Fix detection of Sorbet <code>sig
{}</code> blocks. (<a
href="https://github.com/issyl0 "><code>@issyl0</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11657 ">#11657</a>:
Use cop name to check if cop inside registry is enabled. Previously, it
was able to cause large memory usage during linting. (<a
href="https://github.com/fatkodima "><code>@fatkodima</code></a>)</li>
</ul>
<h3>Changes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11482 ">#11482</a>:
Avoid comment deletion by <code>Style/IfUnlessModifier</code> when the
modifier form expression has long comment. (<a
href="https://github.com/nobuyo "><code>@nobuyo</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11649 ">#11649</a>:
Support <code>MinBranchesCount</code> config for
<code>Style/CaseLikeIf</code> cop. (<a
href="https://github.com/fatkodima "><code>@fatkodima</code></a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md ">rubocop's
changelog</a>.</em></p>
<blockquote>
<h2>1.48.1 (2023-03-13)</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11673 ">#11673</a>:
Fix incorrect <code>Style/HashSyntax</code> autocorrection for
assignment methods. ([<a
href="https://github.com/gsamokovarov "><code>@gsamokovarov</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11682 ">#11682</a>:
Fix a false positive for <code>Lint/UselessRescue</code> when using
<code>Thread#raise</code> in <code>rescue</code> clause. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11672 ">#11672</a>:
Fix an error for <code>Layout/BlockEndNewline</code> when multiline
block <code>}</code> is not on its own line and it is used as multiple
arguments. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11675 ">#11675</a>:
<code>Style/AccessorGrouping</code>: Fix sibling detection for methods
with type sigs. ([<a
href="https://github.com/issyl0 "><code>@issyl0</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11658 ">#11658</a>:
Fix <code>Lint/Debugger</code> should not allow pry. ([<a
href="https://github.com/ThHareau "><code>@ThHareau</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11689 ">#11689</a>:
Fix <code>Lint/Syntax</code> behavior when <code>Enabled: false</code>
of <code>Lint</code> department. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11677 ">#11677</a>:
Fix the severity for <code>Lint/Syntax</code>. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11691 ">#11691</a>:
Fix an error for <code>Gemspec/DependencyVersion</code> when method
called on gem name argument for <code>add_dependency</code>. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
</ul>
<h2>1.48.0 (2023-03-06)</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11628 ">#11628</a>:
Add new <code>Style/DirEmpty</code> cop. ([<a
href="https://github.com/ydah "><code>@ydah</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11629 ">#11629</a>:
Add new <code>Style/FileEmpty</code> cop. ([<a
href="https://github.com/ydah "><code>@ydah</code></a>][])</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11654 ">#11654</a>:
Fix a false positive for <code>Lint/MissingSuper</code> when no
<code>super</code> call and when defining some method. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11661 ">#11661</a>:
Fix an error for <code>Style/Documentation</code> when namespace is a
variable. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11647 ">#11647</a>:
Fix an error for <code>Style/IfWithBooleanLiteralBranches</code> when
using <code>()</code> as a condition. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11646 ">#11646</a>:
Fix an error for <code>Style/NegatedIfElseCondition</code> when using
<code>()</code> as a condition. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11659 ">#11659</a>:
Fix an incorrect autocorrect for
<code>Lint/OrAssignmentToConstant</code> when using or-assignment to a
constant in method definition. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11663 ">#11663</a>:
Fix an incorrect autocorrect for <code>Style/BlockDelimiters</code> when
multi-line blocks to <code>{</code> and <code>}</code> with arithmetic
operation method chain. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11638 ">#11638</a>:
Fix a false positive for <code>Lint/UselessAccessModifier</code> when
using same access modifier inside and outside the <code>included</code>
block. ([<a
href="https://github.com/ydah "><code>@ydah</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11164 ">#11164</a>:
Suppress server mode message with <code>-f json</code>. ([<a
href="https://github.com/jasondoc3 "><code>@jasondoc3</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11643 ">#11643</a>:
Fix incorrect shorthand autocorrections in calls inside parentheses.
([<a
href="https://github.com/gsamokovarov "><code>@gsamokovarov</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11650 ">#11650</a>:
<code>Style/AccessorGrouping</code>: Fix detection of Sorbet <code>sig
{}</code> blocks. ([<a
href="https://github.com/issyl0 "><code>@issyl0</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11657 ">#11657</a>:
Use cop name to check if cop inside registry is enabled. Previously, it
was able to cause large memory usage during linting. ([<a
href="https://github.com/fatkodima "><code>@fatkodima</code></a>][])</li>
</ul>
<h3>Changes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11482 ">#11482</a>:
Avoid comment deletion by <code>Style/IfUnlessModifier</code> when the
modifier form expression has long comment. ([<a
href="https://github.com/nobuyo "><code>@nobuyo</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11649 ">#11649</a>:
Support <code>MinBranchesCount</code> config for
<code>Style/CaseLikeIf</code> cop. ([<a
href="https://github.com/fatkodima "><code>@fatkodima</code></a>][])</li>
</ul>
<h2>1.47.0 (2023-03-01)</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11475 ">#11475</a>:
Add autocorrect for hash in <code>Lint/LiteralInInterpolation</code>.
([<a
href="https://github.com/KessaPassa "><code>@KessaPassa</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/pull/11584 ">#11584</a>:
Add <code>Metrics/CollectionLiteralLength</code> cop. ([<a
href="https://github.com/sambostock "><code>@sambostock</code></a>][])</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11615 ">#11615</a>:
Fix a false negative for <code>Lint/MissingSuper</code> when no
<code>super</code> call with <code>Class.new</code> block. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop/issues/11615 ">#11615</a>:
Fix a false negative for <code>Lint/MissingSuper</code> when using
<code>Class.new</code> without parent class argument. ([<a
href="https://github.com/koic "><code>@koic</code></a>][])</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="675114c1b5a0d896a010ed786ab489https://redirect.github.com/rubocop/rubocop/issues/11658 ">#11658</a>]
Register Object#pry as an offense (<a
href="https://redirect.github.com/rubocop/rubocop/issues/11669 ">#11669</a>)</li>
<li><a
href="96911a9464e79974b846https://redirect.github.com/rubocop/rubocop/issues/11691 ">#11691</a>
from koic/fix_an_error_for_gemspec_dependency_version</li>
<li><a
href="a3b8a8d4a7f0356375b7d11e25fa880fc26d81d2https://redirect.github.com/rubocop/rubocop/issues/11677 ">#11677</a>]
Fix the severity for <code>Lint/Syntax</code></li>
<li><a
href="6c3bbff146https://redirect.github.com/rubocop/rubocop/issues/11682 ">#11682</a>]
Fix a false positive for <code>Lint/UselessRescue</code></li>
<li>Additional commits viewable in <a
href="https://github.com/rubocop/rubocop/compare/v1.46.0...v1.48.1 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jamil <jamilbk@users.noreply.github.com >
2023-03-29 09:12:14 -07:00
