Merge pull request #104 from selvamKrish/hostname-validation

Hostname validation

.github/scripts/get_sonarcloud.sh

@@ -1,24 +0,0 @@
-#!/bin/bash
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-curl -s -L -O https://sonarcloud.io/static/cpp/build-wrapper-linux-x86.zip
-unzip -q -o build-wrapper-linux-x86.zip
-
-
-SONAR_VERSION=`curl -s https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/ |grep -o "sonar-scanner-cli-[0-9.]*-linux.zip"|sort -r|uniq|head -n 1`
-curl -s -L -O https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/$SONAR_VERSION
-curl -s -L -O https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/$SONAR_VERSION.sha256
-echo "  $SONAR_VERSION" >> $SONAR_VERSION.sha256
-sha256sum -c $SONAR_VERSION.sha256
-if [[ $? -ne 0 ]]
-then
-    exit 1
-fi
-unzip -q $SONAR_VERSION
-
-output=`ls | grep -o "sonar-scanner-[0-9.]*-linux"`
-
-echo "Using $output"
-
-mv $output sonar-scanner

.github/workflows/codeql-analysis.yml

@@ -1,50 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-name: LGTM Analysis
-
-on:
-  create:
-  pull_request:
-  push:
-    branches:
-      - main
-  schedule:
-    - cron: '12 9 * * 3'
-
-jobs:
-  codeql:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout repository
-      uses: actions/checkout@v2
-      # Install the dependent packages
-    - name: Install packages
-      run: |
-        sudo apt update
-        sudo apt-get -y install valgrind libcunit1 libcunit1-doc libcunit1-dev libmsgpack-dev gcovr libtool
- 
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v1
-      with:
-        languages: cpp
-        queries: security-extended
-
-    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
-    # If this step fails, then you should remove it and run the build manually (see below)
-    - name: Autobuild
-      uses: github/codeql-action/autobuild@v1
-
-    # ℹ️ Command-line programs to run using the OS shell.
-    # 📚 https://git.io/JvXDl
-
-    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
-    #    and modify them (or add more) to build your code if your project
-    #    uses a compiled language
-
-    #- run: |
-    #   make bootstrap
-    #   make release
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v1

.github/workflows/push.yml

@@ -1,72 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-name: CI
-
-on:
-  pull_request:
-  push:
-    paths-ignore:
-      - 'AUTHORS'
-      - 'LICENSE'
-      - 'NOTICE'
-      - '**.md'
-      - '.gitignore'
-    tags-ignore:
-      - 'v[0-9]+.[0-9]+.[0-9]+'
-    branches:
-      - main
-      - master
-
-jobs:
-  test:
-    name: Unit Tests
-    runs-on: [ ubuntu-latest ]
-    steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-
-      # Install the dependent packages
-      - name: Install packages
-        run: |
-          sudo apt update
-          sudo apt-get -y install valgrind libcunit1 libcunit1-doc libcunit1-dev libmsgpack-dev gcovr libtool
-          pip install codecov
-
-      - name: Make Build Directory
-        run: mkdir build
-
-      - name: Get Sonarcloud Binaries
-        working-directory: build
-        run: |
-          ../.github/scripts/get_sonarcloud.sh
-
-      - name: CMake
-        working-directory: build
-        run: |
-          cmake .. -DINTEGRATION_TESTING:BOOL=false -DDISABLE_VALGRIND:BOOL=${DISABLE_VALGRIND} -DENABLE_SESHAT:BOOL=true -DFEATURE_DNS_QUERY:BOOL=true
-
-
-      - name: Build
-        working-directory: build
-        run: |
-          build-wrapper-linux-x86/build-wrapper-linux-x86-64 --out-dir bw-output make all test
-
-      - name: Merge GCOV Reports for Sonarcloud
-        working-directory: build
-        run: |
-          gcovr --sonarqube coverage.xml -r ..
-
-      - name: Upload SonarCloud
-        run: |
-          build/sonar-scanner/bin/sonar-scanner -Dsonar.host.url=https://sonarcloud.io -Dproject.settings=.sonar-project.properties -Dsonar.login=${{ secrets.SONAR_TOKEN }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Upload Codecov.io
-        uses: codecov/codecov-action@v1
-        with:
-          directory: .
-          fail_ci_if_error: true

.github/workflows/release.yml

@@ -1,49 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-name: release
-
-on:
-  push:
-    tags:
-      # Push events to matching v#.#.#*, ex: v1.2.3, v.2.4.6-beta
-      - 'v[0-9]+.[0-9]+.[0-9]+*'
-
-jobs:
-  release:
-    runs-on: [ ubuntu-latest ]
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-      - name: Determine repo name
-        run: |
-          echo "repo_name=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}')" >> $GITHUB_ENV
-          echo "version=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
-          echo "release_slug=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}')-${GITHUB_REF#refs/tags/v}" >> $GITHUB_ENV
-        shell: bash
-      - name: Create tarball and sha256
-        run: |
-          git archive --format=tar.gz -o ${release_slug}.tar.gz --prefix=${release_slug}/ ${version}
-          git archive --format=zip -o ${release_slug}.zip --prefix=${release_slug}/ ${version}
-          sha256sum ${release_slug}.tar.gz ${release_slug}.zip > ${release_slug}-sha256sums.txt
-          mkdir artifacts
-          cp ${release_slug}* artifacts/.
-      - name: Prepare Release Body
-        id: prep
-        run: |
-          export version=${GITHUB_REF#refs/tags/}
-          export NOTES=$(cat CHANGELOG.md | perl -0777 -ne 'print "$1\n" if /.*## \[${version}\]\s(.*?)\s+## \[(v\d+.\d+.\d+)\].*/s')
-          export TODAY=`date +'%m/%d/%Y'`
-          echo ::set-output name=rname::$(echo ${version} ${TODAY})
-          echo ::set-output name=body::${NOTES}
-      - name: create release
-        id: create_release
-        uses: ncipollo/release-action@v1
-        with:
-          name: ${{ steps.prep.outputs.rname }}
-          draft: false
-          prerelease: false
-          bodyFile: ${{ steps.prep.outputs.body }}
-          artifacts: "artifacts/*"
-          token: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token

.github/workflows/tag.yml

@@ -1,33 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-name: tag
-
-on:
-  push:
-    paths:
-      - "CHANGELOG.md" # only try to tag if the CHANGELOG has been updated.
-    branches:
-      - main
-
-jobs:
-  build:
-    runs-on: [ ubuntu-latest ]
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          token: '${{ secrets.PERSONAL_ACCESS_TOKEN }}'
-          fetch-depth: 0
-      - name: set up bot
-        run: |
-          git config --global user.name "xmidt-bot"
-          git config --global user.email "$BOT_EMAIL"
-      - name: export variables and tag commit
-        run: |
-          export OLD_VERSION=$(git describe --tags `git rev-list --tags --max-count=1` | tail -1)
-          export TAG=$(cat CHANGELOG.md | perl -0777 -ne 'print "$1" if /.*## \[Unreleased\]\s+## \[(v\d+.\d+.\d+)\].*/s')
-          export BINVER=$(cat CMakeLists.txt | perl -0777 -ne 'print "v$1" if /.*project\s*\(.*\s*VERSION\s*(\d+.\d+.\d+).*\s*\)/s')
-          export TODAY=`date +'%m/%d/%Y'`
-          export NOTES=$(cat CHANGELOG.md | perl -0777 -ne 'print "$ENV{TODAY}\n\n$1\n" if /.*## \[$ENV{TAG}\]\s(.*?)\s+## \[(v\d+.\d+.\d+)\].*/s')
-          if [[ "$TAG" != "" && "$TAG" != "$BINVER" ]]; then echo "CHANGELOG.md($TAG) and CMakeLists.txt VERSION($BINVER) do not match"; fi
-          if [[ "$TAG" != "" && "$TAG" != "$OLD_VERSION" && "$TAG" == "$BINVER" ]]; then git tag -a "$TAG" -m "$NOTES"; git push origin --tags; echo $?; fi

.gitignore

@@ -34,5 +34,3 @@
 tags
 
 build/
-
-tests/jwt_key.tst

.sonar-project.properties

@@ -1,34 +0,0 @@
-# SPDX-FileCopyrightText: 2021 Comcast Cable Communications Management, LLC
-# SPDX-License-Identifier: Apache-2.0
-
-# Reference:
-# https://github.com/SonarSource/sonarcloud_example_go-sqscanner-travis/blob/master/sonar-project.properties
-
-
-# =====================================================
-#   Standard properties
-# =====================================================
-
-sonar.organization=xmidt-org
-sonar.projectKey=xmidt-org_parodus
-sonar.projectName=parodus
-
-sonar.sources=src
-
-# =====================================================
-#   Meta-data for the project
-# =====================================================
-
-sonar.links.homepage=https://github.com/xmidt-org/parodus
-sonar.links.ci=https://github.com/xmidt-org/parodus/actions
-sonar.links.scm=https://github.com/xmidt-org/parodus
-sonar.links.issue=https://github.com/xmidt-org/parodus/issues
-
-# =====================================================
-#   Properties specific to C
-# =====================================================
-sonar.cfamily.build-wrapper-output=build/bw-output
-sonar.cfamily.threads=2
-sonar.cfamily.cache.enabled=false
-sonar.coverageReportPaths=build/coverage.xml
-

.travis.yml

@@ -0,0 +1,42 @@
+dist: trusty
+sudo: required
+
+language: c
+compiler:
+    - gcc
+
+addons:
+  coverity_scan:
+    project:
+      name: "Comcast/parodus"
+      description: "C implementation of the WebPA client coordinator"
+    notification_email: weston_schmidt@alumni.purdue.edu
+    build_command_prepend: "mkdir coverity_build && cd coverity_build && cmake .."
+    build_command:   "make"
+    branch_pattern: master
+    
+before_install:
+    - sudo pip install codecov
+    - echo -n | openssl s_client -connect scan.coverity.com:443 | sed -ne '/-BEGIN CERTIFICATE-/,/-END CERTIFICATE-/p' | sudo tee -a /etc/ssl/certs/ca-
+
+install:
+    - sudo apt-get update -qq
+    - sudo apt-get install -y -qq libcunit1 libcunit1-dev uuid-dev
+
+script:
+    - mkdir build
+    - cd build
+    - cmake .. -DINTEGRATION_TESTING:BOOL=false
+    - make
+    - make test
+
+after_success:
+    - codecov
+
+env:
+    global:
+        - secure: EwQu1WDUgIF5qM5tnKj/+NCPz9t15y289bbqFo0wDhyfTlJGS9buQeJNeVLtNJBEOngpo+AkaPGvh/d9NZ0vLdxu+K/e+HhA6kOTxUrCHD8+4oX9XpVs/XvQmD1COlJYeeqd8bJMKtlFtonGdMJogxpEFQzv4fQjmoARvL2ciV4OB0MBcD5Lsb72L3a0aJT69F6WFuDpgGj2eIQyCDSTPNIi2X7EA8R33lxnntFDn8Vj6qSBbVOI2S5R5S+JUCMp1Q1ZbEqmh6j+wKtszWj8wGqfz8Ol5+GYl511bExb+hwvV5zen0Ol0+2LQmSpYhbQZ7prfI8AclLLwhDUrP+WDOv34vwd4EWQ1OoLqG23HbBygCxPSBIB6ZxPtVkzjVlOK8qqIB5QXqCyq8sPKlrXfntOQ+Ha938cIA+A0ag+26MLbhDGj8k3Os7BdY/oqNTKADZQdxfGKhCiA9qO2clpMyRXoE0q6hv9dYoG/2c4sxH8DKsT8XY/QbGmiBsk0DWHcpxkObCsHUxVKi+gIBGSL/tSjz2IJfQVZkdl2hhcyStGuPKbiwAlW3HydMk0VgRhVmHBIc41Cv7vPdMEVf/XiFhr2utRX468M/LR8vkhhokKl1xkVIiquwCPYPzZVAFARHTlaBMhz9kQVtTAHf2JkHuM9XcLWKW996FiSeswKyI=
+        - secure: LQK36EsQdIJw7eSW1yz+yh3+yJdp8cznynBjE3whOEVI2KHZimr+vtK5hxE6TH0QjYyrb/BFgRql6CtLprpaABSEC9gpqpahu50jiAkjKC8DtfSloAbH5jj+ZllaPjURocerllNLVZxiRM/WCuJAy0nzBpAyx62YmVlEYi+zYD67d3wG6gLwso6l2DWuPPze6t5NmbUmH9hNk52++TZalwMtZFdibQoYm64vCTT5gycujw6ZDa8GD0m+Yryvc20kLlWPOVS9lN1iEGo98/gj8Ops8w0iw6k7SfEkvvFsKEUDr77wAN5Tk4tGq7odVrD/y3W9AsHkkSb1B6RqVWkcW3SjCAQc03jhdaBxXwcoJZcYahY21CB12EP7p0HSjEbvIzNpk0D9MulsGaMPlOudnKdG0/kmD7oIAiXjfC7PiPBBFIc/cVF5VAKNTUInEVfcKvlLpqDatwjB+qgb7pld24dUPuJw+yOgglk7J7xckJYHFTHhk0PWI5oN66dndj3yyJp4dz1v64ViFFTG4PO4YPJydZxRxolg1eGMuG0UIYJK6RWcSQ+ZPBm4p78J8xfHtgUkvWvrHJoXC1qAzqx1XRzbHEeTJgbKgLrWY+B6nbNotw1RDX4lNDirp5EI6GqezoFJToZkqe3MRs8DrqhaFjUbbEzAxznRWmxnWNN3Ujc=
+        # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+        #   via the "travis encrypt" command using the project repo's public key
+        - secure: "V/W4Z9/3uXpS83CvlZ1XfDAbHPIA2ID5G5s9GPcsUqoOASQdc6Y/DPejUlot+DgtiHOEdTr9n5iWDOuxqjcVnjVd6ag9i2m0PMqDhPj3fnUJM6dAeXIBda/qSuTsJTX4cIwb371R77cLcIUm35IEOSIAQOBCjh7RCf3ivGPUp+wobTonkNzDw6xqO90hx7NLnxwGSCcaNBFKOcLL0e7DXspp18lTWCSSaHELzXOyLlhZnWhC5tiFUIZk1ixm/cO1YEQH9AzgPJ5OYs+On0j8VT8XWMsxHu0zfkZkdZMAEOQbO6u4HBDePIfp+PoF1LwtX/UXfaEkUHZ0kNVXHfsN/KP7NHgTbASe9EXp+R4pcKEy4ZEbx+xpp7FlMQSJYiYiQbJ2FBrjwRPreXiHyCqn8htd0YNOTH4UykvO3NYxlTaMf9aE041lnLjUY18TuXrILz6SzMsGV+nYqfIci/NPuj/57k7nw127a93S4Mr/phXts9ZL8I7kagd8wKv3m5+7rmIfuSfS2kg2pTa0hk5uMqFWLG8AilUQ5t1ChylzPcl/Gdgi9OP0pG2WyUmkqOiSqhwwdg2ZCwptodwuonfbdKMSBuHOS8lLU1bGyCRdWsMoscSv/xn4t3ikzBsSDiKgI8xq2+aqQyHDeVneqAk1BbxiNIwoJeyVXq2EKU6MlgI="

.whitesource

@@ -1,12 +0,0 @@
-{
-  "scanSettings": {
-    "baseBranches": []
-  },
-  "checkRunSettings": {
-    "vulnerableCheckRunConclusionLevel": "failure",
-    "displayMode": "diff"
-  },
-  "issueSettings": {
-    "minSeverityLevel": "LOW"
-  }
-}

CHANGELOG.md

@@ -1,118 +0,0 @@
-# Changelog
-All notable changes to this project will be documented in this file.
-
-The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
-and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
-
-## [Unreleased]
-- Add additional HTTP headers for call to Themis from Convey
-- Add callback handler for initial cloud connection status change event
-- Fix Parodus connection stuck on interface up down received together
-- Update to use nopoll version 1.0.3
-
-## [1.1.4]
-- on connect retry, requery jwt only if it failed before 
-- put two timestamps in connection health file; start conn and current
-- change health file update interval to 240sec
-- use jitter in backoff delay
-- sendMessage to check cloud status == ONLINE before sending
-- when killed with SIGTERM, close will use msg in close reason file.
-
-## [1.1.3]
-- Add callback handler for ping status change event
-- Fixed nopoll_conn_unref crash
-- Update retry timestamp in connection-health-file
-- fix so that parodus can be killed, even if in a connection fail loop
-- provide signal handlers so we shut down properly when INCLUDE_BREAKPAD active
-- send status code and reason in websocket close message
-- dont try to install handler for signal 9
-
-## [1.1.2]
-- Add pause/resume heartBeatTimer
-- parodus event handler to listen to interface_down and interface_up event
-- Pause connection retry during interface_down event
-
-## [1.1.1]
-- Update to use nanomsg v. 1.1.4
-- requestNewAuthToken will clear the token if it fails.
-- request auth token on every retry, not just after 403
-- update to use nopoll v 1.0.2
-
-## [1.0.4]
-- Fix re-registration fails that lose a socket
-- Fix mutex error in service alive
-- Security: Mutual Authentication (mTLS or two way TLS)
-- Rename command line options for MTLS cert and Key
-
-## [1.0.3]
-- Security: Added support to use auth token during initial connect to cloud
-
-## [1.0.2] - 2019-02-08
-- Refactored connection.c and updated corresponding unit tests
-- Additional `/cloud-status` and `/cloud-disconnect` fields.
-- Switched from nanomsg (Release 1.1.2) to NNG (Release v1.0.1)
-- Memory leak fixes
-- Changed connection logic (connection.c) for retries, and added unit test
-- Partner-id comparison made case insensitive
-- Reverted from NNG to nanomag (v1.1.2)
-- reverted temporary CMake reference to https://github.com/bill1600/seshat
-- Added log for time difference of parodus connect time and boot time
-- added NULL check for device mac id in upstream retrieve message handling
-- backoff retry to include find_servers in loop (connection.c)
-- backoff max is max count not max delay
-- used mutex protection to make client list and nn_sends thread safe
-- put mutex lock into get_global_node
-- change svc alive from a thread to a function called every 30 sec from main
-- shut down tasks properly
-- fix memory leaks
-- Fixed memory leak in upstream event message flow
-- Fixed crash in CRUD request processing
-- Fixed issue on RETRIEVE respone processing
-- Enabled valgrind
-- Fixed main loop to keep calling svc_alive_task during a cloud disconnect and retry
-- change svc alive back to a separate thread.  Shut it down with pthread_cond_timedwait
-- Refactored Upsteam RETRIEVE flow
-- Fix re-registration to call nn_shutdown and nn_close, so we don't lose a socket.
-
-## [1.0.1] - 2018-07-18
-### Added
-- Added command line arguments for secure token read and acquire.
-- DNS check for <device-id>.<URL> to allow custom device handling logic (like test boxes, refurbishing, etc).
-- Add check for matching `partner-id` for incoming WRP messages based on command line argument passed.
-- CRUD operations to local namespace is now supported.
-- Via CRUD calls, the custom metadata tag values are now supported.
-
-### Changed
-- Configurable security flag and port.
-- Default HTTP port to 80 and HTTPS port to 443.
-- Updates to how `nopoll` is called have been implemented.
-
-### Fixed
-- 64 bit pointer fixes (#144, #145).
-- Handle `403` error from talaria (#147).
-- Several additional NULL pointer checks & recovery logic blocks added.
-- A scenario where ping requests are not responded to was fixed. 
-
-### Security
-- Added command line arguments for secure token read and acquire.  Token presented to cloud for authentication verification.
-- Added support for override functions to support drop root capabilities for parodus process
-
-## [1.0.0] - 2017-11-17
-### Added
-- Added the basic implementation.
-
-## [0.0.1] - 2016-08-15
-### Added
-- Initial creation
-
-[Unreleased]: https://github.com/Comcast/parodus/compare/1.1.4...HEAD
-[1.1.4]: https://github.com/Comcast/parodus/compare/1.1.3...1.1.4
-[1.1.3]: https://github.com/Comcast/parodus/compare/1.1.2...1.1.3
-[1.1.2]: https://github.com/Comcast/parodus/compare/1.1.1...1.1.2
-[1.1.1]: https://github.com/Comcast/parodus/compare/1.0.4...1.1.1
-[1.0.4]: https://github.com/Comcast/parodus/compare/1.0.3...1.0.4
-[1.0.3]: https://github.com/Comcast/parodus/compare/1.0.2...1.0.3
-[1.0.2]: https://github.com/Comcast/parodus/compare/1.0.1...1.0.2
-[1.0.1]: https://github.com/Comcast/parodus/compare/1.0.0...1.0.1
-[1.0.0]: https://github.com/Comcast/parodus/compare/79fa7438de2b14ae64f869d52f5c127497bf9c3f...1.0.0
-

CMakeLists.txt

@@ -14,7 +14,6 @@
 
 cmake_minimum_required(VERSION 2.8.7)
 
-#project(parodus VERSION 1.1.15)
 project(parodus)
 
 include(ExternalProject)
@@ -23,8 +22,6 @@ include(CTest)
 set(INSTALL_DIR ${CMAKE_CURRENT_BINARY_DIR}/_install)
 set(PREFIX_DIR ${CMAKE_CURRENT_BINARY_DIR}/_prefix)
 set(INCLUDE_DIR ${INSTALL_DIR}/include)
-set(INCLUDE_UCRESOLV ${PREFIX_DIR}/ucresolv/src/ucresolv/include)
-set(PATCHES_DIR ${CMAKE_CURRENT_SOURCE_DIR}/patches)
 set(LIBRARY_DIR ${INSTALL_DIR}/lib)
 set(LIBRARY_DIR64 ${INSTALL_DIR}/lib64)
 set(COMMON_LIBRARY_DIR ${INSTALL_DIR}/lib/${CMAKE_LIBRARY_ARCHITECTURE})
@@ -35,31 +32,12 @@ include_directories(${INCLUDE_DIR}
                     ${INCLUDE_DIR}/cjson
                     ${INCLUDE_DIR}/nopoll
                     ${INCLUDE_DIR}/msgpack
-	            ${INCLUDE_DIR}/curl
                     ${INCLUDE_DIR}/trower-base64
                     ${INCLUDE_DIR}/wrp-c                   
                     ${INCLUDE_DIR}/libparodus
                     ${INCLUDE_DIR}/cimplog
-                    ${INCLUDE_DIR}/cjwt
-					)	
-
-if (ENABLE_WEBCFGBIN)
-include_directories(${INCLUDE_DIR}/rbus
-		    ${INCLUDE_DIR}/rbus-core
-		    ${INCLUDE_DIR}/rtmessage
-)
-endif (ENABLE_WEBCFGBIN)
-
-# Get git commit hash 
-#-------------------------------------------------------------------------------
-execute_process(
-  COMMAND git describe --tags --always
-  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
-  OUTPUT_VARIABLE GIT_COMMIT_TAG
-  OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-
-add_definitions("-DGIT_COMMIT_TAG=\"${GIT_COMMIT_TAG}\"")	
+                    ${INCLUDE_DIR}/libseshat
+                   )
 
 # Compile options/flags
 #-------------------------------------------------------------------------------
@@ -81,8 +59,8 @@ if (NOT BUILD_YOCTO)
 ExternalProject_Add(trower-base64
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/trower-base64
     GIT_REPOSITORY https://github.com/Comcast/trower-base64.git
-    GIT_TAG "v1.1.1"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
+    GIT_TAG "master"
+    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(libtrower-base64 STATIC SHARED IMPORTED)
 add_dependencies(libtrower-base64 trower-base64)
@@ -90,11 +68,19 @@ add_dependencies(libtrower-base64 trower-base64)
 
 # nopoll external dependency
 #-------------------------------------------------------------------------------
+set(NOPOLL_LOG_SRC ${PREFIX_DIR}/nopoll/src/nopoll/src/nopoll_log.c)
 ExternalProject_Add(nopoll
     PREFIX ${PREFIX_DIR}/nopoll
-    GIT_REPOSITORY https://github.com/Comcast/nopoll.git
-    GIT_TAG "1.0.3"
-    CONFIGURE_COMMAND COMMAND <SOURCE_DIR>/autogen.sh --prefix=${PREFIX}
+    GIT_REPOSITORY https://github.com/selvamKrish/nopoll.git
+    GIT_TAG "testing-branch"
+    PATCH_COMMAND ""
+    COMMAND touch NEWS README AUTHORS ChangeLog
+    COMMAND libtoolize --force
+    COMMAND aclocal
+    COMMAND autoheader --warnings=error
+    COMMAND automake --add-missing -Werror
+    COMMAND autoconf --force --warnings=error
+    CONFIGURE_COMMAND COMMAND <SOURCE_DIR>/configure --prefix=${PREFIX}
                                                      --includedir=${INCLUDE_DIR}
                                                      --libdir=${LIBRARY_DIR}
                                                      ${CUSTOM_HOST}
@@ -109,7 +95,7 @@ add_dependencies(libnopoll nopoll)
 ExternalProject_Add(nanomsg
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/nanomsg
     GIT_REPOSITORY https://github.com/nanomsg/nanomsg.git
-    GIT_TAG "1.1.4"
+    #GIT_TAG "096998834451219ee7813d8977f6a4027b0ccb43"
     CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(libnanomsg STATIC SHARED IMPORTED)
@@ -122,8 +108,8 @@ ExternalProject_Add(cJSON
     #PREFIX ${PREFIX_DIR}/cJSON
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/cJSON
     GIT_REPOSITORY https://github.com/DaveGamble/cJSON.git
-    GIT_TAG "v1.7.8"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
+    GIT_TAG "aafb64a1c549b7b927e339df6d35b1d5059dc235"
+    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(libcJSON STATIC SHARED IMPORTED)
 add_dependencies(libcJSON cJSON)
@@ -134,7 +120,7 @@ add_dependencies(libcJSON cJSON)
 ExternalProject_Add(msgpack
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/msgpack
     GIT_REPOSITORY https://github.com/msgpack/msgpack-c.git
-    GIT_TAG "cpp-3.1.1"
+    GIT_TAG "c6e6dbc608366090c12b142b3832604e6aa12f54"
     CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
                   -DMSGPACK_ENABLE_CXX=OFF
                   -DMSGPACK_BUILD_EXAMPLES=OFF
@@ -143,25 +129,13 @@ add_library(libmsgpack STATIC SHARED IMPORTED)
 add_dependencies(libmsgpack msgpack)
 
 
-# curl external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(curl
-    PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/curl
-    GIT_REPOSITORY https://github.com/curl/curl.git
-    GIT_TAG "curl-7_63_0"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
-)
-add_library(libcurl STATIC SHARED IMPORTED)
-add_dependencies(libcurl curl)
-
-
 # cimplog external dependency
 #-------------------------------------------------------------------------------
 ExternalProject_Add(cimplog
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/cimplog
     GIT_REPOSITORY https://github.com/Comcast/cimplog.git
-    GIT_TAG "1.0.2"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
+    GIT_TAG "master"
+    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(libcimplog STATIC SHARED IMPORTED)
 add_dependencies(libcimplog cimplog)
@@ -170,124 +144,45 @@ add_dependencies(libcimplog cimplog)
 # wrp-c external dependency
 #-------------------------------------------------------------------------------
 ExternalProject_Add(wrp-c
-	DEPENDS trower-base64 msgpack cimplog
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/wrp-c
-    GIT_REPOSITORY https://github.com/xmidt-org/wrp-c.git
-    GIT_TAG "71f8a39fe39f98da007ed4cdabbb192be1da1685"
+    GIT_REPOSITORY https://github.com/Comcast/wrp-c.git
+    GIT_TAG "master"
     CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
                   -DMSGPACK_ENABLE_CXX=OFF
                   -DMSGPACK_BUILD_EXAMPLES=OFF
                   -DBUILD_TESTING=OFF
-                  -DMAIN_PROJ_BUILD=ON
-                  -DMAIN_PROJ_LIB_PATH=${LIBRARY_DIR}
-    		  -DMAIN_PROJ_INCLUDE_PATH=${INCLUDE_DIR}
 )
 add_library(libwrp-c STATIC SHARED IMPORTED)
 add_dependencies(libwrp-c wrp-c)
 
+# libparodus external dependency
+#-------------------------------------------------------------------------------
+ExternalProject_Add(libparodus
+    PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/libparodus
+    GIT_REPOSITORY https://github.com/Comcast/libparodus.git
+    GIT_TAG "master"
+    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
+)
+add_library(liblibparodus STATIC SHARED IMPORTED)
+add_dependencies(liblibparodus libparodus)
 
-if (ENABLE_SESHAT)
 # libseshat external dependency
 #-------------------------------------------------------------------------------
 ExternalProject_Add(libseshat
-    DEPENDS cJSON trower-base64 msgpack nanomsg wrp-c
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/libseshat
-    GIT_REPOSITORY https://github.com/Comcast/seshat.git
-    GIT_TAG "1.0.1"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
-    	          -DMAIN_PROJ_BUILD=ON
-    	          -DMAIN_PROJ_LIB_PATH=${LIBRARY_DIR}
-    	          -DMAIN_PROJ_LIB64_PATH=${LIBRARY_DIR64}
-    		  -DMAIN_PROJ_COMMON_PATH=${COMMON_LIBRARY_DIR}
-    		  -DMAIN_PROJ_INCLUDE_PATH=${INCLUDE_DIR}
+    GIT_REPOSITORY https://github.com/comcast/seshat.git
+    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(liblibseshat STATIC SHARED IMPORTED)
 add_dependencies(liblibseshat libseshat)
-include_directories(${INCLUDE_DIR}/libseshat)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DENABLE_SESHAT ")
-endif (ENABLE_SESHAT)
-
-# libcjwt external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(cjwt
-    PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/cjwt
-    GIT_REPOSITORY https://github.com/Comcast/cjwt.git
-    GIT_TAG "1b023c41bb2d6dbbf493c202ed81f06c84d5b51b"
-    #GIT_TAG "1.0.1"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
-)
-add_library(libcjwt STATIC SHARED IMPORTED)
-add_dependencies(libcjwt cjwt)
-
-if (FEATURE_DNS_QUERY)
-# libucresolv external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(ucresolv
-    PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/ucresolv
-    GIT_REPOSITORY https://github.com/Comcast/libucresolv.git
-    GIT_TAG "1.0.0"
-    CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
-)
-add_library(libucresolv STATIC SHARED IMPORTED)
-add_dependencies(libucresolv ucresolv)
-include_directories(${INCLUDE_DIR}
-                    ${INCLUDE_DIR}/ucresolv
-					)		
-
-endif (FEATURE_DNS_QUERY)
-
-if (ENABLE_WEBCFGBIN)
-# rtMessage external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(rtMessage
-     DEPENDS cJSON
-     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/rtMessage
-     GIT_REPOSITORY https://github.com/rdkcmf/rdk-rtmessage.git
-     GIT_TAG rdk-next
-     CMAKE_ARGS += -DBUILD_RTMESSAGE_LIB=ON
-                   -DBUILD_RTMESSAGE_SAMPLE_APP=ON
-                   -DBUILD_FOR_DESKTOP=OFF
-		   -DCJSON_BUILD=OFF
-                   -DBUILD_DATAPROVIDER_LIB=ON
-                   -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
-)
-add_library(librtMessage STATIC SHARED IMPORTED)
-add_dependencies(librtMessage rtMessage)
-
-# rbus-core external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(rbus-core
-     DEPENDS rtMessage
-     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/rbus-core
-     GIT_REPOSITORY https://github.com/rdkcmf/rbuscore.git
-     GIT_TAG rdk-next
-     CMAKE_ARGS += -DBUILD_FOR_DESKTOP=ON -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
-                   -DBUILD_TESTING=OFF
-)
-add_library(librbus-core STATIC SHARED IMPORTED)
-add_dependencies(librbus-core rbus-core)
-
-# rbus external dependency
-#-------------------------------------------------------------------------------
-ExternalProject_Add(rbus
-     DEPENDS rtMessage rbus-core
-     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/rbus
-     GIT_REPOSITORY https://github.com/rdkcmf/rbus.git
-     GIT_TAG rdk-next
-     CMAKE_ARGS += -DBUILD_FOR_DESKTOP=ON -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} -DBUILD_TESTING=OFF
-)
-
-add_library(librbus STATIC SHARED IMPORTED)
-add_dependencies(librbus rbus)
-endif (ENABLE_WEBCFGBIN)
 
 if (BUILD_TESTING)
 # cmocka external dependency
 #-------------------------------------------------------------------------------
 ExternalProject_Add(cmocka
     PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_prefix/cmocka
-    GIT_REPOSITORY https://github.com/elventear/cmocka.git
-    GIT_TAG "b71a3060699bc1a5b00e958be353772f42545ac2"
+    GIT_REPOSITORY https://git.cryptomilk.org/projects/cmocka.git
+    GIT_TAG "master"
     CMAKE_ARGS += -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
 )
 add_library(libcmocka STATIC SHARED IMPORTED)
@@ -295,23 +190,7 @@ add_dependencies(libcmocka cmocka)
 
 endif (BUILD_TESTING)
 
-endif () # NOT BUILD_YOCTO
-
-if (BUILD_YOCTO)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DBUILD_YOCTO ")
-endif (BUILD_YOCTO)
-
-if (FEATURE_DNS_QUERY)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DFEATURE_DNS_QUERY ")
-endif (FEATURE_DNS_QUERY)
-
-if (ENABLE_WEBCFGBIN)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DENABLE_WEBCFGBIN ")
-endif (ENABLE_WEBCFGBIN)
-
-if (WAN_FAILOVER_SUPPORTED)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DWAN_FAILOVER_SUPPORTED ")
-endif (WAN_FAILOVER_SUPPORTED)
+endif ()
 
 link_directories ( ${LIBRARY_DIR} ${COMMON_LIBRARY_DIR} ${LIBRARY_DIR64} )
 add_subdirectory(src)

CONTRIBUTING.md

@@ -1,31 +1,5 @@
-Contribution Guidelines
-=======================
+If you would like to contribute code to this project you can do so
+through GitHub by forking the repository and sending a pull request.
 
-We love to see contributions to the project and have tried to make it easy to do so. If you would like to contribute code to this project you can do so through GitHub by forking the repository and sending a pull request.
-
-Before Comcast merges your code into the project you must sign the [Comcast Contributor License Agreement (CLA)](https://gist.github.com/ComcastOSS/a7b8933dd8e368535378cda25c92d19a).
-
-If you haven't previously signed a Comcast CLA, you'll automatically be asked to when you open a pull request. Alternatively, we can e-mail you a PDF that you can sign and scan back to us. Please send us an e-mail or create a new GitHub issue to request a PDF version of the CLA.
-
-For more details about contributing to GitHub projects see
-http://gun.io/blog/how-to-github-fork-branch-and-pull-request/
-
-Documentation
--------------
-
-If you contribute anything that changes the behavior of the
-application, document it in the [README](https://github.com/Comcast/parodus/blob/master/README.md) or [wiki](https://github.com/Comcast/parodus/wiki)! This includes new features, additional variants of behavior and breaking changes.
-
-Testing
--------
-
-Tests are written using golang's standard testing tools, and are run prior to the PR being accepted.
-
-Pull Requests
--------------
-
-* should be narrowly focused with no more than 3 or 4 logical commits
-* when possible, address no more than one issue
-* should be reviewable in the GitHub code review tool
-* should be linked to any issues it relates to (i.e. issue number after (#) in commit messages or pull request message)
-* should conform to idiomatic golang code formatting
+Before Comcast accepts your code into the project you must sign the
+Comcast Contributor License Agreement ('CLA.pdf').

NOTICE

@@ -1,16 +0,0 @@
-parodus
-Copyright 2017 Comcast Cable Communications Management, LLC
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-
-This product includes software developed at Comcast (http://www.comcast.com/).

README.md

@@ -1,22 +1,11 @@
-<!--
-SPDX-FileCopyrightText: 2016-2021 Comcast Cable Communications Management, LLC
-SPDX-License-Identifier: Apache-2.0
--->
 # parodus
 
-[![Build Status](https://github.com/xmidt-org/parodus/workflows/CI/badge.svg)](https://github.com/xmidt-org/parodus/actions)
-[![codecov.io](http://codecov.io/github/xmidt-org/parodus/coverage.svg?branch=master)](http://codecov.io/github/xmidt-org/parodus?branch=master)
+C implementation of the WebPA client coordinator
+
+[![Build Status](https://travis-ci.org/Comcast/parodus.svg?branch=master)](https://travis-ci.org/Comcast/parodus)
+[![codecov.io](http://codecov.io/github/Comcast/parodus/coverage.svg?branch=master)](http://codecov.io/github/Comcast/parodus?branch=master)
 [![Coverity](https://img.shields.io/coverity/scan/11192.svg)](https://scan.coverity.com/projects/comcast-parodus)
-[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=xmidt-org_parodus&metric=alert_status)](https://sonarcloud.io/dashboard?id=xmidt-org_parodus)
-[![Language Grade: C/C++](https://img.shields.io/lgtm/grade/cpp/g/xmidt-org/parodus.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/xmidt-org/parodus/context:cpp)
-[![Apache V2 License](http://img.shields.io/badge/license-Apache%20V2-blue.svg)](https://github.com/xmidt-org/parodus/blob/master/LICENSE)
-[![GitHub release](https://img.shields.io/github/release/xmidt-org/parodus.svg)](CHANGELOG.md)
-
-
-C implementation of the XMiDT client coordinator
-
-XMiDT is a highly scalable, highly available, generic message routing system.
-
+[![Apache V2 License](http://img.shields.io/badge/license-Apache%20V2-blue.svg)](https://github.com/Comcast/parodus/blob/master/LICENSE)
 # Building and Testing Instructions
 
 ```
@@ -26,85 +15,3 @@ cmake ..
 make
 make test
 ```
-# Command line Arguments needed to start parodus
-
-```
-- /hw-model -The hardware model name.
-
-- /hw-serial-number -The serial number.
-
-- /hw-manufacturer -The device manufacturer.
-
-- /hw-mac -The MAC address used to manage the device.
-
-- /hw-last-reboot-reason -The last known reboot reason.
-
-- /fw-name -The firmware name.
-
-- /boot-time -The boot time in unix time.
-
-- /webpa-url -The URL that the WRP client should reach out to. (required). Must begin with 'https://' or 'http://'.  May end with a port number. If no port specified, then 443 is assumed for https, 80 for http.
-
-- /webpa-backoff-max -The maximum value of c in the binary backoff algorithm
-
-- /webpa-ping-timeout -The maximum time to wait between pings before assuming the connection is broken.
-
-- /webpa-interface-used -The device interface being used to connect to the cloud.
-
-- /parodus-local-url -Parodus local server url (optional argument)
-
-- /partner-id -  Partner ID of broadband gateway (optional argument)
-
-- /ssl-cert-path -Provide the certs for establishing secure connection (optional argument)
-
-- /force-ipv4 -Forcefully connect parodus to ipv4 address (optional argument)
-
-- /force-ipv6 -Forcefully connect parodus to ipv6 address (optional argument)
-
-- /client-cert-path -MTLS client cert location to request auth token for establishing secure connection [absolute path where client cert is present] (optional argument)
-
-- /token-server-url -complete server url with API path to request new auth token for establishing secure connection (optional argument)
-
-- /crud-config-file -Config json file to store objects during create, retrieve, update and delete (CRUD) operations -optional argument 
-
-
-# if ENABLE_SESHAT is enabled
-- /seshat-url - The seshat server url 
-
-# if FEATURE_DNS_QUERY is enabled then below mentioned arguments are needed
-
-- /acquire-jwt - this parameter (0 or 1) specifies whether there will be a dns lookup. If not, or if any problem occurs with the dns lookup, then webpa-url will be the target. 
-
-- /dns-txt-url  - this parameter is used along with the hw_mac parameter to create the dns txt record id
-
-- /jwt-algo -Allowed algorithm used for communication
-
-- /jwt-public-key-file -JWT token validation key
-
-# if ENABLE_MUTUAL_AUTH is enabled
-
-- /mtls-client-cert-path - Provide the client cert for establishing a mutual auth secure websocket connection
-
-- /mtls-client-key-path - Provide the client cert key for establishing a mutual auth secure websocket connection
-
-```
-
-# Sample parodus start commands:
-
-```
-# Seshat & FEATURE_DNS_QUERY Enabled
-
-./parodus --hw-model=TGXXX --hw-serial-number=E8GBUEXXXXXXXXX --hw-manufacturer=ARRIS --hw-mac=14cfexxxxxxx --hw-last-reboot-reason=unknown --fw-name=TG1682_DEV_master_20170512115046sdy --boot-time=1494590301 --webpa-ping-timeout=180 --webpa-interface-used=eth0 --webpa-url=https://somebody.net:8080 --webpa-backoff-max=9 --parodus-local-url=tcp://127.0.0.1:6666 --partner-id=comcast --ssl-cert-path=/etc/ssl/certs/ca-certificates.crt --acquire-jwt=1 --dns-txt-url=somebody.net --jwt-public-key-file=webpa-rs256.pem --jwt-algo=RS256 --seshat-url=tcp://127.0.0.1:7777 --client-cert-path=/tmp/clientcert.mch --token-server-url=https://somebody.net:8080/token --force-ipv4 --crud-config-file=/tmp/parodus_cfg.json
-
-
-# Seshat is not enabled
-
-./parodus --hw-model=TGXXX --hw-serial-number=E8GBUEXXXXXXXXX --hw-manufacturer=ARRIS --hw-mac=14cfexxxxxxx --hw-last-reboot-reason=unknown --fw-name=TG1682_DEV_master_20170512115046sdy --boot-time=1494590301 --webpa-ping-timeout=180 --webpa-interface-used=eth0 --webpa-url=https://somebody.net:8080 --webpa-backoff-max=9 --parodus-local-url=tcp://127.0.0.1:6666 --partner-id=comcast --ssl-cert-path=/etc/ssl/certs/ca-certificates.crt --acquire-jwt=1 --dns-txt-url=somebody.net --jwt-public-key-file=webpa-rs256.pem --jwt-algo=RS256 --client-cert-path=/tmp/clientcert.mch --token-server-url=https://somebody.net:8080/token --force-ipv4 --crud-config-file=/tmp/parodus_cfg.json
-
-
-# When both Seshat & FEATURE_DNS_QUERY not Enabled
-
-./parodus --hw-model=TGXXX --hw-serial-number=E8GBUEXXXXXXXXX --hw-manufacturer=ARRIS --hw-mac=14cfexxxxxxx --hw-last-reboot-reason=unknown --fw-name=TG1682_DEV_master_20170512115046sdy --boot-time=1494590301 --webpa-ping-timeout=180 --webpa-interface-used=eth0 --webpa-url=https://somebody.net:8080 --webpa-backoff-max=9 --parodus-local-url=tcp://127.0.0.1:6666 --partner-id=comcast --ssl-cert-path=/etc/ssl/certs/ca-certificates.crt --client-cert-path=/tmp/clientcert.mch --token-server-url=https://somebody.net:8080/token --force-ipv4 --crud-config-file=/tmp/parodus_cfg.json
-
-```
-

src/CMakeLists.txt

@@ -11,27 +11,8 @@
 #   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
-set(SOURCES main.c mutex.c networking.c nopoll_helpers.c heartBeat.c nopoll_handlers.c
-    ParodusInternal.c string_helpers.c time.c config.c conn_interface.c
-    connection.c spin_thread.c client_list.c service_alive.c
-    upstream.c downstream.c thread_tasks.c partners_check.c token.c event_handler.c
-	crud_interface.c crud_tasks.c crud_internal.c close_retry.c auth_token.c privilege.c)
-
-if (ENABLE_SESHAT)
-set(SOURCES ${SOURCES} seshat_interface.c)
-else()
-set(SOURCES ${SOURCES} seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-
-if (ENABLE_WEBCFGBIN)
-set(SOURCES ${SOURCES} upstream_rbus.c xmidtsend_rbus.c)
-endif (ENABLE_WEBCFGBIN)
-
-if (WAN_FAILOVER_SUPPORTED)
-message(STATUS "WAN_FAILOVER_SUPPORTED is supported")
-else()
-message(STATUS "WAN_FAILOVER_SUPPORTED is not supported")
-endif (WAN_FAILOVER_SUPPORTED)
+set(SOURCES main.c mutex.c networking.c nopoll_helpers.c nopoll_handlers.c ParodusInternal.c 
+    string_helpers.c time.c config.c conn_interface.c connection.c spin_thread.c client_list.c service_alive.c upstream.c downstream.c thread_tasks.c partners_check.c)
 
 add_executable(parodus ${SOURCES})
 
@@ -39,9 +20,9 @@ target_link_libraries (parodus
     ${CMAKE_THREAD_LIBS_INIT}
     -lwrp-c
     -lmsgpackc
-    -lcurl
     -ltrower-base64
     -lnopoll
+    -llibseshat
     -luuid
     -lm
     -lcimplog
@@ -49,20 +30,7 @@ target_link_libraries (parodus
     -lcrypto
     -lnanomsg
     -lcjson
-    -lcjwt
     -lpthread
     -lrt
     )
-
-if (FEATURE_DNS_QUERY)
-target_link_libraries (parodus -lucresolv -lresolv)
-endif (FEATURE_DNS_QUERY)
-
-if (ENABLE_SESHAT)
-target_link_libraries (parodus -llibseshat)
-endif (ENABLE_SESHAT)
-
-if (ENABLE_WEBCFGBIN)
-target_link_libraries (parodus -lrbus -lrbus-core -lrtMessage)
-endif (ENABLE_WEBCFGBIN)
 install (TARGETS parodus DESTINATION bin)

src/ParodusInternal.c

@@ -1,35 +1,15 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file ParodusInternal.c
  *
  * @description This file is used to manage internal functions of parodus
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #include "ParodusInternal.h"
 #include "config.h"
 #include "connection.h"
 
-bool interface_down_event = false;
-
-pthread_mutex_t interface_down_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t interface_down_con=PTHREAD_COND_INITIALIZER;
-
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -69,9 +49,9 @@ char* getWebpaConveyHeader()
         cJSON_AddStringToObject(response, WEBPA_PROTOCOL, get_parodus_cfg()->webpa_protocol);
     }
 
-    if(strlen(getWebpaInterface())!=0)
+    if(strlen(get_parodus_cfg()->webpa_interface_used)!=0)
     {
-	    cJSON_AddStringToObject(response, WEBPA_INTERFACE, getWebpaInterface());
+	    cJSON_AddStringToObject(response, WEBPA_INTERFACE, get_parodus_cfg()->webpa_interface_used);
     }	
 
     if(strlen(get_parodus_cfg()->hw_last_reboot_reason)!=0)
@@ -92,10 +72,6 @@ char* getWebpaConveyHeader()
      	ParodusError("Failed to GET Reconnect reason value\n");
     }
 	
-	if(get_parodus_cfg()->boot_retry_wait > 0)
-	{
-	    cJSON_AddNumberToObject(response, BOOT_RETRY_WAIT, get_parodus_cfg()->boot_retry_wait);
-	}
     buffer = cJSON_PrintUnformatted(response);
     ParodusInfo("X-WebPA-Convey Header: [%zd]%s\n", strlen(buffer), buffer);
 
@@ -121,91 +97,6 @@ char* getWebpaConveyHeader()
 	    encodedData[j]='\0';
 	    ParodusPrint("Encoded X-WebPA-Convey Header: [%zd]%s\n", strlen(encodedData), encodedData);
     }
-    free(buffer);
-    cJSON_Delete(response);
 
-    if( 0 < strlen(encodedData) ) {
-        return encodedData;
-    }
-
-    return NULL;
+    return encodedData;
 }
-
-int readFromFile(const char *file_name, char **data)
-{
-	FILE *fp;
-	int ch_count = 0;
-	fp = fopen(file_name, "r+");
-	if (fp == NULL)
-	{
-		ParodusError("Failed to open file %s (errno %d)\n", file_name, errno);
-		return 0;
-	}
-	fseek(fp, 0, SEEK_END);
-	ch_count = ftell(fp);
-	fseek(fp, 0, SEEK_SET);
-	*data = (char *) malloc(sizeof(char) * (ch_count + 1));
-	fread(*data, 1, ch_count,fp);
-	(*data)[ch_count] ='\0';
-	fclose(fp);
-	return 1;
-}
-
-
-void timespec_diff(struct timespec *start, struct timespec *stop,
-                   struct timespec *diff)
-{
-    if ((stop->tv_nsec - start->tv_nsec) < 0) {
-        diff->tv_sec = stop->tv_sec - start->tv_sec - 1;
-        diff->tv_nsec = stop->tv_nsec - start->tv_nsec + 1000000000UL;
-    } else {
-        diff->tv_sec = stop->tv_sec - start->tv_sec;
-        diff->tv_nsec = stop->tv_nsec - start->tv_nsec;
-    }
-
-    return;
-}
-
-
-/*------------------------------------------------------------------------------*/
-/*                        For interface_down_event Flag                         */
-/*------------------------------------------------------------------------------*/
-
-// Get value of interface_down_event
-bool get_interface_down_event() 
-{
-	bool tmp = false;
-	pthread_mutex_lock (&interface_down_mut);
-	tmp = interface_down_event;
-	pthread_mutex_unlock (&interface_down_mut);
-	return tmp;
-}
-
-// Reset value of interface_down_event to false
-void reset_interface_down_event() 
-{
-	pthread_mutex_lock (&interface_down_mut);
-	interface_down_event = false;
-	pthread_cond_signal(&interface_down_con);
-	pthread_mutex_unlock (&interface_down_mut);
-}
-
-// set value of interface_down_event to true
-void set_interface_down_event() 
-{
-	pthread_mutex_lock (&interface_down_mut);
-    	interface_down_event = true;
-    	pthread_mutex_unlock (&interface_down_mut);
-}
-
-pthread_cond_t *get_interface_down_con(void)
-{
-    return &interface_down_con;
-}
-
-pthread_mutex_t *get_interface_down_mut(void)
-{
-    return &interface_down_mut;
-}
-
-

src/ParodusInternal.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file ParodusInternal.h
  *
  * @description This file is used to manage internal functions of parodus
  *
+ * Copyright (c) 2015  Comcast
  */
 #ifndef _PARODUSINTERNAL_H_
 #define _PARODUSINTERNAL_H_
@@ -49,10 +34,8 @@
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
 /*----------------------------------------------------------------------------*/
-
 #define UNUSED(x) (void )(x)
-#define NANO_SOCKET_SEND_TIMEOUT_MS                     2000
-#define NANO_SOCKET_RCV_TIMEOUT_MS			500
+#define NANOMSG_SOCKET_TIMEOUT_MSEC                      2000
 
 #ifndef TEST
 #define FOREVER()   1
@@ -61,12 +44,6 @@ extern int numLoops;
 #define FOREVER()   numLoops--
 #endif
 
-// Return values for find_servers() in connection.c
-#define FIND_SUCCESS 0
-#define FIND_INVALID_DEFAULT -2
-#define FIND_JWT_FAIL -1
-
-
 /*----------------------------------------------------------------------------*/
 /*                               Data Structures                              */
 /*----------------------------------------------------------------------------*/
@@ -79,66 +56,12 @@ typedef struct ParodusMsg__
 	struct ParodusMsg__ *next;
 } ParodusMsg;
 
-// Used in token.c to get jwt from dns server
-typedef struct {
-	const char *rr_ptr;
-	int rr_len;
-} rr_rec_t;
-
-//------------ Used in comnection.c -----------------
-typedef struct {
-  int allow_insecure;
-  char *server_addr;  // must be freed
-  unsigned int port;
-} server_t;
-
-typedef struct {
-  server_t defaults;	// from command line
-  server_t jwt;		// from jwt endpoint claim
-  server_t redirect;	// from redirect response to
-			//  nopoll_conn_wait_until_connection_ready
-} server_list_t;
-
-//---- Used in connection.c for expire timer
-typedef struct {
-  int running;
-  struct timespec start_time;
-  struct timespec end_time;
-} expire_timer_t;
-
-//--- Used in connection.c for backoff delay timer
-typedef struct {
-  unsigned long start_time;
-  struct timespec ts;
-  int count;
-  int max_count;
-  int delay;
-} backoff_timer_t;
-
-//--- Used in connection.c for init_header_info
-typedef struct {
-  char *conveyHeader;	// Do not free
-  char *device_id;	// Need to free
-  char *user_agent;	// Need to free
-} header_info_t;
-
-// connection context which is defined in createNopollConnection
-// and passed into functions keep_retrying_connect, connect_and_wait,
-// wait_connection_ready, and nopoll_connect 
-typedef struct {
-  noPollCtx *nopoll_ctx;
-  server_list_t *server_list;
-  server_t *current_server;
-  header_info_t header_info;
-  char *extra_headers;		// need to be freed
-  expire_timer_t connect_timer;
-} create_connection_ctx_t;
-
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-extern bool g_shutdown;
+extern bool LastReasonStatus;
 extern ParodusMsg *ParodusMsgQ;
+int numLoops;
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
@@ -153,42 +76,6 @@ void parStrncpy(char *destStr, const char *srcStr, size_t destSize);
 
 char* getWebpaConveyHeader();
 
-void *CRUDHandlerTask();
-void addCRUDmsgToQueue(wrp_msg_t *crudMsg);
-
-int readFromFile(const char *file_name, char **data);
-
-void timespec_diff(struct timespec *start, struct timespec *stop,
-                   struct timespec *result);
-
-#ifdef ENABLE_WEBCFGBIN
-void subscribeRBUSevent();
-int regXmidtSendDataMethod();
-#endif
-#ifdef WAN_FAILOVER_SUPPORTED
-void setWebpaInterface(char *value);
-#endif
-/*------------------------------------------------------------------------------*/
-/*                        For interface_down_event Flag                         */
-/*------------------------------------------------------------------------------*/
-
-// Get value of interface_down_event
-bool get_interface_down_event();
-
-// Reset value of interface_down_event to false
-void reset_interface_down_event();
-
-// Set value of interface_down_event to true
-void set_interface_down_event();
-
-pthread_cond_t *get_interface_down_con();
-
-pthread_mutex_t *get_interface_down_mut();
-
-pthread_cond_t *get_global_cloud_status_cond(void);
-
-pthread_mutex_t *get_global_cloud_status_mut(void);
-  
 #ifdef __cplusplus
 }
 #endif

src/auth_token.c

@@ -1,322 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file auth_token.c
- *
- * @description This file is to fetch authorization token during parodus cloud connection.
- *
- */
-
-#include <stdio.h>
-#include <fcntl.h> 
-#include "config.h"
-#include "connection.h"
-#include "auth_token.h"
-#include "ParodusInternal.h"
-#include <cjwt/cjwt.h>
-#include <stdlib.h>
-#include <curl/curl.h>
-#include <uuid/uuid.h>
-
-#define MAX_BUF_SIZE	        256
-#define CURL_TIMEOUT_SEC	25L
-#define MAX_CURL_RETRY_COUNT 	3
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-void createCurlheader(struct curl_slist *list, struct curl_slist **header_list);
-long g_response_code;
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-int getGlobalResponseCode()
-{
-	return g_response_code;
-}
-/*
-* @brief Initialize curl object with required options. create newToken using libcurl.
-* @param[out] newToken auth token string obtained from JWT curl response
-* @param[in] len total token size
-* @param[in] r_count Number of curl retries on ipv4 and ipv6 mode during failure
-* @return returns 0 if success, otherwise failed to fetch auth token and will be retried.
-*/
-
-int requestNewAuthToken(char *newToken, size_t len, int r_count)
-{
-	CURL *curl;
-	CURLcode res;
-	CURLcode time_res;
-	struct curl_slist *list = NULL;
-	struct curl_slist *headers_list = NULL;
-
-	char webpa_interface[64]={'\0'};
-	double total;
-
-	struct token_data data;
-	data.size = 0;
-	data.data = newToken;
-
-	curl = curl_easy_init();
-	if(curl)
-	{
-		data.data[0] = '\0';
-
-		createCurlheader(list, &headers_list);
-
-		curl_easy_setopt(curl, CURLOPT_URL, get_parodus_cfg()->token_server_url);
-		curl_easy_setopt(curl, CURLOPT_TIMEOUT, CURL_TIMEOUT_SEC);
-
-		parStrncpy(webpa_interface, getWebpaInterface(), sizeof(webpa_interface));
-		if(webpa_interface !=NULL && strlen(webpa_interface) >0)
-		{
-			curl_easy_setopt(curl, CURLOPT_INTERFACE, webpa_interface);
-		}
-		/* set callback for writing received data */
-		curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_callback_fn);
-		curl_easy_setopt(curl, CURLOPT_WRITEDATA, &data);
-
-		curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headers_list);
-
-		/* setting curl resolve option as default mode.
-		If any failure, retry with v4 first and then v6 mode. */
-
-		if(r_count == 1)
-		{
-			ParodusInfo("curl Ip resolve option set as V4 mode\n");
-			curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
-		}
-		else if(r_count == 2)
-		{
-			ParodusInfo("curl Ip resolve option set as V6 mode\n");
-			curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V6);
-		}
-		else
-		{
-			ParodusInfo("curl Ip resolve option set as default mode\n");
-			curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_WHATEVER);
-		}
-
-		/* set the cert for client authentication */
-		curl_easy_setopt(curl, CURLOPT_SSLCERT, get_parodus_cfg()->client_cert_path);
-
-		curl_easy_setopt(curl, CURLOPT_CAINFO, get_parodus_cfg()->cert_path);
-
-		/* disconnect if it is failed to validate server's cert */
-		curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 1L);
-
-		/* Perform the request, res will get the return code */
-		res = curl_easy_perform(curl);
-
-		curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &g_response_code);
-		ParodusInfo("themis curl response %d http_code %d\n", res, g_response_code);
-
-		time_res = curl_easy_getinfo(curl, CURLINFO_TOTAL_TIME, &total);
-		if(time_res == 0)
-		{
-			ParodusInfo("curl response Time: %.1f seconds\n", total);
-		}
-		curl_slist_free_all(headers_list);
-		if(res != 0)
-		{
-			ParodusError("curl_easy_perform() failed: %s\n", curl_easy_strerror(res));
-			curl_easy_cleanup(curl);
-			data.size = 0;
-			memset (data.data, 0, len);
-			return -1;
-		}
-		else
-		{
-			if(getGlobalResponseCode() == 200)
-			{
-				ParodusInfo("cURL success\n");
-			}
-			else
-			{
-				ParodusError("Failed response from auth token server %s\n", data.data);
-				curl_easy_cleanup(curl);
-				data.size = 0;
-				memset (data.data, 0, len);
-				return -1;
-			}
-		}
-		curl_easy_cleanup(curl);
-	}
-	else
-	{
-		ParodusError("curl init failure\n");
-		data.size = 0;
-		memset (data.data, 0, len);
-		return -1;
-	}
-
-	return 0;
-}
-
-/*
-* @brief Fetches authorization token and update to parodus config.
-  This will do curl retry in case of any failure till it reaches max curl retry count.
- * @param[in] cfg Global parodus config structure to update webpa_auth_token
-*/
-
-void getAuthToken(ParodusCfg *cfg)
-{
-	int status = -1;
-	int retry_count = 0;
-
-	memset (cfg->webpa_auth_token, 0, sizeof(cfg->webpa_auth_token));
-	if( cfg->hw_mac != NULL && strlen(cfg->hw_mac) !=0 )
-	{
-		if( cfg->client_cert_path !=NULL && strlen(cfg->client_cert_path) !=0 )
-		{
-			while(1)
-			{
-				//Fetch new auth token using libcurl
-				status = requestNewAuthToken(cfg->webpa_auth_token, sizeof(cfg->webpa_auth_token), retry_count);
-				if(status == 0)
-				{
-					ParodusInfo("cfg->webpa_auth_token created successfully\n");
-					break;
-				}
-				else
-				{
-					ParodusError("Failed to create new token\n");
-					retry_count++;
-					ParodusError("Curl execution is failed, retry attempt: %d\n", retry_count);
-				}
-
-				if(retry_count == MAX_CURL_RETRY_COUNT)
-				{
-					ParodusError("Curl retry is reached to max %d attempts, proceeding without token\n", retry_count);
-					break;
-				}
-			}
-		}
-		else
-		{
-			ParodusError("client_cert_path is NULL, failed to fetch auth token\n");
-		}
-	}
-	else
-	{
-		ParodusError("hw_mac is NULL, failed to fetch auth token\n");
-	}
-}
-
-/* @brief callback function for writing libcurl received data
- * @param[in] buffer curl delivered data which need to be saved.
- * @param[in] size size is always 1
- * @param[in] nmemb size of delivered data
- * @param[out] data curl response data saved.
-*/
-size_t write_callback_fn(void *buffer, size_t size, size_t nmemb, struct token_data *data)
-{
-    ParodusCfg *cfg;
-    size_t max_data_size = sizeof (cfg->webpa_auth_token);
-    size_t index = data->size;
-    size_t n = (size * nmemb);
-
-    data->size += n;
-
-    if (data->size >= max_data_size) {
-        ParodusError("Auth token data overruns buffer\n");
-	data->size = 0;
-        return 0;
-    }
-
-    memcpy((data->data + index), buffer, n);
-    data->data[data->size] = '\0';
-
-    return n;
-}
-
-/* @brief function to generate random uuid.
-*/
-char* generate_trans_uuid()
-{
-	char *transID = NULL;
-	uuid_t transaction_Id;
-	char *trans_id = NULL;
-	trans_id = (char *)malloc(37);
-	uuid_generate_random(transaction_Id);
-	uuid_unparse(transaction_Id, trans_id);
-
-	if(trans_id !=NULL)
-	{
-		transID = trans_id;
-	}
-	return transID;
-}
-
-/* @brief function to create curl header contains mac, serial number and uuid.
- * @param[in] h the auth headers to populate
- * @param[in] list temp curl header list
- * @param[out] header_list output curl header list
-*/
-void createCurlheader(struct curl_slist *list, struct curl_slist **header_list)
-{
-    char buf[MAX_BUF_SIZE];
-    char *uuid = NULL;
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Mac-Address: %s", get_parodus_cfg()->hw_mac);
-    ParodusPrint("mac_header formed %s\n", buf);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Serial-Number: %s", get_parodus_cfg()->hw_serial_number);
-    ParodusPrint("serial_header formed %s\n", buf);
-    list = curl_slist_append(list, buf);
-
-    uuid = generate_trans_uuid();
-    if(uuid !=NULL) {
-        snprintf(buf, MAX_BUF_SIZE, "X-Midt-Uuid: %s", uuid);
-        ParodusInfo("uuid_header formed %s\n", buf);
-        list = curl_slist_append(list, buf);
-        free(uuid);
-    } else {
-        ParodusError("Failed to generate transaction_uuid\n");
-    }
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Partner-Id: %s", get_parodus_cfg()->partner_id);
-    ParodusInfo("partnerid_header formed %s\n", buf);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Hardware-Model: %s", get_parodus_cfg()->hw_model);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Hardware-Manufacturer: %s", get_parodus_cfg()->hw_manufacturer);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Firmware-Name: %s", get_parodus_cfg()->fw_name);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Protocol: %s", get_parodus_cfg()->webpa_protocol);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Interface-Used: %s", getWebpaInterface());
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Last-Reboot-Reason: %s", get_parodus_cfg()->hw_last_reboot_reason);
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Last-Reconnect-Reason: %s", get_global_reconnect_reason());
-    list = curl_slist_append(list, buf);
-
-    snprintf(buf, MAX_BUF_SIZE, "X-Midt-Boot-Retry-Wait: %d", get_parodus_cfg()->boot_retry_wait);
-    list = curl_slist_append(list, buf);
-
-    *header_list = list;
-}

src/auth_token.h

@@ -1,57 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file auth_token.h
- *
- * @description This file is to fetch authorization token during parodus cloud connection.
- *
- */
- 
-#ifndef _AUTH_TOKEN_H_ 
-#define _AUTH_TOKEN_H_
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                               Data Structures                              */
-/*----------------------------------------------------------------------------*/
-
-struct token_data {
-    size_t size;
-    char* data;
-};
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-int requestNewAuthToken(char *newToken, size_t len, int r_count);
-void getAuthToken(ParodusCfg *cfg);
-size_t write_callback_fn(void *buffer, size_t size, size_t nmemb, struct token_data *data);
-char* generate_trans_uuid();
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif

src/client_list.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file client_list.h
  *
  * @description This file is used to manage registered clients
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
@@ -30,7 +15,6 @@
 /*----------------------------------------------------------------------------*/
 static int numOfClients = 0;
 static reg_list_item_t * g_head = NULL;
-pthread_mutex_t client_mut=PTHREAD_MUTEX_INITIALIZER;
 
 /*----------------------------------------------------------------------------*/
 /*                             External functions                             */
@@ -38,16 +22,9 @@ pthread_mutex_t client_mut=PTHREAD_MUTEX_INITIALIZER;
 
 reg_list_item_t * get_global_node(void)
 {
-    pthread_mutex_lock (&client_mut);
     return g_head;
 }
 
-void release_global_node (void)
-{
-    pthread_mutex_unlock (&client_mut);
-}
-
-
 int get_numOfClients()
 {
     return numOfClients;
@@ -60,12 +37,11 @@ int addToList( wrp_msg_t **msg)
     int rc = -1;
     int sock;
     int retStatus = -1;
-
     sock = nn_socket( AF_SP, NN_PUSH );
     ParodusPrint("sock created for adding entries to list: %d\n", sock);
     if(sock >= 0)
     {
-            int t = NANO_SOCKET_SEND_TIMEOUT_MS;
+            int t = NANOMSG_SOCKET_TIMEOUT_MSEC;
             rc = nn_setsockopt(sock, NN_SOL_SOCKET, NN_SNDTIMEO, &t, sizeof(t));
             if(rc < 0)
             {
@@ -76,11 +52,7 @@ int addToList( wrp_msg_t **msg)
             if(rc < 0)
             {
                 ParodusError ("Unable to connect socket (errno=%d, %s)\n",errno, strerror(errno));
-		if (nn_close (sock) < 0)
-                {
-                   ParodusError ("nn_close socket=%d (err=%d, %s)\n", 
-			sock, errno, strerror(errno));
-		}
+                nn_close (sock);
                 
             }
             else
@@ -91,15 +63,15 @@ int addToList( wrp_msg_t **msg)
 		{
     			memset( new_node, 0, sizeof( reg_list_item_t ) );
     			new_node->sock = sock;
-                        new_node->endpoint = rc;
     			ParodusPrint("new_node->sock is %d\n", new_node->sock);
     			
     			
 	                ParodusPrint("(*msg)->u.reg.service_name is %s\n", (*msg)->u.reg.service_name);
 	                ParodusPrint("(*msg)->u.reg.url is %s\n", (*msg)->u.reg.url);
 
-	                parStrncpy(new_node->service_name, (*msg)->u.reg.service_name, sizeof(new_node->service_name));
-	                parStrncpy(new_node->url, (*msg)->u.reg.url, sizeof(new_node->url));
+	                strncpy(new_node->service_name, (*msg)->u.reg.service_name, strlen((*msg)->u.reg.service_name)+1);
+	                strncpy(new_node->url, (*msg)->u.reg.url, strlen((*msg)->u.reg.url)+1);
+
 	                new_node->next=NULL;
 	                 
 	                if (g_head == NULL) //adding first client
@@ -224,21 +196,11 @@ int deleteFromList(char* service_name)
 			}
 			
 			ParodusPrint("Deleting the node\n");
-                        if(nn_shutdown(curr_node->sock, curr_node->endpoint) < 0)
-                        {
-                           ParodusError ("nn_shutdown socket=%d endpt=%d, err=%d\n", 
-				curr_node->sock, curr_node->endpoint, errno);
-                        }
-			if (nn_close (curr_node->sock) < 0)
-                        {
-                           ParodusError ("nn_close socket=%d err=%d\n", 
-				curr_node->sock, errno);
-                        }
 			free( curr_node );
 			curr_node = NULL;
 			ParodusInfo("Deleted successfully and returning..\n");
 			numOfClients =numOfClients - 1;
-			ParodusPrint("numOfClients after delete is %d\n", numOfClients);
+			ParodusPrint("numOfClients after delte is %d\n", numOfClients);
 			return 0;
 		}
 		
@@ -248,70 +210,3 @@ int deleteFromList(char* service_name)
 	ParodusError("Could not find the entry to delete from list\n");
 	return -1;
 }
-
-void deleteAllClients (void)
-{
-  reg_list_item_t *next_node = NULL;
-
-  while (NULL != g_head)
-  {
-    next_node = g_head->next;
-    free (g_head);
-    g_head = next_node;
-  }
-  if (numOfClients > 0) {
-    ParodusInfo ("Deleted %d clients\n", numOfClients);
-    numOfClients = 0;
-  }
-}
-
-/*
-*@dest : Client destination to send message
-*@Msg:	Msg to send it to client (No free done here), user responsibilites to free the msg
-*@msgSize : Total size of the msg to send to client
-*/
-int sendMsgtoRegisteredClients(char *dest,const char **Msg,size_t msgSize)
-{
-	int bytes =0;
-	reg_list_item_t *temp = NULL;
-	temp = get_global_node();
-	//Checking for individual clients & Sending msg to registered client
-	while (NULL != temp)
-	{
-		ParodusPrint("node is pointing to temp->service_name %s \n",temp->service_name);
-		// Sending message to registered clients
-		if( strcmp(dest, temp->service_name) == 0)
-		{
-			bytes = nn_send(temp->sock, *Msg, msgSize, 0);
-			release_global_node ();
-			ParodusInfo("sent downstream message to reg_client '%s'\n", temp->url);
-			ParodusPrint("downstream bytes sent:%d\n", bytes);
-			return 1;
-		}
-		ParodusPrint("checking the next item in the list\n");
-		temp= temp->next;
-	}
-	release_global_node ();
-	return 0;
-}
-
-//To check client registration status with parodus.
-int checkClientStatus(char *serviceName)
-{
-	reg_list_item_t *temp = NULL;
-	temp = get_global_node();
-	while (NULL != temp)
-	{
-		ParodusPrint("node is pointing to temp->service_name %s \n",temp->service_name);
-		// Sending message to registered clients
-		if( strcmp(serviceName, temp->service_name) == 0)
-		{
-			release_global_node ();
-			return 1;
-		}
-		ParodusPrint("checking the next item in the list\n");
-		temp= temp->next;
-	}
-	release_global_node ();
-	return 0;
-}

src/client_list.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file client_list.h
  *
  * @description This file is used to manage registered clients
  *
+ * Copyright (c) 2015  Comcast
  */
 #ifndef _CLIENTLIST_H_
 #define _CLIENTLIST_H_
@@ -30,7 +15,6 @@
 typedef struct reg_list_item
 {
 	int sock;
-	int endpoint;
 	char service_name[32];
 	char url[100];
 	struct reg_list_item *next;
@@ -51,12 +35,9 @@ int sendAuthStatus(reg_list_item_t *new_node);
 
 int deleteFromList(char* service_name);
 int get_numOfClients();
-void deleteAllClients (void);
-int sendMsgtoRegisteredClients(char *dest,const char **Msg,size_t msgSize);
 
 reg_list_item_t * get_global_node(void);
-void release_global_node (void);
-int checkClientStatus();
+
 #ifdef __cplusplus
 }
 #endif

src/close_retry.c

@@ -1,56 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file close_retry.c
- *
- * @description Functions required to manage connection close retry.
- *
- */
-
-#include "close_retry.h"
-
-bool close_retry = false;
-
-pthread_mutex_t close_mut=PTHREAD_MUTEX_INITIALIZER;
-
-// Get value of close_retry
-bool get_close_retry() 
-{
-	bool tmp = false;
-	pthread_mutex_lock (&close_mut);
-	tmp = close_retry;
-	pthread_mutex_unlock (&close_mut);
-	return tmp;
-}
-
-// Reset value of close_retry to false
-void reset_close_retry() 
-{
-	pthread_mutex_lock (&close_mut);
-	close_retry = false;
-	pthread_mutex_unlock (&close_mut);
-}
-
-// set value of close_retry to true
-void set_close_retry() 
-{
-	pthread_mutex_lock (&close_mut);
-    close_retry = true;
-    pthread_mutex_unlock (&close_mut);
-}
-
-

src/close_retry.h

@@ -1,47 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file close_retry.h
- *
- * @description Functions required to manage connection close retry.
- *
- */
-
-#ifndef _CLOSERETRY_H_
-#define _CLOSERETRY_H_
-
-#include <pthread.h>
-#include <stdbool.h>
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-// Get value of close_retry
-bool get_close_retry();
-
-// Reset value of close_retry to false
-void reset_close_retry();
-
-// Set value of close_retry to true
-void set_close_retry();
-
-#ifdef __cplusplus
-}
-#endif
-    
-#endif

src/config.c

@@ -1,62 +1,23 @@
 /**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file config.c
+ * @file config.h
  *
  * @description This file contains configuration details of parodus
  *
+ * Copyright (c) 2015  Comcast
  */
-
-#include <stdio.h>
-#include <fcntl.h> 
+ 
 #include "config.h"
 #include "ParodusInternal.h"
-#include <cjwt/cjwt.h>
-#include <stdlib.h>
-#include <curl/curl.h>
-#include <uuid/uuid.h>
 
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-pthread_mutex_t config_mut=PTHREAD_MUTEX_INITIALIZER;
 
-//For sending cond signal when cloud status is ONLINE
-pthread_mutex_t cloud_status_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t cloud_status_cond=PTHREAD_COND_INITIALIZER;
-
-char webpa_interface[64]={'\0'};
-
-char cloud_status[32]={'\0'};
 static ParodusCfg parodusCfg;
-static unsigned int rsa_algorithms = 
-	(1<<alg_rs256) | (1<<alg_rs384) | (1<<alg_rs512);
+
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
-pthread_cond_t *get_global_cloud_status_cond(void)
-{
-    return &cloud_status_cond;
-}
-
-pthread_mutex_t *get_global_cloud_status_mut(void)
-{
-    return &cloud_status_mut;
-}
 
 ParodusCfg *get_parodus_cfg(void) 
 {
@@ -65,390 +26,35 @@ ParodusCfg *get_parodus_cfg(void)
 
 void set_parodus_cfg(ParodusCfg *cfg) 
 {
-    memcpy(&parodusCfg, cfg, sizeof(ParodusCfg));
+    parodusCfg = *cfg;
 }
 
-void set_cloud_disconnect_reason(ParodusCfg *cfg, char *disconn_reason)
+void parseCommandLine(int argc,char **argv,ParodusCfg * cfg)
 {
-    cfg->cloud_disconnect = strdup(disconn_reason);
-}
-
-void reset_cloud_disconnect_reason(ParodusCfg *cfg)
-{
-	cfg->cloud_disconnect = NULL;
-}
-
-void set_cloud_status(char *status)
-{
-    if(status != NULL)
-    {
-        pthread_mutex_lock(&config_mut);
-        get_parodus_cfg()->cloud_status = status;
-        if(strcmp (status, CLOUD_STATUS_ONLINE) == 0)
-        {
-              pthread_cond_signal(&cloud_status_cond);
-        }
-        pthread_mutex_unlock(&config_mut);
-    }
-}
-
-char *get_cloud_status(void)
-{
-    pthread_mutex_lock(&config_mut);
-    parStrncpy(cloud_status, get_parodus_cfg()->cloud_status, sizeof(cloud_status));
-    pthread_mutex_unlock(&config_mut);	
-    return cloud_status;
-}
-
-const char *get_tok (const char *src, int delim, char *result, int resultsize)
-{
-	int i;
-	char c;
-	int endx = resultsize-1;
-
-	memset (result, 0, resultsize);
-	for (i=0; (c=src[i]) != 0; i++) {
-		if (c == delim)
-			break;
- 		if (i < endx)
-			result[i] = c;
-	}
-	if (c == 0)
-		return NULL;
-	return src + i + 1;
-}
-
-// the algorithm mask indicates which algorithms are allowed
-unsigned int get_algo_mask (const char *algo_str)
-{
-  unsigned int mask = 0;
-  unsigned int mask_val;
-#define BUFLEN 16
-  char tok[BUFLEN];
-	int alg_val;
-
-	while(NULL != algo_str)
-	{
-		algo_str = get_tok (algo_str, ':', tok, BUFLEN);
-		alg_val = cjwt_alg_str_to_enum (tok);
-		if ((alg_val < 0)  || (alg_val >= num_algorithms)) {
-       ParodusError("Invalid jwt algorithm %s\n", tok);
-       return (unsigned int) (-1);
-		}
-		if (alg_val == alg_none) {
-       ParodusError("Disallowed jwt algorithm none\n");
-       return (unsigned int) (-1);
-		}
-		mask_val = (1<<alg_val);
-#if !ALLOW_NON_RSA_ALG
-		if (0 == (mask_val & rsa_algorithms)) {
-       ParodusError("Disallowed non-rsa jwt algorithm %s\n", tok);
-       return (unsigned int) (-1);
-		}
-#endif
-		mask |= mask_val;
-		
-	}
-	return mask;
-#undef BUFLEN
-}
-
-static int open_input_file (const char *fname)
-{
-  int fd = open(fname, O_RDONLY);
-  if (fd<0)
-  {
-    ParodusError ("File %s open error\n", fname);
-    abort ();
-  }
-  return fd;
-} 
-
-void read_key_from_file (const char *fname, char *buf, size_t buflen)
-{
-  ssize_t nbytes;
-  int fd = open_input_file(fname);
-  nbytes = read(fd, buf, buflen);
-  if (nbytes < 0)
-  {
-    ParodusError ("Read file %s error\n", fname);
-    close(fd);
-    abort ();
-  }
-  close(fd);
-  ParodusInfo ("%d bytes read\n", nbytes);
-}
-
-// strips ':' characters
-// verifies that there exactly 12 characters
-int parse_mac_address (char *target, const char *arg)
-{
-	int count = 0;
-	int i, j;
-	char c;
-	char *mac = target;
-	for (i=0; (c=arg[i]) != 0; i++) {
-		if (c !=':')
-			count++;
-	}
-	if (count != 12)
-		return -1;			// bad mac address
-	for (i=0; (c=arg[i]) != 0; i++) {
-		if (c != ':')
-			*(target++) = c;
-	}
-	*target = 0;	// terminating null
-
-	//convert mac to lowercase
-	for(j = 0; mac[j]; j++)
-	{
-		mac[j] = tolower(mac[j]);
-	}
-	ParodusPrint("mac in lowercase is %s\n", mac);
-	return 0;
-}
-
-int server_is_http (const char *full_url,
-	const char **server_ptr)
-{
-	int http_match;
-	const char *ptr;
-	
-	if (strncmp(full_url, "https://", 8) == 0) {
-		http_match = 0;
-		ptr = full_url + 8;
-	} else if (strncmp(full_url, "http://", 7) == 0) {
-		http_match = 1;
-		ptr = full_url + 7;	
-	} else {
-		ParodusError ("Invalid url %s\n", full_url);
-		return -1;
-	}
-	if (NULL != server_ptr)
-		*server_ptr = ptr;
-	return http_match;
-}
-	
-	
-int parse_webpa_url__ (const char *full_url, 
-	char *server_addr, int server_addr_buflen,
-	char *port_buf, int port_buflen)
-{
-	const char *server_ptr;
-	char *port_val;
-	char *end_port;
-	size_t server_len;
-	int http_match;
-	char *closeBracket = NULL;
-	char *openBracket = NULL;
-	char *checkPort = NULL;
-
-	ParodusInfo ("full url: %s\n", full_url);
-	http_match = server_is_http (full_url, &server_ptr);
-	if (http_match < 0)
-		return http_match;
-
-	ParodusInfo ("server address copied from url\n");
-	parStrncpy (server_addr, server_ptr, server_addr_buflen);
-	server_len = strlen(server_addr);
-	// If there's a '/' on end, null it out
-	if ((server_len>0) && (server_addr[server_len-1] == '/'))
-		server_addr[server_len-1] = '\0';
-
-    openBracket = strchr(server_addr,'[');
-    if(openBracket != NULL){
-        //Remove [ from server address
-        char *remove = server_addr;
-        int i;
-
-        // Strings can overlap, so don't use strncpy()
-        remove++;
-        for( i = 0; i < server_addr_buflen; i++ ) {
-            server_addr[i] = remove[i];
-        }
-        closeBracket = strchr(server_addr,']');
-        if(closeBracket != NULL){
-            //Remove ] by making it as null
-            *closeBracket = '\0';
-            closeBracket++;
-            checkPort = strchr(closeBracket,':');
-            if (NULL == checkPort) {
-                if (http_match)
-                    parStrncpy (port_buf, "80", port_buflen);
-                else
-                    parStrncpy (port_buf, "443", port_buflen);
-            } else {
-                checkPort++;
-                end_port = strchr (checkPort, '/');
-                if (NULL != end_port)
-                    *end_port = '\0'; // terminate port with null
-                parStrncpy (port_buf, checkPort, port_buflen);
-            }
-
-        }else{
-            ParodusError("Invalid url %s\n", full_url);
-            return -1;
-        }
-    }else if (strchr(server_addr,']') != NULL ){
-		ParodusError("Invalid url %s\n", full_url);
-		return -1;
-	}else{
-	// Look for ':'
-	port_val = strchr (server_addr, ':');
-
-	if (NULL == port_val) {
-		if (http_match)
-			parStrncpy (port_buf, "80", port_buflen);
-		else
-			parStrncpy (port_buf, "443", port_buflen);
-		end_port = strchr (server_addr, '/');
-		if (NULL != end_port) {
-			*end_port = '\0'; // terminate server address with null
-		}
-
-	} else {
-		*port_val = '\0'; // terminate server address with null
-		port_val++;
-		end_port = strchr (port_val, '/');
-		if (NULL != end_port)
-			*end_port = '\0'; // terminate port with null
-		parStrncpy (port_buf, port_val, port_buflen);
-	}
-    }
-	ParodusInfo ("server %s, port %s, http_match %d\n", 
-		server_addr, port_buf, http_match);
-	return http_match;
-
-}
-
-unsigned int parse_num_arg (const char *arg, const char *arg_name)
-{
-	unsigned int result = 0;
-	int i;
-	char c;
-	
-	if (arg[0] == '\0') {
-		ParodusError ("Empty %s argument\n", arg_name);
-		return (unsigned int) -1;
-	}
-	for (i=0; '\0' != (c=arg[i]); i++)
-	{
-		if ((c<'0') || (c>'9')) {
-			ParodusError ("Non-numeric %s argument\n", arg_name);
-			return (unsigned int) -1;
-		}
-		result = (result*10) + c - '0';
-	}
-	return result;
-}
-
-int parse_webpa_url (const char *full_url, 
-	char **server_addr, unsigned int *port)
-{
-  int allow_insecure;
-  unsigned int port_val;
-  int buflen = strlen (full_url) + 1;
-  char *url_buf = NULL;
-  char port_buf[8];
-
-#define ERROR__(msg) \
-  ParodusError (msg); \
-  if (NULL != url_buf) \
-    free (url_buf);
-
-  *server_addr = NULL;
-     
-  url_buf = (char *) malloc (buflen);
-  if (NULL == url_buf) {
-    ERROR__ ("parse_webpa_url allocatio n failed.\n")
-    return -1;
-  }
-  allow_insecure = parse_webpa_url__ (full_url,
-	url_buf, buflen, port_buf, 8);
-  if (allow_insecure < 0) {
-    ERROR__ ("parse_webpa_url invalid url\n")
-    return -1;
-  }
-  port_val = parse_num_arg (port_buf, "server port");
-  if (port_val == (unsigned int) -1) {
-    ERROR__ ("Invalid port in server url")
-    return -1;
-  }
-  if ((port_val == 0) || (port_val > 65535)) {
-    ERROR__ ("port value out of range in server url")
-    return -1;
-  }
-  *server_addr = url_buf;
-  *port = port_val;	
-  return allow_insecure;
-#undef ERROR__
-}
-
-
-int parseCommandLine(int argc,char **argv,ParodusCfg * cfg)
-{
-    static const struct option long_options[] = {
-        {"hw-model",                required_argument, 0, 'm'},
-        {"hw-serial-number",        required_argument, 0, 's'},
-        {"hw-manufacturer",         required_argument, 0, 'f'},
-        {"hw-mac",                  required_argument, 0, 'd'},
-        {"hw-last-reboot-reason",   required_argument, 0, 'r'},
-        {"fw-name",                 required_argument, 0, 'n'},
-        {"boot-time",               required_argument, 0, 'b'},
-        {"webpa-url",               required_argument, 0, 'u'},
-        {"webpa-ping-timeout",      required_argument, 0, 't'},
-        {"webpa-backoff-max",       required_argument, 0, 'o'},
-        {"webpa-interface-used",    required_argument, 0, 'i'},
-        {"parodus-local-url",       required_argument, 0, 'l'},
-        {"partner-id",              required_argument, 0, 'p'},
-#ifdef ENABLE_SESHAT
-        {"seshat-url",              required_argument, 0, 'e'},
-#endif
-        {"dns-txt-url",             required_argument, 0, 'D'},
-        {"acquire-jwt",				required_argument, 0, 'j'},
-        {"jwt-algo",                required_argument, 0, 'a'},
-        {"jwt-public-key-file",     required_argument, 0, 'k'},
-        {"ssl-cert-path",           required_argument, 0, 'c'},
-        {"force-ipv4",              no_argument,       0, '4'},
-        {"force-ipv6",              no_argument,       0, '6'},
-        {"boot-time-retry-wait",    required_argument, 0, 'w'},
-	{"client-cert-path",        required_argument, 0, 'P'},
-	{"token-server-url",        required_argument, 0, 'U'},
-	{"crud-config-file",        required_argument, 0, 'C'},
-	{"connection-health-file",  required_argument, 0, 'S'},
-	{"close-reason-file",  		required_argument, 0, 'R'},
-	{"mtls-client-key-path",    required_argument, 0, 'K'},
-	{"mtls-client-cert-path",    required_argument, 0,'M'},
-        {0, 0, 0, 0}
-    };
     int c;
-    ParodusInfo("Parsing parodus command line arguments..\n");
 
-	if (NULL == cfg) {
-		ParodusError ("NULL cfg structure\n");
-		return -1;
-	} 
-	cfg->flags = 0;
-	parStrncpy (cfg->webpa_url, "", sizeof(cfg->webpa_url));
-	cfg->acquire_jwt = 0;
-	cfg->jwt_algo = 0;
-	parStrncpy (cfg->jwt_key, "", sizeof(cfg->jwt_key));
-	cfg->crud_config_file = NULL;
-	cfg->connection_health_file = NULL;
-	cfg->close_reason_file = NULL;
-	cfg->client_cert_path = NULL;
-	cfg->token_server_url = NULL;
-	cfg->cloud_status = NULL;
-	cfg->cloud_disconnect = NULL;
-	optind = 1;  /* We need this if parseCommandLine is called again */
     while (1)
     {
-
+      static struct option long_options[] = {
+          {"hw-model",     required_argument,   0, 'm'},
+          {"hw-serial-number",  required_argument,  0, 's'},
+          {"hw-manufacturer",  required_argument, 0, 'f'},
+          {"hw-mac",  required_argument, 0, 'd'},
+          {"hw-last-reboot-reason",  required_argument, 0, 'r'},
+          {"fw-name",  required_argument, 0, 'n'},
+          {"boot-time",  required_argument, 0, 'b'},
+          {"webpa-url",  required_argument, 0, 'u'},
+          {"webpa-ping-timeout",    required_argument, 0, 't'},
+          {"webpa-backoff-max",  required_argument, 0, 'o'},
+          {"webpa-inteface-used",    required_argument, 0, 'i'},
+          {"parodus-local-url",  required_argument, 0, 'l'},
+          {"partner-id",  required_argument, 0, 'p'},
+	  {"seshat-url", required_argument, 0, 'e'},
+          {0, 0, 0, 0}
+        };
       /* getopt_long stores the option index here. */
       int option_index = 0;
-      c = getopt_long (argc, argv, 
-			"m:s:f:d:r:n:b:u:t:o:i:l:p:e:D:j:a:k:c:T:w:J:46:C:S:R:K:M",
-			long_options, &option_index);
+      c = getopt_long (argc, argv, "m:s:f:d:r:n:b:u:t:o:i:l:p:e:",long_options, &option_index);
 
       /* Detect the end of the options. */
       if (c == -1)
@@ -472,23 +78,18 @@ int parseCommandLine(int argc,char **argv,ParodusCfg * cfg)
           break;
 
         case 'd':
-					if (parse_mac_address (cfg->hw_mac, optarg) == 0) {
-            ParodusInfo ("hw_mac is %s\n",cfg->hw_mac);
-					} else {
-						ParodusError ("Bad mac address %s\n", optarg);
-						return -1;
-					}
+           parStrncpy(cfg->hw_mac, optarg,sizeof(cfg->hw_mac));
+           ParodusInfo("hw_mac is %s\n",cfg->hw_mac);
           break;
-#ifdef ENABLE_SESHAT
+
          case 'e':
            parStrncpy(cfg->seshat_url, optarg,sizeof(cfg->seshat_url));
            ParodusInfo("seshat_url is %s\n",cfg->seshat_url);
           break;
-#endif
+ 
         case 'r':
           parStrncpy(cfg->hw_last_reboot_reason, optarg,sizeof(cfg->hw_last_reboot_reason));
           ParodusInfo("hw_last_reboot_reason is %s\n",cfg->hw_last_reboot_reason);
-          OnboardLog("Last reboot reason is %s\n",cfg->hw_last_reboot_reason);
           break;
 
         case 'n':
@@ -497,158 +98,50 @@ int parseCommandLine(int argc,char **argv,ParodusCfg * cfg)
           break;
 
         case 'b':
-          cfg->boot_time = parse_num_arg (optarg, "boot-time");
+          cfg->boot_time = atoi(optarg);
           ParodusInfo("boot_time is %d\n",cfg->boot_time);
           break;
        
          case 'u':
-			parStrncpy(cfg->webpa_url, optarg,sizeof(cfg->webpa_url));
-			if (server_is_http (cfg->webpa_url, NULL) < 0) {
-				ParodusError ("Bad webpa url %s\n", optarg);
-				return -1;
-			}
+          parStrncpy(cfg->webpa_url, optarg,sizeof(cfg->webpa_url));
           ParodusInfo("webpa_url is %s\n",cfg->webpa_url);
           break;
         
         case 't':
-          cfg->webpa_ping_timeout = parse_num_arg (optarg, "webpa-ping-timeout");
-          if (cfg->webpa_ping_timeout == (unsigned int) -1)
-			return -1;
+          cfg->webpa_ping_timeout = atoi(optarg);
           ParodusInfo("webpa_ping_timeout is %d\n",cfg->webpa_ping_timeout);
           break;
 
         case 'o':
-          cfg->webpa_backoff_max = parse_num_arg (optarg, "webpa-backoff-max");
-          if (cfg->webpa_backoff_max == (unsigned int) -1)
-			return -1;
+          cfg->webpa_backoff_max = atoi(optarg);
           ParodusInfo("webpa_backoff_max is %d\n",cfg->webpa_backoff_max);
           break;
 
         case 'i':
           parStrncpy(cfg->webpa_interface_used, optarg,sizeof(cfg->webpa_interface_used));
-          ParodusInfo("webpa_interface_used is %s\n",cfg->webpa_interface_used);
+          ParodusInfo("webpa_inteface_used is %s\n",cfg->webpa_interface_used);
           break;
           
         case 'l':
           parStrncpy(cfg->local_url, optarg,sizeof(cfg->local_url));
           ParodusInfo("parodus local_url is %s\n",cfg->local_url);
-          break;
-        case 'D':
-          // like 'fabric' or 'test'
-          // this parameter is used, along with the hw_mac parameter
-          // to create the dns txt record id
-          parStrncpy(cfg->dns_txt_url, optarg,sizeof(cfg->dns_txt_url));
-          ParodusInfo("parodus dns-txt-url is %s\n",cfg->dns_txt_url);
-          break;
-		 
-        case 'j':
-          cfg->acquire_jwt = parse_num_arg (optarg, "acquire-jwt");
-          if (cfg->acquire_jwt == (unsigned int) -1)
-			return -1;
-          ParodusInfo("acquire jwt option is %d\n",cfg->acquire_jwt);
           break;
 
-		case 'a':
-			// the command line argument is a list of allowed algoritms,
-			// separated by colons, like "RS256:RS512:none"
-			cfg->jwt_algo = get_algo_mask (optarg);
-			if (cfg->jwt_algo == (unsigned int) -1) {
-			  return -1;
-			}
-          ParodusInfo("jwt_algo is %u\n",cfg->jwt_algo);
-          break;
-		case 'k':
-          read_key_from_file (optarg, cfg->jwt_key, sizeof(cfg->jwt_key));
-          ParodusInfo("jwt_key is %s\n",cfg->jwt_key);
-          break;
         case 'p':
           parStrncpy(cfg->partner_id, optarg,sizeof(cfg->partner_id));
           ParodusInfo("partner_id is %s\n",cfg->partner_id);
           break;
 
-        case 'c':
-          parStrncpy(cfg->cert_path, optarg,sizeof(cfg->cert_path));
-          ParodusInfo("cert_path is %s\n",cfg->cert_path);
-          break;
-
-        case '4':
-          ParodusInfo("Force IPv4\n");
-          cfg->flags |= FLAGS_IPV4_ONLY;
-          break;
-
-        case '6':
-          ParodusInfo("Force IPv6\n");
-          cfg->flags |= FLAGS_IPV6_ONLY;
-          break;
-
-        case 'w':
-          cfg->boot_retry_wait = parse_num_arg (optarg, "boot-time-retry-wait");
-          ParodusInfo("boot_retry_wait is %d\n",cfg->boot_retry_wait);
-          break;
-
-	case 'S':
-	  cfg->connection_health_file = strdup(optarg);
-	  ParodusInfo("connection_health_file is %s\n", cfg->connection_health_file);
-	  break;
-
-	case 'R':
-	  cfg->close_reason_file = strdup(optarg);
-	  ParodusInfo("sigterm_close_reason_file is %s\n", cfg->close_reason_file);
-	  break;
-
-	case 'C':
-	  cfg->crud_config_file = strdup(optarg);
-	  ParodusInfo("crud_config_file is %s\n", cfg->crud_config_file);
-	  break;
-
-	case 'P':
-		cfg->client_cert_path = strdup(optarg);
-		ParodusInfo("client_cert_path is %s\n", cfg->client_cert_path);
-		break;
-
-	case 'U':
-		cfg->token_server_url = strdup(optarg);
-		ParodusInfo("token_server_url is %s\n", cfg->token_server_url);
-		break;
-
-        case 'K':
-          cfg->mtls_client_key_path = strdup(optarg);
-          ParodusInfo("mtls_client_key_path is %s\n", cfg->mtls_client_key_path);
-          break;
-
-	case 'M':
-          cfg->mtls_client_cert_path = strdup(optarg);
-          ParodusInfo("mtls_client_cert_path is %s\n", cfg->mtls_client_cert_path);
-          break;
-
         case '?':
           /* getopt_long already printed an error message. */
           break;
 
         default:
            ParodusError("Enter Valid commands..\n");
-		   return -1;
+          abort ();
         }
     }
 
-	if (0 == strlen (cfg->webpa_url)) {
-		ParodusError ("Missing webpa url argument\n");
-		return -1;
-	}
-
-    if (cfg->acquire_jwt) {
-		if (0 == cfg->jwt_algo) {
-			ParodusError ("Missing jwt algorithm argument\n");
-			return -1;
-		}
-		if ((0 != (cfg->jwt_algo & rsa_algorithms)) &&
-		    (0 == strlen (cfg->jwt_key)) ) {
-			ParodusError ("Missing jwt public key file argument\n");
-			return -1;
-		}
-		    
-	}
-	
     ParodusPrint("argc is :%d\n", argc);
     ParodusPrint("optind is :%d\n", optind);
 
@@ -660,47 +153,6 @@ int parseCommandLine(int argc,char **argv,ParodusCfg * cfg)
         ParodusPrint ("%s ", argv[optind++]);
       putchar ('\n');
     }
-    return 0;
-}
-
-void setDefaultValuesToCfg(ParodusCfg *cfg)
-{
-    if(cfg == NULL)
-    {
-        ParodusError("cfg is NULL\n");
-        return;
-    }
-    
-    ParodusInfo("Setting default values to parodusCfg\n");
-    parStrncpy(cfg->local_url, PARODUS_UPSTREAM, sizeof(cfg->local_url));
-
-	cfg->acquire_jwt = 0;
-
-    parStrncpy(cfg->dns_txt_url, DNS_TXT_URL, sizeof(cfg->dns_txt_url));
-
-    parStrncpy(cfg->jwt_key, "\0", sizeof(cfg->jwt_key));
-    
-    cfg->jwt_algo = 0;
-   
-    parStrncpy(cfg->cert_path, "\0", sizeof(cfg->cert_path));
-
-    cfg->flags = 0;
-    
-    parStrncpy(cfg->webpa_path_url, WEBPA_PATH_URL,sizeof(cfg->webpa_path_url));
-    
-    snprintf(cfg->webpa_protocol, sizeof(cfg->webpa_protocol), "%s-%s", PROTOCOL_VALUE, GIT_COMMIT_TAG);
-    ParodusInfo(" cfg->webpa_protocol is %s\n", cfg->webpa_protocol);
-    
-    parStrncpy(cfg->webpa_uuid, "1234567-345456546",sizeof(cfg->webpa_uuid));
-    ParodusPrint("cfg->webpa_uuid is :%s\n", cfg->webpa_uuid);
-    cfg->crud_config_file = NULL;
-    cfg->connection_health_file = NULL;
-    cfg->close_reason_file = NULL;
-    cfg->client_cert_path = NULL;
-    cfg->token_server_url = NULL;
-	
-	cfg->cloud_status = CLOUD_STATUS_OFFLINE;
-	ParodusInfo("Default cloud_status is %s\n", cfg->cloud_status);
 }
 
 void loadParodusCfg(ParodusCfg * config,ParodusCfg *cfg)
@@ -711,208 +163,99 @@ void loadParodusCfg(ParodusCfg * config,ParodusCfg *cfg)
         return;
     }
     
-    if(strlen (config->hw_model) !=0)
+    ParodusCfg *pConfig =config;
+    
+    if(strlen (pConfig->hw_model) !=0)
     {
-          parStrncpy(cfg->hw_model, config->hw_model, sizeof(cfg->hw_model));
+        strncpy(cfg->hw_model, pConfig->hw_model,strlen(pConfig->hw_model)+1);
     }
     else
     {
         ParodusPrint("hw_model is NULL. read from tmp file\n");
     }
-    if( strlen(config->hw_serial_number) !=0)
+    if( strlen(pConfig->hw_serial_number) !=0)
     {
-        parStrncpy(cfg->hw_serial_number, config->hw_serial_number, sizeof(cfg->hw_serial_number));
+        strncpy(cfg->hw_serial_number, pConfig->hw_serial_number,strlen(pConfig->hw_serial_number)+1);
     }
     else
     {
         ParodusPrint("hw_serial_number is NULL. read from tmp file\n");
     }
-    if(strlen(config->hw_manufacturer) !=0)
+    if(strlen(pConfig->hw_manufacturer) !=0)
     {
-        parStrncpy(cfg->hw_manufacturer, config->hw_manufacturer,sizeof(cfg->hw_manufacturer));
+        strncpy(cfg->hw_manufacturer, pConfig->hw_manufacturer,strlen(pConfig->hw_manufacturer)+1);
     }
     else
     {
         ParodusPrint("hw_manufacturer is NULL. read from tmp file\n");
     }
-    if(strlen(config->hw_mac) !=0)
+    if(strlen(pConfig->hw_mac) !=0)
     {
-       parStrncpy(cfg->hw_mac, config->hw_mac,sizeof(cfg->hw_mac));
+       strncpy(cfg->hw_mac, pConfig->hw_mac,strlen(pConfig->hw_mac)+1);
     }
     else
     {
         ParodusPrint("hw_mac is NULL. read from tmp file\n");
     }
-    if(strlen (config->hw_last_reboot_reason) !=0)
+    if(strlen (pConfig->hw_last_reboot_reason) !=0)
     {
-         parStrncpy(cfg->hw_last_reboot_reason, config->hw_last_reboot_reason,sizeof(cfg->hw_last_reboot_reason));
+         strncpy(cfg->hw_last_reboot_reason, pConfig->hw_last_reboot_reason,strlen(pConfig->hw_last_reboot_reason)+1);
     }
     else
     {
         ParodusPrint("hw_last_reboot_reason is NULL. read from tmp file\n");
     }
-    if(strlen(config->fw_name) !=0)
+    if(strlen(pConfig->fw_name) !=0)
     {   
-        parStrncpy(cfg->fw_name, config->fw_name,sizeof(cfg->fw_name));
+        strncpy(cfg->fw_name, pConfig->fw_name,strlen(pConfig->fw_name)+1);
     }
     else
     {
         ParodusPrint("fw_name is NULL. read from tmp file\n");
     }
-    if( strlen(config->webpa_url) !=0)
+    if( strlen(pConfig->webpa_url) !=0)
     {
-        parStrncpy(cfg->webpa_url, config->webpa_url,sizeof(cfg->webpa_url));
+        strncpy(cfg->webpa_url, pConfig->webpa_url,strlen(pConfig->webpa_url)+1);
     }
     else
     {
         ParodusPrint("webpa_url is NULL. read from tmp file\n");
     }
-    if(strlen(config->webpa_interface_used )!=0)
+    if(strlen(pConfig->webpa_interface_used )!=0)
     {
-        parStrncpy(getWebpaInterface(), config->webpa_interface_used,sizeof(getWebpaInterface()));
+        strncpy(cfg->webpa_interface_used, pConfig->webpa_interface_used,strlen(pConfig->webpa_interface_used)+1);
     }
     else
     {
         ParodusPrint("webpa_interface_used is NULL. read from tmp file\n");
     }
-    if( strlen(config->local_url) !=0)
+    if( strlen(pConfig->local_url) !=0)
     {
-        parStrncpy(cfg->local_url, config->local_url,sizeof(cfg->local_url));
+        strncpy(cfg->local_url, pConfig->local_url,strlen(pConfig->local_url)+1);
     }
     else
     {
 		ParodusInfo("parodus local_url is NULL. adding default url\n");
-		parStrncpy(cfg->local_url, PARODUS_UPSTREAM, sizeof(cfg->local_url));
+		strncpy(cfg->local_url, PARODUS_UPSTREAM, strlen(PARODUS_UPSTREAM)+1);
         
     }
 
-    if( strlen(config->partner_id) !=0)
+    if( strlen(pConfig->partner_id) !=0)
     {
-        parStrncpy(cfg->partner_id, config->partner_id,sizeof(cfg->partner_id));
+        strncpy(cfg->partner_id, pConfig->partner_id,strlen(pConfig->partner_id)+1);
     }
     else
     {
 		ParodusPrint("partner_id is NULL. read from tmp file\n");
     }
-#ifdef ENABLE_SESHAT
-    if( strlen(config->seshat_url) !=0)
-    {
-        parStrncpy(cfg->seshat_url, config->seshat_url,sizeof(cfg->seshat_url));
-    }
-    else
-    {
-        ParodusInfo("seshat_url is NULL. Read from tmp file\n");
-    }
-#endif
-	cfg->acquire_jwt = config->acquire_jwt;
-
-     if( strlen(config->dns_txt_url) !=0)
-    {
-        parStrncpy(cfg->dns_txt_url, config->dns_txt_url, sizeof(cfg->dns_txt_url));
-    }
-    else
-    {
-	ParodusInfo("parodus dns-txt-url is NULL. adding default\n");
-	parStrncpy(cfg->dns_txt_url, DNS_TXT_URL, sizeof(cfg->dns_txt_url));
-    }
-
-    if(strlen(config->jwt_key )!=0)
-    {
-        parStrncpy(cfg->jwt_key, config->jwt_key,sizeof(cfg->jwt_key));
-    }
-    else
-    {
-        parStrncpy(cfg->jwt_key, "\0", sizeof(cfg->jwt_key));
-        ParodusPrint("jwt_key is NULL. set to empty\n");
-    }
-
-	cfg->jwt_algo = config->jwt_algo;        
-
-    if(strlen(config->cert_path )!=0)
-    {
-        parStrncpy(cfg->cert_path, config->cert_path,sizeof(cfg->cert_path));
-    }
-    else
-    {
-        parStrncpy(cfg->cert_path, "\0", sizeof(cfg->cert_path));
-        ParodusPrint("cert_path is NULL. set to empty\n");
-    }
-
-    cfg->boot_time = config->boot_time;
-    cfg->webpa_ping_timeout = config->webpa_ping_timeout;
-    cfg->webpa_backoff_max = config->webpa_backoff_max;
-    parStrncpy(cfg->webpa_path_url, WEBPA_PATH_URL,sizeof(cfg->webpa_path_url));
-    snprintf(cfg->webpa_protocol, sizeof(cfg->webpa_protocol), "%s-%s", PROTOCOL_VALUE, GIT_COMMIT_TAG);
-    ParodusInfo("cfg->webpa_protocol is %s\n", cfg->webpa_protocol);
-    parStrncpy(cfg->webpa_uuid, "1234567-345456546",sizeof(cfg->webpa_uuid));
+        
+    cfg->boot_time = pConfig->boot_time;
+    cfg->secureFlag = 1;
+    cfg->webpa_ping_timeout = pConfig->webpa_ping_timeout;
+    cfg->webpa_backoff_max = pConfig->webpa_backoff_max;
+    strncpy(cfg->webpa_path_url, WEBPA_PATH_URL, strlen(WEBPA_PATH_URL)+1);
+    strncpy(cfg->webpa_protocol, WEBPA_PROTOCOL_VALUE, strlen(WEBPA_PROTOCOL_VALUE)+1);
+    strncpy(cfg->webpa_uuid, "1234567-345456546", strlen("1234567-345456546")+1);
     ParodusPrint("cfg->webpa_uuid is :%s\n", cfg->webpa_uuid);
     
-    if(config->connection_health_file != NULL)
-    {
-        cfg->connection_health_file = strdup(config->connection_health_file);
-    }
-    else
-    {
-        ParodusPrint("connection_health_file is NULL. set to empty\n");
-    }
-
-    if(config->close_reason_file != NULL)
-    {
-        cfg->close_reason_file = strdup(config->close_reason_file);
-    }
-    else
-    {
-        ParodusPrint("close_reason_file is NULL. set to empty\n");
-    }
-
-    if(config->crud_config_file != NULL)
-    {
-        cfg->crud_config_file = strdup(config->crud_config_file);
-    }
-    else
-    {
-        ParodusPrint("crud_config_file is NULL. set to empty\n");
-    }
-
-    if(config->client_cert_path != NULL)
-    {
-        cfg->client_cert_path = strdup(config->client_cert_path);
-    }
-    else
-    {
-        ParodusPrint("client_cert_path is NULL. set to empty\n");
-    }
-
-    if(config->token_server_url != NULL)
-    {
-        cfg->token_server_url = strdup(config->token_server_url);
-    }
-    else
-    {
-        ParodusPrint("token_server_url is NULL. set to empty\n");
-    }
 }
-
-#ifdef WAN_FAILOVER_SUPPORTED
-void setWebpaInterface(char *value)
-{
-	pthread_mutex_lock (&config_mut);
-	parStrncpy(get_parodus_cfg()->webpa_interface_used, value, sizeof(get_parodus_cfg()->webpa_interface_used));
-	pthread_mutex_unlock (&config_mut);
-}
-#endif
-
-char *getWebpaInterface(void)
-{
-	#ifdef WAN_FAILOVER_SUPPORTED	
-		ParodusPrint("WAN_FAILOVER_SUPPORTED mode \n");
-		pthread_mutex_lock (&config_mut);	
-		parStrncpy(webpa_interface, get_parodus_cfg()->webpa_interface_used, sizeof(webpa_interface));
-		pthread_mutex_unlock (&config_mut);
-	#else
-		parStrncpy(webpa_interface, get_parodus_cfg()->webpa_interface_used, sizeof(webpa_interface));
-	#endif
-		ParodusPrint("webpa_interface:%s\n", webpa_interface);
-		return webpa_interface;
-}
-

src/config.h

@@ -1,30 +1,14 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file config.h
  *
  * @description This file contains configuration details of parodus
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _CONFIG_H_ 
 #define _CONFIG_H_
 
-#include <pthread.h>
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -34,37 +18,25 @@ extern "C" {
 /*----------------------------------------------------------------------------*/
 
 /* WRP CRUD Model Macros */
-#define HW_MODELNAME            "hw-model"
-#define HW_SERIALNUMBER         "hw-serial-number"
-#define HW_MANUFACTURER         "hw-manufacturer"
-#define HW_DEVICEMAC            "hw-mac"
-#define HW_LAST_REBOOT_REASON   "hw-last-reboot-reason"
-#define FIRMWARE_NAME           "fw-name"
-#define BOOT_TIME               "boot-time"
-#define LAST_RECONNECT_REASON   "webpa-last-reconnect-reason"
-#define WEBPA_PROTOCOL          "webpa-protocol"
-#define WEBPA_INTERFACE         "webpa-interface-used"
-#define WEBPA_UUID              "webpa-uuid"
-#define WEBPA_URL               "webpa-url"
-#define WEBPA_PING_TIMEOUT      "webpa-ping-timeout"
-#define WEBPA_BACKOFF_MAX       "webpa-backoff-max"
-#define PARTNER_ID              "partner-id"
-#define CERT_PATH               "ssl-cert-path"
-#define CLOUD_STATUS            "cloud-status"
-#define CLOUD_DISCONNECT        "cloud-disconnect"
-#define CLOUD_STATUS_ONLINE     "online"
-#define CLOUD_STATUS_OFFLINE    "offline"
-#define CLOUD_DISCONNECT_REASON "disconnection-reason"
-#define BOOT_RETRY_WAIT         "boot-time-retry-wait"
+#define HW_MODELNAME                                	"hw-model"
+#define HW_SERIALNUMBER                                 "hw-serial-number"
+#define HW_MANUFACTURER                                 "hw-manufacturer"
+#define HW_DEVICEMAC                                  	"hw-mac"
+#define HW_LAST_REBOOT_REASON                           "hw-last-reboot-reason"
+#define FIRMWARE_NAME                                  	"fw-name"
+#define BOOT_TIME                                  	"boot-time"
+#define LAST_RECONNECT_REASON                           "webpa-last-reconnect-reason"
+#define WEBPA_PROTOCOL                                  "webpa-protocol"
+#define WEBPA_INTERFACE                                 "webpa-inteface-used"
+#define WEBPA_UUID                                      "webpa-uuid"
+#define WEBPA_URL                                       "webpa-url"
+#define WEBPA_PING_TIMEOUT                              "webpa-ping-timeout"
+#define WEBPA_BACKOFF_MAX                               "webpa-backoff-max"
+#define PARTNER_ID                                      "partner-id"
 
-#define PROTOCOL_VALUE 					"PARODUS-2.0"
-#define WEBPA_PATH_URL                  "/api/v2/device"
-#define JWT_ALGORITHM					"jwt-algo"
-#define	JWT_KEY						"jwt-key"
-#define DNS_TXT_URL	"fabric"
-#define PARODUS_UPSTREAM                "tcp://127.0.0.1:6666"
-
-#define ALLOW_NON_RSA_ALG	false
+#define WEBPA_PROTOCOL_VALUE 				"WebPA-1.6"
+#define WEBPA_PATH_URL                                    "/api/v2/device"
+#define PARODUS_UPSTREAM                		"tcp://127.0.0.1:6666"
 
 /*----------------------------------------------------------------------------*/
 /*                               Data Structures                              */
@@ -76,7 +48,7 @@ typedef struct
     char hw_serial_number[64];
     char hw_manufacturer[64];
     char hw_mac[64];
-    char hw_last_reboot_reason[128];
+    char hw_last_reboot_reason[64];
     char fw_name[64];
     unsigned int boot_time;
     unsigned int webpa_ping_timeout;
@@ -84,80 +56,26 @@ typedef struct
     char webpa_path_url[124];
     unsigned int webpa_backoff_max;
     char webpa_interface_used[16];
-    char webpa_protocol[32];
+    char webpa_protocol[16];
     char webpa_uuid[64];
-    unsigned int flags;
+    unsigned int secureFlag;
     char local_url[124];
     char partner_id[64];
-#ifdef ENABLE_SESHAT
     char seshat_url[128];
-#endif
-    char dns_txt_url[64];
-    unsigned int acquire_jwt;
-    unsigned int jwt_algo;  // bit mask set for each allowed algorithm
-    char jwt_key[4096]; // may be read in from a pem file
-    char cert_path[64];
-    char webpa_auth_token[4096];
-    char token_acquisition_script[64];
-    char token_read_script[64];
-    char *client_cert_path;
-    char *token_server_url;
-    char *connection_health_file;
-    char *close_reason_file;
-    char *mtls_client_key_path;
-    char *mtls_client_cert_path;
-	char *crud_config_file;
-	char *cloud_status;
-	char *cloud_disconnect;
-	unsigned int boot_retry_wait;
 } ParodusCfg;
 
-#define FLAGS_IPV6_ONLY (1 << 0)
-#define FLAGS_IPV4_ONLY (1 << 1)
-#define FLAGS_IPV6_IPV4 (FLAGS_IPV6_ONLY | FLAGS_IPV4_ONLY)
-
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
 
 void loadParodusCfg(ParodusCfg * config,ParodusCfg *cfg);
 
-/**
- * parse command line arguments and create config structure
- * and return whether args are valid or not
- *
- * @param argc	number of command line arguments
- * @param argv	command line argument lis
- * @return 0 if OK
-*    or -1 if error
-*/ 
-int parseCommandLine(int argc,char **argv,ParodusCfg * cfg);
+void parseCommandLine(int argc,char **argv,ParodusCfg * cfg);
 
-void setDefaultValuesToCfg(ParodusCfg *cfg); 
 // Accessor for the global config structure.
 ParodusCfg *get_parodus_cfg(void);
 void set_parodus_cfg(ParodusCfg *);
-char *get_token_application(void) ;
-void set_cloud_disconnect_reason(ParodusCfg *cfg, char *disconn_reason);
-void reset_cloud_disconnect_reason(ParodusCfg *cfg);
-char *getWebpaInterface(void);
-void set_cloud_status(char *status);
-char *get_cloud_status(void);
-int get_parodus_init();
-/**
- * parse a webpa url. Extract the server address, the port
- * and return whether it's secure or not
- *
- * @param full_url	full url
- * @param server_addr	ptr to a server address ptr
- *                      will be NULL if invalid,
- *                      otherwise will need to be freed
- * @param port 		ptr to port variable
- * @return 1 if insecure connection is allowed, 0 if not,
-*    or -1 if error
-*/ 
-int parse_webpa_url (const char *full_url, 
-	char **server_addr, unsigned int *port);
+
 #ifdef __cplusplus
 }
 #endif

src/conn_interface.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file conn_interface.c
  *
  * @description This decribes interface to create WebSocket client connections.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #include "connection.h"
@@ -32,60 +17,35 @@
 #include "mutex.h"
 #include "spin_thread.h"
 #include "service_alive.h"
-#include "seshat_interface.h"
-#include "event_handler.h"
-#include "crud_interface.h"
-#include "heartBeat.h"
-#include "close_retry.h"
-#include <curl/curl.h>
-#ifdef FEATURE_DNS_QUERY
-#include <ucresolv_log.h>
-#endif
-#include <time.h>
+#include <libseshat.h>
 
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
 /*----------------------------------------------------------------------------*/
 
 #define HEARTBEAT_RETRY_SEC                         	30      /* Heartbeat (ping/pong) timeout in seconds */
-#define CLOUD_RECONNECT_TIME                       		5		/* Cloud disconnect max time in minutes */
 
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-bool g_shutdown  = false;
-pthread_t upstream_tid;
-pthread_t upstream_msg_tid;
-pthread_t downstream_tid;
-pthread_t svc_alive_tid;
-pthread_t crud_tid;
 
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-void timespec_diff(struct timespec *start, struct timespec *stop,
-                   struct timespec *result);
+bool close_retry = false;
+bool LastReasonStatus = false;
+volatile unsigned int heartBeatTimer = 0;
+pthread_mutex_t close_mut=PTHREAD_MUTEX_INITIALIZER;
 
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
 
-void createSocketConnection(void (* initKeypress)())
+void createSocketConnection(void *config_in, void (* initKeypress)())
 {
-    //ParodusCfg *tmpCfg = (ParodusCfg*)config_in;
+    int intTimer=0;	
+    ParodusCfg *tmpCfg = (ParodusCfg*)config_in;
     noPollCtx *ctx;
-    server_list_t server_list;  
-    bool seshat_registered = false;
-    int create_conn_rtn = 0;
-    int nopoll_returnvalue = 0;	
-    unsigned int webpa_ping_timeout_ms = 1000 * get_parodus_cfg()->webpa_ping_timeout;
-    unsigned int heartBeatTimer = 0;
-    struct timespec start_svc_alive_timer;
+    bool seshat_started;
     
-    //loadParodusCfg(tmpCfg,get_parodus_cfg());
-#ifdef FEATURE_DNS_QUERY
-	register_ucresolv_logger (__cimplog);
-#endif
+    loadParodusCfg(tmpCfg,get_parodus_cfg());
     ParodusPrint("Configure nopoll thread handlers in Parodus\n");
     nopoll_thread_handlers(&createMutex, &destroyMutex, &lockMutex, &unlockMutex);
     ctx = nopoll_ctx_new();
@@ -98,146 +58,75 @@ void createSocketConnection(void (* initKeypress)())
     nopoll_log_set_handler (ctx, __report_log, NULL);
     #endif
 
-    EventHandler();
-    
-    set_server_list_null (&server_list);
-    create_conn_rtn = createNopollConnection(ctx, &server_list);
-    if(!create_conn_rtn)
-    {
-		ParodusError("Unrecovered error, terminating the process\n");
-		OnboardLog("Unrecovered error, terminating the process\n");
-		abort();
-    }
+    createNopollConnection(ctx);
     packMetaData();
     
     UpStreamMsgQ = NULL;
-    StartThread(handle_upstream, &upstream_tid);
-    StartThread(processUpstreamMessage, &upstream_msg_tid);
-    #ifdef WAN_FAILOVER_SUPPORTED
-    subscribeCurrentActiveInterfaceEvent();
-    #endif 
+    StartThread(handle_upstream);
+    StartThread(processUpstreamMessage);
     ParodusMsgQ = NULL;
-    StartThread(messageHandlerTask, &downstream_tid);
-    StartThread(serviceAliveTask, &svc_alive_tid);
-    StartThread(CRUDHandlerTask, &crud_tid);
+    StartThread(messageHandlerTask);
+    StartThread(serviceAliveTask);
 
     if (NULL != initKeypress) 
     {
         (* initKeypress) ();
     }
 
-    seshat_registered = __registerWithSeshat();
+        /* Start seshat lib interface */
+    seshat_started = (0 == init_lib_seshat(get_parodus_cfg()->seshat_url));
+    if (false == seshat_started) {
+        ParodusPrint("init_lib_seshat() Failed, seshatlib not available!\n");
+    } else {
+        ParodusPrint("init_lib_seshat() seshatlib initialized! (url %s)\n",
+	            get_parodus_cfg()->seshat_url);           
+    } 
     
-    clock_gettime(CLOCK_REALTIME, &start_svc_alive_timer);
-
     do
     {
-        struct timespec start, stop, diff;
-        int time_taken_ms;
+        nopoll_loop_wait(ctx, 5000000);
+        intTimer = intTimer + 5;
 
-        clock_gettime(CLOCK_MONOTONIC, &start);
-        nopoll_returnvalue = nopoll_loop_wait(ctx, 5000000);
-        clock_gettime(CLOCK_MONOTONIC, &stop);
-
-        timespec_diff(&start, &stop, &diff);
-        time_taken_ms = diff.tv_sec * 1000 + (diff.tv_nsec / 1000000);
-	if(time_taken_ms/1000 != 5)
-	{
-        	ParodusInfo("nopoll_loop_wait value %d,nopoll_loop_wait() time %d msec\n",nopoll_returnvalue, time_taken_ms);
-	}
-	ParodusPrint("webpa_ping_timeout_ms %d msec\n", webpa_ping_timeout_ms);
-	heartBeatTimer = get_heartBeatTimer();
-        if(heartBeatTimer >= webpa_ping_timeout_ms)
+        if(heartBeatTimer >= get_parodus_cfg()->webpa_ping_timeout) 
         {
-            ParodusInfo("heartBeatTimer %d webpa_ping_timeout_ms %d\n", heartBeatTimer, webpa_ping_timeout_ms);
-
-            if(!get_close_retry())
+            if(!close_retry) 
             {
-                ParodusError("ping wait time > %d . Terminating the connection with WebPA server and retrying\n", webpa_ping_timeout_ms / 1000);
-                ParodusInfo("Reconnect detected, setting Ping_Miss reason for Reconnect\n");
-                OnboardLog("Reconnect detected, setting Ping_Miss reason for Reconnect\n");
+                ParodusError("ping wait time > %d. Terminating the connection with WebPA server and retrying\n", get_parodus_cfg()->webpa_ping_timeout);
                 set_global_reconnect_reason("Ping_Miss");
-                set_global_reconnect_status(true);
-		// Invoke the ping status change event callback as "missed" ping
-		if(NULL != on_ping_status_change)
-		{ 
-			on_ping_status_change("missed");
-		}
-                set_close_retry();
+                LastReasonStatus = true;
+                pthread_mutex_lock (&close_mut);
+                close_retry = true;
+                pthread_mutex_unlock (&close_mut);
             }
             else
-            {
-				ParodusPrint("heartBeatHandler - close_retry set to %d, hence resetting the heartBeatTimer\n",get_close_retry());
+            {			
+                ParodusPrint("heartBeatHandler - close_retry set to %d, hence resetting the heartBeatTimer\n",close_retry);
             }
-            reset_heartBeatTimer();
+            heartBeatTimer = 0;
         }
-        else {
-            increment_heartBeatTimer(time_taken_ms);
-        }
-
-        if( false == seshat_registered ) {
-            seshat_registered = __registerWithSeshat();
-        }
-        
-        if (get_interface_down_event ())
-          if (0 != wait_while_interface_down ())
-            break;
-
-        if(get_close_retry())
+        else if(intTimer >= 30)
         {
-            ParodusInfo("close_retry is %d, hence closing the connection and retrying\n", get_close_retry());
-            close_and_unref_connection(get_global_conn(), false);
-            set_global_conn(NULL);
-
-            if(get_parodus_cfg()->cloud_disconnect !=NULL)
-            {
-                ParodusPrint("get_parodus_cfg()->cloud_disconnect is %s\n", get_parodus_cfg()->cloud_disconnect);
-		set_cloud_disconnect_time(CLOUD_RECONNECT_TIME);
-		ParodusInfo("Waiting for %d minutes for reconnecting .. \n", get_cloud_disconnect_time());
-
-		sleep (get_cloud_disconnect_time() * 60);
-		ParodusInfo("cloud-disconnect reason reset after %d minutes\n", get_cloud_disconnect_time());
-		free(get_parodus_cfg()->cloud_disconnect);
-		reset_cloud_disconnect_reason(get_parodus_cfg());
-            }
-            createNopollConnection(ctx, &server_list);
+            ParodusPrint("heartBeatTimer %d\n",heartBeatTimer);
+            heartBeatTimer += HEARTBEAT_RETRY_SEC;	
+            intTimer = 0;		
         }
-	 //process exit only when g_shutdown is true.
-       } while(FOREVER() && !g_shutdown);
 
-    pthread_mutex_lock (get_global_svc_mut());
-    pthread_cond_signal (get_global_svc_con());
-    pthread_mutex_unlock (get_global_svc_mut());
-    pthread_mutex_lock (get_global_crud_mut());
-    pthread_cond_signal (get_global_crud_con());
-    pthread_mutex_unlock (get_global_crud_mut());
-    pthread_mutex_lock (&g_mutex);
-    pthread_cond_signal (&g_cond);
-    pthread_mutex_unlock (&g_mutex);
-    pthread_mutex_lock (get_global_nano_mut ());
-    pthread_cond_signal (get_global_nano_con());
-    pthread_mutex_unlock (get_global_nano_mut());
+        if(close_retry)
+        {
+            ParodusInfo("close_retry is %d, hence closing the connection and retrying\n", close_retry);
+            close_and_unref_connection(get_global_conn());
+            set_global_conn(NULL);
+            createNopollConnection(ctx);
+        }		
+    } while(!close_retry);
 
-    ParodusInfo ("joining threads\n");
-    JoinThread (svc_alive_tid);
-    JoinThread (upstream_tid);
-    JoinThread (downstream_tid);
-    JoinThread (upstream_msg_tid);
-    JoinThread (crud_tid);
-
-    deleteAllClients ();
-
-    ParodusInfo ("reconnect reason at close %s\n", get_global_reconnect_reason());
-    close_and_unref_connection(get_global_conn(), true);
+    close_and_unref_connection(get_global_conn());
     nopoll_ctx_unref(ctx);
     nopoll_cleanup_library();
-    curl_global_cleanup();
-}
-
-void shutdownSocketConnection(char *reason) {
-   set_global_shutdown_reason (reason);
-   g_shutdown = true;
-   reset_interface_down_event ();
-   terminate_backoff_delay ();
+
+    if (seshat_started) {
+	    shutdown_seshat_lib();
+    }
+    
 }
 

src/conn_interface.h

@@ -1,25 +1,11 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file conn_interface.h
  *
  * @description This header defines interface to create WebSocket client connections.
  *
+ * Copyright (c) 2015  Comcast
  */
+ 
 #ifndef _CONN_INTERFACE_H_
 #define _CONN_INTERFACE_H_
 
@@ -44,8 +30,7 @@ extern UpStreamMsg *UpStreamMsgQ;
  * Loads the WebPA config file, if not provided by the caller,
  *  and creates the intial connection and manages the connection wait, close mechanisms.
  */
-void createSocketConnection(void (* initKeypress)());
-void shutdownSocketConnection(char *reason);
+void createSocketConnection(void *config_in, void (* initKeypress)());
    
 #ifdef __cplusplus
 }

src/connection.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file connection.h
  *
  * @description This header defines functions required to manage WebSocket client connections.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _CONNECTION_H_
@@ -33,72 +18,28 @@ extern "C" {
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-#define SHUTDOWN_REASON_PARODUS_STOP    "parodus_stopping"
-#define SHUTDOWN_REASON_SYSTEM_RESTART  "system_restarting"
-#define SHUTDOWN_REASON_SIGTERM 		"SIGTERM"
 
-/**
-* parodusOnConnStatusChangeHandler - Function pointer
-* Used to define callback function to do additional processing
-* when websocket cloud connection status change event
-* i.e. "cloud-conn-status" as "fail" or "success"
-*/
-typedef void (*parodusOnConnStatusChangeHandler) (char * status);
-extern parodusOnConnStatusChangeHandler on_conn_status_change;
-
-/**
-* parodusOnPingStatusChangeHandler - Function pointer
-* Used to define callback function to do additional processing 
-* when websocket Ping status change event 
-* i.e. ping_miss or ping receive after miss
-*/
-typedef void (*parodusOnPingStatusChangeHandler) (char * status);
-extern parodusOnPingStatusChangeHandler on_ping_status_change;
+extern bool close_retry;
+extern volatile unsigned int heartBeatTimer;
+extern pthread_mutex_t close_mut;
 
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
 
-void set_server_list_null (server_list_t *server_list);
-int createNopollConnection(noPollCtx *, server_list_t *);
+int createNopollConnection(noPollCtx *);
 
 /**
  * @brief Interface to terminate WebSocket client connections and clean up resources.
  */
-void close_and_unref_connection(noPollConn *conn, bool is_shutting_down);
+void close_and_unref_connection(noPollConn *);
 
 noPollConn *get_global_conn(void);
 void set_global_conn(noPollConn *);
 
-char *get_global_shutdown_reason();
-void set_global_shutdown_reason(char *reason);
-
 char *get_global_reconnect_reason();
 void set_global_reconnect_reason(char *reason);
 
-bool get_global_reconnect_status();
-void set_global_reconnect_status(bool status);
-
-int get_cloud_disconnect_time();
-void set_cloud_disconnect_time(int disconnTime);
-
-/**
- * @brief Interface to self heal connection in progress getting stuck
- */
-void start_conn_in_progress (unsigned long start_time);
-void stop_conn_in_progress (void);
-
-// To Register parodusOnConnStatusChangeHandler Callback function
-void registerParodusOnConnStatusChangeHandler(parodusOnConnStatusChangeHandler on_conn_status_change);
-
-// To Register parodusOnPingStatusChangeHandler Callback function
-void registerParodusOnPingStatusChangeHandler(parodusOnPingStatusChangeHandler on_ping_status_change);
-
-// To stop connection and wait duing interface down state
-int wait_while_interface_down (void);
-
-void terminate_backoff_delay (void);
-
 #ifdef __cplusplus
 }
 #endif

src/crud_interface.c

@@ -1,187 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file crud_interface.c
- *
- * @description This file is used to manage incoming and outgoing CRUD messages.
- *
- */
-
-#include "ParodusInternal.h"
-#include "crud_tasks.h"
-#include "crud_interface.h"
-#include "upstream.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-
-pthread_mutex_t crud_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t crud_con=PTHREAD_COND_INITIALIZER;
-
-
-/*----------------------------------------------------------------------------*/
-/*                             Internal variables                             */
-/*----------------------------------------------------------------------------*/
-
-CrudMsg *crudMsgQ = NULL;
-
-/*----------------------------------------------------------------------------*/
-/*                             External functions                             */
-/*----------------------------------------------------------------------------*/
-
-pthread_cond_t *get_global_crud_con(void)
-{
-    return &crud_con;
-}
-
-pthread_mutex_t *get_global_crud_mut(void)
-{
-    return &crud_mut;
-}
-
-void addCRUDmsgToQueue(wrp_msg_t *crudMsg)
-{
-	CrudMsg * crudMessage;
-	crudMessage = (CrudMsg *)malloc(sizeof(CrudMsg));
-	if(crudMessage && crudMsg!=NULL)
-	{
-		crudMessage->msg = crudMsg;
-		crudMessage->next = NULL;
-		ParodusPrint("Inside addCRUDmsgToQueue : mutex lock in producer \n");
-		pthread_mutex_lock(&crud_mut);
-		if(crudMsgQ ==NULL)
-		{
-			crudMsgQ = crudMessage;
-			ParodusPrint("Producer added message\n");
-			pthread_cond_signal(&crud_con);
-			pthread_mutex_unlock(&crud_mut);
-			ParodusPrint("Inside addCRUDmsgToQueue : mutex unlock in producer \n");
-		}
-		else
-		{
-			CrudMsg *temp = crudMsgQ;
-			while(temp->next)
-			{
-				temp = temp->next;
-			}
-			temp->next = crudMessage;
-			pthread_mutex_unlock(&crud_mut);
-		}
-	}
-	else
-	{
-		ParodusError("Memory allocation failed for CRUD\n");
-	}
-}
-
-
-void *CRUDHandlerTask()
-{
-	int ret = 0;
-	ssize_t resp_size = 0;
-	void *resp_bytes;
-	wrp_msg_t *crud_response = NULL;
-
-	while(FOREVER())
-	{
-		pthread_mutex_lock(&crud_mut);
-		ParodusPrint("Mutex lock in CRUD consumer thread\n");
-
-		if(crudMsgQ !=NULL)
-		{
-			CrudMsg *message = crudMsgQ;
-			crudMsgQ = crudMsgQ->next;
-			pthread_mutex_unlock(&crud_mut);
-			ParodusPrint("Mutex unlock in CRUD consumer thread\n");
-
-			ret = processCrudRequest(message->msg, &crud_response);
-			wrp_free_struct(message->msg);
-			free(message);
-			message = NULL;
-
-			if(ret == 0)
-			{
-				ParodusInfo("CRUD processed successfully\n");
-			}
-			else
-			{
-				ParodusError("Failure in CRUD request processing !!\n");
-			}
-			ParodusPrint("msgpack encode to send to upstream\n");
-			resp_size = wrp_struct_to( crud_response, WRP_BYTES, &resp_bytes );
-			ParodusPrint("Encoded CRUD resp_size :%lu\n", resp_size);
-
-			ParodusPrint("Adding CRUD response to upstreamQ\n");
-			addCRUDresponseToUpstreamQ(resp_bytes, resp_size);
-			wrp_free_struct(crud_response);
-		}
-		else
-		{
-			if (g_shutdown) {
-			  pthread_mutex_unlock (&crud_mut);
-			  break;
-			}
-			pthread_cond_wait(&crud_con, &crud_mut);
-			pthread_mutex_unlock (&crud_mut);
-		}
-	}
-	return 0;
-}
-
-
-//CRUD Producer adds the response into common UpStreamQ
-void addCRUDresponseToUpstreamQ(void *response_bytes, ssize_t response_size)
-{
-	UpStreamMsg *response;
-
-	response = (UpStreamMsg *)malloc(sizeof(UpStreamMsg));
-	if(response)
-	{
-		response->msg =(void *)response_bytes;
-		response->len =(int)response_size;
-		response->next=NULL;
-		pthread_mutex_lock (get_global_nano_mut());
-		ParodusPrint("Mutex lock in CRUD response producer\n");
-
-		if(get_global_UpStreamMsgQ() == NULL)
-		{
-			set_global_UpStreamMsgQ(response);
-			ParodusPrint("Producer added CRUD response to UpStreamQ\n");
-			pthread_cond_signal(get_global_nano_con());
-			pthread_mutex_unlock (get_global_nano_mut());
-			ParodusPrint("mutex unlock in CRUD response producer\n");
-		}
-		else
-		{
-			ParodusPrint("Producer adding CRUD response to UpStreamQ\n");
-			UpStreamMsg *temp = get_global_UpStreamMsgQ();
-			while(temp->next)
-			{
-				temp = temp->next;
-			}
-			temp->next = response;
-			pthread_mutex_unlock (get_global_nano_mut());
-		}
-	}
-	else
-	{
-		ParodusError("failure in allocation for CRUD response\n");
-	}
-
-}
-

src/crud_interface.h

@@ -1,57 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file crud_interface.h
- *
- * @description This header defines functions required to manage CRUD messages.
- *
- */
- 
-#ifndef _CRUD_INTERFACE_H_
-#define _CRUD_INTERFACE_H_
-
-#include <pthread.h>
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-
-/*----------------------------------------------------------------------------*/
-/*                               Data Structures                              */
-/*----------------------------------------------------------------------------*/
-typedef struct CrudMsg__
-{
-	wrp_msg_t *msg;
-	struct CrudMsg__ *next;
-} CrudMsg;
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-void addCRUDresponseToUpstreamQ(void *response_bytes, ssize_t response_size);
-pthread_cond_t *get_global_crud_con(void);
-pthread_mutex_t *get_global_crud_mut(void);
-
-#ifdef __cplusplus
-}
-#endif
-
-
-#endif /* _CRUD_INTERFACE_H_ */
-

src/crud_internal.h

@@ -1,27 +0,0 @@
-/**
- * Copyright 2016 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-#include <wrp-c.h>
-#include <stdlib.h>
-
-int createObject( wrp_msg_t *reqMsg, wrp_msg_t **response );
-int retrieveObject( wrp_msg_t *reqMsg, wrp_msg_t **response);
-int updateObject( wrp_msg_t *reqMsg, wrp_msg_t **response);
-int deleteObject(wrp_msg_t *reqMsg, wrp_msg_t **response);
-
-int writeToJSON(char *data);
-int readFromJSON(char **data);
-int retrieveFromMemory(char *keyName, cJSON **jsonresponse);

src/crud_tasks.c

@@ -1,109 +0,0 @@
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-#include <cJSON.h>
-#include <wrp-c.h>
-#include "crud_tasks.h"
-#include "crud_internal.h"
-
-
-int processCrudRequest( wrp_msg_t *reqMsg, wrp_msg_t **responseMsg)
-{
-	wrp_msg_t *resp_msg = NULL;
-    int ret = -1;
-
-    resp_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(resp_msg, 0, sizeof(wrp_msg_t));
-
-    resp_msg->msg_type = reqMsg->msg_type;
-    resp_msg->u.crud.transaction_uuid = strdup(reqMsg->u.crud.transaction_uuid);
-    resp_msg->u.crud.source = strdup(reqMsg->u.crud.dest);
-    resp_msg->u.crud.dest = strdup(reqMsg->u.crud.source);
-
-    switch( reqMsg->msg_type ) 
-    {
-
-	case WRP_MSG_TYPE__CREATE:
-	ParodusInfo( "CREATE request\n" );
-
-	ret = createObject( reqMsg, &resp_msg );
-
-	if(ret != 0)
-	{
-		ParodusError("Failed to create object in config JSON\n");
-
-		//WRP payload is NULL for failure cases
-		resp_msg ->u.crud.payload = NULL;
-		resp_msg ->u.crud.payload_size = 0;
-		*responseMsg = resp_msg;
-		return -1;
-	}
-
-	*responseMsg = resp_msg;
-	break;
-
-	case WRP_MSG_TYPE__RETREIVE:
-	ParodusInfo( "RETREIVE request\n" );
-
-	ret = retrieveObject( reqMsg, &resp_msg );
-	if(ret != 0)
-	{
-	    ParodusError("Failed to retrieve object \n");
-
-	    //WRP payload is NULL for failure cases
-	    resp_msg ->u.crud.payload = NULL;
-	    resp_msg ->u.crud.payload_size = 0;
-	    *responseMsg = resp_msg;
-	    return -1;
-	}
-
-	*responseMsg = resp_msg;
-	break;
-
-	case WRP_MSG_TYPE__UPDATE:
-	ParodusInfo( "UPDATE request\n" );
-
-	ret = updateObject( reqMsg, &resp_msg );
-	if(ret ==0)
-	{
-		//WRP payload is NULL for update requests
-		resp_msg ->u.crud.payload = NULL;
-		resp_msg ->u.crud.payload_size = 0;
-	}
-	else
-	{
-		ParodusError("Failed to update object \n");
-		*responseMsg = resp_msg;
-		return -1;
-	}
-	*responseMsg = resp_msg;
-	break;
-
-	case WRP_MSG_TYPE__DELETE:
-	ParodusInfo( "DELETE request\n" );
-
-	ret = deleteObject(reqMsg, &resp_msg );
-	if(ret == 0)
-	{
-		//WRP payload is NULL for delete requests
-		resp_msg ->u.crud.payload = NULL;
-		resp_msg ->u.crud.payload_size = 0;
-	}
-	else
-	{
-		ParodusError("Failed to delete object \n");
-		*responseMsg = resp_msg;
-		return -1;
-	}
-	*responseMsg = resp_msg;
-	break;
-
-	default:
-	    ParodusInfo( "Unknown msgType for CRUD request\n" );
-	    *responseMsg = resp_msg;
-	    break;
-     }
-
-    return  0;
-}
-

src/crud_tasks.h

@@ -1,31 +0,0 @@
-/**
- * Copyright 2016 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
- 
- 
-#include <wrp-c.h>
-#include "ParodusInternal.h"
-
-/**
- * @brief processCrudRequest function to process CRUD operations.
- *
- * @note processCrudRequest function allocates memory for response, 
- * caller needs to free the response (resMsg) in both success and failure case.
- * @param[in] decoded request in wrp_msg_t structure format
- * @param[out] resulting wrp_msg_t structure as a response 
- * @return  0 in success case and -1 in error case
- */
-int processCrudRequest(wrp_msg_t * reqMsg, wrp_msg_t **resMsg);

src/downstream.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file downstream.c
  *
  * @description This describes functions required to manage downstream messages.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "downstream.h"
@@ -26,11 +11,7 @@
 #include "connection.h"
 #include "partners_check.h"
 #include "ParodusInternal.h"
-#include "crud_interface.h"
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-static void createNewMsgForCRUD(wrp_msg_t *message, wrp_msg_t **crudMessage );
+
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -45,7 +26,6 @@ void listenerOnMessage(void * msg, size_t msgSize)
 {
     int rv =0;
     wrp_msg_t *message;
-    wrp_msg_t *crudMessage= NULL;
     char* destVal = NULL;
     char dest[32] = {'\0'};
     int msgType;
@@ -62,7 +42,7 @@ void listenerOnMessage(void * msg, size_t msgSize)
 
     recivedMsg =  (const char *) msg;
 
-    ParodusInfo("Received msg from server\n");
+    ParodusInfo("Received msg from server:%s\n", recivedMsg);
     if(recivedMsg!=NULL) 
     {
         /*** Decoding downstream recivedMsg to check destination ***/
@@ -73,297 +53,90 @@ void listenerOnMessage(void * msg, size_t msgSize)
             ParodusPrint("\nDecoded recivedMsg of size:%d\n", rv);
             msgType = message->msg_type;
             ParodusInfo("msgType received:%d\n", msgType);
-            
-            switch( message->msg_type )
+
+            if(message->msg_type == WRP_MSG_TYPE__REQ)
             {
-                case WRP_MSG_TYPE__AUTH:
+                ParodusPrint("numOfClients registered is %d\n", get_numOfClients());
+                int ret = validate_partner_id(message, NULL);
+                if(ret < 0)
                 {
-                    ParodusInfo("Authorization Status received with Status code :%d\n", message->u.auth.status);
-                    break;
+                    response = cJSON_CreateObject();
+                    cJSON_AddNumberToObject(response, "statusCode", 430);
+                    cJSON_AddStringToObject(response, "message", "Invalid partner_id");
                 }
 
-                case WRP_MSG_TYPE__EVENT:
-                case WRP_MSG_TYPE__REQ:
-                case WRP_MSG_TYPE__CREATE:
-                case WRP_MSG_TYPE__UPDATE:
-                case WRP_MSG_TYPE__RETREIVE:
-                case WRP_MSG_TYPE__DELETE:
+                if((message->u.req.dest !=NULL) && (ret >= 0))
                 {
-                    ParodusPrint("numOfClients registered is %d\n", get_numOfClients());
-                    int ret = validate_partner_id(message, NULL);
-                    if(ret < 0)
+                    destVal = message->u.req.dest;
+                    strtok(destVal , "/");
+                    parStrncpy(dest,strtok(NULL , "/"), sizeof(dest));
+                    ParodusInfo("Received downstream dest as :%s\n", dest);
+                    temp = get_global_node();
+                    //Checking for individual clients & Sending to each client
+
+                    while (NULL != temp)
                     {
+                        ParodusPrint("node is pointing to temp->service_name %s \n",temp->service_name);
+                        // Sending message to registered clients
+                        if( strcmp(dest, temp->service_name) == 0)
+                        {
+                            ParodusPrint("sending to nanomsg client %s\n", dest);
+                            bytes = nn_send(temp->sock, recivedMsg, msgSize, 0);
+                            ParodusInfo("sent downstream message '%s' to reg_client '%s'\n",recivedMsg,temp->url);
+                            ParodusPrint("downstream bytes sent:%d\n", bytes);
+                            destFlag =1;
+                            break;
+                        }
+                        ParodusPrint("checking the next item in the list\n");
+                        temp= temp->next;
+                    }
+
+                    //if any unknown dest received sending error response to server
+                    if(destFlag ==0)
+                    {
+                        ParodusError("Unknown dest:%s\n", dest);
                         response = cJSON_CreateObject();
-                        cJSON_AddNumberToObject(response, "statusCode", 403);
-                        cJSON_AddStringToObject(response, "message", "Invalid partner_id");
-                    } 
-
-                      
-                    destVal = strdup(((WRP_MSG_TYPE__EVENT == msgType) ? message->u.event.dest : 
-                              ((WRP_MSG_TYPE__REQ   == msgType) ? message->u.req.dest : message->u.crud.dest)));
-
-                    if( (destVal != NULL) && (ret >= 0) )
-                    {
-						char *newDest = NULL;
-						char *tempDest = strtok(destVal , "/");
-						if(tempDest != NULL)
-						{
-							newDest = strtok(NULL , "/");
-						}
-						if(newDest != NULL)
-						{
-							parStrncpy(dest,newDest, sizeof(dest));
-						}
-						else
-						{
-							parStrncpy(dest,destVal, sizeof(dest));
-						}
-                        ParodusInfo("Received downstream dest as :%s and transaction_uuid :%s\n", dest, 
-                            ((WRP_MSG_TYPE__REQ   == msgType) ? message->u.req.transaction_uuid : 
-                            ((WRP_MSG_TYPE__EVENT == msgType) ? "NA" : message->u.crud.transaction_uuid)));
-			OnboardLog("%s\n",
-                            ((WRP_MSG_TYPE__REQ   == msgType) ? message->u.req.transaction_uuid :
-                            ((WRP_MSG_TYPE__EVENT == msgType) ? "NA" : message->u.crud.transaction_uuid)));
-                        
-                        free(destVal);
-
-                        temp = get_global_node();
-                        //Checking for individual clients & Sending to each client
-
-                        while (NULL != temp)
-                        {
-                            ParodusPrint("node is pointing to temp->service_name %s \n",temp->service_name);
-                            // Sending message to registered clients
-                            if( strcmp(dest, temp->service_name) == 0)
-                            {
-                                ParodusPrint("sending to nanomsg client %s\n", dest);
-                                bytes = nn_send(temp->sock, recivedMsg, msgSize, 0);
-                                ParodusInfo("sent downstream message to reg_client '%s'\n",temp->url);
-                                ParodusPrint("downstream bytes sent:%d\n", bytes);
-                                destFlag =1;
-                                break;
-                            }
-                            ParodusPrint("checking the next item in the list\n");
-                            temp= temp->next;
-                        }
-                        release_global_node ();
-
-			/* check Downstream dest for CRUD requests */
-			if(destFlag ==0 && strcmp("parodus", dest)==0)
-			{
-							ParodusPrint("Received CRUD request : dest : %s\n", dest);
-							if ((message->u.crud.source == NULL) || (message->u.crud.transaction_uuid == NULL))
-							{
-								ParodusError("Invalid request\n");
-								response = cJSON_CreateObject();
-								cJSON_AddNumberToObject(response, "statusCode", 400);
-								cJSON_AddStringToObject(response, "message", "Invalid Request");
-								ret = -1;
-							}
-							else
-							{
-							    createNewMsgForCRUD(message, &crudMessage);
-							    addCRUDmsgToQueue(crudMessage);
-							}
-							destFlag =1;
-			}
-			//if any unknown dest received sending error response to server
-                        if(destFlag ==0)
-                        {
-                            ParodusError("Unknown dest:%s\n", dest);
-                            response = cJSON_CreateObject();
-                            cJSON_AddNumberToObject(response, "statusCode", 531);
-                            cJSON_AddStringToObject(response, "message", "Service Unavailable");
-                        }
+                        cJSON_AddNumberToObject(response, "statusCode", 531);
+                        cJSON_AddStringToObject(response, "message", "Service Unavailable");
                     }
-
-                    if( (WRP_MSG_TYPE__EVENT != msgType) &&
-                        ((destFlag == 0) || (ret < 0)) )
-                    {
-                        resp_msg = (wrp_msg_t *)malloc(sizeof(wrp_msg_t));
-                        memset(resp_msg, 0, sizeof(wrp_msg_t));
-
-                        resp_msg ->msg_type = msgType;
-                        if( WRP_MSG_TYPE__REQ == msgType )
-                        {
-                            resp_msg ->u.req.source = message->u.req.dest;
-                            resp_msg ->u.req.dest = message->u.req.source;
-                            resp_msg ->u.req.transaction_uuid=message->u.req.transaction_uuid;
-                        }
-                        else
-                        {
-                            resp_msg ->u.crud.source = message->u.crud.dest;
-				if(message->u.crud.source !=NULL)
-				{
-					resp_msg ->u.crud.dest = message->u.crud.source;
-				}
-				else
-				{
-					resp_msg ->u.crud.dest = "unknown";
-				}
-                            resp_msg ->u.crud.transaction_uuid = message->u.crud.transaction_uuid;
-                            resp_msg ->u.crud.path =             message->u.crud.path;
-                        }
-
-                        if(response != NULL)
-                        {
-                            str = cJSON_PrintUnformatted(response);
-                            ParodusInfo("Payload Response: %s\n", str);
-
-                            if( WRP_MSG_TYPE__REQ == msgType )
-                            {
-                                resp_msg ->u.req.payload = (void *)str;
-                                resp_msg ->u.req.payload_size = strlen(str);
-                            }
-                            else
-                            {
-                                resp_msg ->u.crud.payload = (void *)str;
-                                resp_msg ->u.crud.payload_size = strlen(str);
-                            }
-
-                            ParodusPrint("msgpack encode\n");
-                            resp_size = wrp_struct_to( resp_msg, WRP_BYTES, &resp_bytes );
-                            if(resp_size > 0)
-                            {
-                                size = (size_t) resp_size;
-                                sendUpstreamMsgToServer(&resp_bytes, size);
-                            }
-                            free(str);
-                            cJSON_Delete(response);
-                            free(resp_bytes);
-                            resp_bytes = NULL;
-                        }
-                        free(resp_msg);
-                    }
-                    break;
                 }
 
-                case WRP_MSG_TYPE__SVC_REGISTRATION:
-                case WRP_MSG_TYPE__SVC_ALIVE:
-                case WRP_MSG_TYPE__UNKNOWN:
-                default:
-                    break;
+                if(destFlag == 0 || ret < 0)
+                {
+                    resp_msg = (wrp_msg_t *)malloc(sizeof(wrp_msg_t));
+                    memset(resp_msg, 0, sizeof(wrp_msg_t));
+
+                    resp_msg ->msg_type = msgType;
+                    resp_msg ->u.req.source = message->u.req.dest;
+                    resp_msg ->u.req.dest = message->u.req.source;
+                    resp_msg ->u.req.transaction_uuid=message->u.req.transaction_uuid;
+
+                    if(response != NULL)
+                    {
+                        str = cJSON_PrintUnformatted(response);
+                        ParodusInfo("Payload Response: %s\n", str);
+
+                        resp_msg ->u.req.payload = (void *)str;
+                        resp_msg ->u.req.payload_size = strlen(str);
+
+                        ParodusPrint("msgpack encode\n");
+                        resp_size = wrp_struct_to( resp_msg, WRP_BYTES, &resp_bytes );
+                        if(resp_size > 0)
+                        {
+                            size = (size_t) resp_size;
+                            sendUpstreamMsgToServer(&resp_bytes, size);
+                        }
+                        free(str);
+                    }
+                    free(resp_msg);
+                }
             }
-            ParodusPrint("free for downstream decoded msg\n");
-            wrp_free_struct(message);
-            message = NULL;
         }
         else
         {
             ParodusError( "Failure in msgpack decoding for receivdMsg: rv is %d\n", rv );
         }
-    }
-}
-/*----------------------------------------------------------------------------*/
-/*                             Internal Functions                             */
-/*----------------------------------------------------------------------------*/
-/**
- * @brief createNewMsgForCRUD function to create new message for processing CRUD requests
- *
- * @param[in] message The message received from server
- * @param[out] crudMessage New message for processing CRUD requests
- */
-static void createNewMsgForCRUD(wrp_msg_t *message, wrp_msg_t **crudMessage )
-{
-    wrp_msg_t *msg;
-    msg = ( wrp_msg_t * ) malloc( sizeof( wrp_msg_t ) );
-    size_t i;
-    if(msg != NULL)
-    {
-        memset( msg, 0, sizeof( wrp_msg_t ) );
-        msg->msg_type = message->msg_type;
-        if(message->u.crud.source != NULL)
-        {
-            ParodusPrint("message->u.crud.source = %s\n",message->u.crud.source);
-            msg->u.crud.source = strdup(message->u.crud.source);
-        }
-
-        if(message->u.crud.dest!= NULL)
-        {
-            ParodusPrint("message->u.crud.dest = %s\n",message->u.crud.dest);
-            msg->u.crud.dest = strdup(message->u.crud.dest);
-        }
-
-        if(message->u.crud.transaction_uuid != NULL)
-        {
-            ParodusPrint("message->u.crud.transaction_uuid = %s\n",message->u.crud.transaction_uuid);
-            msg->u.crud.transaction_uuid = strdup(message->u.crud.transaction_uuid);
-        }
-
-        if(message->u.crud.partner_ids!= NULL && message->u.crud.partner_ids->count >0)
-        {
-            msg->u.crud.partner_ids = ( partners_t * ) malloc( sizeof( partners_t ) +
-                                                              sizeof( char * ) * message->u.crud.partner_ids->count );
-            if(msg->u.crud.partner_ids != NULL)
-            {
-                msg->u.crud.partner_ids->count = message->u.crud.partner_ids->count;
-                for(i = 0; i<message->u.crud.partner_ids->count; i++)
-                {
-                    ParodusPrint("message->u.crud.partner_ids->partner_ids[%d] = %s\n",i,message->u.crud.partner_ids->partner_ids[i]);
-                    msg->u.crud.partner_ids->partner_ids[i] = strdup(message->u.crud.partner_ids->partner_ids[i]);
-                }
-            }
-        }
-
-        if(message->u.crud.headers!= NULL && message->u.crud.headers->count >0)
-        {
-            msg->u.crud.headers = ( headers_t * ) malloc( sizeof( headers_t ) +
-                                                                sizeof( char * ) * message->u.crud.headers->count );
-            if(msg->u.crud.headers != NULL)
-            {
-                msg->u.crud.headers->count = message->u.crud.headers->count;
-                for(i = 0; i<message->u.crud.headers->count; i++)
-                {
-                    ParodusPrint("message->u.crud.headers->headers[%d] = %s\n",i,message->u.crud.headers->headers[i]);
-                    msg->u.crud.headers->headers[i] = strdup(message->u.crud.headers->headers[i]);
-                }
-            }
-        }
-
-        if(message->u.crud.metadata != NULL && message->u.crud.metadata->count > 0)
-        {
-            msg->u.crud.metadata = (data_t *) malloc( sizeof( data_t ) );
-            if(msg->u.crud.metadata != NULL)
-            {
-                memset( msg->u.crud.metadata, 0, sizeof( data_t ) );
-                msg->u.crud.metadata->count = message->u.crud.metadata->count;
-                msg->u.crud.metadata->data_items = ( struct data* )malloc( sizeof( struct data ) * ( message->u.crud.metadata->count ) );
-                for(i=0; i<message->u.crud.metadata->count; i++)
-                {
-                    if(message->u.crud.metadata->data_items[i].name != NULL)
-                    {
-                        ParodusPrint("message->u.crud.metadata->data_items[%d].name : %s\n",i,message->u.crud.metadata->data_items[i].name);
-                        msg->u.crud.metadata->data_items[i].name = strdup(message->u.crud.metadata->data_items[i].name);
-                    }
-                    if(message->u.crud.metadata->data_items[i].value != NULL)
-                    {
-                        ParodusPrint("message->u.crud.metadata->data_items[%d].value : %s\n",i,message->u.crud.metadata->data_items[i].value);
-                        msg->u.crud.metadata->data_items[i].value = strdup(message->u.crud.metadata->data_items[i].value);
-                    }
-                }
-            }
-        }
-        msg->u.crud.include_spans = message->u.crud.include_spans;
-        if(message->u.crud.content_type != NULL)
-        {
-            ParodusPrint("message->u.crud.content_type : %s\n",message->u.crud.content_type);
-            msg->u.crud.content_type = strdup(message->u.crud.content_type);
-        }
-        msg->u.crud.spans.spans = NULL;   /* not supported */
-        msg->u.crud.spans.count = 0;     /* not supported */
-        msg->u.crud.status = message->u.crud.status;
-        msg->u.crud.rdr = message->u.crud.rdr;
-        if(message->u.crud.payload != NULL)
-        {
-            ParodusPrint("message->u.crud.payload = %s\n", (char *)message->u.crud.payload);
-            msg->u.crud.payload = strdup((char *)message->u.crud.payload);
-        }
-        msg->u.crud.payload_size = message->u.crud.payload_size;
-        if(message->u.crud.path != NULL)
-        {
-            ParodusPrint("message->u.crud.path = %s\n", message->u.crud.path);
-            msg->u.crud.path = strdup(message->u.crud.path);
-        }
-        *crudMessage = msg;
+        ParodusPrint("free for downstream decoded msg\n");
+        wrp_free_struct(message);
     }
 }

src/downstream.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file downstream.h
  *
  * @description This header defines functions required to manage downstream messages.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _DOWNSTREAM_H_

src/event_handler.c

@@ -1,26 +0,0 @@
-/*
- * If not stated otherwise in this file or this component's Licenses.txt file the
- * following copyright and licenses apply:
- *
- * Copyright 2016 RDK Management
- * Copyright [2014] [Cisco Systems, Inc.]
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
-*/
-
-/* This is a stub file that will be overridden in a patch */
-
-#include "event_handler.h"
-
-void EventHandler()
-{
-}

src/event_handler.h

@@ -1,21 +0,0 @@
-/*
- * If not stated otherwise in this file or this component's Licenses.txt file the
- * following copyright and licenses apply:
- *
- * Copyright 2016 RDK Management
- * Copyright [2014] [Cisco Systems, Inc.]
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
-*/
-
-void EventHandler();
-#define LOGGING_INTERVAL_SECS    ( 60 * 60 )

src/heartBeat.c

@@ -1,77 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file heartBeat.c
- *
- * @description This decribes functions required to manage heartBeatTimer.
- *
- */
-
-#include "heartBeat.h"
-#include <stdbool.h>
-
-volatile unsigned int heartBeatTimer = 0;
-volatile bool paused = false;
-
-pthread_mutex_t heartBeat_mut=PTHREAD_MUTEX_INITIALIZER;
-
-// Get value of heartBeatTimer
-unsigned int get_heartBeatTimer() 
-{
-	unsigned int tmp = 0;
-	pthread_mutex_lock (&heartBeat_mut);
-	tmp = heartBeatTimer;
-	pthread_mutex_unlock (&heartBeat_mut);
-	return tmp;
-}
-
-// Reset value of heartBeatTimer to 0
-void reset_heartBeatTimer() 
-{
-	pthread_mutex_lock (&heartBeat_mut);
-	heartBeatTimer = 0;
-	pthread_mutex_unlock (&heartBeat_mut);
-}
-
-// Increment value of heartBeatTimer to desired value
-void increment_heartBeatTimer(unsigned int inc_time_ms) 
-{
-	pthread_mutex_lock (&heartBeat_mut);
-	if (!paused)
-	  heartBeatTimer += inc_time_ms;
-	pthread_mutex_unlock (&heartBeat_mut);
-}
-
-// Pause heartBeatTimer, i.e. stop incrementing
-void pause_heartBeatTimer()
-{
-	pthread_mutex_lock (&heartBeat_mut);
-	heartBeatTimer = 0;
-	paused = true;
-	pthread_mutex_unlock (&heartBeat_mut);
-}
-
-// Resume heartBeatTimer, i.e. resume incrementing
-void resume_heartBeatTimer()
-{
-	pthread_mutex_lock (&heartBeat_mut);
-	paused = false;
-	pthread_mutex_unlock (&heartBeat_mut);
-}
-
-
-

src/heartBeat.h

@@ -1,52 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file heartBeat.h
- *
- * @description This decribes functions required to manage heartBeatTimer.
- *
- */
-
-#ifndef _HEARBEAT_H_
-#define _HEARBEAT_H_
-
-#include <pthread.h>
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-// Get value of heartBeatTimer
-unsigned int get_heartBeatTimer();
-
-// Reset value of heartBeatTimer to 0
-void reset_heartBeatTimer();
-
-// Increment value of heartBeatTimer to desired value
-void increment_heartBeatTimer(unsigned int inc_time_ms);
-
-// Pause heartBeatTimer, i.e. stop incrementing
-void pause_heartBeatTimer();
-
-// Resume heartBeatTimer, i.e. resume incrementing
-void resume_heartBeatTimer();
-
-#ifdef __cplusplus
-}
-#endif
-    
-#endif

src/main.c

@@ -16,18 +16,10 @@
  */
  
 #include <string.h>
-#include "stdlib.h"
+
 #include "config.h"
-#include "auth_token.h"
-#include "connection.h"
 #include "conn_interface.h"
 #include "parodus_log.h"
-#include <curl/curl.h>
-#ifdef INCLUDE_BREAKPAD
-#include "breakpad_wrapper.h"
-#endif
-#include "signal.h"
-#include "privilege.h"
 
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
@@ -37,86 +29,30 @@
 /*----------------------------------------------------------------------------*/
 /*                               Data Structures                              */
 /*----------------------------------------------------------------------------*/
-typedef    void    Sigfunc(int);
+/* none */
 
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-int numLoops;
+/* none */
 
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
-static void sig_handler(int sig);
-
-Sigfunc *
-signal (int signo, Sigfunc *func)
-{
-    struct sigaction act, oact;
-
-    act.sa_handler = func;
-    sigemptyset (&act.sa_mask);
-    act.sa_flags = 0;
-    if (signo == SIGALRM) {
-#ifdef  SA_INTERRUPT
-        act.sa_flags |= SA_INTERRUPT;     /* SunOS 4.x */
-#endif
-    } else {
-#ifdef  SA_RESTART
-        act.sa_flags |= SA_RESTART; /* SVR4, 4.4BSD */
-#endif
-    }
-    if (sigaction (signo, &act, &oact) < 0) {
-	ParodusError ("Signal Handler for signal %d not installed!\n", signo);
-        return (SIG_ERR);
-    }
-    return (oact.sa_handler);
-}
+/* none */
 
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
 int main( int argc, char **argv)
 {
-    set_global_shutdown_reason (SHUTDOWN_REASON_PARODUS_STOP);
-    signal(SIGTERM, sig_handler);
-    signal(SIGINT, sig_handler);
-	signal(SIGUSR1, sig_handler);
-	signal(SIGUSR2, sig_handler);
-	signal(SIGQUIT, sig_handler);
-	signal(SIGHUP, sig_handler);   
-	signal(SIGALRM, sig_handler);
-#ifdef INCLUDE_BREAKPAD
-    /* breakpad handles the signals SIGSEGV, SIGBUS, SIGFPE, and SIGILL */
-    breakpad_ExceptionHandler();
-#else
-	signal(SIGSEGV, sig_handler);
-	signal(SIGBUS, sig_handler);
-	signal(SIGFPE, sig_handler);
-	signal(SIGILL, sig_handler);
-#endif	
-    ParodusCfg *cfg;
-
-	ParodusInfo ("RAND_MAX is %ld (0x%lx)\n", RAND_MAX, RAND_MAX);
-	srandom (getpid());
-
-    /* TODO not ideal, but it fixes a more major problem for now. */
-    cfg = get_parodus_cfg();
-    memset(cfg,0,sizeof(ParodusCfg));
+    ParodusCfg parodusCfg;
+    memset(&parodusCfg,0,sizeof(parodusCfg));
     
     ParodusInfo("********** Starting component: Parodus **********\n "); 
-    drop_root_privilege();
-    #ifdef ENABLE_WEBCFGBIN
-    subscribeRBUSevent();
-    regXmidtSendDataMethod();
-    #endif
-    setDefaultValuesToCfg(cfg);
-    if (0 != parseCommandLine(argc,argv,cfg)) {
-		abort();
-	}
-    curl_global_init(CURL_GLOBAL_DEFAULT);
+    parseCommandLine(argc,argv,&parodusCfg);
      
-    createSocketConnection( NULL);
+    createSocketConnection(&parodusCfg,NULL);
     
     return 0;
 }
@@ -129,51 +65,4 @@ const char *rdk_logger_module_fetch(void)
 /*----------------------------------------------------------------------------*/
 /*                             Internal functions                             */
 /*----------------------------------------------------------------------------*/
-static void sig_handler(int sig)
-{
-
-	if ( sig == SIGINT ) 
-	{
-		signal(SIGINT, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGINT received!\n");
-		shutdownSocketConnection(SHUTDOWN_REASON_PARODUS_STOP);
-	}
-	else if ( sig == SIGUSR1 ) 
-	{
-		signal(SIGUSR1, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGUSR1 received!\n");
-		shutdownSocketConnection(SHUTDOWN_REASON_SYSTEM_RESTART);
-	}
-	else if ( sig == SIGUSR2 ) 
-	{
-		signal(SIGUSR2, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGUSR2 received!\n");
-	}
-	else if ( sig == SIGTERM ) 
-	{
-		signal(SIGTERM, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGTERM received!\n");
-		shutdownSocketConnection(SHUTDOWN_REASON_SIGTERM);
-	}
-	else if ( sig == SIGCHLD ) 
-	{
-		signal(SIGCHLD, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGHLD received!\n");
-	}
-	else if ( sig == SIGPIPE ) 
-	{
-		signal(SIGPIPE, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGPIPE received!\n");
-	}
-	else if ( sig == SIGALRM ) 
-	{
-		signal(SIGALRM, sig_handler); /* reset it to this function */
-		ParodusInfo("SIGALRM received!\n");
-	}
-	else 
-	{
-		ParodusInfo("Signal %d received!\n", sig);
-		shutdownSocketConnection(SHUTDOWN_REASON_PARODUS_STOP);
-	}
-	
-}
+/* none */

src/networking.c

@@ -70,7 +70,6 @@ int checkHostIp(char * serverIP)
 	if (retVal != 0) 
 	{
 		ParodusError("getaddrinfo: %s\n", gai_strerror(retVal));
-		OnboardLog("getaddrinfo: %s\n", gai_strerror(retVal));
 	}
 	else
 	{

src/nopoll_handlers.c

@@ -1,31 +1,14 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file nopoll_handlers.c
  *
  * @description This describes nopoll handler functions.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
 #include "nopoll_handlers.h"
 #include "connection.h"
-#include "heartBeat.h"
-#include "close_retry.h"
 
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
@@ -38,7 +21,6 @@
 pthread_mutex_t g_mutex=PTHREAD_MUTEX_INITIALIZER;
 pthread_cond_t g_cond=PTHREAD_COND_INITIALIZER;
 ParodusMsg *ParodusMsgQ = NULL;
-noPollMsg * previous_msg = NULL;
 
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
@@ -57,43 +39,18 @@ void listenerOnMessage_queue(noPollCtx * ctx, noPollConn * conn, noPollMsg * msg
     UNUSED(ctx);
     UNUSED(conn);
     UNUSED(user_data);
-    noPollMsg  * aux;
-
-	if (nopoll_msg_is_fragment (msg))
-	{
-		ParodusInfo("Found fragment, FIN = %d \n", nopoll_msg_is_final (msg));
-		aux          = previous_msg;
-		previous_msg = nopoll_msg_join (previous_msg, msg);
-		nopoll_msg_unref (aux);
-
-		if (! nopoll_msg_is_final (msg)) {
-			ParodusInfo ("Found fragment that is not final..\n");
-			return;
-		}
-		ParodusInfo("Found final fragment *** \n");
-	}
 
     ParodusMsg *message;
     message = (ParodusMsg *)malloc(sizeof(ParodusMsg));
 
     if(message)
     {
-        if(previous_msg)
-        {
-			message->msg = previous_msg;
-		    message->payload = (void *)nopoll_msg_get_payload (previous_msg);
-		    message->len = nopoll_msg_get_payload_size (previous_msg);
-		    message->next = NULL;
-        }
-        else
-        {
-			message->msg = msg;
-			message->payload = (void *)nopoll_msg_get_payload (msg);
-			message->len = nopoll_msg_get_payload_size (msg);
-			message->next = NULL;
+        message->msg = msg;
+        message->payload = (void *)nopoll_msg_get_payload (msg);
+        message->len = nopoll_msg_get_payload_size (msg);
+        message->next = NULL;
 
         nopoll_msg_ref(msg);
-		}
 
         pthread_mutex_lock (&g_mutex);		
         ParodusPrint("mutex lock in producer thread\n");
@@ -122,7 +79,6 @@ void listenerOnMessage_queue(noPollCtx * ctx, noPollConn * conn, noPollMsg * msg
         //Memory allocation failed
         ParodusError("Memory allocation is failed\n");
     }
-	previous_msg = NULL;
     ParodusPrint("*****Returned from listenerOnMessage_queue*****\n");
 }
 
@@ -138,7 +94,6 @@ void listenerOnPingMessage (noPollCtx * ctx, noPollConn * conn, noPollMsg * msg,
 {
     UNUSED(ctx);
     UNUSED(user_data);
-    UNUSED(conn);
 
     noPollPtr payload = NULL;
     payload = (noPollPtr ) nopoll_msg_get_payload(msg);
@@ -148,7 +103,9 @@ void listenerOnPingMessage (noPollCtx * ctx, noPollConn * conn, noPollMsg * msg,
         ParodusInfo("Ping received with payload %s, opcode %d\n",(char *)payload, nopoll_msg_opcode(msg));
         if (nopoll_msg_opcode(msg) == NOPOLL_PING_FRAME) 
         {
-            reset_heartBeatTimer();
+            nopoll_conn_send_frame (conn, nopoll_true, nopoll_true, NOPOLL_PONG_FRAME, strlen(payload), payload, 0);
+            heartBeatTimer = 0;
+            ParodusPrint("Sent Pong frame and reset HeartBeat Timer\n");
         }
     }
 }
@@ -157,35 +114,22 @@ void listenerOnCloseMessage (noPollCtx * ctx, noPollConn * conn, noPollPtr user_
 {
     UNUSED(ctx);
     UNUSED(conn);
-    UNUSED(user_data);
-    int closeStatus;
-    char * defaultReason = "SSL_Socket_Close";
 
     ParodusPrint("listenerOnCloseMessage(): mutex lock in producer thread\n");
 
-    closeStatus = nopoll_conn_get_close_status (conn);
-    if( closeStatus == 1006 && !get_global_reconnect_status())
+    if((user_data != NULL) && (strstr(user_data, "SSL_Socket_Close") != NULL) && !LastReasonStatus)
     {
-	ParodusInfo("Reconnect detected, setting default Reconnect reason %s\n",defaultReason);
-	OnboardLog("Reconnect detected, setting default Reconnect reason %s\n",defaultReason);
-        set_global_reconnect_reason(defaultReason);
-        set_global_reconnect_status(true);
+        set_global_reconnect_reason("Server_closed_connection");
+        LastReasonStatus = true;
     }
-    else if(!get_global_reconnect_status())
+    else if ((user_data == NULL) && !LastReasonStatus)
     {
-    	ParodusInfo("Reconnect detected, setting Reconnect reason as Unknown\n");
-	OnboardLog("Reconnect detected, setting Reconnect reason as Unknown\n");
         set_global_reconnect_reason("Unknown");
     }
-    
-    if(!get_interface_down_event())
-    {
-	ParodusInfo("Setting the close and retry connection\n");
-    	set_close_retry();
-    }
-    else
-    	ParodusInfo("Not Setting the close and retry connection as interface is down\n");
 
+    pthread_mutex_lock (&close_mut);
+    close_retry = true;
+    pthread_mutex_unlock (&close_mut);
     ParodusPrint("listenerOnCloseMessage(): mutex unlock in producer thread\n");
 }
 

src/nopoll_handlers.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file nopoll_handlers.h
  *
  * @description This header defines nopoll handler functions.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #ifndef _NOPOLL_HANDLERS_H_
@@ -36,6 +21,9 @@ extern "C" {
 
 extern pthread_mutex_t g_mutex;
 extern pthread_cond_t g_cond; 
+extern pthread_mutex_t close_mut;
+extern volatile unsigned int heartBeatTimer;
+extern bool close_retry;
 
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */

src/nopoll_helpers.c

@@ -1,32 +1,15 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file nopoll_helpers.c
  *
  * @description This file is used to manage incomming and outgoing messages.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
 #include "connection.h"
 #include "nopoll_helpers.h"
 #include "nopoll_handlers.h"
-#include "time.h"
-#include "config.h"
 
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
@@ -35,10 +18,6 @@
 #define MAX_SEND_SIZE (60 * 1024)
 #define FLUSH_WAIT_TIME (2000000LL)
 
-struct timespec connStuck_start,connStuck_end;
-struct timespec *connStuck_startPtr = &connStuck_start;
-struct timespec *connStuck_endPtr = &connStuck_end;
-
 /*----------------------------------------------------------------------------*/
 /*                             External functions                             */
 /*----------------------------------------------------------------------------*/
@@ -50,36 +29,27 @@ void setMessageHandlers()
     nopoll_conn_set_on_close(get_global_conn(), (noPollOnCloseHandler)listenerOnCloseMessage, NULL);
 }
 
-static int cloud_status_is_online (void)
-{
-	const char *status = get_cloud_status();
-	if (NULL == status)
-	  return false;
-	return (strcmp (status, CLOUD_STATUS_ONLINE) == 0);
-}
-
 /** To send upstream msgs to server ***/
 
-int sendMessage(noPollConn *conn, void *msg, size_t len)
+void sendMessage(noPollConn *conn, void *msg, size_t len)
 {
     int bytesWritten = 0;
 
-    if (!cloud_status_is_online ()) {
-        ParodusError("Failed to send msg upstream as connection is not OK\n");
-        OnboardLog("Failed to send msg upstream as connection is not OK\n");
-		return 1;
-	}
-
     ParodusInfo("sendMessage length %zu\n", len);
-
-    bytesWritten = sendResponse(conn, msg, len);
-    ParodusPrint("Number of bytes written: %d\n", bytesWritten);
-    if (bytesWritten != (int) len) 
+    if(nopoll_conn_is_ok(conn) && nopoll_conn_is_ready(conn))
     {
-        ParodusError("Failed to send bytes %zu, bytes written were=%d (errno=%d, %s)..\n", len, bytesWritten, errno, strerror(errno));
-	return 1;
+        //bytesWritten = nopoll_conn_send_binary(conn, msg, len);
+        bytesWritten = sendResponse(conn, msg, len);
+        ParodusPrint("Number of bytes written: %d\n", bytesWritten);
+        if (bytesWritten != (int) len) 
+        {
+            ParodusError("Failed to send bytes %zu, bytes written were=%d (errno=%d, %s)..\n", len, bytesWritten, errno, strerror(errno));
+        }
+    }
+    else
+    {
+        ParodusError("Failed to send msg upstream as connection is not OK\n");
     }
-	return 0;
 }
 
 int sendResponse(noPollConn * conn, void * buffer, size_t length)
@@ -100,7 +70,7 @@ int sendResponse(noPollConn * conn, void * buffer, size_t length)
         {
             if (-1 == bytes_sent || (bytes_sent = nopoll_conn_flush_writes(conn, FLUSH_WAIT_TIME, bytes_sent)) != len_to_send)
             {
-                ParodusError("sendResponse() Failed to send all the data\n");
+                ParodusPrint("sendResponse() Failed to send all the data\n");
                 cp = NULL;
                 break;
             }
@@ -136,7 +106,6 @@ void __report_log (noPollCtx * ctx, noPollDebugLevel level, const char * log_msg
     if (level == NOPOLL_LEVEL_CRITICAL) 
     {
         ParodusError("%s\n", log_msg );
-	OnboardLog("%s\n", log_msg );
     }
     return;
 }

src/nopoll_helpers.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file nopoll_handlers.h
  *
  * @description This header defines functions to manage incomming and outgoing messages.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #ifndef _NOPOLL_HELPERS_H_
@@ -41,7 +26,7 @@ extern "C" {
  */
 int sendResponse(noPollConn * conn,void *str, size_t bufferSize);
 void setMessageHandlers();
-int sendMessage(noPollConn *conn, void *msg, size_t len);
+void sendMessage(noPollConn *conn, void *msg, size_t len);
 
 /**
  * @brief __report_log Nopoll log handler 

src/parodus_log.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file parodus_log.h
  *
  * @description This header defines parodus log levels
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #include <stdarg.h>
@@ -33,9 +18,3 @@
 #define ParodusError(...)                   cimplog_error(LOGGING_MODULE, __VA_ARGS__)
 #define ParodusInfo(...)                    cimplog_info(LOGGING_MODULE, __VA_ARGS__)
 #define ParodusPrint(...)                   cimplog_debug(LOGGING_MODULE, __VA_ARGS__)
-#ifdef FEATURE_SUPPORT_ONBOARD_LOGGING
-#define OnboardLog(...)                     onboarding_log(LOGGING_MODULE, __VA_ARGS__)
-#else
-#define OnboardLog(...)
-#endif
-

src/partners_check.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file partners_check.c
  *
  * @description This describes functions to validate partner_id.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
@@ -39,184 +24,85 @@
 /*----------------------------------------------------------------------------*/
 /*                             External functions                             */
 /*----------------------------------------------------------------------------*/
-static void parse_partner_id(char *partnerId, partners_t **partnersList)
-{
-    char *token;
-    int i = 0, j = 0, count = 0;
-    ParodusPrint("********* %s ********\n",__FUNCTION__);
-    while(partnerId[i] != '\0')
-    {
-        if(partnerId[i] == ',')
-        {
-            count++;
-        }
-        i++;
-    }
-    ParodusPrint("count = %d\n", count+1);
-    *partnersList = (partners_t *)malloc(sizeof(partners_t)+ sizeof( char * ) * (count+1));
-    memset(*partnersList, 0, sizeof(partners_t));
-    (*partnersList)->count = count+1;
-    while ((token = strsep(&partnerId, ",")) != NULL)
-    {
-        ParodusPrint("token=%s\n", token);
-        (*partnersList)->partner_ids[j] = strdup(token);
-        ParodusPrint("(*partnersList)->partner_ids[%d] = %s\n",j,(*partnersList)->partner_ids[j]);
-        j++;
-    }
-}
-
 int validate_partner_id(wrp_msg_t *msg, partners_t **partnerIds)
 {
     int matchFlag = 0, i = 0, count = 0;
-    size_t j = 0;
-    partners_t *partnersList = NULL;
-    char *partnerId = NULL;
     ParodusPrint("********* %s ********\n",__FUNCTION__);
-    char *temp = get_parodus_cfg()->partner_id;
-    ParodusPrint("temp = %s\n",temp);
-    if(temp[0] != '\0' && strlen(temp) > 0)
-    {
-        partnerId = strdup(temp);
-    }
-    ParodusPrint("partnerId = %s\n",partnerId);
-    if(partnerId != NULL)
-    {
-        parse_partner_id(partnerId, &partnersList);
-        ParodusPrint("partnersList->count = %lu\n", partnersList->count);
-        if(msg->msg_type == WRP_MSG_TYPE__EVENT)
-        {
-            if(msg->u.event.partner_ids != NULL)
-            {
-                count = (int) msg->u.event.partner_ids->count;
-                ParodusPrint("partner_ids count is %d\n",count);
-                for(i = 0; i < count; i++)
-                {
-                    for(j = 0; j<partnersList->count; j++)
-                    {
-			if(NULL != partnersList->partner_ids[j]) {
-		                ParodusPrint("partnersList->partner_ids[%lu] = %s\n",j, partnersList->partner_ids[j]);
-				ParodusPrint("msg->u.event.partner_ids->partner_ids[%lu] = %s\n",i, msg->u.event.partner_ids->partner_ids[i]);
-		                if(strcasecmp(partnersList->partner_ids[j], msg->u.event.partner_ids->partner_ids[i]) == 0)
-		                {
-		                    ParodusInfo("partner_id match found\n");
-		                    matchFlag = 1;
-		                    break;
-		                }
-			}
-			else
-				ParodusError("partner Id in partnersList is NULL but count is not 0");
-                    }
-                    /* Commandline input partner_ids matched with partner_ids from request */
-                    if(matchFlag == 1)
-                    {
-                        break;
-                    }
-                }
-
-                /* Commandline input partner_ids not matching with partner_ids from request, appending to request partner_ids*/
-                if(matchFlag != 1)
-                {
-                    (*partnerIds) = (partners_t *) malloc(sizeof(partners_t) + (sizeof(char *) * (count+partnersList->count)));
-                    (*partnerIds)->count = count+partnersList->count;
-                    for(i = 0; i < count; i++)
-                    {
-                        (*partnerIds)->partner_ids[i] = msg->u.event.partner_ids->partner_ids[i];
-                        ParodusPrint("(*partnerIds)->partner_ids[%d] : %s\n",i,(*partnerIds)->partner_ids[i]);
-                    }
-                    i = 0;
-                    for(j = count; j<(count+partnersList->count); j++)
-                    {
-                        (*partnerIds)->partner_ids[j] = (char *) malloc(sizeof(char) * 64);
-                        parStrncpy((*partnerIds)->partner_ids[j], partnersList->partner_ids[i], 64);
-                        ParodusPrint("(*partnerIds)->partner_ids[%lu] : %s\n",j,(*partnerIds)->partner_ids[j]);
-                        i++;
-                    }
-                }
-            }
-            else
-            {
-                ParodusPrint("partner_ids list is NULL\n");
-                (*partnerIds) = (partners_t *) malloc(sizeof(partners_t) + (sizeof(char *) * partnersList->count));
-                (*partnerIds)->count = partnersList->count;
-                i=0;
-                for(j = 0; j<partnersList->count; j++)
-                {
-                    (*partnerIds)->partner_ids[j] = (char *) malloc(sizeof(char) * 64);
-                    parStrncpy((*partnerIds)->partner_ids[j], partnersList->partner_ids[i], 64);
-                    ParodusPrint("(*partnerIds)->partner_ids[%lu] : %s\n",j,(*partnerIds)->partner_ids[j]);
-                    i++;
-                }
-            }
-        }
-        else if(msg->msg_type == WRP_MSG_TYPE__REQ)
-        {
-            if(msg->u.req.partner_ids != NULL)
-            {
-                count = (int) msg->u.req.partner_ids->count;
-                ParodusPrint("partner_ids count is %d\n",count);
-                for(i = 0; i < count; i++)
-                {
-                    for(j = 0; j<partnersList->count; j++)
-                    {
-			if(NULL != partnersList->partner_ids[j]) 
-			{
-		                ParodusPrint("partnersList->partner_ids[%lu] = %s\n",j, partnersList->partner_ids[j]);
-				ParodusPrint("msg->u.req.partner_ids->partner_ids[%lu] = %s\n",i, msg->u.req.partner_ids->partner_ids[i]);
-		                if(strcasecmp(partnersList->partner_ids[j], msg->u.req.partner_ids->partner_ids[i]) == 0)
-		                {
-		                    ParodusInfo("partner_id match found\n");
-		                    matchFlag = 1;
-		                    break;
-		                }
-			}
-			else
-				ParodusError("partner Id in partnersList is NULL but count is not 0");
-                    }
-                }
-
-                /* Commandline input partner_ids not matching with partner_ids from request, ignoring request*/
-                if(matchFlag != 1)
-                {
-                    ParodusError("Invalid partner_id %s\n",temp);
-                    OnboardLog("Invalid partner_id %s\n",temp);
-                    if(partnersList != NULL)
-                    {
-                        for(j=0; j<partnersList->count; j++)
-                        {
-                            if(NULL != partnersList->partner_ids[j])
-                            {
-                                free(partnersList->partner_ids[j]);
-                            }
-                        }
-                        free(partnersList);
-                    }
-                    free(partnerId);
-                    return -1;
-                }
-            }
-            else
-            {
-                ParodusPrint("partner_ids list is NULL\n");
-            }
-        }
-        if(partnersList != NULL)
-        {
-            for(j=0; j<partnersList->count; j++)
-            {
-                if(NULL != partnersList->partner_ids[j])
-                {
-                    free(partnersList->partner_ids[j]);
-                }
-            }
-            free(partnersList);
-        }
-        free(partnerId);
-    }
-    else
+    char *partnerId = get_parodus_cfg()->partner_id;
+    if(strlen(partnerId) <= 0)
     {
         ParodusPrint("partner_id is not available to validate\n");
         return 0;
     }
+    
+    if(msg->msg_type == WRP_MSG_TYPE__EVENT)
+    {
+        if(msg->u.event.partner_ids != NULL)
+        {
+            count = (int) msg->u.event.partner_ids->count;
+            ParodusPrint("partner_ids count is %d\n",count);
+            for(i = 0; i < count; i++)
+            {
+                if(strcmp(partnerId, msg->u.event.partner_ids->partner_ids[i]) == 0)
+                {
+                    ParodusInfo("partner_id match found\n");
+                    matchFlag = 1;
+                    break;
+                }
+            }
+            
+            if(matchFlag != 1)
+            {
+                (*partnerIds) = (partners_t *) malloc(sizeof(partners_t));
+                (*partnerIds)->count = count+1;
+                for(i = 0; i < count; i++)
+                {
+                    (*partnerIds)->partner_ids[i] = msg->u.event.partner_ids->partner_ids[i];
+                    ParodusPrint("(*partnerIds)->partner_ids[%d] : %s\n",i,(*partnerIds)->partner_ids[i]);
+                }
+                (*partnerIds)->partner_ids[count] = (char *) malloc(sizeof(char) * 64);
+                strcpy((*partnerIds)->partner_ids[count], partnerId);
+                ParodusPrint("(*partnerIds)->partner_ids[%d] : %s\n",count,(*partnerIds)->partner_ids[count]);
+            }
+        }
+        else
+        {
+            ParodusPrint("partner_ids list is NULL\n");
+            (*partnerIds) = (partners_t *) malloc(sizeof(partners_t));
+            (*partnerIds)->count = 1;
+            (*partnerIds)->partner_ids[0] = (char *) malloc(sizeof(char) * 64);
+            strcpy((*partnerIds)->partner_ids[0], partnerId);
+            ParodusPrint("(*partnerIds)->partner_ids[0] : %s\n",(*partnerIds)->partner_ids[0]);
+        }
+    }
+    else if(msg->msg_type == WRP_MSG_TYPE__REQ)
+    {
+        if(msg->u.req.partner_ids != NULL)
+        {
+            count = (int) msg->u.req.partner_ids->count;
+            ParodusPrint("partner_ids count is %d\n",count);
+            for(i = 0; i < count; i++)
+            {
+                if(strcmp(partnerId, msg->u.req.partner_ids->partner_ids[i]) == 0)
+                {
+                    ParodusInfo("partner_id match found\n");
+                    matchFlag = 1;
+                    break;
+                }
+            }
+
+            if(matchFlag != 1)
+            {
+                ParodusError("Invalid partner_id %s\n",partnerId);
+                return -1;
+            }
+        }
+        else
+        {
+            ParodusPrint("partner_ids list is NULL\n");
+        }
+    }
+    
     return 1;
 }
 

src/partners_check.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file partners_check.h
  *
  * @description This describes functions to validate partner_id.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _PARTNERS_CHECK_H_

src/privilege.c

@@ -1,6 +0,0 @@
-#include "privilege.h"
-
-void drop_root_privilege()
-{
-
-}

src/privilege.h

@@ -1,2 +0,0 @@
-/* This is a stub function that will be overridden in a patch */
-void drop_root_privilege();

src/service_alive.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file service_alive.c
  *
  * @description This file is used to manage keep alive section
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
@@ -31,41 +16,9 @@
 /*----------------------------------------------------------------------------*/
 #define KEEPALIVE_INTERVAL_SEC                         	30
 
-pthread_mutex_t svc_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t svc_con=PTHREAD_COND_INITIALIZER;
-
-/*----------------------------------------------------------------------------*/
-/*                             Utiliy Functions                               */
-/*----------------------------------------------------------------------------*/
-static int wait__ (unsigned int secs)
-{
-  int shutdown_flag;
-  struct timespec svc_alive_timer;
-
-  clock_gettime(CLOCK_REALTIME, &svc_alive_timer);
-  svc_alive_timer.tv_sec += secs;
-  pthread_mutex_lock(&svc_mut);
-  pthread_cond_timedwait (&svc_con, &svc_mut, &svc_alive_timer);
-  shutdown_flag = g_shutdown;
-  pthread_mutex_unlock (&svc_mut);
-  return shutdown_flag;
-}
-
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
-
-pthread_cond_t *get_global_svc_con(void)
-{
-    return &svc_con;
-}
-
-pthread_mutex_t *get_global_svc_mut(void)
-{
-    return &svc_mut;
-}
-
-
 /*
  * @brief To handle registered services to indicate that the service is still alive.
  */
@@ -90,10 +43,10 @@ void *serviceAliveTask()
 	        while(1)
 	        {
 		        ParodusPrint("serviceAliveTask: numOfClients registered is %d\n", get_numOfClients());
-		        temp = get_global_node();
 		        if(get_numOfClients() > 0)
 		        {
 			        //sending svc msg to all the clients every 30s
+			        temp = get_global_node();
 			        size = (size_t) nbytes;
 			        while(NULL != temp)
 			        {
@@ -114,9 +67,8 @@ void *serviceAliveTask()
 				        byte = 0;
 				        if(ret == 0)
 				        {
-						release_global_node ();
+					        ParodusPrint("Deletion from list is success, doing resync with head\n");
 					        temp= get_global_node();
-					        ParodusInfo("Deletion from list is success, doing resync with head\n");
 					        ret = -1;
 				        }
 				        else
@@ -124,20 +76,15 @@ void *serviceAliveTask()
 					        temp= temp->next;
 				        }
 			        }
-				release_global_node ();
 		         	ParodusPrint("Waiting for 30s to send keep alive msg \n");
-		         	if (wait__ (KEEPALIVE_INTERVAL_SEC))
-				  break;
+		         	sleep(KEEPALIVE_INTERVAL_SEC);
 	            	}
 	            	else
 	            	{
-				release_global_node ();
 	            		ParodusInfo("No clients are registered, waiting ..\n");
-	            		if (wait__ (50))
-				  break;
+	            		sleep(70);
 	            	}
 	        }
-		free (svc_bytes);
 	}
 	return 0;
 }

src/service_alive.h

@@ -1,31 +1,14 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file service_alive.h
  *
  * @description This file is used to manage keep alive section
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _SERVICE_ALIVE_H_
 #define _SERVICE_ALIVE_H_
 
-#include <pthread.h>
-
 /*----------------------------------------------------------------------------*/
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
@@ -35,8 +18,7 @@ extern "C" {
 #endif
   
 void *serviceAliveTask();
-pthread_cond_t *get_global_svc_con(void);
-pthread_mutex_t *get_global_svc_mut(void);
+
 
 #ifdef __cplusplus
 }

src/seshat_interface.c

@@ -1,81 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file seshat_interface.c
- *
- * @description This decribes interface to register seshat service.
- *
- */
- 
-#include "seshat_interface.h"
-#include "ParodusInternal.h"
-#include "config.h"
-#include <libseshat.h>
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-#define SESHAT_SERVICE_NAME                             "Parodus"
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-
-/*----------------------------------------------------------------------------*/
-/*                             Internal Functions                             */
-/*----------------------------------------------------------------------------*/
-
-
-/*----------------------------------------------------------------------------*/
-/*                             External functions                             */
-/*----------------------------------------------------------------------------*/
-
-bool __registerWithSeshat()
-{
-    char *seshat_url = get_parodus_cfg()->seshat_url;
-    char *parodus_url = get_parodus_cfg()->local_url;
-    char *discover_url = NULL;
-    bool rv = false;
-
-    if( 0 == init_lib_seshat(seshat_url) ) {
-        ParodusInfo("seshatlib initialized! (url %s)\n", seshat_url);
-
-        if( 0 == seshat_register(SESHAT_SERVICE_NAME, parodus_url) ) {
-            ParodusInfo("seshatlib registered! (url %s)\n", parodus_url);
-
-            discover_url = seshat_discover(SESHAT_SERVICE_NAME);
-            if( (NULL != discover_url) && (0 == strcmp(parodus_url, discover_url)) ) {
-                ParodusInfo("seshatlib discovered url = %s\n", discover_url);
-                rv = true;
-            } else {
-                ParodusError("seshatlib registration error (url %s)!", discover_url);
-            }
-            free(discover_url);
-        } else {
-            ParodusError("seshatlib not registered! (url %s)\n", parodus_url);
-        }
-    } else {
-        ParodusPrint("seshatlib not initialized! (url %s)\n", seshat_url);
-    }
-
-    shutdown_seshat_lib();
-    return rv;
-}

src/seshat_interface.h

@@ -1,54 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file seshat_interface.h
- *
- * @description This header defines interface to register seshat service.
- *
- */
- 
-#ifndef _SESHAT_INTERFACE_H_
-#define _SESHAT_INTERFACE_H_
-
-#include <stdbool.h>
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-/**
- * @brief Helper function to register with seshat.
- * 
- * @note return whether successfully registered.
- *
- * @return true when registered, false otherwise.
- */
-bool __registerWithSeshat();
-   
-#ifdef __cplusplus
-}
-#endif
-    
-#endif

src/seshat_interface_stub.c

@@ -1,53 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file seshat_interface_stub.c
- *
- * @description This decribes interface to register seshat service
- *
- */
- 
-#include "seshat_interface.h"
-#include "ParodusInternal.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-
-/*----------------------------------------------------------------------------*/
-/*                             Internal Functions                             */
-/*----------------------------------------------------------------------------*/
-
-
-/*----------------------------------------------------------------------------*/
-/*                             External functions                             */
-/*----------------------------------------------------------------------------*/
-
-bool __registerWithSeshat()
-{
-    ParodusInfo("libseshat disabled, Hence proceeding without registration\n");
-    return true;
-}

src/spin_thread.c

@@ -1,28 +1,14 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file spin_thread.c
  *
  * @description This file is used to define thread function
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #include <stdlib.h>
 #include <string.h>
+#include <pthread.h>
 
 #include "spin_thread.h"
 #include "parodus_log.h"
@@ -30,12 +16,12 @@
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
-void StartThread(void *(*start_routine) (void *), pthread_t *threadId)
+void StartThread(void *(*start_routine) (void *))
 {
     int err = 0;
-	pthread_t __threadId;
+	pthread_t threadId;
 
-	err = pthread_create(&__threadId, NULL, start_routine, NULL);
+	err = pthread_create(&threadId, NULL, start_routine, NULL);
 	if (err != 0) 
 	{
 		ParodusError("Error creating thread :[%s]\n", strerror(err));
@@ -43,13 +29,8 @@ void StartThread(void *(*start_routine) (void *), pthread_t *threadId)
 	}
 	else
 	{
-		*threadId = __threadId;
-		ParodusPrint("Thread created Successfully %lu\n", (unsigned long) __threadId);
+		ParodusPrint("Thread created Successfully %d\n", (int ) threadId);
 	}    
 }
 
-
-void JoinThread (pthread_t threadId)
-{
-  pthread_join (threadId, NULL);
-}
+         

src/spin_thread.h

@@ -1,31 +1,14 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file spin_thread.h
  *
  * @description This file is used to define thread function
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _SPIN_THREAD_H_
 #define _SPIN_THREAD_H_
 
-#include <pthread.h>
-
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -34,8 +17,8 @@ extern "C" {
 /*                             Function Prototypes                            */
 /*----------------------------------------------------------------------------*/
 
-void StartThread(void *(*start_routine) (void *), pthread_t *threadId);
-void JoinThread (pthread_t threadId);
+void StartThread(void *(*start_routine) (void *));
+
 
 #ifdef __cplusplus
 }

src/thread_tasks.c

@@ -43,10 +43,6 @@ void *messageHandlerTask()
         }
         else
         {
-            if (g_shutdown) {
-                pthread_mutex_unlock (&g_mutex);
-                break;
-            }
             ParodusPrint("Before pthread cond wait in consumer thread\n");
             pthread_cond_wait(&g_cond, &g_mutex);
             pthread_mutex_unlock (&g_mutex);

src/thread_tasks.h

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file thread_tasks.h
  *
  * @description This header defines thread functions.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _THREAD_TASKS_H_

src/time.c

@@ -34,7 +34,7 @@ uint64_t getCurrentTimeInMicroSeconds(struct timespec *timer)
     ParodusPrint("timer->tv_sec : %lu\n",timer->tv_sec);
     ParodusPrint("timer->tv_nsec : %lu\n",timer->tv_nsec);
     systime = (uint64_t)timer->tv_sec * 1000000L + timer->tv_nsec/ 1000;
-    return systime;
+    return systime;	
 }
 
 long timeValDiff(struct timespec *starttime, struct timespec *finishtime)

src/token.c

@@ -1,548 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file token.c
- *
- * @description This file contains operations for using jwt token.
- *
- */
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdbool.h>
-#include <unistd.h>
-#include <netinet/in.h>
-#ifdef FEATURE_DNS_QUERY
-#include <ucresolv.h>
-#endif
-//#include <res_update.h>
-#include <netdb.h>
-#include <strings.h>
-#include <string.h>
-
-#include <assert.h>
-#include <sys/types.h>
-#include <sys/param.h>
-#include <arpa/inet.h>
-#include <arpa/nameser.h>
-#include <ctype.h>
-#include <errno.h>
-#include <time.h>
-
-#include <cjwt/cjwt.h>
-#include "token.h"
-#include "config.h"
-#include "parodus_log.h"
-#include "ParodusInternal.h"
-
-#define JWT_MAXBUF	8192
-
-#ifdef NS_MAXMSG
-#if NS_MAXMSG > JWT_MAXBUF
-#define NS_MAXBUF JWT_MAXBUF
-#else
-#define NS_MAXBUF NS_MAXMSG
-#endif
-#else
-#define NS_MAXBUF JWT_MAXBUF
-#endif
-
-#define TXT_REC_ID_MAXSIZE	128
-
-#define MAX_RR_RECS 10
-#define SEQ_TABLE_SIZE (MAX_RR_RECS + 1)
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-#define ENDPOINT_NAME "endpoint"
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-/* none */
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-/* none */
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-#ifdef FEATURE_DNS_QUERY
-
-extern int __res_ninit(res_state statp);
-extern void __res_nclose(res_state statp);
-extern int __res_nquery(res_state statp,
-	   const char *name,	/* domain name */
-	   int class, int type,	/* class and type of query */
-	   u_char *answer,	/* buffer to put answer */
-	   int anslen);		/* size of answer buffer */
-
-/*----------------------------------------------------------------------------*/
-/*                             Internal functions                             */
-/*----------------------------------------------------------------------------*/
-
-
-static void show_times (time_t exp_time, time_t cur_time)
-{
-	char exp_buf[30];
-	char cur_buf[30];
-	ctime_r (&exp_time, exp_buf);
-	exp_buf[strlen(exp_buf)-1] = 0;
-	ctime_r (&cur_time, cur_buf);
-	cur_buf[strlen(cur_buf)-1] = 0;
-	ParodusInfo ("Exp: %d %s, Current: %d %s\n", 
-		(int)exp_time, exp_buf+4, (int)cur_time, cur_buf+4);
-}
-
-// returns 1 if insecure, 0 if secure, < 0 if error
-int analyze_jwt (const cjwt_t *jwt, char **url_buf, unsigned int *port)
-{
-	cJSON *claims = jwt->private_claims;
-	cJSON *endpoint = NULL;
-	time_t exp_time, cur_time;
-	int http_match;
-
-	if (!claims) {
-		ParodusError ("Private claims not found in jwt\n");
-		return TOKEN_ERR_INVALID_JWT_CONTENT;
-	}
-
-	endpoint = cJSON_GetObjectItem(claims, ENDPOINT_NAME);
-	if (!endpoint) {
-		ParodusError ("Endpoint claim not found in jwt\n");
-		return TOKEN_ERR_INVALID_JWT_CONTENT;
-	}
-
-	ParodusInfo ("JWT endpoint: %s\n", endpoint->valuestring);
-	exp_time = jwt->exp.tv_sec;
-	if (0 == exp_time) {
-		ParodusError ("exp not found in JWT payload\n");
-		return TOKEN_ERR_NO_EXPIRATION;
-	} else {
-		cur_time = time(NULL);
-		show_times (exp_time, cur_time);
-		if (exp_time < cur_time) {
-			ParodusError ("JWT has expired\n");
-			OnboardLog ("JWT has expired\n");
-			return TOKEN_ERR_JWT_EXPIRED;
-		}
-	}
-	http_match = parse_webpa_url (endpoint->valuestring,
-		url_buf, port);
-	if (http_match < 0) {
-		ParodusError ("Invalid endpoint claim in JWT\n");
-		OnboardLog("Invalid endpoint claim in JWT\n");
-		return TOKEN_ERR_BAD_ENDPOINT;
-	}
-	ParodusInfo ("JWT is_http strncmp: %d\n", http_match);
-
-	return http_match;
-}
-
-bool validate_algo(const cjwt_t *jwt)
-{
-	// return true if jwt->header.alg is included in the set
-	// of allowed algorithms specified by cfg->jwt_algo
-	ParodusCfg *cfg = get_parodus_cfg();
-        int alg = jwt->header.alg;
-        int alg_mask;
-
-	if ((alg < 0) || (alg >= num_algorithms))
-		return false;
-	alg_mask = 1<<alg;
-	if ((alg_mask & cfg->jwt_algo) == 0) {
-		ParodusError ("Algorithm %d not allowed (mask %d)\n", alg, alg_mask); 
-		return false;
-	}
-	return true;
-}
-
-
-int nquery(const char* dns_txt_record_id, u_char *nsbuf)
-{
-	
-    int len;
-    struct __res_state statp;
-
-    /* Initialize resolver */
-		memset (&statp, 0, sizeof(__res_state));
-		if (NULL == nsbuf) {
-			ParodusError ("nquery: nsbuf is NULL\n");
-			return (-1);
-		}
-		statp.options = RES_DEBUG;
-    if (__res_ninit(&statp) < 0) {
-        ParodusError ("res_ninit error: can't initialize statp.\n");
-        return (-1);
-    }
-
-		ParodusInfo ("nquery: domain : %s\n", dns_txt_record_id);
-		memset (nsbuf, 0, NS_MAXBUF);
-		len = __res_nquery(&statp, dns_txt_record_id, ns_c_in, ns_t_txt, nsbuf, NS_MAXBUF);
-    if (len < 0) {
-				if (0 != statp.res_h_errno) {
-					const char *msg = hstrerror (statp.res_h_errno);
-        	ParodusError ("Error in res_nquery: %s\n", msg);
-				}
-        return len;
-    }
-    __res_nclose (&statp);
-	ParodusInfo ("nquery: nsbuf (1) 0x%lx\n", (unsigned long) nsbuf);
-    if (len >= NS_MAXBUF) {
-        ParodusError ("res_nquery error: ns buffer too small.\n");
-        return -1;
-    }
-
-    return len;
-
-}
-
-bool valid_b64_char (char c)
-{
-	if ((c>='A') && (c<='Z'))
-		return true;
-	if ((c>='a') && (c<='z'))
-		return true;
-	if ((c>='0') && (c<='9'))
-		return true;
-  if ((c=='/') || (c=='+') || (c=='-') || (c=='_'))
-		return true;
-	return false;
-}
-
-static bool is_digit (char c)
-{
-	return (bool) ((c>='0') && (c<='9'));
-}
-
-// strip quotes and newlines from rr rec
-const char *strip_rr_data (const char *rr_ptr, int *rrlen)
-{
-	int len = *rrlen;
-	const char *optr = rr_ptr;
-	char c;
-
-	if (len > 0) {
-		c = optr[0];
-		if (!is_digit(c)) {
-			optr++;
-			len--;
-		}
-	}
-	if (len > 0) {
-		if (!valid_b64_char (optr[len-1]))
-			len--;
-	}
-	if (len > 0) {
-		if (!valid_b64_char (optr[len-1]))
-			len--;
-	}
-	*rrlen = len;
-	return optr;
-}
-
-// return offset to seq number in record
-// return -1 if not found, -2 if invalid fmt
-int find_seq_num (const char *rr_ptr, int rrlen)
-{
-	char c;
-	int i;
-	int digit_ct = 0;
-
-	for (i=0; i<rrlen; i++)
-	{
-		c = rr_ptr[i];
-		if (c == ':') {
-			if (digit_ct >= 2)
-				return i - 2;
-			else
-				return -2;
-		}
-		if (is_digit (c))
-			digit_ct++;
-		else
-			digit_ct = 0;
-	}
-	return -1;		
-}
-
-// get seq num in rr rec
-// return -1 if not formatted correctly
-int get_rr_seq_num (const char *rr_ptr, int rrlen)
-{
-	char c;
-	int lo, hi;
-	if (rrlen < 3)
-		return -1;
-	if (rr_ptr[2] != ':')
-		return -1;
-	c = rr_ptr[0];
-	if (is_digit (c))
-		hi = c - '0';
-	else
-		return -1;
-	c = rr_ptr[1];
-	if (is_digit (c))
-		lo = c - '0';
-	else
-		return -1;
-	return (10*hi) + lo;
-}
-
-// scan rr recs and build seq table using seq numbers in the recs
-// return num_txt_recs
-int get_rr_seq_table (ns_msg *msg_handle, int num_rr_recs, rr_rec_t *seq_table)
-{
-	ns_rr rr;
-	const char *rr_ptr;
-	int seq_pos;
-	int rrlen;
-	int i, ret, seq_num;
-	int num_txt_recs = 0;
-
-	if (num_rr_recs > MAX_RR_RECS) {
-		ParodusError ("num rr recs (%d) to big, > %d\n", num_rr_recs, MAX_RR_RECS);
-		return -1;
-	}
-	// clear seq table
-	for (i=0; i<SEQ_TABLE_SIZE; i++)
-	{
-		seq_table[i].rr_ptr = NULL;
-		seq_table[i].rr_len = 0;
-	}
-
-	// extract and concatenate all the records in rr
-	for (i=0; i<num_rr_recs; i++) {
-		ret = ns_parserr(msg_handle, ns_s_an, i, &rr);
-		if (ret != 0) {
-			ParodusError ("query_dns: ns_parserr failed: %s\n", strerror (errno));
-			return ret;
-		}
-		if (ns_rr_type(rr) != ns_t_txt)
-    	continue;
-		++num_txt_recs;
-    rr_ptr = (const char *)ns_rr_rdata(rr);
-    rrlen = ns_rr_rdlen(rr);
-		ParodusPrint ("Found rr rec type %d: %s\n", ns_t_txt, rr_ptr);
-		rr_ptr = strip_rr_data (rr_ptr, &rrlen);		
-		seq_pos = find_seq_num (rr_ptr, rrlen);
-		if (seq_pos == -2) {
-			ParodusError ("Invalid seq number in rr record %d\n", i);
-			return -1;
-		}
-		if (seq_pos < 0) {
-			seq_num = 0;
-		} else {
-			rr_ptr += seq_pos;
-			rrlen -= seq_pos;
-			seq_num = get_rr_seq_num (rr_ptr, rrlen);
-		}
-		ParodusPrint ("Found seq num %d in rr rec %d\n", seq_num, i);
-
-		if (seq_num < 0) {
-			ParodusError ("Seq number not found in rr record %d\n", i);
-			return -1;
-		}
-		if (seq_num > num_rr_recs) {
-			ParodusError ("Invalid seq number (too big) in rr record %d\n", i);
-			return -1;
-		}
-		if (NULL != seq_table[seq_num].rr_ptr) {
-			ParodusError ("Duplicate rr record number %d\n", seq_num);
-			return -1;
-		}
-		if (seq_num != 0) {
-			rr_ptr += 3; // skip the seq number
-			rrlen -= 3;
-		}
-		seq_table[seq_num].rr_ptr = rr_ptr;
-		seq_table[seq_num].rr_len = rrlen;
-	}
-
-	if (NULL != seq_table[0].rr_ptr) {
-		// sequence-less record should not be used when there
-		// are multiple records
-		if (num_txt_recs > 1) {
-			ParodusError ("Seq number not found in rr record\n");
-			return -1;
-		}
-		// when there is only one record, use the sequence-less record
-		seq_table[1].rr_ptr = seq_table[0].rr_ptr;
-		seq_table[1].rr_len = seq_table[0].rr_len;
-	}
-
-	// check if we got them all
-	for (i=1; i<num_txt_recs; i++) {
-		if (NULL == seq_table[i].rr_ptr) {
-			ParodusError ("Missing rr record number %d\n", i+1);
-			return -1;
-		}
-	}
-	return num_txt_recs;
-}
-
-int assemble_jwt_from_dns (ns_msg *msg_handle, int num_rr_recs, char *jwt_ans)
-{
-	// slot 0 in the seq table is for the sequence-less record that
-	// you get when there is only one record.
-	rr_rec_t seq_table[SEQ_TABLE_SIZE];
-	int i;
-	int num_txt_recs = get_rr_seq_table (msg_handle, num_rr_recs, seq_table);
-
-	if (num_txt_recs < 0)
-		return num_txt_recs;
-	ParodusPrint ("Found %d TXT records\n", num_txt_recs);
-	jwt_ans[0] = 0;
-	for (i=1; i<=num_txt_recs; i++)
-		strncat (jwt_ans, seq_table[i].rr_ptr, seq_table[i].rr_len);
-	return 0;
-}
-
-int query_dns(const char* dns_txt_record_id,char *jwt_ans)
-{
-	u_char *nsbuf;
-	ns_msg msg_handle;
-	int ret;
-	int l = -1;
-	
-	if( !dns_txt_record_id || !jwt_ans )
-		return l;
-   
-	nsbuf = (u_char *) malloc (NS_MAXBUF);
-	ParodusInfo ("nsbuf (1) 0x%lx\n", (unsigned long) nsbuf);
-	if (NULL == nsbuf) {
-		ParodusError ("Unable to allocate nsbuf in query_dns\n");
-		return TOKEN_ERR_MEMORY_FAIL;
-	}
-	
-	l = nquery(dns_txt_record_id,nsbuf);
-	if (l < 0) {
-		ParodusError("nquery returns error: l value is %d\n", l);
-		free (nsbuf);
-		return l;
-	}
-	ParodusInfo ("nsbuf (2) 0x%lx\n", (unsigned long) nsbuf);
-
-/*--
-	memset((void *) &msg_handle, 0x5e, sizeof (ns_msg));
-	ParodusInfo ("nsbuf (3) 0x%lx\n", (unsigned long) nsbuf);
-	msg_handle._msg = nsbuf;
-*/
-	ParodusInfo ("ns_initparse, msglen %d, nsbuf 0x%lx\n",
-    l, (unsigned long) nsbuf);
-	ret = ns_initparse((const u_char *) nsbuf, l, &msg_handle);
-	if (ret != 0) {
-		ParodusError ("ns_initparse failed\n");
-		free (nsbuf);
-		return ret;
-	}
-	
-	ParodusInfo ("ns_msg_count\n");
-	l = ns_msg_count(msg_handle, ns_s_an);
-	ParodusInfo ("query_dns: ns_msg_count : %d\n",l);
-  jwt_ans[0] = 0;
-	
-	ret = assemble_jwt_from_dns (&msg_handle, l, jwt_ans);
-	free (nsbuf);
-	if (ret == 0)
-		ParodusInfo ("query_dns JWT: %s\n", jwt_ans);
-	return ret;
-}
-
-static void get_dns_txt_record_id (char *buf)
-{
-	ParodusCfg *cfg = get_parodus_cfg();
-	buf[0] = 0;
-
-	sprintf (buf, "%s.%s", cfg->hw_mac, cfg->dns_txt_url);
-	ParodusInfo("dns_txt_record_id %s\n", buf);
-}
-#endif
-
-int allow_insecure_conn(char **server_addr, unsigned int *port)
-{
-#ifdef FEATURE_DNS_QUERY	
-	int insecure=0, ret = -1;
-	char *jwt_token, *key;
-	cjwt_t *jwt = NULL;
-	char dns_txt_record_id[TXT_REC_ID_MAXSIZE];
-	
-	jwt_token = malloc (NS_MAXBUF);
-	if (NULL == jwt_token) {
-		ParodusError ("Unable to allocate jwt_token in allow_insecure_conn\n");
-		insecure = TOKEN_ERR_MEMORY_FAIL;
-		goto end;
-	}
-
-	get_dns_txt_record_id (dns_txt_record_id);
-	
-	ret = query_dns(dns_txt_record_id, jwt_token);
-	ParodusPrint("query_dns returns %d\n", ret);
-		
-	if(ret){
-		ParodusError("Failed in DNS query\n");
-		if (ret == TOKEN_ERR_MEMORY_FAIL){
-			insecure = ret;
-		} 
-		else{
-			insecure = TOKEN_ERR_QUERY_DNS_FAIL;
-		}
-		goto end;
-	}
-	//Decoding the jwt token
-	key = get_parodus_cfg()->jwt_key;
-	ret = cjwt_decode( jwt_token, 0, &jwt, ( const uint8_t * )key,strlen(key) );
-
-	if(ret) {
-		if (ret == ENOMEM) {
-			ParodusError ("Memory allocation failed in JWT decode\n");
-		} else {
-			ParodusError ("CJWT decode error\n");
-		}
-		insecure = TOKEN_ERR_JWT_DECODE_FAIL;
-		goto end;
-	}
-
-	ParodusPrint("Decoded CJWT successfully\n");
-
-	//validate algo from --jwt_algo
-	if( validate_algo(jwt) ) {
-		insecure = analyze_jwt (jwt, server_addr, port);
-	} else {
-		insecure = TOKEN_ERR_ALGO_NOT_ALLOWED;
-	}
-
-	if (insecure >= 0) {
-		char *claim_str = cJSON_Print (jwt->private_claims);
-		ParodusInfo ("JWT claims: %s\n", claim_str);
-		free (claim_str);
-	}
-	cjwt_destroy(&jwt);
-	
-end:
-	if (NULL != jwt_token)
-		free (jwt_token);
-#else
-  (void) server_addr;
-  (void) port;
-  int insecure = TOKEN_NO_DNS_QUERY;
-#endif
-	ParodusPrint ("Allow Insecure %d\n", insecure);
-	return insecure;
-}

src/token.h

@@ -1,90 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file token.h
- *
- * @description This file contains apis and error codes for using jwt token.
- *
- */
-
-#ifndef _TOKEN_H_
-#define _TOKEN_H_
-
-/** 
- * @brief token error rtn codes
- * 
- */
-typedef enum {
-	TOKEN_ERR_MEMORY_FAIL = -999,
-	TOKEN_ERR_QUERY_DNS_FAIL = -101,
-	TOKEN_ERR_JWT_DECODE_FAIL = -102,
-	TOKEN_ERR_ALGO_NOT_ALLOWED = -103,
-	TOKEN_ERR_INVALID_JWT_CONTENT = -104,
-	TOKEN_ERR_NO_EXPIRATION = -105,
-	TOKEN_ERR_JWT_EXPIRED = -106,
-	TOKEN_ERR_BAD_ENDPOINT = -107,
-	TOKEN_NO_DNS_QUERY = -1
-} token_error_t;
-
-
-/**
-
-Connection Logic:
-
------ Criteria  -----
-
-Feature					FeatureDnsQuery enabled
-QueryGood				Dns query succeeds, jwt decodes and is valid and unexpired
-Endpt starts		Endpoint specified in the jwt starts with http:// or https://
-Config Secflag	secureFlag in config is set.  Currently always set.
-
-
------ Actions -----
-
-Default			Securely connect to the default URL, specified
-						in the config
-Secure			Securely connect to the endpoint given in the jwt
-Insecure		Insecurely connect to the endpoint given in the jwt
-
- 
------ Logic Table -----
-
-Feature		Query		Endpt		Config			Action
-			Good		Claim		SecFlag
-
-No													Default
-Yes			No										Default
-Yes			Yes			https						Secure
-Yes			Yes			http		False			Insecure
-Yes			Yes			http		True			Default
-*/
-
-
-/**
- * query the dns server, obtain a jwt, determine if insecure
- * connections can be allowed. 
- *
- * @param server_addr	ptr to buffer ptr containing endpoint value found in JWT
- *                      will be NULL if invalid, otherwise needs to be freed
- * @param port 		ptr to variable receiving the port number
- * @return 1 if insecure connection is allowed, 0 if not,
-*    or one of the error codes given above. 
-*/ 
-int allow_insecure_conn (char **server_addr, unsigned int *port);
-
-
-#endif

src/token_stub.c

@@ -1,52 +0,0 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file token_stub.c
- *
- * @description This file contains operations for using jwt token.
- *
- */
-#include "token.h"
-#include "parodus_log.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-/* none */
-
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-/* none */
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-
-/*----------------------------------------------------------------------------*/
-/*                             Internal functions                             */
-/*----------------------------------------------------------------------------*/
-
-int allow_insecure_conn(void)
-{
-        ParodusInfo("CJWT is disabled, Hence proceeding without validation\n");	
-	return 1;
-}

src/upstream.c

@@ -1,24 +1,9 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file upstream.c
  *
  * @description This describes functions required to manage upstream messages.
  *
+ * Copyright (c) 2015  Comcast
  */
 
 #include "ParodusInternal.h"
@@ -28,13 +13,12 @@
 #include "connection.h"
 #include "client_list.h"
 #include "nopoll_helpers.h"
-#include "close_retry.h"
 
 /*----------------------------------------------------------------------------*/
 /*                                   Macros                                   */
 /*----------------------------------------------------------------------------*/
 #define METADATA_COUNT 					12
-#define PARODUS_SERVICE_NAME			"parodus"
+
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
@@ -49,26 +33,6 @@ pthread_mutex_t nano_mut=PTHREAD_MUTEX_INITIALIZER;
 
 pthread_cond_t nano_con=PTHREAD_COND_INITIALIZER;
 
-UpStreamMsg * get_global_UpStreamMsgQ(void)
-{
-    return UpStreamMsgQ;
-}
-
-void set_global_UpStreamMsgQ(UpStreamMsg * UpStreamQ)
-{
-    UpStreamMsgQ = UpStreamQ;
-}
-
-pthread_cond_t *get_global_nano_con(void)
-{
-    return &nano_con;
-}
-
-pthread_mutex_t *get_global_nano_mut(void)
-{
-    return &nano_mut;
-}
-
 /*----------------------------------------------------------------------------*/
 /*                             Internal Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -83,6 +47,7 @@ void packMetaData()
     //Pack the metadata initially to reuse for every upstream msg sending to server
     ParodusPrint("-------------- Packing metadata ----------------\n");
     sprintf(boot_time, "%d", get_parodus_cfg()->boot_time);
+
     struct data meta_pack[METADATA_COUNT] = {
             {HW_MODELNAME, get_parodus_cfg()->hw_model},
             {HW_SERIALNUMBER, get_parodus_cfg()->hw_serial_number},
@@ -94,9 +59,10 @@ void packMetaData()
             {LAST_RECONNECT_REASON, get_global_reconnect_reason()},
             {WEBPA_PROTOCOL, get_parodus_cfg()->webpa_protocol},
             {WEBPA_UUID,get_parodus_cfg()->webpa_uuid},
-            {WEBPA_INTERFACE, getWebpaInterface()},
+            {WEBPA_INTERFACE, get_parodus_cfg()->webpa_interface_used},
             {PARTNER_ID, get_parodus_cfg()->partner_id}
         };
+
     const data_t metapack = {METADATA_COUNT, meta_pack};
 
     metaPackSize = wrp_pack_metadata( &metapack , &metadataPack );
@@ -127,12 +93,6 @@ void *handle_upstream()
     sock = nn_socket( AF_SP, NN_PULL );
     if(sock >= 0)
     {
-        int t = NANO_SOCKET_RCV_TIMEOUT_MS;
-        int rc = nn_setsockopt(sock, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
-        if (rc < 0)
-        {
-            ParodusError ("Unable to set socket receive timeout (errno=%d, %s)\n",errno, strerror(errno));
-        }
         ParodusPrint("Nanomsg bind with get_parodus_cfg()->local_url  %s\n", get_parodus_cfg()->local_url);
         bind = nn_bind(sock, get_parodus_cfg()->local_url);
         if(bind < 0)
@@ -141,19 +101,12 @@ void *handle_upstream()
         }
         else
         {
-            ParodusInfo("nanomsg server gone into the listening mode...\n");
             while( FOREVER() ) 
             {
                 buf = NULL;
+                ParodusInfo("nanomsg server gone into the listening mode...\n");
                 bytes = nn_recv (sock, &buf, NN_MSG, 0);
-                if (g_shutdown)
-                  break;
-                if (bytes < 0) {
-                  if ((errno != EAGAIN) && (errno != ETIMEDOUT))
-                    ParodusInfo ("Error (%d) receiving message from nanomsg client\n", errno);
-                  continue;
-                }
-                ParodusInfo ("Upstream message received from nanomsg client\n");
+                ParodusInfo ("Upstream message received from nanomsg client: \"%s\"\n", (char*)buf);
                 message = (UpStreamMsg *)malloc(sizeof(UpStreamMsg));
 
                 if(message)
@@ -188,16 +141,6 @@ void *handle_upstream()
                     ParodusError("failure in allocation for message\n");
                 }
             }
-	    if(nn_shutdown(sock, bind) < 0)
-	    {
-	        ParodusError ("nn_shutdown bind socket=%d endpt=%d, err=%d\n", 
-		    sock, bind, errno);
-	    }
-	    if (nn_close (sock) < 0)
-	    {
-	        ParodusError ("nn_close bind socket=%d err=%d\n", 
-		    sock, errno);
-	    }
         }
     }
     else
@@ -213,15 +156,12 @@ void *processUpstreamMessage()
 {		
     int rv=-1, rc = -1;	
     int msgType;
-    wrp_msg_t *msg,*retrieve_msg = NULL;
-    void *bytes;
+    wrp_msg_t *msg;	
+    void *appendData, *bytes;
+    size_t encodedSize;
     reg_list_item_t *temp = NULL;
     int matchFlag = 0;
     int status = -1;
-	char *device_id = NULL;
-	size_t device_id_len = 0;
-	size_t parodus_len;
-	int ret = -1;
 
     while(FOREVER())
     {
@@ -242,40 +182,34 @@ void *processUpstreamMessage()
             if(rv > 0)
             {
                 msgType = msg->msg_type;				   
-                if(msgType == WRP_MSG_TYPE__SVC_REGISTRATION)
+                if(msgType == 9)
                 {
                     ParodusInfo("\n Nanomsg client Registration for Upstream\n");
                     //Extract serviceName and url & store it in a linked list for reg_clients
-                    temp = get_global_node();
                     if(get_numOfClients() !=0)
                     {
                         matchFlag = 0;
                         ParodusPrint("matchFlag reset to %d\n", matchFlag);
+                        temp = get_global_node();
                         while(temp!=NULL)
                         {
                             if(strcmp(temp->service_name, msg->u.reg.service_name)==0)
                             {
                                 ParodusInfo("match found, client is already registered\n");
-                                parStrncpy(temp->url,msg->u.reg.url, sizeof(temp->url));
-                                if(nn_shutdown(temp->sock, temp->endpoint) < 0)
+                                strncpy(temp->url,msg->u.reg.url, strlen(msg->u.reg.url)+1);
+                                if(nn_shutdown(temp->sock, 0) < 0)
                                 {
-                                    ParodusError ("nn_shutdown socket=%d endpt=%d, err=%d\n", 
-					temp->sock, temp->endpoint, errno);
-                                }
-				if (nn_close (temp->sock) < 0)
-                                {
-                                    ParodusError ("nn_close socket=%d err=%d\n", 
-					temp->sock, errno);
+                                    ParodusError ("Failed to shutdown\n");
                                 }
 
                                 temp->sock = nn_socket(AF_SP,NN_PUSH );
                                 if(temp->sock >= 0)
                                 {					
-                                    int t = NANO_SOCKET_SEND_TIMEOUT_MS;
+                                    int t = NANOMSG_SOCKET_TIMEOUT_MSEC;
                                     rc = nn_setsockopt(temp->sock, NN_SOL_SOCKET, NN_SNDTIMEO, &t, sizeof(t));
                                     if(rc < 0)
                                     {
-                                        ParodusError ("Unable to set socket send timeout (errno=%d, %s)\n",errno, strerror(errno));
+                                        ParodusError ("Unable to set socket timeout (errno=%d, %s)\n",errno, strerror(errno));
                                     }
                                     rc = nn_connect(temp->sock, msg->u.reg.url); 
                                     if(rc < 0)
@@ -284,8 +218,7 @@ void *processUpstreamMessage()
                                     }
                                     else
                                     {
-                                        temp->endpoint = rc;
-                                        ParodusInfo("Client registered before. Sending ack on socket %d\n", temp->sock); 
+                                        ParodusInfo("Client registered before. Sending acknowledgement \n"); 
                                         status =sendAuthStatus(temp);
 
                                         if(status == 0)
@@ -316,19 +249,16 @@ void *processUpstreamMessage()
                             ParodusPrint("sent auth status to reg client\n");
                         }
                     }
-                    release_global_node ();
                 }
                 else if(msgType == WRP_MSG_TYPE__EVENT)
                 {
-                    ParodusInfo(" Received upstream event data: dest '%s'\n", msg->u.event.dest);
+                    ParodusInfo(" Received upstream event data\n");
                     partners_t *partnersList = NULL;
-                    int j = 0;
 
                     int ret = validate_partner_id(msg, &partnersList);
                     if(ret == 1)
                     {
                         wrp_msg_t *eventMsg = (wrp_msg_t *) malloc(sizeof(wrp_msg_t));
-			memset( eventMsg, 0, sizeof( wrp_msg_t ) );
                         eventMsg->msg_type = msgType;
                         eventMsg->u.event.content_type=msg->u.event.content_type;
                         eventMsg->u.event.source=msg->u.event.source;
@@ -338,15 +268,6 @@ void *processUpstreamMessage()
                         eventMsg->u.event.headers=msg->u.event.headers;
                         eventMsg->u.event.metadata=msg->u.event.metadata;
                         eventMsg->u.event.partner_ids = partnersList;
-			if(msg->u.event.transaction_uuid)
-			{
-				ParodusPrint("Inside Trans id in PARODUS\n");
-			}
-			else
-			{
-				ParodusPrint("Assigning NULL to trans id\n");
-				eventMsg->u.event.transaction_uuid = NULL;
-			}
 
                         int size = wrp_struct_to( eventMsg, WRP_BYTES, &bytes );
                         if(size > 0)
@@ -354,146 +275,52 @@ void *processUpstreamMessage()
                             sendUpstreamMsgToServer(&bytes, size);
                         }
                         free(eventMsg);
-                        free(bytes);
-                        bytes = NULL;
                     }
                     else
                     {
                         sendUpstreamMsgToServer(&message->msg, message->len);
                     }
-                    if(partnersList != NULL)
-                    {
-                        for(j=0; j<(int)partnersList->count; j++)
-                        {
-                            if(NULL != partnersList->partner_ids[j])
-                            {
-                                free(partnersList->partner_ids[j]);
-                            }
-                        }
-                        free(partnersList);
-                    }
-                    partnersList = NULL;
                 }
                 else
                 {
-					//Sending to server for msgTypes 3, 5, 6, 7, 8.
-					if( WRP_MSG_TYPE__REQ == msgType )
-					{
-						ParodusInfo(" Received upstream data with MsgType: %d dest: '%s' transaction_uuid: %s\n", msgType, msg->u.req.dest, msg->u.req.transaction_uuid );
-						sendUpstreamMsgToServer(&message->msg, message->len);
-					}
-					else
-					{
-						ParodusInfo(" Received upstream data with MsgType: %d dest: '%s' transaction_uuid: %s status: %d\n",msgType, msg->u.crud.dest, msg->u.crud.transaction_uuid, msg->u.crud.status );
-						if(WRP_MSG_TYPE__RETREIVE == msgType)
-						{
-								ret = getDeviceId(&device_id, &device_id_len);
-								if(ret == 0)
-								{
-									ParodusPrint("device_id %s device_id_len %lu\n", device_id, device_id_len);
-									/* Match dest based on device_id. Check dest start with: "mac:112233445xxx" ? */
-									if( 0 == strncasecmp(device_id, msg->u.crud.dest, device_id_len-1) )
-									{
-										 /* For this device. */
-										parodus_len = strlen( PARODUS_SERVICE_NAME );
-										if( 0 == strncmp(PARODUS_SERVICE_NAME, &msg->u.crud.dest[device_id_len], parodus_len-1) ) 
-										{
-											/* For Parodus CRUD queue. */
-											ParodusInfo("Create RetrieveMsg and add to parodus CRUD queue\n");
-											createUpstreamRetrieveMsg(msg, &retrieve_msg);
-											addCRUDmsgToQueue(retrieve_msg);
-										}
-										else
-										{
-											/* For nanomsg clients. */
-											getServiceNameAndSendResponse(msg, &message->msg, message->len);
-										}
-									}
-									else
-									{
-										/* Not for this device. Send upstream */
-										ParodusInfo("sendUpstreamMsgToServer \n");
-										sendUpstreamMsgToServer(&message->msg, message->len);
-									}
-									if(device_id != NULL)
-									{
-										free(device_id);
-										device_id = NULL;
-									}
-								}
-								else
-								{
-									ParodusError("Failed to get device_id\n");
-								}
-						}
-						else if((WRP_MSG_TYPE__UPDATE == msgType) || (WRP_MSG_TYPE__DELETE == msgType))
-						{
-							ParodusPrint("UPDATE/DELETE request\n");
-							ret = getDeviceId(&device_id, &device_id_len);
-							if(ret == 0)
-							{
-								ParodusPrint("device_id %s device_id_len %lu\n", device_id, device_id_len);
-								/* Match dest based on device_id. Check dest start with: "mac:112233445xxx" ? */
-								if( 0 == strncasecmp(device_id, msg->u.crud.dest, device_id_len-1) )
-								{
-									/* For this device. For nanomsg clients.*/
-									getServiceNameAndSendResponse(msg, &message->msg, message->len);
-								}
-								else
-								{
-									/* Not for this device. Send upstream */
-									ParodusInfo("sendUpstreamMsgToServer \n");
-									sendUpstreamMsgToServer(&message->msg, message->len);
-								}
-								if(device_id != NULL)
-								{
-									free(device_id);
-									device_id = NULL;
-								}
-							}
-							else
-							{
-								ParodusError("Failed to get device_id\n");
-							}
-						 }
-						 else if (WRP_MSG_TYPE__SVC_ALIVE != msgType) {
-						  /* Don't reply to service alive message */
-							sendUpstreamMsgToServer(&message->msg, message->len);
-					}
-			  }
-		    }
-           	}
+                    //Sending to server for msgTypes 3, 5, 6, 7, 8.
+                    ParodusInfo(" Received upstream data with MsgType: %d\n", msgType);
+                    //Appending metadata with packed msg received from client
+                    if(metaPackSize > 0)
+                    {
+                        ParodusPrint("Appending received msg with metadata\n");
+                        encodedSize = appendEncodedData( &appendData, message->msg, message->len, metadataPack, metaPackSize );
+                        ParodusPrint("encodedSize after appending :%zu\n", encodedSize);
+                        ParodusPrint("metadata appended upstream msg %s\n", (char *)appendData);
+                        ParodusInfo("Sending metadata appended upstream msg to server\n");
+                        sendMessage(get_global_conn(),appendData, encodedSize);
+
+                        free( appendData);
+                        appendData =NULL;
+                    }
+                    else
+                    {		
+                        ParodusError("Failed to send upstream as metadata packing is not successful\n");
+                    }
+                }
+            }
             else
             {
                 ParodusError("Error in msgpack decoding for upstream\n");
             }
+            ParodusPrint("Free for upstream decoded msg\n");
+            wrp_free_struct(msg);
+            msg = NULL;
 
-			//nn_freemsg should not be done for parodus/tags/ CRUD requests as it is not received through nanomsg.
-			if ((msg && (msg->u.crud.source !=NULL) && wrp_does_service_match("parodus", msg->u.crud.source) == 0))
-			{
-				free(message->msg);
-			}
-			else
-			{
-				if(nn_freemsg (message->msg) < 0)
-				{
-					ParodusError ("Failed to free msg\n");
-				}
-			}
-			ParodusPrint("Free for upstream decoded msg\n");
-			if (msg) {
-                wrp_free_struct(msg);
+            if(nn_freemsg (message->msg) < 0)
+            {
+                ParodusError ("Failed to free msg\n");
             }
-			msg = NULL;
-			free(message);
-			message = NULL;
+            free(message);
+            message = NULL;
         }
         else
         {
-            if (g_shutdown) {
-                pthread_mutex_unlock (&nano_mut);
-                break;
-            }
             ParodusPrint("Before pthread cond wait in consumer thread\n");   
             pthread_cond_wait(&nano_con, &nano_mut);
             pthread_mutex_unlock (&nano_mut);
@@ -503,113 +330,11 @@ void *processUpstreamMessage()
     return NULL;
 }
 
-/**
- * @brief getDeviceId function to create deviceId in the format "mac:112233445xxx"
- *
- * @param[out] device_id in the format "mac:112233445xxx"
- * @param[out] total size of device_id
- */
-int getDeviceId(char **device_id, size_t *device_id_len)
-{
-	char *deviceID = NULL;
-	size_t len;
-
-	if((get_parodus_cfg()->hw_mac !=NULL) && (strlen(get_parodus_cfg()->hw_mac)!=0))
-	{
-		len = strlen(get_parodus_cfg()->hw_mac) + 5;
-
-		deviceID = (char *) malloc(sizeof(char)*64);
-		if(deviceID != NULL)
-		{
-			snprintf(deviceID, len, "mac:%s", get_parodus_cfg()->hw_mac);
-			*device_id = deviceID;
-			*device_id_len = len;
-		}
-		else
-		{
-			ParodusError("device_id allocation failed\n");
-			return -1;
-		}
-	}
-	else
-	{
-		ParodusError("device mac is NULL\n");
-		return -1;
-	}
-	return 0;
-}
-
-
-/**
- * @brief createUpstreamRetrieveMsg function to create new message for processing Retrieve requests
- *
- * @param[in] message The upstream message received from cloud or internal clients
- * @param[out] retrieve_msg New message for processing Retrieve requests
- */
-void createUpstreamRetrieveMsg(wrp_msg_t *message, wrp_msg_t **retrieve_msg)
-{
-	wrp_msg_t *msg;
-	msg = ( wrp_msg_t * ) malloc( sizeof( wrp_msg_t ) );
-	if(msg != NULL)
-    {
-		memset(msg, 0, sizeof(wrp_msg_t));
-
-		msg->msg_type = message->msg_type;
-		if(message->u.crud.transaction_uuid != NULL)
-		{
-			msg->u.crud.transaction_uuid = strdup(message->u.crud.transaction_uuid);
-		}
-		if(message->u.crud.source !=NULL)
-		{
-			msg->u.crud.source = strdup(message->u.crud.source);
-		}
-		if(message->u.crud.dest != NULL)
-		{
-			msg->u.crud.dest = strdup(message->u.crud.dest);
-		}
-		*retrieve_msg = msg;
-	}
-}
-
-/**
- * @brief getServiceNameAndSendResponse function to fetch client service name and to send msg to it.
- *
- * @param[in] msg The decoded message to fetch client service name from its dest field
- * @param[in] msg_bytes The encoded upstream msg to be sent to client
- * @param[in] msg_size Total size of the msg to send to client
- */
-void getServiceNameAndSendResponse(wrp_msg_t *msg, void **msg_bytes, size_t msg_size)
-{
-	char *serviceName = NULL;
-	int sendStatus =-1;
-
-	serviceName = wrp_get_msg_element(WRP_ID_ELEMENT__SERVICE, msg, DEST);
-	if ( serviceName != NULL)
-	{
-		sendStatus=sendMsgtoRegisteredClients(serviceName,(const char **)msg_bytes, msg_size);
-		if(sendStatus ==1)
-		{
-			ParodusInfo("Send upstreamMsg successfully to registered client %s\n", serviceName);
-		}
-		else
-		{
-			ParodusError("Failed to send upstreamMsg to registered client %s\n", serviceName);
-		}
-		free(serviceName);
-		serviceName = NULL;
-	}
-	else
-	{
-		ParodusError("serviceName is NULL,not sending retrieve response to client\n");
-	}
-}
-
-int sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
+void sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
 {
 	void *appendData;
 	size_t encodedSize;
-	bool close_retry = false;
-	int sendRetStatus = 1;
+
 	//appending response with metadata 			
 	if(metaPackSize > 0)
 	{
@@ -618,29 +343,14 @@ int sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
 	   	ParodusPrint("encodedSize after appending :%zu\n", encodedSize);
 	   		   
 		ParodusInfo("Sending response to server\n");
-		close_retry = get_close_retry();
-
-		/* send response when connection retry is not in progress. Also during cloud_disconnect UPDATE request. Here, close_retry becomes 1 hence check is added to send disconnect response to server. */
-		//TODO: Upstream and downstream messages in queue should be handled and queue should be empty before parodus forcefully disconnect from cloud.
-		if(!close_retry || (get_parodus_cfg()->cloud_disconnect !=NULL))
-		{
-			sendRetStatus = sendMessage(get_global_conn(),appendData, encodedSize);
-		}
-		else
-		{
-			ParodusInfo("close_retry is %d, unable to send response as connection retry is in progress\n", close_retry);
-			OnboardLog("close_retry is %d, unable to send response as connection retry is in progress\n", close_retry);
-			sendRetStatus = 1;
-		}
+	   	sendMessage(get_global_conn(),appendData, encodedSize);
+	   	
 		free(appendData);
 		appendData =NULL;
 	}
 	else
 	{		
 		ParodusError("Failed to send upstream as metadata packing is not successful\n");
-		sendRetStatus = 1;
 	}
-	ParodusPrint("sendRetStatus is %d\n", sendRetStatus);
 
-	return sendRetStatus;
 }

src/upstream.h

@@ -1,35 +1,18 @@
-/**
- * Copyright 2015 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
 /**
  * @file upstream.h
  *
  * @description This header defines functions required to manage upstream messages.
  *
+ * Copyright (c) 2015  Comcast
  */
  
 #ifndef _UPSTREAM_H_
 #define _UPSTREAM_H_
 
-#include <pthread.h>
-#include <wrp-c.h>
 #ifdef __cplusplus
 extern "C" {
 #endif
-	
+
 /*----------------------------------------------------------------------------*/
 /*                               Data Structures                              */
 /*----------------------------------------------------------------------------*/
@@ -47,18 +30,8 @@ typedef struct UpStreamMsg__
 void packMetaData();
 void *handle_upstream();
 void *processUpstreamMessage();
-void registerRBUSlistener();
-int getDeviceId(char **device_id, size_t *device_id_len);
-int sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size);
-void getServiceNameAndSendResponse(wrp_msg_t *msg, void **msg_bytes, size_t msg_size);
-void createUpstreamRetrieveMsg(wrp_msg_t *message, wrp_msg_t **retrieve_msg);
-void set_global_UpStreamMsgQ(UpStreamMsg * UpStreamQ);
-#ifdef WAN_FAILOVER_SUPPORTED
-int subscribeCurrentActiveInterfaceEvent();
-#endif
-UpStreamMsg * get_global_UpStreamMsgQ(void);
-pthread_cond_t *get_global_nano_con(void);
-pthread_mutex_t *get_global_nano_mut(void);
+
+void sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size);
 
 #ifdef __cplusplus
 }

src/upstream_rbus.c

@@ -1,211 +0,0 @@
-/**
- * Copyright 2021 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file upstream_rbus.c
- *
- * @description This is used for parodus-RBUS communication 
- * to send notification events upstream to cloud.
- *
- */
-
-#include <stdlib.h>
-#include <rbus.h>
-#include "upstream.h"
-#include "ParodusInternal.h"
-#include "partners_check.h"
-#include "close_retry.h"
-#include "connection.h"
-#include "heartBeat.h"
-
-#define WEBCFG_UPSTREAM_EVENT "Webconfig.Upstream"
-#ifdef WAN_FAILOVER_SUPPORTED
-#define WEBPA_INTERFACE "Device.X_RDK_WanManager.CurrentActiveInterface"
-#endif
-
-rbusHandle_t rbus_Handle;
-rbusError_t err;
-
-void processWebconfigUpstreamEvent(rbusHandle_t handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription);
-
-void subscribeAsyncHandler( rbusHandle_t handle, rbusEventSubscription_t* subscription, rbusError_t error);
-
-rbusHandle_t get_parodus_rbus_Handle(void)
-{
-     return rbus_Handle;
-}
-#ifdef WAN_FAILOVER_SUPPORTED
-void eventReceiveHandler( rbusHandle_t rbus_Handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription );
-#endif
-
-/* API to register RBUS listener to receive messages from webconfig */
-void subscribeRBUSevent()
-{
-    int rc = RBUS_ERROR_SUCCESS;
-	err = rbus_open(&rbus_Handle, "parodus");
-	if (err)
-	{
-		ParodusError("rbus_open failed :%s\n", rbusError_ToString(err));
-		return;
-	}
-    rc = rbusEvent_SubscribeAsync(rbus_Handle,WEBCFG_UPSTREAM_EVENT,processWebconfigUpstreamEvent,subscribeAsyncHandler,"parodus",10*60);
-    if(rc != RBUS_ERROR_SUCCESS)
-        ParodusError("rbusEvent_Subscribe failed: %d, %s\n", rc, rbusError_ToString(rc));
-    else
-        ParodusInfo("rbusEvent_Subscribe was successful\n");
-}
-
-#ifdef WAN_FAILOVER_SUPPORTED
-/* API to subscribe Active Interface name on value change event*/
-int subscribeCurrentActiveInterfaceEvent()
-{
-	int rc = RBUS_ERROR_SUCCESS;
-	ParodusPrint("Subscribing to Device.X_RDK_WanManager.CurrentActiveInterface Event\n");
-	rc = rbusEvent_SubscribeAsync(rbus_Handle,WEBPA_INTERFACE,eventReceiveHandler,subscribeAsyncHandler,"parodusInterface",10*20);
-        if(rc != RBUS_ERROR_SUCCESS)
-	{
-		ParodusError("%s subscribe failed : %d - %s\n", WEBPA_INTERFACE, rc, rbusError_ToString(rc));
-        }   
-	return rc;	
-} 
-#endif
-
-void processWebconfigUpstreamEvent(rbusHandle_t handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription)
-{
-    (void)handle;
-    (void)subscription;
-    
-    int rv=-1;
-	wrp_msg_t *event_msg;
-	void *bytes;
-	const uint8_t* bytesVal = NULL;
-    int len;
-    rbusValue_t value = NULL;
-
-    value = rbusObject_GetValue(event->data, "value");
-    bytesVal = rbusValue_GetBytes(value, &len);
-
-	bytes = (void*) bytesVal;
-	rv = wrp_to_struct( bytes, len, WRP_BYTES, &event_msg );
-	if(rv > 0)
-	{
-		ParodusInfo(" Received upstream event data: dest '%s'\n", event_msg->u.event.dest);
-		partners_t *partnersList = NULL;
-		int j = 0;
-
-		int ret = validate_partner_id(event_msg, &partnersList);
-		if(ret == 1)
-		{
-		    wrp_msg_t *eventMsg = (wrp_msg_t *) malloc(sizeof(wrp_msg_t));
-		    memset( eventMsg, 0, sizeof( wrp_msg_t ) );
-		    eventMsg->msg_type = event_msg->msg_type;
-		    eventMsg->u.event.content_type=event_msg->u.event.content_type;
-		    eventMsg->u.event.source=event_msg->u.event.source;
-		    eventMsg->u.event.dest=event_msg->u.event.dest;
-		    eventMsg->u.event.payload=event_msg->u.event.payload;
-		    eventMsg->u.event.payload_size=event_msg->u.event.payload_size;
-		    eventMsg->u.event.headers=event_msg->u.event.headers;
-		    eventMsg->u.event.metadata=event_msg->u.event.metadata;
-		    eventMsg->u.event.partner_ids = partnersList;
-		    if(event_msg->u.event.transaction_uuid)
-		    {
-			  ParodusPrint("Inside Trans id in PARODUS_rbus\n");
-		    }
-		    else
-		    {
-			  ParodusPrint("Assigning NULL to trans id RBUS\n");
-			  eventMsg->u.event.transaction_uuid = NULL;
-		    }
-
-		   int size = wrp_struct_to( eventMsg, WRP_BYTES, &bytes );
-		   if(size > 0)
-		   {
-		       sendUpstreamMsgToServer(&bytes, size);
-		   }
-		   free(eventMsg);
-		   free(bytes);
-		   bytes = NULL;
-		}
-		else
-		{
-		   sendUpstreamMsgToServer((void **)(&bytes), len);
-		}
-		if(partnersList != NULL)
-		{
-		    for(j=0; j<(int)partnersList->count; j++)
-		    {
-		        if(NULL != partnersList->partner_ids[j])
-		        {
-		             free(partnersList->partner_ids[j]);
-		        }
-		    }
-		    free(partnersList);
-		}
-		partnersList = NULL;
-	}
-}
-
-void subscribeAsyncHandler( rbusHandle_t handle, rbusEventSubscription_t* subscription, rbusError_t error)
-{
-	(void)handle;
-	ParodusInfo("subscribeAsyncHandler event %s, error %d - %s\n",subscription->eventName, error, rbusError_ToString(error));
-}
-
-#ifdef WAN_FAILOVER_SUPPORTED
-void eventReceiveHandler( rbusHandle_t rbus_Handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription )
-{
-    (void)subscription;
-    ParodusPrint("Handling event inside eventReceiveHandler\n");
-    (void)rbus_Handle;
-    char * interface = NULL;
-    rbusValue_t newValue = rbusObject_GetValue(event->data, "value");
-    rbusValue_t oldValue = rbusObject_GetValue(event->data, "oldValue");
-    ParodusInfo("Consumer received ValueChange event for param %s\n", event->name);
-    
-    if(newValue) {    
-        interface = (char *) rbusValue_GetString(newValue, NULL);
-	setWebpaInterface(interface);
-    }
-    else {
-	   ParodusError("newValue is NULL\n");
-    }
-
-    if(newValue !=NULL && oldValue!=NULL && interface!=NULL) {
-	ParodusInfo("New Value: %s Old Value: %s New Interface Value: %s\n", rbusValue_GetString(newValue, NULL), rbusValue_GetString(oldValue, NULL), interface);
-	
-	// If interface is already down then reset it and reconnect cloud conn as wan failover event is received
-	if(get_interface_down_event()) 
-	{
-		reset_interface_down_event();
-		ParodusInfo("Interface_down_event is reset\n");
-		resume_heartBeatTimer();
-	}
-	// Close cloud conn and reconnect with the new interface as wan failover event is received
-	set_global_reconnect_reason("WAN_FAILOVER");
-	set_global_reconnect_status(true);
-	set_close_retry();
-
-    }
-    else {
-         if(oldValue == NULL) {
-     	        ParodusError("oldValue is NULL\n");
-         }  
-         if(interface == NULL) {
-	        ParodusError("interface is NULL\n"); 
-         }  
-    }
-}
-#endif

src/xmidtsend_rbus.c

@@ -1,881 +0,0 @@
-/**
- * Copyright 2022 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file xmidtsend_rbus.c
- *
- * @ To provide Xmidt send RBUS method to send events upstream.
- *
- */
-
-#include <stdlib.h>
-#include <rbus.h>
-#include "upstream.h"
-#include "ParodusInternal.h"
-#include "partners_check.h"
-#include "xmidtsend_rbus.h"
-#include "config.h"
-
-static pthread_t processThreadId = 0;
-static int XmidtQsize = 0;
-
-XmidtMsg *XmidtMsgQ = NULL;
-
-pthread_mutex_t xmidt_mut=PTHREAD_MUTEX_INITIALIZER;
-
-pthread_cond_t xmidt_con=PTHREAD_COND_INITIALIZER;
-
-const char * contentTypeList[]={
-"application/json",
-"avro/binary",
-"application/msgpack",
-"application/binary"
-};
-
-void printSendMsgData(char* status, int qos, char* dest, char* transaction_uuid) {
-	ParodusInfo("status: %s, qos: %d, dest: %s, transaction_uuid: %s\n", (status!=NULL)?status:"NULL", qos, (dest!=NULL)?dest:"NULL", (transaction_uuid!=NULL)?transaction_uuid:"NULL");
-}
-
-bool highQosValueCheck(int qos)
-{
-	if(qos > 24)
-	{
-		ParodusInfo("The qos value is high\n");
-		return true;
-	}
-	else
-	{
-		ParodusPrint("The qos value is low\n");
-	}
-
-	return false;
-}
-/*
- * @brief To handle xmidt rbus messages received from various components.
- */
-void addToXmidtUpstreamQ(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle)
-{
-	XmidtMsg *message;
-
-	ParodusPrint("XmidtQsize is %d\n" , XmidtQsize);
-	if(XmidtQsize == MAX_QUEUE_SIZE)
-	{
-		char * errorMsg = strdup("Max Queue Size Exceeded");
-		ParodusError("Queue Size Exceeded\n");
-		createOutParamsandSendAck(msg, asyncHandle, errorMsg , QUEUE_SIZE_EXCEEDED, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-		wrp_free_struct(msg);
-		return;
-	}
-
-	ParodusPrint ("Add Xmidt Upstream message to queue\n");
-	message = (XmidtMsg *)malloc(sizeof(XmidtMsg));
-
-	if(message)
-	{
-		message->msg = msg;
-		message->asyncHandle =asyncHandle;
-		//Increment queue size to handle max queue limit
-		XmidtQsize++;
-		message->next=NULL;
-		pthread_mutex_lock (&xmidt_mut);
-		//Producer adds the rbus msg into queue
-		if(XmidtMsgQ == NULL)
-		{
-			XmidtMsgQ = message;
-
-			ParodusPrint("Producer added xmidt message\n");
-			pthread_cond_signal(&xmidt_con);
-			pthread_mutex_unlock (&xmidt_mut);
-			ParodusPrint("mutex unlock in xmidt producer\n");
-		}
-		else
-		{
-			XmidtMsg *temp = XmidtMsgQ;
-			while(temp->next)
-			{
-				temp = temp->next;
-			}
-			temp->next = message;
-			pthread_mutex_unlock (&xmidt_mut);
-		}
-	}
-	else
-	{
-		char * errorMsg = strdup("Unable to enqueue");
-		ParodusError("failure in allocation for xmidt message\n");
-		createOutParamsandSendAck(msg, asyncHandle, errorMsg , ENQUEUE_FAILURE, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-		wrp_free_struct(msg);
-	}
-	return;
-}
-
-//Xmidt consumer thread to process the rbus events.
-void processXmidtData()
-{
-	int err = 0;
-	err = pthread_create(&processThreadId, NULL, processXmidtUpstreamMsg, NULL);
-	if (err != 0)
-	{
-		ParodusError("Error creating processXmidtData thread :[%s]\n", strerror(err));
-	}
-	else
-	{
-		ParodusInfo("processXmidtData thread created Successfully\n");
-	}
-
-}
-
-//Consumer to Parse and process rbus data.
-void* processXmidtUpstreamMsg()
-{
-	int rv = 0;
-	while(FOREVER())
-	{
-		if(get_parodus_init())
-		{
-			ParodusInfo("Initial cloud connection is not established, Xmidt wait till connection up\n");
-			pthread_mutex_lock(get_global_cloud_status_mut());
-			pthread_cond_wait(get_global_cloud_status_cond(), get_global_cloud_status_mut());
-			pthread_mutex_unlock(get_global_cloud_status_mut());
-			ParodusInfo("Received cloud status signal proceed to event processing\n");
-		}
-		pthread_mutex_lock (&xmidt_mut);
-		ParodusPrint("mutex lock in xmidt consumer thread\n");
-		if(XmidtMsgQ != NULL)
-		{
-			XmidtMsg *Data = XmidtMsgQ;
-			
-			pthread_mutex_unlock (&xmidt_mut);
-			ParodusPrint("mutex unlock in xmidt consumer thread\n");
-			rv = processData(Data->msg, Data->asyncHandle);
-			if(!rv)
-			{
-				ParodusPrint("Data->msg wrp free\n");
-				wrp_free_struct(Data->msg);
-			}
-			else
-			{
-				free(Data->msg);
-			}
-			free(Data);
-			Data = NULL;
-		}
-		else
-		{
-			if (g_shutdown)
-			{
-				pthread_mutex_unlock (&xmidt_mut);
-				break;
-			}
-			ParodusPrint("Before cond wait in xmidt consumer thread\n");
-			pthread_cond_wait(&xmidt_con, &xmidt_mut);
-			pthread_mutex_unlock (&xmidt_mut);
-			ParodusPrint("mutex unlock in xmidt thread after cond wait\n");
-		}
-	}
-	return NULL;
-}
-
-//To validate and send events upstream
-int processData(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle)
-{
-	int rv = 0;
-	char *errorMsg = "none";
-	int statuscode =0;
-
-	wrp_msg_t * xmidtMsg = msg;
-	if (xmidtMsg == NULL)
-	{
-		ParodusError("xmidtMsg is NULL\n");
-		errorMsg = strdup("Unable to enqueue");
-		createOutParamsandSendAck(xmidtMsg, asyncHandle, errorMsg, ENQUEUE_FAILURE, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-		xmidtQDequeue();
-		return rv;
-	}
-
-	rv = validateXmidtData(xmidtMsg, &errorMsg, &statuscode);
-	ParodusPrint("validateXmidtData, errorMsg %s statuscode %d\n", errorMsg, statuscode);
-	if(rv)
-	{
-		ParodusPrint("validation successful, send event to server\n");
-		sendXmidtEventToServer(xmidtMsg, asyncHandle);
-		return rv;
-	}
-	else
-	{
-		ParodusError("validation failed, send failure ack\n");
-		createOutParamsandSendAck(xmidtMsg, asyncHandle, errorMsg , statuscode, RBUS_ERROR_INVALID_INPUT);
-		xmidtQDequeue();
-	}
-	return rv;
-}
-
-//To remove an event from Queue
-void xmidtQDequeue()
-{
-	pthread_mutex_lock (&xmidt_mut);
-	if(XmidtMsgQ != NULL)
-	{
-		XmidtMsgQ = XmidtMsgQ->next;
-		XmidtQsize -= 1;
-	}
-	else
-	{
-		ParodusError("XmidtMsgQ is NULL\n");
-	}
-	pthread_mutex_unlock (&xmidt_mut);
-}
-
-int validateXmidtData(wrp_msg_t * eventMsg, char **errorMsg, int *statusCode)
-{
-	if(eventMsg == NULL)
-	{
-		ParodusError("eventMsg is NULL\n");
-		return 0;
-	}
-
-	if(eventMsg->msg_type != WRP_MSG_TYPE__EVENT)
-	{
-		*errorMsg = strdup("Message format is invalid");
-		*statusCode = INVALID_MSG_TYPE;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-
-	if(eventMsg->u.event.source == NULL)
-	{
-		*errorMsg = strdup("Missing source");
-		*statusCode = MISSING_SOURCE;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-
-	if(eventMsg->u.event.dest == NULL)
-	{
-		*errorMsg = strdup("Missing dest");
-		*statusCode = MISSING_DEST;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-
-	if(eventMsg->u.event.content_type == NULL)
-	{
-		*errorMsg = strdup("Missing content_type");
-		*statusCode = MISSING_CONTENT_TYPE;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-	else
-	{
-		int i =0, count = 0, valid = 0;
-		count = sizeof(contentTypeList)/sizeof(contentTypeList[0]);
-		for(i = 0; i<count; i++)
-		{
-			if (strcmp(eventMsg->u.event.content_type, contentTypeList[i]) == 0)
-			{
-				ParodusPrint("content_type is valid %s\n", contentTypeList[i]);
-				valid = 1;
-				break;
-			}
-		}
-		if (!valid)
-		{
-			ParodusError("content_type is not valid, %s\n", eventMsg->u.event.content_type);
-			*errorMsg = strdup("Invalid content_type");
-			*statusCode = INVALID_CONTENT_TYPE;
-			ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-			return 0;
-		}
-	}
-
-	if(eventMsg->u.event.payload == NULL)
-	{
-		*errorMsg = strdup("Missing payload");
-		*statusCode = MISSING_PAYLOAD;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-
-	if(eventMsg->u.event.payload_size == 0)
-	{
-		*errorMsg = strdup("Missing payloadlen");
-		*statusCode = MISSING_PAYLOADLEN;
-		ParodusError("errorMsg: %s, statusCode: %d\n", *errorMsg, *statusCode);
-		return 0;
-	}
-
-	ParodusPrint("validateXmidtData success. errorMsg %s statusCode %d\n", *errorMsg, *statusCode);
-	return 1;
-}
-
-void sendXmidtEventToServer(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle)
-{
-	wrp_msg_t *notif_wrp_msg = NULL;
-	ssize_t msg_len;
-	void *msg_bytes;
-	int ret = -1;
-	char sourceStr[64] = {'\0'};
-	char *device_id = NULL;
-	size_t device_id_len = 0;
-	int sendRetStatus = 1;
-	char *errorMsg = NULL;
-	int qos = 0;
-
-	notif_wrp_msg = (wrp_msg_t *)malloc(sizeof(wrp_msg_t));
-	if(notif_wrp_msg != NULL)
-	{
-		memset(notif_wrp_msg, 0, sizeof(wrp_msg_t));
-		notif_wrp_msg->msg_type = WRP_MSG_TYPE__EVENT;
-
-		ParodusPrint("msg->u.event.source: %s\n",msg->u.event.source);
-
-		if(msg->u.event.source !=NULL)
-		{
-			//To get device_id in the format "mac:112233445xxx"
-			ret = getDeviceId(&device_id, &device_id_len);
-			if(ret == 0)
-			{
-				ParodusPrint("device_id %s device_id_len %lu\n", device_id, device_id_len);
-				snprintf(sourceStr, sizeof(sourceStr), "%s/%s", device_id, msg->u.event.source);
-				ParodusPrint("sourceStr formed is %s\n" , sourceStr);
-				notif_wrp_msg->u.event.source = strdup(sourceStr);
-				ParodusInfo("source:%s\n", notif_wrp_msg->u.event.source);
-			}
-			else
-			{
-				ParodusError("Failed to get device_id\n");
-			}
-			if(device_id != NULL)
-			{
-				free(device_id);
-				device_id = NULL;
-			}
-		}
-
-		if(msg->u.event.dest != NULL)
-		{
-			notif_wrp_msg->u.event.dest = msg->u.event.dest;
-			ParodusInfo("destination: %s\n", notif_wrp_msg->u.event.dest);
-		}
-
-		if(msg->u.event.transaction_uuid != NULL)
-		{
-			notif_wrp_msg->u.event.transaction_uuid = msg->u.event.transaction_uuid;
-			ParodusPrint("Notification transaction_uuid %s\n", notif_wrp_msg->u.event.transaction_uuid);
-		}
-
-		if(msg->u.event.content_type != NULL)
-		{
-			notif_wrp_msg->u.event.content_type = msg->u.event.content_type;
-			ParodusInfo("content_type is %s\n",notif_wrp_msg->u.event.content_type);
-		}
-
-		if(msg->u.event.payload != NULL)
-		{
-			ParodusInfo("Notification payload: %s\n",msg->u.event.payload);
-			notif_wrp_msg->u.event.payload = (void *)msg->u.event.payload;
-			notif_wrp_msg->u.event.payload_size = msg->u.event.payload_size;
-			ParodusPrint("payload size %lu\n", notif_wrp_msg->u.event.payload_size);
-		}
-
-		if(msg->u.event.qos != 0)
-		{
-			notif_wrp_msg->u.event.qos = msg->u.event.qos;
-			qos = notif_wrp_msg->u.event.qos;
-			ParodusInfo("Notification qos: %d\n",notif_wrp_msg->u.event.qos);
-		}
-		msg_len = wrp_struct_to (notif_wrp_msg, WRP_BYTES, &msg_bytes);
-
-		ParodusPrint("Encoded xmidt wrp msg, msg_len %lu\n", msg_len);
-		if(msg_len > 0)
-		{
-			ParodusPrint("sendUpstreamMsgToServer\n");
-			printSendMsgData("send to server", notif_wrp_msg->u.event.qos, notif_wrp_msg->u.event.dest, notif_wrp_msg->u.event.transaction_uuid);
-			sendRetStatus = sendUpstreamMsgToServer(&msg_bytes, msg_len);
-		}
-		else
-		{
-			ParodusError("wrp msg_len is zero\n");
-			errorMsg = strdup("Wrp message encoding failed");
-			createOutParamsandSendAck(msg, asyncHandle, errorMsg, WRP_ENCODE_FAILURE, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-			xmidtQDequeue();
-
-			ParodusPrint("wrp_free_struct\n");
-			if(notif_wrp_msg != NULL)
-			{
-				wrp_free_struct(notif_wrp_msg);
-			}
-
-			if(msg_bytes != NULL)
-			{
-				free(msg_bytes);
-				msg_bytes = NULL;
-			}
-			return;
-		}
-
-		while(sendRetStatus)     //If SendMessage is failed condition
-		{
-			ParodusError("sendXmidtEventToServer is Failed\n");
-			if(highQosValueCheck(qos))
-			{
-				ParodusPrint("The event is having high qos retry again\n");
-				ParodusInfo("Wait till connection is Up\n");
-  
-       			        pthread_mutex_lock(get_global_cloud_status_mut());
-				pthread_cond_wait(get_global_cloud_status_cond(), get_global_cloud_status_mut());
-				pthread_mutex_unlock(get_global_cloud_status_mut());
-				ParodusInfo("Received cloud status signal proceed to retry\n");
-                                printSendMsgData("send to server after cloud reconnect", notif_wrp_msg->u.event.qos, notif_wrp_msg->u.event.dest, notif_wrp_msg->u.event.transaction_uuid);
-			}
-			else
-			{
-				errorMsg = strdup("send failed due to client disconnect");
-				ParodusInfo("The event is having low qos proceed to dequeue\n");
-				printSendMsgData(errorMsg, notif_wrp_msg->u.event.qos, notif_wrp_msg->u.event.dest, notif_wrp_msg->u.event.transaction_uuid);
-				createOutParamsandSendAck(msg, asyncHandle, errorMsg, CLIENT_DISCONNECT, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-				xmidtQDequeue();
-				break;
-		        }
-			sendRetStatus = sendUpstreamMsgToServer(&msg_bytes, msg_len);
-		}
-                
-		if(sendRetStatus == 0)
-		{
-			errorMsg = strdup("send to server success");
-			createOutParamsandSendAck(msg, asyncHandle, errorMsg, DELIVERED_SUCCESS, RBUS_ERROR_SUCCESS);
-			xmidtQDequeue();
-		}
-
-		ParodusPrint("B4 notif wrp_free_struct\n");
-		if(notif_wrp_msg != NULL)
-		{
-			wrp_free_struct(notif_wrp_msg);
-		}
-
-		if(msg_bytes != NULL)
-		{
-			free(msg_bytes);
-			msg_bytes = NULL;
-		}
-
-	}
-	else
-	{
-		errorMsg = strdup("Memory allocation failed");
-		ParodusError("Memory allocation failed\n");
-		createOutParamsandSendAck(msg, asyncHandle, errorMsg, MSG_PROCESSING_FAILED, RBUS_ERROR_INVALID_RESPONSE_FROM_DESTINATION);
-		xmidtQDequeue();
-	}
-
-	if(msg->u.event.source !=NULL)
-	{
-		free(msg->u.event.source);
-		msg->u.event.source = NULL;
-	}
-}
-
-void createOutParamsandSendAck(wrp_msg_t *msg, rbusMethodAsyncHandle_t asyncHandle, char *errorMsg, int statuscode, rbusError_t error)
-{
-	rbusObject_t outParams;
-	rbusError_t err;
-	rbusValue_t value;
-	char qosstring[20] = "";
-
-	rbusValue_Init(&value);
-	rbusValue_SetString(value, "event");
-	rbusObject_Init(&outParams, NULL);
-	rbusObject_SetValue(outParams, "msg_type", value);
-	rbusValue_Release(value);
-
-	ParodusPrint("statuscode %d errorMsg %s\n", statuscode, errorMsg);
-	rbusValue_Init(&value);
-	rbusValue_SetInt32(value, statuscode);
-	rbusObject_SetValue(outParams, "status", value);
-	rbusValue_Release(value);
-
-	if(errorMsg !=NULL)
-	{
-		rbusValue_Init(&value);
-		rbusValue_SetString(value, errorMsg);
-		rbusObject_SetValue(outParams, "error_message", value);
-		rbusValue_Release(value);
-		free(errorMsg);
-	}
-
-	if(msg != NULL)
-	{
-		if(msg->u.event.source !=NULL)
-		{
-			ParodusPrint("msg->u.event.source is %s\n", msg->u.event.source);
-			rbusValue_Init(&value);
-			rbusValue_SetString(value, msg->u.event.source);
-			rbusObject_SetValue(outParams, "source", value);
-			rbusValue_Release(value);
-		}
-
-		if(msg->u.event.dest !=NULL)
-		{
-			rbusValue_Init(&value);
-			rbusValue_SetString(value, msg->u.event.dest);
-			rbusObject_SetValue(outParams, "dest", value);
-			rbusValue_Release(value);
-		}
-
-		if(msg->u.event.content_type !=NULL)
-		{
-			rbusValue_Init(&value);
-			rbusValue_SetString(value, msg->u.event.content_type);
-			rbusObject_SetValue(outParams, "content_type", value);
-			rbusValue_Release(value);
-		}
-
-		rbusValue_Init(&value);
-		snprintf(qosstring, sizeof(qosstring), "%d", msg->u.event.qos);
-		ParodusPrint("qosstring is %s\n", qosstring);
-		rbusValue_SetString(value, qosstring);
-		rbusObject_SetValue(outParams, "qos", value);
-		rbusValue_Release(value);
-
-		if(msg->u.event.transaction_uuid !=NULL)
-		{
-			rbusValue_Init(&value);
-			rbusValue_SetString(value, msg->u.event.transaction_uuid);
-			rbusObject_SetValue(outParams, "transaction_uuid", value);
-			rbusValue_Release(value);
-			ParodusPrint("outParams msg->u.event.transaction_uuid %s\n", msg->u.event.transaction_uuid);
-		}
-	}
-
-	if(outParams !=NULL)
-	{
-		//rbusObject_fwrite(outParams, 1, stdout);
-		if(asyncHandle == NULL)
-		{
-			ParodusError("asyncHandle is NULL\n");
-			return;
-		}
-
-		err = rbusMethod_SendAsyncResponse(asyncHandle, error, outParams);
-		
-		if(err != RBUS_ERROR_SUCCESS)
-		{
-			ParodusError("rbusMethod_SendAsyncResponse failed err: %d\n", err);
-		}
-		else
-		{
-			ParodusInfo("rbusMethod_SendAsyncResponse success: %d\n", err);
-		}
-
-		rbusObject_Release(outParams);
-	}
-	else
-	{
-		ParodusError("Failed to create outParams\n");
-	}
-
-	return;
-}
-
-/*
-* @brief This function handles check method call from t2 before the actual inParams SET and to not proceed with inParams processing. 
-*/
-int checkInputParameters(rbusObject_t inParams)
-{
-	rbusValue_t check = rbusObject_GetValue(inParams, "check");
-	if(check)
-	{
-		ParodusPrint("Rbus check method. Not proceeding to process this inparam\n");
-		return 0;
-	}
-	return 1;
-}
-
-//To generate unique transaction id for xmidt send requests
-char* generate_transaction_uuid()
-{
-	char *transID = NULL;
-	uuid_t transaction_Id;
-	char *trans_id = NULL;
-	trans_id = (char *)malloc(37);
-	uuid_generate_random(transaction_Id);
-	uuid_unparse(transaction_Id, trans_id);
-
-	if(trans_id !=NULL)
-	{
-		transID = trans_id;
-	}
-	return transID;
-}
-
-void parseRbusInparamsToWrp(rbusObject_t inParams, char *trans_id, wrp_msg_t **eventMsg)
-{
-	char *msg_typeStr = NULL;
-	char *sourceVal = NULL;
-	char *destStr = NULL, *contenttypeStr = NULL;
-	char *payloadStr = NULL, *qosVal = NULL;
-	unsigned int payloadlength = 0;
-	wrp_msg_t *msg = NULL;
-
-	msg = ( wrp_msg_t * ) malloc( sizeof( wrp_msg_t ) );
-	if(msg == NULL)
-	{
-		ParodusError("Wrp msg allocation failed\n");
-		return;
-	}
-
-	memset( msg, 0, sizeof( wrp_msg_t ) );
-
-	rbusValue_t msg_type = rbusObject_GetValue(inParams, "msg_type");
-	if(msg_type)
-	{
-		if(rbusValue_GetType(msg_type) == RBUS_STRING)
-		{
-			msg_typeStr = (char *) rbusValue_GetString(msg_type, NULL);
-			ParodusPrint("msg_type value received is %s\n", msg_typeStr);
-			if(msg_typeStr !=NULL)
-			{
-				if(strcmp(msg_typeStr, "event") ==0)
-				{
-					msg->msg_type = WRP_MSG_TYPE__EVENT;
-				}
-				else
-				{
-					ParodusError("msg_type received is not event : %s\n", msg_typeStr);
-				}
-			}
-		}
-	}
-	else
-	{
-		ParodusError("msg_type is empty\n");
-	}
-
-	rbusValue_t source = rbusObject_GetValue(inParams, "source");
-	if(source)
-	{
-		if(rbusValue_GetType(source) == RBUS_STRING)
-		{
-			sourceVal = (char *)rbusValue_GetString(source, NULL);
-			if(sourceVal !=NULL)
-			{
-				ParodusInfo("source value received is %s\n", sourceVal);
-				msg->u.event.source = strdup(sourceVal);
-			}
-			ParodusPrint("msg->u.event.source is %s\n", msg->u.event.source);
-		}
-	}
-	else
-	{
-		ParodusError("source is empty\n");
-	}
-
-	rbusValue_t dest = rbusObject_GetValue(inParams, "dest");
-	if(dest)
-	{
-		if(rbusValue_GetType(dest) == RBUS_STRING)
-		{
-			destStr = (char *)rbusValue_GetString(dest, NULL);
-			if(destStr !=NULL)
-			{
-				ParodusPrint("dest value received is %s\n", destStr);
-				msg->u.event.dest = strdup(destStr);
-				ParodusPrint("msg->u.event.dest is %s\n", msg->u.event.dest);
-			}
-		}
-	}
-	else
-	{
-		ParodusError("dest is empty\n");
-	}
-
-	rbusValue_t contenttype = rbusObject_GetValue(inParams, "content_type");
-	if(contenttype)
-	{
-		if(rbusValue_GetType(contenttype) == RBUS_STRING)
-		{
-			contenttypeStr = (char *)rbusValue_GetString(contenttype, NULL);
-			if(contenttypeStr !=NULL)
-			{
-				ParodusPrint("contenttype value received is %s\n", contenttypeStr);
-				msg->u.event.content_type = strdup(contenttypeStr);
-				ParodusPrint("msg->u.event.content_type is %s\n", msg->u.event.content_type);
-			}
-		}
-	}
-	else
-	{
-		ParodusError("contenttype is empty\n");
-	}
-
-	rbusValue_t payload = rbusObject_GetValue(inParams, "payload");
-	if(payload)
-	{
-		if((rbusValue_GetType(payload) == RBUS_STRING))
-		{
-			payloadStr = (char *)rbusValue_GetString(payload, NULL);
-			if(payloadStr !=NULL)
-			{
-				ParodusPrint("payload received is %s\n", payloadStr);
-				msg->u.event.payload = strdup(payloadStr);
-				ParodusPrint("msg->u.event.payload is %s\n", msg->u.event.payload);
-			}
-			else
-			{
-				ParodusError("payloadStr is empty\n");
-			}
-		}
-	}
-	else
-	{
-		ParodusError("payload is empty\n");
-	}
-
-	rbusValue_t payloadlen = rbusObject_GetValue(inParams, "payloadlen");
-	if(payloadlen)
-	{
-		if(rbusValue_GetType(payloadlen) == RBUS_INT32)
-		{
-			ParodusPrint("payloadlen type %d RBUS_INT32 %d\n", rbusValue_GetType(payloadlen), RBUS_INT32);
-			payloadlength = rbusValue_GetInt32(payloadlen);
-			ParodusPrint("payloadlen received is %lu\n", payloadlength);
-			msg->u.event.payload_size = (size_t) payloadlength;
-			ParodusPrint("msg->u.event.payload_size is %lu\n", msg->u.event.payload_size);
-		}
-	}
-	else
-	{
-		ParodusError("payloadlen is empty\n");
-	}
-
-	ParodusPrint("check qos\n");
-	rbusValue_t qos = rbusObject_GetValue(inParams, "qos");
-	if(qos)
-	{
-		if(rbusValue_GetType(qos) == RBUS_STRING)
-		{
-			ParodusPrint("qos type %d RBUS_STRING %d\n", rbusValue_GetType(qos), RBUS_STRING);
-			qosVal = (char *)rbusValue_GetString(qos, NULL);
-			ParodusPrint("qos received is %s\n", qosVal);
-			if(qosVal !=NULL)
-			{
-				msg->u.event.qos = atoi(qosVal);
-				ParodusPrint("msg->u.event.qos is %d\n", msg->u.event.qos);
-			}
-		}
-	}
-
-	if(trans_id !=NULL)
-	{
-			ParodusPrint("Add trans_id %s to wrp message\n", trans_id);
-			msg->u.event.transaction_uuid = strdup(trans_id);
-			free(trans_id);
-			trans_id = NULL;
-			ParodusPrint("msg->u.event.transaction_uuid is %s\n", msg->u.event.transaction_uuid);
-	}
-	else
-	{
-		ParodusError("transaction_uuid is empty\n");
-	}
-
-	*eventMsg = msg;
-	ParodusPrint("parseRbusInparamsToWrp End\n");
-}
-
-static rbusError_t sendDataHandler(rbusHandle_t handle, char const* methodName, rbusObject_t inParams, rbusObject_t outParams, rbusMethodAsyncHandle_t asyncHandle)
-{
-	(void) handle;
-	(void) outParams;
-	int inStatus = 0;
-	char *transaction_uuid = NULL;
-	wrp_msg_t *wrpMsg= NULL;
-	ParodusInfo("methodHandler called: %s\n", methodName);
-	//printRBUSParams(inParams, INPARAMS_PATH);
-
-	if((methodName !=NULL) && (strcmp(methodName, XMIDT_SEND_METHOD) == 0))
-	{
-		inStatus = checkInputParameters(inParams);
-		if(inStatus)
-		{
-			//generate transaction id to create outParams and send ack
-			transaction_uuid = generate_transaction_uuid();
-			ParodusInfo("xmidt transaction_uuid generated is %s\n", transaction_uuid);
-			parseRbusInparamsToWrp(inParams, transaction_uuid, &wrpMsg);
-
-			//xmidt send producer
-			addToXmidtUpstreamQ(wrpMsg, asyncHandle);
-			ParodusInfo("sendDataHandler returned %d\n", RBUS_ERROR_ASYNC_RESPONSE);
-			return RBUS_ERROR_ASYNC_RESPONSE;
-		}
-		else
-		{
-			ParodusPrint("check method call received, ignoring input\n");
-		}
-	}
-	else
-	{
-		ParodusError("Method %s received is not supported\n", methodName);
-		return RBUS_ERROR_BUS_ERROR;
-	}
-	ParodusPrint("send RBUS_ERROR_SUCCESS\n");
-	return RBUS_ERROR_SUCCESS;
-}
-
-
-int regXmidtSendDataMethod()
-{
-	int rc = RBUS_ERROR_SUCCESS;
-	rbusDataElement_t dataElements[1] = { { XMIDT_SEND_METHOD, RBUS_ELEMENT_TYPE_METHOD, { NULL, NULL, NULL, NULL, NULL, sendDataHandler } } };
-
-	rbusHandle_t rbus_handle = get_parodus_rbus_Handle();
-
-	ParodusPrint("Registering xmidt sendData method %s\n", XMIDT_SEND_METHOD);
-	if(!rbus_handle)
-	{
-		ParodusError("regXmidtSendDataMethod failed as rbus_handle is empty\n");
-		return -1;
-	}
-
-	rc = rbus_regDataElements(rbus_handle, 1, dataElements);
-	
-	if(rc != RBUS_ERROR_SUCCESS)
-	{
-		ParodusError("Register xmidt sendData method failed: %d\n", rc);
-	}
-	else
-	{
-		ParodusInfo("Register xmidt sendData method %s success\n", XMIDT_SEND_METHOD);
-
-		//start xmidt queue consumer thread .
-		processXmidtData();
-	}
-	return rc;
-}
-
-//To print and store params output to a file
-void printRBUSParams(rbusObject_t params, char* file_path)
-{
-      if( NULL != params )
-      {
-          FILE *fd = fopen(file_path, "w+");
-          rbusObject_fwrite(params, 1, fd);
-          fclose(fd);
-      }
-      else
-      {
-           ParodusError("Params is NULL\n");
-      }
-}

src/xmidtsend_rbus.h

@@ -1,87 +0,0 @@
-/**
- * Copyright 2022 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-/**
- * @file xmidtsend_rbus.h
- *
- * @description This header defines functions required to manage xmidt send messages via rbus.
- *
- */
- 
-#ifndef _XMIDTSEND_RBUS_H_
-#define _XMIDTSEND_RBUS_H_
-#include <rbus.h>
-#include <uuid/uuid.h>
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-#define XMIDT_SEND_METHOD "Device.X_RDK_Xmidt.SendData"
-#define MAX_QUEUE_SIZE 10
-#define INPARAMS_PATH   "/tmp/inparams.txt"
-/*----------------------------------------------------------------------------*/
-/*                               Data Structures                              */
-/*----------------------------------------------------------------------------*/
-typedef struct XmidtMsg__
-{
-	wrp_msg_t *msg;
-	rbusMethodAsyncHandle_t asyncHandle;
-	struct XmidtMsg__ *next;
-} XmidtMsg;
-
-typedef enum
-{
-    DELIVERED_SUCCESS = 0,
-    INVALID_MSG_TYPE,
-    MISSING_SOURCE,
-    MISSING_DEST,
-    MISSING_CONTENT_TYPE,
-    MISSING_PAYLOAD,
-    MISSING_PAYLOADLEN,
-    INVALID_CONTENT_TYPE,
-    ENQUEUE_FAILURE = 100,
-    CLIENT_DISCONNECT = 101,
-    QUEUE_SIZE_EXCEEDED = 102,
-    WRP_ENCODE_FAILURE = 103,
-    MSG_PROCESSING_FAILED = 104
-} XMIDT_STATUS;
-/*----------------------------------------------------------------------------*/
-/*                             Function Prototypes                            */
-/*----------------------------------------------------------------------------*/
-
-rbusHandle_t get_parodus_rbus_Handle(void);
-void addToXmidtUpstreamQ(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle);
-void* processXmidtUpstreamMsg();
-void processXmidtData();
-int processData(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle);
-void sendXmidtEventToServer(wrp_msg_t * msg, rbusMethodAsyncHandle_t asyncHandle);
-int checkInputParameters(rbusObject_t inParams);
-char* generate_transaction_uuid();
-void parseRbusInparamsToWrp(rbusObject_t inParams, char *trans_id, wrp_msg_t **eventMsg);
-void createOutParamsandSendAck(wrp_msg_t *msg, rbusMethodAsyncHandle_t asyncHandle, char *errorMsg, int statuscode, rbusError_t error);
-int validateXmidtData(wrp_msg_t * eventMsg, char **errorMsg, int *statusCode);
-void xmidtQDequeue();
-void printSendMsgData(char* status, int qos, char* dest, char* transaction_uuid);
-bool highQosValueCheck(int qos);
-void waitTillConnectionIsUp();
-void printRBUSParams(rbusObject_t params, char* file_path);
-#ifdef __cplusplus
-}
-#endif
-
-
-#endif /* _XMIDTSEND_RBUS_H_ */
-

tests/CMakeLists.txt

@@ -1,4 +1,4 @@
-#   Copyright 2016 Comcast Cable Communications Management, LLCD
+#   Copyright 2016 Comcast Cable Communications Management, LLC
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -16,392 +16,205 @@ set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -W -g -fprofile-arcs -ftest-coverage
 set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DTEST ")
 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -W  -g -fprofile-arcs -ftest-coverage -O0")
 set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fprofile-arcs -ftest-coverage -O0")
-set (PARODUS_COMMON_SRC ../src/string_helpers.c ../src/mutex.c 
-  ../src/time.c ../src/config.c ../src/spin_thread.c 
-  ../src/event_handler.c ../src/token.c)
-set (PARODUS_COMMON_LIBS gcov -lcunit -lcimplog -lwrp-c
- -luuid -lmsgpackc -lnopoll -lnanomsg -lpthread
- -Wl,--no-as-needed -lcjson -lcjwt -ltrower-base64
- -lssl -lcrypto -lrt -lm)
-
-if (ENABLE_SESHAT)
-set (PARODUS_COMMON_LIBS -llibseshat ${PARODUS_COMMON_LIBS})
-endif (ENABLE_SESHAT)
-
-if (FEATURE_DNS_QUERY)
-set (PARODUS_COMMON_LIBS ${PARODUS_COMMON_LIBS} -lucresolv -lresolv)
-endif (FEATURE_DNS_QUERY)
-
-if (ENABLE_WEBCFGBIN)
-set (PARODUS_COMMON_LIBS ${PARODUS_COMMON_LIBS} -lrbus -lrbus-core)
-endif (ENABLE_WEBCFGBIN)
-
-if(NOT DISABLE_VALGRIND)
-set (MEMORY_CHECK valgrind --leak-check=full --show-reachable=yes -v)
-endif ()
+set (PARODUS_COMMON_SRC ../src/string_helpers.c ../src/mutex.c ../src/time.c ../src/config.c ../src/spin_thread.c)
+set (PARODUS_COMMON_LIBS gcov -lcunit -lcimplog -llibseshat -lwrp-c -luuid -lpthread -lm -lmsgpackc -lcjson -ltrower-base64 -lnopoll -lnanomsg -Wl,--no-as-needed -lrt)
 
 link_directories ( ${LIBRARY_DIR} )
 
-#-------------------------------------------------------------------------------
-#   test_heartBeatTimer
-#-------------------------------------------------------------------------------
-add_test(NAME test_heartBeatTimer COMMAND ${MEMORY_CHECK} ./test_heartBeatTimer)
-add_executable(test_heartBeatTimer test_heartBeatTimer.c ../src/heartBeat.c)
-target_link_libraries (test_heartBeatTimer ${PARODUS_COMMON_LIBS} -lcmocka)
-
-#-------------------------------------------------------------------------------
-#   test_close_retry
-#-------------------------------------------------------------------------------
-add_test(NAME test_close_retry COMMAND ${MEMORY_CHECK} ./test_close_retry)
-add_executable(test_close_retry test_close_retry.c ../src/close_retry.c)
-target_link_libraries (test_close_retry ${PARODUS_COMMON_LIBS} -lcmocka)
-
 #-------------------------------------------------------------------------------
 #   test_mutex
 #-------------------------------------------------------------------------------
-add_test(NAME test_mutex COMMAND ${MEMORY_CHECK} ./test_mutex)
+add_test(NAME test_mutex COMMAND test_mutex)
 add_executable(test_mutex test_mutex.c ../src/mutex.c)
 target_link_libraries (test_mutex ${PARODUS_COMMON_LIBS} -lcmocka)
 
 #-------------------------------------------------------------------------------
 #   test_networking
 #-------------------------------------------------------------------------------
-add_test(NAME test_networking COMMAND ${MEMORY_CHECK} ./test_networking)
+add_test(NAME test_networking COMMAND test_networking)
 add_executable(test_networking test_networking.c ../src/networking.c)
 target_link_libraries (test_networking ${PARODUS_COMMON_LIBS})
 
 #-------------------------------------------------------------------------------
 #   test_nopoll_helpers
 #-------------------------------------------------------------------------------
-add_test(NAME test_nopoll_helpers COMMAND ${MEMORY_CHECK} ./test_nopoll_helpers)
+add_test(NAME test_nopoll_helpers COMMAND test_nopoll_helpers)
 add_executable(test_nopoll_helpers test_nopoll_helpers.c ../src/nopoll_helpers.c)
 target_link_libraries (test_nopoll_helpers -Wl,--no-as-needed -lrt -lcmocka -lcimplog -lnopoll)
 
+#-------------------------------------------------------------------------------
+#   libpd_test
+#-------------------------------------------------------------------------------
+add_executable (libpd_test libpd_test.c)
+
+target_link_libraries (libpd_test
+                       cunit
+                       -llibparodus
+                       -lwrp-c
+		       -llibseshat
+		       -luuid
+                       -lmsgpackc
+                       -ltrower-base64
+                       -lnanomsg
+                       -lcimplog 
+                       -lm
+                       -lpthread
+                       -lrt)
+
 #-------------------------------------------------------------------------------
 #   test_time
 #-------------------------------------------------------------------------------
-add_test(NAME test_time COMMAND ${MEMORY_CHECK} ./test_time)
+add_test(NAME test_time COMMAND test_time)
 add_executable(test_time test_time.c ../src/time.c)
 target_link_libraries (test_time ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_spin_thread error
 #-------------------------------------------------------------------------------
-add_test(NAME test_spin_thread_e COMMAND ${MEMORY_CHECK} ./test_spin_thread_e)
+add_test(NAME test_spin_thread_e COMMAND test_spin_thread_e)
 add_executable(test_spin_thread_e test_spin_thread_e.c ../src/spin_thread.c)
 target_link_libraries (test_spin_thread_e ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_spin_thread success
 #-------------------------------------------------------------------------------
-# add_test(NAME test_spin_thread_s COMMAND ${MEMORY_CHECK} ./test_spin_thread_s)
-# add_executable(test_spin_thread_s test_spin_thread_s.c ../src/spin_thread.c)
-# target_link_libraries (test_spin_thread_s ${PARODUS_COMMON_LIBS} )
+add_test(NAME test_spin_thread_s COMMAND test_spin_thread_s)
+add_executable(test_spin_thread_s test_spin_thread_s.c ../src/spin_thread.c)
+target_link_libraries (test_spin_thread_s ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_string_helpers 
 #-------------------------------------------------------------------------------
-# add_test(NAME test_string_helpers COMMAND ${MEMORY_CHECK} ./test_string_helpers)
-# add_executable(test_string_helpers test_string_helpers.c ../src/string_helpers.c)
-# target_link_libraries (test_string_helpers ${PARODUS_COMMON_LIBS} )
+add_test(NAME test_string_helpers COMMAND test_string_helpers)
+add_executable(test_string_helpers test_string_helpers.c ../src/string_helpers.c)
+target_link_libraries (test_string_helpers ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_nopoll_handlers
 #-------------------------------------------------------------------------------
-add_test(NAME test_nopoll_handlers COMMAND ${MEMORY_CHECK} ./test_nopoll_handlers)
-add_executable(test_nopoll_handlers test_nopoll_handlers.c ../src/nopoll_handlers.c ../src/heartBeat.c ../src/close_retry.c)
+add_test(NAME test_nopoll_handlers COMMAND test_nopoll_handlers)
+add_executable(test_nopoll_handlers test_nopoll_handlers.c ../src/nopoll_handlers.c)
 target_link_libraries (test_nopoll_handlers -lnopoll -lcunit -lcimplog -Wl,--no-as-needed -lrt -lpthread -lm)
 
-
-#-------------------------------------------------------------------------------
-#   test_nopoll_handlers_fragment
-#-------------------------------------------------------------------------------
-add_test(NAME test_nopoll_handlers_fragment COMMAND ${MEMORY_CHECK} ./test_nopoll_handlers_fragment)
-add_executable(test_nopoll_handlers_fragment test_nopoll_handlers_fragment.c ../src/nopoll_handlers.c ../src/heartBeat.c ../src/close_retry.c)
-target_link_libraries (test_nopoll_handlers_fragment -lnopoll -lcunit -lcimplog -Wl,--no-as-needed -lrt -lpthread -lm -lcmocka)
-
 #-------------------------------------------------------------------------------
 #   test_connection
 #-------------------------------------------------------------------------------
-add_test(NAME test_connection COMMAND ${MEMORY_CHECK} ./test_connection)
-set (CONN_SRC ../src/connection.c 
-  ../src/string_helpers.c ../src/mutex.c ../src/time.c 
-  ../src/config.c ../src/auth_token.c ../src/spin_thread.c  ../src/heartBeat.c ../src/close_retry.c)
-#set(CONN_SRC ../src/connection.c ${PARODUS_COMMON_SRC})
-add_executable(test_connection test_connection.c ${CONN_SRC})
-target_link_libraries (test_connection ${PARODUS_COMMON_LIBS} -lcmocka -lcurl -luuid)
+add_test(NAME test_connection COMMAND test_connection)
+add_executable(test_connection test_connection.c ../src/connection.c ${PARODUS_COMMON_SRC}) 
+target_link_libraries (test_connection ${PARODUS_COMMON_LIBS} -lcmocka)
 
 #-------------------------------------------------------------------------------
 #   test_connection - function createNopollConnection
 #-------------------------------------------------------------------------------
-#add_test(NAME test_createConnection COMMAND ${MEMORY_CHECK} ./test_createConnection)
-#add_executable(test_createConnection test_createConnection.c ../src/connection.c ../src/string_helpers.c ../src/config.c) 
-#target_link_libraries (test_createConnection ${PARODUS_COMMON_LIBS} -lcmocka)
-#add_executable(test_createConnection test_createConnection.c ../src/connection.c ../src/string_helpers.c ../src/config.c ../src/heartBeat.c) 
-#target_link_libraries (test_createConnection ${PARODUS_CONN_LIBS} ${PARODUS_COMMON_LIBS} -lcmocka )
-#target_link_libraries (test_createConnection ${PARODUS_COMMON_LIBS} -lcmocka )
+add_test(NAME test_createConnection COMMAND test_createConnection)
+add_executable(test_createConnection test_createConnection.c ../src/connection.c ../src/string_helpers.c ../src/config.c) 
+target_link_libraries (test_createConnection ${PARODUS_COMMON_LIBS} -lcmocka)
 
 #-------------------------------------------------------------------------------
 #   test_client_list
 #-------------------------------------------------------------------------------
-add_test(NAME test_client_list COMMAND ${MEMORY_CHECK} ./test_client_list)
-#add_executable(test_client_list test_client_list.c ../src/client_list.c ../src/service_alive.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/downstream.c ../src/connection.c ../src/nopoll_handlers.c ../src/ParodusInternal.c ../src/thread_tasks.c ../src/conn_interface.c ../src/partners_check.c ${PARODUS_COMMON_SRC})
-#target_link_libraries (test_client_list ${PARODUS_COMMON_LIBS})
-set(CLIST_SRC test_client_list.c ../src/client_list.c ../src/auth_token.c
- ../src/service_alive.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c 
- ../src/downstream.c ../src/connection.c ../src/nopoll_handlers.c ../src/heartBeat.c ../src/close_retry.c
- ../src/ParodusInternal.c ../src/thread_tasks.c ../src/conn_interface.c 
- ../src/partners_check.c ../src/crud_interface.c ../src/crud_tasks.c ../src/crud_internal.c ${PARODUS_COMMON_SRC})
-
-if (ENABLE_SESHAT)
-set(CLIST_SRC ${CLIST_SRC} ../src/seshat_interface.c)
-else()
-set(CLIST_SRC ${CLIST_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-
-if (ENABLE_WEBCFGBIN)
-set(CLIST_SRC ${CLIST_SRC} ../src/upstream_rbus.c ../src/xmidtsend_rbus.c)
-endif (ENABLE_WEBCFGBIN)
-
-add_executable(test_client_list ${CLIST_SRC})
-#target_link_libraries (test_client_list ${PARODUS_CONN_LIBS} ${PARODUS_COMMON_LIBS})
-target_link_libraries (test_client_list ${PARODUS_COMMON_LIBS} -lcurl -luuid)
+add_test(NAME test_client_list COMMAND test_client_list)
+add_executable(test_client_list test_client_list.c ../src/client_list.c ../src/service_alive.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/downstream.c ../src/connection.c ../src/nopoll_handlers.c ../src/ParodusInternal.c ../src/thread_tasks.c ../src/conn_interface.c ../src/partners_check.c ${PARODUS_COMMON_SRC})
+target_link_libraries (test_client_list ${PARODUS_COMMON_LIBS})
 
 #-------------------------------------------------------------------------------
 #   test_service_alive
 #-------------------------------------------------------------------------------
-add_test(NAME test_service_alive COMMAND ${MEMORY_CHECK} ./test_service_alive)
-#add_executable(test_service_alive test_service_alive.c ../src/client_list.c ../src/service_alive.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/nopoll_handlers.c ../src/config.c ../src/connection.c ../src/ParodusInternal.c ../src/downstream.c ../src/thread_tasks.c ../src/conn_interface.c ../src/partners_check.c ${PARODUS_COMMON_SRC})
-#target_link_libraries (test_service_alive ${PARODUS_COMMON_LIBS})
-set(SVA_SRC test_service_alive.c ../src/client_list.c ../src/service_alive.c ../src/auth_token.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/nopoll_handlers.c ../src/config.c ../src/connection.c ../src/ParodusInternal.c ../src/downstream.c ../src/thread_tasks.c ../src/conn_interface.c ../src/partners_check.c ../src/heartBeat.c ../src/close_retry.c ${PARODUS_COMMON_SRC})
-if (ENABLE_SESHAT)
-set(SVA_SRC ${SVA_SRC} ../src/seshat_interface.c)
-else()
-set(SVA_SRC ${SVA_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-
-if (ENABLE_WEBCFGBIN)
-set(SVA_SRC ${SVA_SRC} ../src/upstream_rbus.c ../src/xmidtsend_rbus.c)
-endif (ENABLE_WEBCFGBIN)
-
-add_executable(test_service_alive ${SVA_SRC})
-#target_link_libraries (test_service_alive ${PARODUS_CONN_LIBS} ${PARODUS_COMMON_LIBS})
-target_link_libraries (test_service_alive ${PARODUS_COMMON_LIBS} -lcurl -luuid)
+add_test(NAME test_service_alive COMMAND test_service_alive)
+add_executable(test_service_alive test_service_alive.c ../src/client_list.c ../src/service_alive.c ../src/upstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/nopoll_handlers.c ../src/config.c ../src/connection.c ../src/ParodusInternal.c ../src/downstream.c ../src/thread_tasks.c ../src/conn_interface.c ../src/partners_check.c ${PARODUS_COMMON_SRC})
+target_link_libraries (test_service_alive ${PARODUS_COMMON_LIBS})
 
 #-------------------------------------------------------------------------------
 #   test_config
 #-------------------------------------------------------------------------------
-add_test(NAME test_config COMMAND ${MEMORY_CHECK} ./test_config)
-add_executable(test_config test_config.c ../src/config.c ../src/auth_token.c ../src/string_helpers.c)
-target_link_libraries (test_config -lcmocka
- -Wl,--no-as-needed -lcimplog
- -lcjson -lcjwt -ltrower-base64 -lssl -lcrypto -lrt -lm -lcurl -luuid
-)
-
-#-------------------------------------------------------------------------------
-#   test_auth_token
-#-------------------------------------------------------------------------------
-add_test(NAME test_auth_token COMMAND ${MEMORY_CHECK} ./test_auth_token)
-add_executable(test_auth_token test_auth_token.c ../src/config.c ../src/auth_token.c ../src/string_helpers.c)
-target_link_libraries (test_auth_token -lcmocka
- -Wl,--no-as-needed -lcimplog
- -lcjson -lcjwt -ltrower-base64 -lssl -lcrypto -lrt -lm -lcurl -luuid
-)
-
-#-------------------------------------------------------------------------------
-#   test_auth_token_more
-#-------------------------------------------------------------------------------
-add_test(NAME test_auth_token_more COMMAND ${MEMORY_CHECK} ./test_auth_token_more)
-add_executable(test_auth_token_more test_auth_token_more.c ../src/config.c ../src/auth_token.c ../src/string_helpers.c)
-target_link_libraries (test_auth_token_more -lcmocka
- -Wl,--no-as-needed -lcimplog
- -lcjson -lcjwt -ltrower-base64 -lssl -lcrypto -lrt -lm -lcurl -luuid
-)
-
-#-------------------------------------------------------------------------------
-#   test_crud_interface
-#-------------------------------------------------------------------------------
-add_test(NAME test_crud_interface COMMAND ${MEMORY_CHECK} ./test_crud_interface)
-add_executable(test_crud_interface test_crud_interface.c ../src/crud_interface.c ../src/ParodusInternal.c)
-target_link_libraries (test_crud_interface -lcmocka ${PARODUS_COMMON_LIBS} )
-
-#-------------------------------------------------------------------------------
-#   test_crud_tasks
-#-------------------------------------------------------------------------------
-add_test(NAME test_crud_tasks COMMAND ${MEMORY_CHECK} ./test_crud_tasks)
-add_executable(test_crud_tasks test_crud_tasks.c ../src/crud_tasks.c )
-target_link_libraries (test_crud_tasks -lcmocka ${PARODUS_COMMON_LIBS} )
-
-#-------------------------------------------------------------------------------
-#   test_crud_internal
-#-------------------------------------------------------------------------------
-add_test(NAME test_crud_internal COMMAND ${MEMORY_CHECK} ./test_crud_internal)
-add_executable(test_crud_internal test_crud_internal.c ../src/config.c ../src/close_retry.c 
-  ../src/ParodusInternal.c ../src/string_helpers.c ../src/crud_internal.c ../src/client_list.c)
-target_link_libraries (test_crud_internal -lcmocka ${PARODUS_COMMON_LIBS} -lcurl -luuid)
+add_test(NAME test_config COMMAND test_config)
+add_executable(test_config test_config.c ../src/config.c ../src/string_helpers.c)
+target_link_libraries (test_config -lcmocka -lm -Wl,--no-as-needed -lrt -lcimplog)
 
 #-------------------------------------------------------------------------------
 #   test_upstream
 #-------------------------------------------------------------------------------
-add_test(NAME test_upstream COMMAND ${MEMORY_CHECK} ./test_upstream)
-add_executable(test_upstream test_upstream.c ../src/upstream.c ../src/close_retry.c ../src/string_helpers.c)
-target_link_libraries (test_upstream -lcmocka gcov -lcunit -lcimplog
- -lwrp-c -luuid -lpthread -lmsgpackc -lnopoll
- -Wl,--no-as-needed -lcjson -lcjwt -ltrower-base64
- -lssl -lcrypto -lrt -lm -lnanomsg)
-
-#-------------------------------------------------------------------------------
-#   test_upstream_sock
-#-------------------------------------------------------------------------------
-add_test(NAME test_upstream_sock COMMAND ${MEMORY_CHECK} ./test_upstream_sock)
-add_executable(test_upstream_sock test_upstream_sock.c ../src/upstream.c 
-  ../src/client_list.c ../src/close_retry.c ../src/string_helpers.c)
-target_link_libraries (test_upstream_sock -lcmocka gcov -lcunit -lcimplog
- -lwrp-c -luuid -lpthread -lmsgpackc -lnopoll -lnanomsg
- -Wl,--no-as-needed -lcjson -lcjwt -ltrower-base64
- -lssl -lcrypto -lrt -lm)
+add_test(NAME test_upstream COMMAND test_upstream)
+add_executable(test_upstream test_upstream.c ../src/upstream.c)
+target_link_libraries (test_upstream -lcmocka ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_downstream
 #-------------------------------------------------------------------------------
-add_test(NAME test_downstream COMMAND ${MEMORY_CHECK} ./test_downstream)
+add_test(NAME test_downstream COMMAND test_downstream)
 add_executable(test_downstream test_downstream.c ../src/downstream.c ../src/string_helpers.c)
-target_link_libraries (test_downstream -lcmocka gcov -lcunit -lcimplog
- -lwrp-c -luuid -lpthread -lmsgpackc -lnopoll
- -Wl,--no-as-needed -lcjson -lcjwt -ltrower-base64
- -lssl -lcrypto -lrt -lm)
-
-#-------------------------------------------------------------------------------
-#   test_downstream_more
-#-------------------------------------------------------------------------------
-add_test(NAME test_downstream_more COMMAND ${MEMORY_CHECK} ./test_downstream_more)
-add_executable(test_downstream_more test_downstream_more.c ../src/downstream.c ../src/string_helpers.c)
-target_link_libraries (test_downstream_more -lcmocka ${PARODUS_COMMON_LIBS} )
+target_link_libraries (test_downstream -lcmocka ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_thread_tasks
 #-------------------------------------------------------------------------------
-add_test(NAME test_thread_tasks COMMAND ${MEMORY_CHECK} ./test_thread_tasks)
+add_test(NAME test_thread_tasks COMMAND test_thread_tasks)
 add_executable(test_thread_tasks test_thread_tasks.c ../src/thread_tasks.c)
 target_link_libraries (test_thread_tasks -lcmocka ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_conn_interface
 #-------------------------------------------------------------------------------
-add_test(NAME test_conn_interface COMMAND ${MEMORY_CHECK} ./test_conn_interface)
-set(CONIFC_SRC test_conn_interface.c 
-  ../src/crud_interface.c ../src/crud_tasks.c ../src/crud_internal.c 
-  ../src/conn_interface.c 
-  ../src/config.c 
-  ../src/token.c
-  ../src/string_helpers.c 
-  ../src/mutex.c
-  ../src/heartBeat.c
-  ../src/close_retry.c
-  ../src/event_handler.c
-  ../src/client_list.c
-)
-if (ENABLE_SESHAT)
-set(CONIFC_SRC ${CONIFC_SRC} ../src/seshat_interface.c)
-else()
-set(CONIFC_SRC ${CONIFC_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-if (ENABLE_WEBCFGBIN)
-set(CONIFC_SRC ${CONIFC_SRC} ../src/upstream_rbus.c ../src/xmidtsend_rbus.c)
-endif (ENABLE_WEBCFGBIN)
-add_executable(test_conn_interface ${CONIFC_SRC})
-target_link_libraries (test_conn_interface -lcmocka ${PARODUS_COMMON_LIBS} -lcurl -luuid )
+add_test(NAME test_conn_interface COMMAND test_conn_interface)
+add_executable(test_conn_interface test_conn_interface.c ../src/conn_interface.c ../src/config.c ../src/string_helpers.c ../src/mutex.c)
+target_link_libraries (test_conn_interface -lcmocka ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_ParodusInternal
 #-------------------------------------------------------------------------------
-add_test(NAME test_ParodusInternal COMMAND ${MEMORY_CHECK} ./test_ParodusInternal)
+add_test(NAME test_ParodusInternal COMMAND test_ParodusInternal)
 add_executable(test_ParodusInternal test_ParodusInternal.c ../src/ParodusInternal.c ../src/config.c ../src/string_helpers.c)
-target_link_libraries (test_ParodusInternal -lcmocka ${PARODUS_COMMON_LIBS} -lcurl -luuid)
+target_link_libraries (test_ParodusInternal -lcmocka ${PARODUS_COMMON_LIBS} )
 
 #-------------------------------------------------------------------------------
 #   test_partners_check
 #-------------------------------------------------------------------------------
-add_test(NAME test_partners_check COMMAND ${MEMORY_CHECK} ./test_partners_check)
-add_executable(test_partners_check test_partners_check.c ../src/partners_check.c ../src/string_helpers.c)
-target_link_libraries (test_partners_check -lcmocka ${PARODUS_COMMON_LIBS} -lwrp-c)
-
-#-------------------------------------------------------------------------------
-#   test_token - token.c tests
-#-------------------------------------------------------------------------------
-add_test(NAME test_token COMMAND ${MEMORY_CHECK} ./test_token)
-set(TOKEN_SRC ../src/conn_interface.c ../src/config.c
- ../src/connection.c ../src/spin_thread.c
- ../src/service_alive.c ../src/client_list.c
- ../src/nopoll_handlers.c ../src/nopoll_helpers.c
- ../src/partners_check.c ../src/ParodusInternal.c
- ../src/upstream.c ../src/downstream.c 
- ../src/networking.c ../src/auth_token.c
- ../src/thread_tasks.c ../src/time.c
- ../src/string_helpers.c ../src/mutex.c 
- ../src/token.c ../src/heartBeat.c
- ../src/close_retry.c ../src/event_handler.c
- )
-
-if (ENABLE_SESHAT)
-set(TOKEN_SRC ${TOKEN_SRC} ../src/seshat_interface.c)
-else()
-set(TOKEN_SRC ${TOKEN_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-
-if (FEATURE_DNS_QUERY)
-set(TOKEN_SRC test_token.c ${TOKEN_SRC})
-else()
-set(TOKEN_SRC test_token_stub.c ${TOKEN_SRC})
-endif (FEATURE_DNS_QUERY)
-
-if (ENABLE_WEBCFGBIN)
-set(TOKEN_SRC ${TOKEN_SRC} ../src/upstream_rbus.c ../src/xmidtsend_rbus.c)
-endif (ENABLE_WEBCFGBIN)
-
-add_executable(test_token ${TOKEN_SRC} ) 
-#target_link_libraries (test_token ${PARODUS_COMMON_LIBS} ${PARODUS_JWT_LIBS} -lcmocka )
-target_link_libraries (test_token ${PARODUS_COMMON_LIBS} -lcmocka -lcurl -luuid)
-
-#-------------------------------------------------------------------------------
-#   test_seshat_interface - registerWithSeshat
-#-------------------------------------------------------------------------------
-add_test(NAME test_seshat_interface COMMAND ${MEMORY_CHECK} ./test_seshat_interface)
-if (ENABLE_SESHAT)
-set(SESHIFC_SRC test_seshat_interface.c ../src/seshat_interface.c ../src/string_helpers.c)
-else()
-set(SESHIFC_SRC test_seshat_interface_stub.c ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-add_executable(test_seshat_interface ${SESHIFC_SRC})
-target_link_libraries (test_seshat_interface -lcmocka ${PARODUS_COMMON_LIBS} -lwrp-c)
+add_test(NAME test_partners_check COMMAND test_partners_check)
+add_executable(test_partners_check test_partners_check.c ../src/partners_check.c)
+target_link_libraries (test_partners_check -lcmocka -lwrp-c -llibseshat ${PARODUS_COMMON_LIBS})
 
 if (INTEGRATION_TESTING)
 #-------------------------------------------------------------------------------
 #   simple_connection test
 #-------------------------------------------------------------------------------
-add_test(NAME simple_connection COMMAND ${MEMORY_CHECK} ./simple_connection)
-set(SIMCON_SRC simple_connection.c ${PARODUS_COMMON_SRC} ../src/upstream.c ../src/conn_interface.c
- ../src/thread_tasks.c ../src/downstream.c ../src/networking.c ../src/nopoll_helpers.c ../src/nopoll_handlers.c ../src/connection.c ../src/ParodusInternal.c ../src/client_list.c ../src/partners_check.c ../src/service_alive.c)
-if (ENABLE_SESHAT)
-set(SIMCON_SRC ${SIMCON_SRC} ../src/seshat_interface.c)
-else()
-set(SIMCON_SRC ${SIMCON_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-add_executable(simple_connection ${SIMCON_SRC}) 
-target_link_libraries (simple_connection ${PARODUS_CONN_LIBS} ${PARODUS_COMMON_LIBS} )
+add_test(NAME simple_connection COMMAND simple_connection)
+add_executable(simple_connection simple_connection.c ${PARODUS_COMMON_SRC}
+                    ../src/upstream.c
+                    ../src/conn_interface.c
+                    ../src/thread_tasks.c
+                    ../src/downstream.c
+                    ../src/networking.c
+                    ../src/nopoll_helpers.c
+                    ../src/nopoll_handlers.c
+                    ../src/connection.c
+                    ../src/ParodusInternal.c
+                    ../src/client_list.c
+                    ../src/partners_check.c
+                    ../src/service_alive.c) 
+target_link_libraries (simple_connection ${PARODUS_COMMON_LIBS})
 
 #-------------------------------------------------------------------------------
 #   simple test
 #-------------------------------------------------------------------------------
-add_test(NAME simple COMMAND ${MEMORY_CHECK} ./simple)
-set(SIMPLE_SRC simple.c ../src/upstream.c ../src/conn_interface.c ../src/downstream.c ../src/thread_tasks.c ../src/networking.c ../src/nopoll_helpers.c ../src/nopoll_handlers.c ../src/string_helpers.c ../src/mutex.c ../src/time.c
- ../src/config.c ../src/connection.c ../src/ParodusInternal.c ../src/spin_thread.c ../src/client_list.c ../src/partners_check.c ../src/service_alive.c)
-if (ENABLE_SESHAT)
-set(SIMPLE_SRC ${SIMPLE_SRC} ../src/seshat_interface.c)
-else()
-set(SIMPLE_SRC ${SIMPLE_SRC} ../src/seshat_interface_stub.c)
-endif (ENABLE_SESHAT)
-add_executable(simple ${SIMPLE_SRC}) 
+add_test(NAME simple COMMAND simple)
+add_executable(simple simple.c
+                    ../src/upstream.c
+                    ../src/conn_interface.c
+                    ../src/downstream.c
+                    ../src/thread_tasks.c
+                    ../src/networking.c
+                    ../src/nopoll_helpers.c
+                    ../src/nopoll_handlers.c
+                    ../src/string_helpers.c
+                    ../src/mutex.c
+                    ../src/time.c
+                    ../src/config.c
+                    ../src/connection.c
+                    ../src/ParodusInternal.c
+                    ../src/spin_thread.c
+                    ../src/client_list.c
+                    ../src/partners_check.c
+                    ../src/service_alive.c) 
 
-target_link_libraries (simple ${PARODUS_CONN_LIBS} ${PARODUS_COMMON_LIBS}  gcov -lnopoll )
+target_link_libraries (simple ${PARODUS_COMMON_LIBS} gcov -lnopoll -lnanomsg )
 endif (INTEGRATION_TESTING)

tests/key4.pem

@@ -1,28 +0,0 @@
------BEGIN PRIVATE KEY-----
-MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQDsLxH6GZFxU64v
-GL9CNz3hLSoCb7TckabgbVp6PIRy9cKEwfqnQ/2ohqrdolMA6Peru2+DgBs1iJ3u
-JNSc+8XFphUj0Jm2gVumVfclSZTEkM4xI4D3ABXn0Pj6/Ps5Skx9pXk3KI988ksB
-secD+FNqBPgmKWG0Gp+JSrPEwAtA4ZBP/4vtCGxEFzRCSOSBkTh27n1f08M4PjsY
-+vMvyTVF67y4Zb3nWJHpa1yOBlHid0xI138KPEBl+9Vai1AwRWbhlq52I9+IVjCo
-N7Ui9KbRgfd21SJFLh3hDw6xSrNqtcU+mvv5GuLAxHF5tCcGpAgKvKhvjQU4v+fh
-lGW77zkVAgMBAAECggEBAI8DoZsTyGIbDaovDgEGek3Tj1CSW64D9EyJavQBmSIT
-don0+9Y08XAOu4AhPqmaZ/5xLQEvnUo5Q4hkfOnh+svH2Z0qPymoAtshytmlSJQO
-KwzONtVaE+mfPGSes3DpcI/UlyWzRc+e15RbKUvaHohgIfLZs/Pe+yOjPF+y+h16
-Tpvklvk9GuS5/njOm0N8iRZw0+mKMLjwKCf0Q9WpF5OXW7hYccG9aTpmiUDnpixP
-nMyEdZMhmfFDLl+t6Txj3KhNX8jixDmfkuiPuoADWZuYk3GjS499nb3Y5Tmm8TLq
-jf0St48y1bObNnkceSqODnUK2hUZzzWcgTLwIC1E0DECgYEA+QoVuCA5i3eAiyE7
-PUsKpT0qVH/rWVWl0HYykUI7MSv0KJH7uPS+m2GzScxpCZoA4wtu6iK5IePNf645
-yJAleglx+1vuBGCWQrr206gOPWrkthfVHd+pDCr/fnIG+RdNr9SgwUx1youpovQ4
-x64RQuEyBXENt+xx2+fFI28GxEcCgYEA8skAisNqPgREewZ+hM2OkhIyU7GaKWgt
-HfjPYHHYWVO/sSfOdcyzcCUZJkseBhIVEmIeiXM4NCO0spmieHa6bo8oLr1nPMtm
-J4UkyVRPtO99V5mIBYOS3cWAEwEt7lWZ+4JiIyEBO/tMVjIrB8YkOE4LqV40Vvpu
-XGJbtw3JEcMCgYEA15xnmXYs3Bamb85hn3tsyArgry/g7wM7//OVbDXPUY8gYE+j
-hEpBC/3WX7pd5jYzNl8btBJD/pdfv39z/7Ts/W9YA6tfsuJ8tWFxeWYyjfIR+aVA
-mhCeJy7C7RKD/vyyAd0xIKm2AZpRUAfpcNe/kguuZw+uNOK84QsUnsztKtkCgYAE
-KBDMT2AoQ6ZwfMH5wBMqyQj3idjb0J7FHpdeTVSo4tgrTkUomyKPTvNJRovzCqg1
-slxXehOCQQI89Ihli5LRhb3oXvG/hrPvBUaF892ReXAp6cT8Yy5GgbUZnjGNHQYP
-2kGX3F7LChhaeW1nKqtAE4X7llNLEeqFxmFPlvrURQKBgA0c5s3WPeX5OfSRsLaF
-iXaQNQ88QORNJ4hp/L7/o3ZNy7elH/R3GM1fs8Yf711CDxy4qI7icRYyrkl0P/Py
-WyRbNnvw0JMa5xkzRgKlnvspfEfve7gzcZhE9yEw173MIyyoxIn43G9aGNSN3QIR
-51ZlCYyuIAgR7p+9lKvM74HR
------END PRIVATE KEY-----

tests/libpd_test.c

@@ -0,0 +1,402 @@
+/**
+ *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/wait.h>
+#include <stdarg.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <ctype.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <CUnit/Basic.h>
+#include <stdbool.h>
+
+#include <libparodus.h>
+#include <pthread.h>
+
+#define SEND_EVENT_MSGS 1
+
+//#define TCP_URL(ip) "tcp://" ip
+
+#define GOOD_CLIENT_URL "tcp://127.0.0.1:6667"
+//#define PARODUS_URL "ipc:///tmp/parodus_server.ipc"
+#define GOOD_PARODUS_URL "tcp://127.0.0.1:6666"
+//#define CLIENT_URL "ipc:///tmp/parodus_client.ipc"
+
+
+static void initEndKeypressHandler();
+static void *endKeypressHandlerTask();
+
+static pthread_t endKeypressThreadId;
+
+static const char *service_name = "iot";
+//static const char *service_name = "config";
+
+static bool no_mock_send_only_test = false;
+
+static libpd_instance_t test_instance;
+
+// libparodus functions to be tested
+extern int flush_wrp_queue (uint32_t delay_ms);
+extern int connect_receiver (const char *rcv_url);
+extern int connect_sender (const char *send_url);
+extern void shutdown_socket (int *sock);
+
+extern bool is_auth_received (void);
+extern int libparodus_receive__ (wrp_msg_t **msg, uint32_t ms);
+
+// libparodus_log functions to be tested
+extern int get_valid_file_num (const char *file_name, const char *date);
+extern int get_last_file_num_in_dir (const char *date, const char *log_dir);
+
+extern const char *wrp_queue_name;
+extern const char *parodus_url;
+extern const char *client_url;
+extern volatile int keep_alive_count;
+extern volatile int reconnect_count;
+
+void show_src_dest_payload (char *src, char *dest, void *payload, size_t payload_size)
+{
+	size_t i;
+	char *payload_str = (char *) payload;
+	printf (" SOURCE:  %s\n", src);
+	printf (" DEST  :  %s\n", dest);
+	printf (" PAYLOAD: ");
+	for (i=0; i<payload_size; i++)
+		putchar (payload_str[i]);
+	putchar ('\n');
+}
+
+void show_wrp_req_msg (struct wrp_req_msg *msg)
+{
+	show_src_dest_payload (msg->source, msg->dest, msg->payload, msg->payload_size);
+}
+
+void show_wrp_event_msg (struct wrp_event_msg *msg)
+{
+	show_src_dest_payload (msg->source, msg->dest, msg->payload, msg->payload_size);
+}
+
+void show_wrp_msg (wrp_msg_t *wrp_msg)
+{
+	printf ("Received WRP Msg type %d\n", wrp_msg->msg_type);
+	if (wrp_msg->msg_type == WRP_MSG_TYPE__REQ) {
+		show_wrp_req_msg (&wrp_msg->u.req);
+		return;
+	}
+	if (wrp_msg->msg_type == WRP_MSG_TYPE__EVENT) {
+		show_wrp_event_msg (&wrp_msg->u.event);
+		return;
+	}
+	return;
+}
+
+void send_reply (wrp_msg_t *wrp_msg)
+{
+	size_t i;
+	size_t payload_size = wrp_msg->u.req.payload_size;
+	char *payload = (char *) wrp_msg->u.req.payload;
+	char *temp;
+	// swap source and dest
+	temp = wrp_msg->u.req.source;
+	wrp_msg->u.req.source = wrp_msg->u.req.dest;
+	wrp_msg->u.req.dest = temp;
+	// Alter the payload
+	for (i=0; i<payload_size; i++)
+		payload[i] = tolower (payload[i]);
+	libparodus_send (test_instance, wrp_msg);
+}
+
+char *new_str (const char *str)
+{
+	char *buf = malloc (strlen(str) + 1);
+	if (NULL == buf)
+		return NULL;
+	strcpy (buf, str);
+	return buf;
+}
+
+void insert_number_into_buf (char *buf, unsigned num)
+{
+	char *pos = strrchr (buf, '#');
+	if (NULL == pos)
+		return;
+	while (true) {
+		*pos = (num%10) + '0';
+		num /= 10;
+		if (pos <= buf)
+			break;
+		pos--;
+		if (*pos != '#')
+			break;
+	}
+}
+
+int send_event_msg (const char *src, const char *dest, 
+	const char *payload, unsigned event_num)
+{
+	int rtn = 0;
+	char *payload_buf;
+	wrp_msg_t *new_msg;
+
+#ifndef SEND_EVENT_MSGS
+	return 0;
+#endif
+	new_msg = malloc (sizeof (wrp_msg_t));
+	if (NULL == new_msg)
+		return -1;
+	printf ("Making event msg\n");
+	new_msg->msg_type = WRP_MSG_TYPE__EVENT;
+	new_msg->u.event.source = new_str (src);
+	new_msg->u.event.dest = new_str (dest);
+	new_msg->u.event.headers = NULL;
+	new_msg->u.event.metadata = NULL;
+	payload_buf = new_str (payload);
+	insert_number_into_buf (payload_buf, event_num);
+	new_msg->u.event.payload = (void*) payload_buf;
+	new_msg->u.event.payload_size = strlen (payload) + 1;
+	printf ("Sending event msg %u\n", event_num);
+	rtn = libparodus_send (test_instance, new_msg);
+	//printf ("Freeing event msg\n");
+	wrp_free_struct (new_msg);
+	//printf ("Freed event msg\n");
+	return rtn;
+}
+
+int send_event_msgs (unsigned *msg_num, unsigned *event_num, int count)
+{
+	int i;
+	unsigned msg_num_mod;
+
+#ifndef SEND_EVENT_MSGS
+	return 0;
+#endif
+	if (NULL != msg_num) {
+		(*msg_num)++;
+		msg_num_mod = (*msg_num) % 3;
+		if (msg_num_mod != 0)
+			return 0;
+	}
+	for (i=0; i<count; i++) {
+		(*event_num)++;
+		if (send_event_msg ("---LIBPARODUS---", "---ParodusService---",
+			"---EventMessagePayload####", *event_num) != 0)
+			return -1;
+	}
+	return 0;
+}
+
+int get_msg_num (const char *msg)
+{
+	int num = -1;
+	bool found_pound = false;
+	int i;
+	char c;
+
+	for (i=0; (c=msg[i]) != 0; i++)
+	{
+		if (!found_pound) {
+			if (c == '#')
+				found_pound = true;
+			continue;
+		}
+		if ((c>='0') && (c<='9')) {
+			if (num == -1)
+				num = c - '0';
+			else
+				num = 10*num + (c - '0');
+		}
+	}
+	return num;
+}
+
+static int flush_queue_count = 0;
+
+void qfree (void * msg)
+{
+	flush_queue_count++;
+	free (msg);
+}
+
+void delay_ms(unsigned int secs, unsigned int msecs)
+{
+  struct timespec ts;
+  ts.tv_sec = (time_t) secs;
+  ts.tv_nsec = (long) msecs * 1000000L;
+  nanosleep (&ts, NULL);
+}
+
+void dbg_log_err (const char *fmt, ...)
+{
+		char errbuf[100];
+
+    va_list arg_ptr;
+    va_start(arg_ptr, fmt);
+    vprintf(fmt, arg_ptr);
+    va_end(arg_ptr);
+		printf ("LIBPD_TEST: %s\n", strerror_r (errno, errbuf, 100));
+}
+
+void wait_auth_received (void)
+{
+	if (!is_auth_received ()) {
+		printf ("Waiting for auth received\n");
+		sleep(1);
+	}
+	if (!is_auth_received ()) {
+		printf ("Waiting for auth received\n");
+		sleep(1);
+	}
+	CU_ASSERT (is_auth_received ());
+}
+
+void test_send_only (void)
+{
+	unsigned event_num = 0;
+
+        libpd_cfg_t cfg = {.service_name = service_name,
+                .receive = false, .keepalive_timeout_secs = 0};
+        CU_ASSERT (libparodus_init (&test_instance, &cfg) == 0);
+        CU_ASSERT (send_event_msgs (NULL, &event_num, 10) == 0);
+	CU_ASSERT (libparodus_shutdown (&test_instance) == 0);
+}
+
+ void test_1(void)
+{
+	unsigned msgs_received_count = 0;
+	int rtn;
+	wrp_msg_t *wrp_msg;
+	unsigned event_num = 0;
+	unsigned msg_num = 0;
+        libpd_cfg_t cfg = {.service_name = service_name,
+                .receive = true, .keepalive_timeout_secs = 0};
+
+	if (no_mock_send_only_test) {
+		test_send_only ();
+		return;
+	}
+
+        cfg.parodus_url = GOOD_PARODUS_URL;
+        cfg.client_url = GOOD_CLIENT_URL;
+        CU_ASSERT (libparodus_init (&test_instance, &cfg) == 0);
+	printf ("LIBPD_TEST: libparodus_init successful\n");
+	initEndKeypressHandler ();
+
+	wait_auth_received ();
+
+	printf ("LIBPD_TEST: starting msg receive loop\n");
+	while (true) {
+		rtn = libparodus_receive (test_instance, &wrp_msg, 2000);
+		if (rtn == 1) {
+			printf ("LIBPD_TEST: Timed out waiting for msg\n");
+			if (msgs_received_count > 0)
+				if (send_event_msgs (&msg_num, &event_num, 5) != 0)
+					break;
+			continue;
+		}
+		if (rtn != 0)
+			break;
+		show_wrp_msg (wrp_msg);
+		msgs_received_count++;
+		if (wrp_msg->msg_type == WRP_MSG_TYPE__REQ)
+			send_reply (wrp_msg);
+		wrp_free_struct (wrp_msg);
+		if (send_event_msgs (&msg_num, &event_num, 5) != 0)
+			break;
+	}
+	printf ("Messages received %u\n", msgs_received_count);
+	CU_ASSERT (libparodus_shutdown (&test_instance) == 0);
+}
+
+/*
+ * @brief To initiate end keypress handler
+ */
+static void initEndKeypressHandler()
+{
+	int err = 0;
+	err = pthread_create(&endKeypressThreadId, NULL, endKeypressHandlerTask, NULL);
+	if (err != 0) 
+	{
+		libpd_log (LEVEL_ERROR, "Error creating End Keypress Handler thread\n");
+	}
+	else 
+	{
+		printf ("End Keypress handler Thread created successfully\n");
+		printf ("\n--->> Press <Enter> to shutdown the test. ---\n");
+	}
+}
+
+/*
+ * @brief To handle End Keypress
+ */
+static void *endKeypressHandlerTask()
+{
+	char inbuf[10];
+	memset(inbuf, 0, 10);
+	while (true) {
+		fgets (inbuf, 10, stdin);
+		if ((inbuf[0] != '\n') && (inbuf[0] != '\0')) {
+            printf ("endKeyPressHandler exiting\n");
+			break;
+		}
+	}
+	libparodus_close_receiver (test_instance);
+	return NULL;
+}
+
+
+void add_suites( CU_pSuite *suite )
+{
+    *suite = CU_add_suite( "libparodus tests", NULL, NULL );
+    CU_add_test( *suite, "Test 1", test_1 );
+}
+
+/*----------------------------------------------------------------------------*/
+/*                             External Functions                             */
+/*----------------------------------------------------------------------------*/
+int main( int argc, char **argv __attribute__((unused)) )
+{
+    unsigned rv = 1;
+    CU_pSuite suite = NULL;
+
+		if (argc > 1) {
+			const char *arg = argv[1];
+			if ((arg[0] == 's') || (arg[0] == 'S'))
+				no_mock_send_only_test = true;
+		}
+
+    if( CUE_SUCCESS == CU_initialize_registry() ) {
+        add_suites( &suite );
+
+        if( NULL != suite ) {
+            CU_basic_set_mode( CU_BRM_VERBOSE );
+            CU_basic_run_tests();
+            printf( "\n" );
+            CU_basic_show_failures( CU_get_failure_list() );
+            printf( "\n\n" );
+            rv = CU_get_number_of_tests_failed();
+        }
+
+        CU_cleanup_registry();
+    }
+
+    if( 0 != rv ) {
+        return 1;
+    }
+    return 0;
+}

tests/mock_event_handler.c

@@ -1,104 +0,0 @@
-/*
- * If not stated otherwise in this file or this component's Licenses.txt file the
- * following copyright and licenses apply:
- *
- * Copyright 2016 RDK Management
- * Copyright [2014] [Cisco Systems, Inc.]
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
-*/
-
-/* This is a test version of event_handler.c that can be used
- * to simulate interface down, interface up event
- * You overwrite event_handler.c in the src diectory with this
- * version.  It will generate interface down / interface up events
- * at random intervals between 60 secs and 124 secs
- */
-
-#include "parodus_log.h"
-#include "event_handler.h"
-#include "connection.h"
-#include "config.h"
-#include "heartBeat.h"
-#include <stdlib.h>
-#include <string.h>
-#include <pthread.h>
-#include <unistd.h>
-#include "time.h"
-#include "close_retry.h"
-
-extern bool g_shutdown;
-
-static pthread_t sysevent_tid;
-
-static void start_interface_down (void)
-{
-	  	set_interface_down_event();
-		ParodusInfo("Interface_down_event is set\n");				
-		pause_heartBeatTimer();
-}
-
-static void end_interface_down (void)
-{
-		reset_interface_down_event();
-		ParodusInfo("Interface_down_event is reset\n");
-		resume_heartBeatTimer();
-		set_close_retry();
-}
-
-// waits from 60 to 124 secs
-int wait_random (const char *msg)
-{
-  #define HALF_SEC 500000l
-  long delay = (random() >> 5) + 60000000l;
-  long secs, usecs;
-  struct timeval timeout;
-
-  secs = delay / 1000000;
-  usecs = delay % 1000000;
-  ParodusInfo ("Waiting %ld secs %ld usecs for %s\n", secs, usecs, msg);
-  
-  while (!g_shutdown) {
-	timeout.tv_sec = 0;
-	if (delay <= HALF_SEC) {
-	  timeout.tv_usec = delay;
-	  select (0, NULL, NULL, NULL, &timeout);
-	  return 0;
-	}
-	timeout.tv_usec = HALF_SEC;
-	delay -= HALF_SEC;
-	select (0, NULL, NULL, NULL, &timeout);
-  }
-  return -1;    
-}
-
-
-static void *parodus_sysevent_handler (void *data)
-{
-	while (!g_shutdown) {
-	  if (wait_random ("interface down") != 0)
-	    break;
-	  start_interface_down ();
-	  wait_random ("interface up");
-	  end_interface_down ();	
-	}
-	ParodusInfo ("Exiting event handler\n");
-	return data;
-}
-
-void EventHandler()
-{
-	ParodusInfo ("RAND_MAX is %ld (0x%lx)\n", RAND_MAX, RAND_MAX);
-	srandom (getpid());
-
-	pthread_create(&sysevent_tid, NULL, parodus_sysevent_handler, NULL);
-}

tests/parodus_cmd.sh

@@ -1,3 +0,0 @@
-sudo ./parodus --hw-model=TG1682 --hw-serial-number=Fer23u948590 --hw-manufacturer=ARRISGroup,Inc. --hw-mac=aabb33ddeeff --hw-last-reboot-reason=unknown --fw-name=TG1682_DEV_master_2016000000sdy --boot-time=123589 --webpa-ping-timeout=180 --webpa-backoff-max=0 --webpa-interface-used=p7p1 --webpa-url=https://example.net:8080 --acquire-jwt=1 --jwt-algo=RS256 --jwt-public-key-file=../../tests/webpa-rs256.pem --dns-txt-url=example.net
-
- 

tests/pubkey4.pem

@@ -1,9 +0,0 @@
------BEGIN PUBLIC KEY-----
-MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA7C8R+hmRcVOuLxi/Qjc9
-4S0qAm+03JGm4G1aejyEcvXChMH6p0P9qIaq3aJTAOj3q7tvg4AbNYid7iTUnPvF
-xaYVI9CZtoFbplX3JUmUxJDOMSOA9wAV59D4+vz7OUpMfaV5NyiPfPJLAbHnA/hT
-agT4JilhtBqfiUqzxMALQOGQT/+L7QhsRBc0QkjkgZE4du59X9PDOD47GPrzL8k1
-Reu8uGW951iR6WtcjgZR4ndMSNd/CjxAZfvVWotQMEVm4ZaudiPfiFYwqDe1IvSm
-0YH3dtUiRS4d4Q8OsUqzarXFPpr7+RriwMRxebQnBqQICryob40FOL/n4ZRlu+85
-FQIDAQAB
------END PUBLIC KEY-----

tests/return_failure.bsh

@@ -1 +0,0 @@
-echo -n FAILURE

tests/return_ser_mac.bsh

@@ -1 +0,0 @@
-echo -n SER_MAC $1 $2

tests/return_success.bsh

@@ -1 +0,0 @@
-echo -n SUCCESS

tests/simple.c

@@ -0,0 +1,712 @@
+/**
+ *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+#include <stdarg.h>
+
+#include <CUnit/Basic.h>
+#include <stdbool.h>
+
+#include <assert.h>
+#include <nopoll.h>
+
+//#include <nanomsg/bus.h>
+
+#include "../src/ParodusInternal.h"
+#include "../src/config.h"
+#include "../src/nopoll_helpers.h"
+#include "../src/downstream.h"
+#include "../src/upstream.h"
+
+#include<errno.h>
+
+/* Nanomsg related Macros */
+#define ENDPOINT "tcp://127.0.0.1:6666"
+#define CLIENT1_URL "tcp://127.0.0.1:6667"
+#define CLIENT2_URL "tcp://127.0.0.1:6668"
+#define CLIENT3_URL "tcp://127.0.0.1:6669"
+#define HTTP_CUSTOM_HEADER_COUNT                    	4
+
+static void send_nanomsg_upstream(void **buf, int size);
+void *handle_testsuites();
+headers_t headers = { 2, {"Header 1", "Header 2"}};
+
+void test_nanomsg_client_registration1()
+{
+		    
+	/*****Test svc registation for nanomsg client1 ***/
+	ParodusInfo("test_nanomsg_client_registration1\n");
+
+	const wrp_msg_t reg = { .msg_type = WRP_MSG_TYPE__SVC_REGISTRATION,
+	  .u.reg.service_name = "iot",
+	  .u.reg.url = CLIENT1_URL};
+	  
+	void *bytes;
+	int size =0;
+	int rv1, rc;
+	wrp_msg_t  *msg1;
+	int sock, bind;
+	int byte =0;
+	int t=25000;
+	  
+	// msgpack encode
+	ParodusPrint("msgpack encode\n");
+	size = wrp_struct_to( &reg, WRP_BYTES, &bytes );
+
+	/*** Enable this to decode and verify upstream registration msg **/
+	/***	
+	rv = wrp_to_struct(bytes, size, WRP_BYTES, &message);
+	ParodusPrint("decoded msgType:%d\n", message->msg_type);
+	ParodusPrint("decoded service_name:%s\n", message->u.reg.service_name);
+	ParodusPrint("decoded dest:%s\n", message->u.reg.url);
+	wrp_free_struct(message);	
+	***/
+	  
+	//nanomsg socket
+	sock = nn_socket (AF_SP, NN_PUSH);
+	int connect = nn_connect (sock, ENDPOINT);
+	CU_ASSERT(connect >= 0);
+	rc = nn_setsockopt(sock, NN_SOL_SOCKET, NN_SNDTIMEO, &t, sizeof(t));
+	CU_ASSERT(rc >= 0);
+	byte = nn_send (sock, bytes, size, 0);
+	ParodusInfo("----->Expected byte to be sent:%d\n", size);
+	ParodusInfo("----->actual byte sent:%d\n", byte);
+	ParodusInfo("Nanomsg client1 - Testing Upstream Registration msg send\n");		
+	CU_ASSERT_EQUAL( byte, size );
+
+	//************************************************************
+
+	int sock1 = nn_socket (AF_SP, NN_PULL);
+	byte = 0;
+	bind = nn_bind(sock1, reg.u.reg.url);
+	CU_ASSERT(bind >= 0);
+	
+	void *buf = NULL;
+	rc = nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
+	CU_ASSERT(rc >= 0);
+	
+	ParodusPrint("Client 1 waiting for acknowledgement \n");
+	byte = nn_recv(sock1, &buf, NN_MSG, 0);
+	ParodusInfo("Data Received for client 1 : %s \n", (char * )buf);
+
+	rv1 = wrp_to_struct((void *)buf, byte, WRP_BYTES, &msg1);
+
+	CU_ASSERT_EQUAL( rv1, byte );
+	
+	ParodusPrint("msg1->msg_type for client 1 = %d \n", msg1->msg_type);
+	ParodusPrint("msg1->status for client 1 = %d \n", msg1->u.auth.status);
+	CU_ASSERT_EQUAL(msg1->msg_type, 2);
+	CU_ASSERT_EQUAL(msg1->u.auth.status, 200);
+
+	rc = nn_freemsg(buf);	
+        CU_ASSERT(rc == 0);
+	free(bytes);	
+	wrp_free_struct(msg1);
+	rc = nn_shutdown(sock1, bind);
+        CU_ASSERT(rc == 0);
+}
+
+void test_nanomsg_client_registration2()
+{
+		    
+	/*****Test svc registation for upstream - nanomsg client2 ***/
+	ParodusInfo("test_nanomsg_client_registration2\n");
+	
+	const wrp_msg_t reg = { .msg_type = WRP_MSG_TYPE__SVC_REGISTRATION,
+	  .u.reg.service_name = "iot2",
+	  .u.reg.url = CLIENT2_URL};
+	  
+	void *bytes;
+	int size;
+	int rv1, rc;
+	wrp_msg_t  *msg1;
+	int sock, bind;
+	int byte =0;
+	int t=28000;
+	  
+	// msgpack encode
+	ParodusPrint("msgpack encode\n");
+	size = wrp_struct_to( &reg, WRP_BYTES, &bytes );
+
+	/*** Enable this to decode and verify packed upstream registration msg **/
+	/**
+	rv = wrp_to_struct(bytes, size, WRP_BYTES, &message);
+	ParodusPrint("decoded msgType:%d\n", message->msg_type);
+	ParodusPrint("decoded service_name:%s\n", message->u.reg.service_name);
+	ParodusPrint("decoded dest:%s\n", message->u.reg.url);
+	wrp_free_struct(message);
+	***/
+	  
+	//nanomsg socket 
+	sock = nn_socket (AF_SP, NN_PUSH);
+	int connect = nn_connect (sock, ENDPOINT);
+	CU_ASSERT( connect >= 0);
+	rc = nn_setsockopt(sock, NN_SOL_SOCKET, NN_SNDTIMEO, &t, sizeof(t));
+	CU_ASSERT(rc >= 0);
+	byte = nn_send (sock, bytes, size,0);
+	ParodusInfo("----->Expected byte to be sent:%d\n", size);
+	ParodusInfo("----->actual byte sent:%d\n", byte);
+	ParodusInfo("Nanomsg client2 - Testing Upstream Registration msg send\n");
+	CU_ASSERT_EQUAL( byte, size );
+
+	int sock1 = nn_socket (AF_SP, NN_PULL);
+	byte = 0;
+	bind = nn_bind(sock1, reg.u.reg.url);
+	CU_ASSERT(bind >= 0);
+	
+	void *buf1 = NULL;
+	
+	rc = nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
+        CU_ASSERT(rc >= 0);
+        
+	ParodusPrint("Client 2 waiting for acknowledgement \n");
+	
+	byte = nn_recv(sock1, &buf1, NN_MSG, 0);
+	ParodusInfo("Data Received : %s \n", (char * )buf1);
+
+	rv1 = wrp_to_struct((void *)buf1, byte, WRP_BYTES, &msg1);
+	CU_ASSERT_EQUAL( rv1, byte );
+	ParodusPrint("msg1->msg_type for client 2 = %d \n", msg1->msg_type);
+	ParodusPrint("msg1->status for client 2 = %d \n", msg1->u.auth.status);
+	CU_ASSERT_EQUAL(msg1->msg_type, 2);
+	CU_ASSERT_EQUAL(msg1->u.auth.status, 200);
+	
+	rc = nn_freemsg(buf1);	
+	CU_ASSERT(rc == 0);
+	free(bytes);
+	wrp_free_struct(msg1);
+        rc = nn_shutdown(sock1, bind);
+        CU_ASSERT(rc == 0);
+
+}
+
+
+void test_nanomsg_client_registration3()
+{
+		    
+	/*****Test svc registation for upstream - nanomsg client2 ***/
+	ParodusInfo("test_nanomsg_client_registration3\n");
+	
+	const wrp_msg_t reg = { .msg_type = WRP_MSG_TYPE__SVC_REGISTRATION,
+	  .u.reg.service_name = "iot",
+	  .u.reg.url = CLIENT3_URL};
+	void *bytes;
+	int size;
+	int rv1, rc;
+	wrp_msg_t *msg1;
+	int sock;
+	int byte =0;
+	int t=35000;
+	  
+	// msgpack encode
+	ParodusPrint("msgpack encode\n");
+	size = wrp_struct_to( &reg, WRP_BYTES, &bytes );
+
+	/*** Enable this to decode and verify packed upstream registration msg **/
+	/**
+	rv = wrp_to_struct(bytes, size, WRP_BYTES, &message);		
+	ParodusPrint("decoded msgType:%d\n", message->msg_type);
+	ParodusPrint("decoded service_name:%s\n", message->u.reg.service_name);
+	ParodusPrint("decoded dest:%s\n", message->u.reg.url);
+	wrp_free_struct(message);
+	***/
+	  
+	//nanomsg socket 
+	sock = nn_socket (AF_SP, NN_PUSH);
+	int connect = nn_connect (sock, ENDPOINT);
+	CU_ASSERT(connect >= 0);
+	rc = nn_setsockopt(sock, NN_SOL_SOCKET, NN_SNDTIMEO, &t, sizeof(t));
+	CU_ASSERT(rc >= 0);
+	byte = nn_send (sock, bytes, size,0);
+	ParodusInfo("----->Expected byte to be sent:%d\n", size);
+	ParodusInfo("----->actual byte sent:%d\n", byte);
+	ParodusInfo("Nanomsg client3 - Testing Upstream Registration msg send\n");
+	CU_ASSERT_EQUAL( byte, size );
+
+	int sock1 = nn_socket (AF_SP, NN_PULL);
+	byte = 0;
+	
+	int bind = nn_bind(sock1, reg.u.reg.url);
+        CU_ASSERT(bind >= 0);
+	ParodusPrint("Need to close this bind %d \n", bind);
+	
+	void *buf2 = NULL;
+	
+	rc = nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
+	CU_ASSERT(rc >= 0);
+	ParodusPrint("Client 3 is waiting for acknowledgement \n");
+	byte = nn_recv(sock1, &buf2, NN_MSG, 0);
+	
+	ParodusInfo("Data Received : %s \n", (char * )buf2);
+	
+	rv1 = wrp_to_struct((void *)buf2, byte, WRP_BYTES, &msg1);
+	CU_ASSERT_EQUAL( rv1, byte );
+	ParodusPrint("msg1->msg_type for client 3 = %d \n", msg1->msg_type);
+	ParodusPrint("msg1->status for client 3 = %d \n", msg1->u.auth.status);
+	CU_ASSERT_EQUAL(msg1->msg_type, 2);
+	CU_ASSERT_EQUAL(msg1->u.auth.status, 200);
+	
+	rc = nn_freemsg(buf2);
+	CU_ASSERT(rc == 0);
+	free(bytes);
+	wrp_free_struct(msg1);
+        rc = nn_shutdown(sock1, bind);
+        CU_ASSERT(rc == 0);
+	
+}
+
+void test_nanomsg_downstream_success()
+{
+
+	ParodusInfo("test_nanomsg_downstream_success\n");
+	
+	int sock;
+	int bit=0, rc;
+	wrp_msg_t *message;
+	void *buf =NULL;
+	char* destVal = NULL;
+//	char dest[32] = {'\0'};
+	char *dest = NULL;
+	//char *temp_ptr;
+	int bind = -1;
+	
+	const wrp_msg_t msg = { .msg_type = WRP_MSG_TYPE__SVC_REGISTRATION,
+	  .u.reg.service_name = "iot",
+	  .u.reg.url = CLIENT3_URL};
+	
+	sock = nn_socket (AF_SP, NN_PULL);
+
+	while(bind == -1)
+        {
+                bind = nn_bind(sock, msg.u.reg.url);
+                sleep(3);
+        }
+	
+	ParodusPrint("Bind returns = %d \n", bind);
+	ParodusPrint("***** Nanomsg client3 in Receiving mode in %s *****\n", msg.u.reg.url);
+	bit = nn_recv (sock, &buf, NN_MSG, 0);
+	ParodusInfo ("----->Received downstream request from server to client3 : \"%s\"\n", (char *)buf);
+	ParodusPrint("Received %d bytes\n", bit);
+	CU_ASSERT(bit >= 0);
+	
+	//Decode and verify downstream request has received by correct registered client
+	
+	wrp_to_struct(buf, bit, WRP_BYTES, &message);		
+	destVal = message->u.req.dest;
+	dest = strtok(destVal , "/");
+	//temp_ptr = strtok(destVal , "/");
+//	ParodusPrint("temp_ptr = %s \n", temp_ptr);
+	strcpy(dest,strtok(NULL , "/"));
+	ParodusInfo("------>decoded dest:%s\n", dest);	
+	CU_ASSERT_STRING_EQUAL( msg.u.reg.service_name, dest );	
+	wrp_free_struct(message);
+	
+	//To send nanomsg client response upstream
+	send_nanomsg_upstream(&buf, bit);
+	
+	rc = nn_freemsg(buf);
+	CU_ASSERT(rc == 0);
+        rc = nn_shutdown(sock, bind);
+        CU_ASSERT(rc == 0);
+	//Need to wait for parodus to finish it's task.
+	sleep(10);
+}
+
+
+void test_nanomsg_downstream_failure()
+{
+	int sock, bind, rc;
+	int bit =0;
+	char *buf =NULL;
+	ParodusError("test_nanomsg_downstream_failure\n");
+	
+	sleep(60);
+	sock = nn_socket (AF_SP, NN_PULL);
+	bind = nn_bind (sock, CLIENT3_URL);
+	CU_ASSERT(bind >= 0);	
+	ParodusPrint("***** Nanomsg client3 in Receiving mode *****\n");
+	
+	bit = nn_recv (sock, &buf, NN_MSG, 0);
+	ParodusInfo ("Received downstream request from server for client3 : \"%s\"\n", buf);
+	CU_ASSERT(bit >= 0);
+	rc = nn_freemsg(buf);
+	CU_ASSERT(rc == 0);
+        rc = nn_shutdown(sock, bind);
+        CU_ASSERT(rc == 0);
+}
+
+
+void test_checkHostIp()
+{
+	int ret;
+	
+	ParodusPrint("**********************************Calling check_host_ip \n");
+	ret = checkHostIp("fabric.webpa.comcast.net");
+	ParodusPrint("------------------> Ret = %d \n", ret);
+	CU_ASSERT_EQUAL(ret, 0);
+	
+}
+
+void test_sendMessage()
+{
+	noPollConnOpts * opts;
+	noPollCtx *ctx = NULL;
+	noPollConn *conn = NULL;
+        
+    ParodusPrint("**********************************Calling sendMessage \n");
+	const char * headerNames[HTTP_CUSTOM_HEADER_COUNT] = {"X-WebPA-Device-Name","X-WebPA-Device-Protocols","User-Agent", "X-WebPA-Convey"};
+	const char * headerValues[HTTP_CUSTOM_HEADER_COUNT];
+
+	headerValues[0] = "123567892366";
+	headerValues[1] = "wrp-0.11,getset-0.1";  
+	headerValues[2] = "WebPA-1.6 (TG1682_DEV_master_2016000000sdy;TG1682/ARRISGroup,Inc.;)";
+	headerValues[3] = "zacbvfxcvglodfjdigjkdshuihgkvn";
+
+	int headerCount = HTTP_CUSTOM_HEADER_COUNT;
+
+	//ctx = nopoll_ctx_new();
+
+	opts = nopoll_conn_opts_new ();
+	nopoll_conn_opts_ssl_peer_verify (opts, nopoll_false);
+	nopoll_conn_opts_set_ssl_protocol (opts, NOPOLL_METHOD_TLSV1_2); 
+	conn = nopoll_conn_tls_new(ctx, opts, "fabric.webpa.comcast.net", "8080", NULL, "/api/v2/device", NULL, NULL, "eth0",
+                                headerNames, headerValues, headerCount);
+	/*while(conn == NULL)
+	{
+		opts = nopoll_conn_opts_new ();
+		nopoll_conn_opts_ssl_peer_verify (opts, nopoll_false);
+		nopoll_conn_opts_set_ssl_protocol (opts, NOPOLL_METHOD_TLSV1_2); 
+		conn = nopoll_conn_tls_new(ctx, opts, "fabric.webpa.comcast.net", 8080, NULL, "/api/v2/device", NULL, NULL, "eth0",
+                                headerNames, headerValues, headerCount);
+	}*/
+
+	ParodusPrint("Sending conn as %p \n", conn);
+	sendMessage(conn, "hello", 6);
+
+}
+
+void test_parseCommandLine()
+{
+    int argc =11;
+    char * command[15]={'\0'};
+     
+    command[0] = "parodus";
+    command[1] = "--hw-model=TG1682";
+    command[2] = "--hw-serial-number=Fer23u948590";
+    command[3] = "--hw-manufacturer=ARRISGroup,Inc.";
+    command[4] = "--hw-mac=123567892366";
+    command[5] = "--hw-last-reboot-reason=unknown";
+    command[6] = "--fw-name=TG1682_DEV_master_2016000000sdy";
+    command[7] = "--webpa-ping-time=180";
+    command[8] = "--webpa-inteface-used=eth0";
+    command[9] = "--webpa-url=fabric.webpa.comcast.net";
+    command[10] = "--webpa-backoff-max=0";
+    
+    ParodusCfg parodusCfg;
+    memset(&parodusCfg,0,sizeof(parodusCfg));
+    ParodusPrint("call parseCommand\n");
+    parseCommandLine(argc,command,&parodusCfg);
+   
+    ParodusPrint("parodusCfg.webpa_ping_timeout is %d\n", parodusCfg.webpa_ping_timeout);
+    ParodusPrint("parodusCfg.webpa_backoff_max is %d\n", parodusCfg.webpa_backoff_max);
+    CU_ASSERT_STRING_EQUAL( parodusCfg.hw_model, "TG1682");
+    CU_ASSERT_STRING_EQUAL( parodusCfg.hw_serial_number, "Fer23u948590");
+    CU_ASSERT_STRING_EQUAL( parodusCfg.hw_manufacturer, "ARRISGroup,Inc.");
+    CU_ASSERT_STRING_EQUAL( parodusCfg.hw_mac, "123567892366");	
+    CU_ASSERT_STRING_EQUAL( parodusCfg.hw_last_reboot_reason, "unknown");	
+    CU_ASSERT_STRING_EQUAL( parodusCfg.fw_name, "TG1682_DEV_master_2016000000sdy");	
+    CU_ASSERT( parodusCfg.webpa_ping_timeout==180);	
+    CU_ASSERT_STRING_EQUAL( parodusCfg.webpa_interface_used, "eth0");	
+    CU_ASSERT_STRING_EQUAL( parodusCfg.webpa_url, "fabric.webpa.comcast.net");
+    CU_ASSERT( parodusCfg.webpa_backoff_max==0);
+}
+
+
+void test_loadParodusCfg()
+{
+	
+	ParodusPrint("Calling test_loadParodusCfg \n");
+	//ParodusCfg parodusCfg, tmpcfg;
+	ParodusCfg  tmpcfg;
+	ParodusCfg *Cfg;
+	Cfg = (ParodusCfg*)malloc(sizeof(ParodusCfg));
+	
+	strcpy(Cfg->hw_model, "TG1682");
+	strcpy(Cfg->hw_serial_number, "Fer23u948590");
+	strcpy(Cfg->hw_manufacturer , "ARRISGroup,Inc.");
+	strcpy(Cfg->hw_mac , "123567892366");
+	memset(&tmpcfg,0,sizeof(tmpcfg));
+	loadParodusCfg(Cfg,&tmpcfg);
+	ParodusInfo("tmpcfg.hw_model = %s, tmpcfg.hw_serial_number = %s, tmpcfg.hw_manufacturer = %s, tmpcfg.hw_mac = %s, \n", tmpcfg.hw_model,tmpcfg.hw_serial_number, tmpcfg.hw_manufacturer,   tmpcfg.hw_mac);
+
+	CU_ASSERT_STRING_EQUAL( tmpcfg.hw_model, "TG1682");
+	CU_ASSERT_STRING_EQUAL( tmpcfg.hw_serial_number, "Fer23u948590");
+	CU_ASSERT_STRING_EQUAL( tmpcfg.hw_manufacturer, "ARRISGroup,Inc.");
+	CU_ASSERT_STRING_EQUAL( tmpcfg.hw_mac, "123567892366");	
+
+}
+
+void add_suites( CU_pSuite *suite )
+{
+    ParodusInfo("--------Start of Test Cases Execution ---------\n");
+    *suite = CU_add_suite( "tests", NULL, NULL );
+    CU_add_test( *suite, "Test 1", test_nanomsg_client_registration1 );
+    CU_add_test( *suite, "Test 2", test_nanomsg_client_registration2 );
+    CU_add_test( *suite, "Test 3", test_nanomsg_client_registration3 );
+    CU_add_test( *suite, "Test 4", test_nanomsg_downstream_success );
+    //CU_add_test( *suite, "Test 5", test_nanomsg_downstream_failure );
+
+    ParodusInfo("-------------Integration testing is completed-----------\n");
+    ParodusInfo("******************************************************************\n");
+    //sleep(10);
+    ParodusInfo("-------------Start of Unit Test Cases Execution---------\n");
+    CU_add_test( *suite, "UnitTest 1", test_parseCommandLine );
+    CU_add_test( *suite, "UnitTest 2", test_checkHostIp );
+	
+    CU_add_test( *suite, "UnitTest 3", test_sendMessage );
+
+    CU_add_test( *suite, "UnitTest 4", test_loadParodusCfg );
+    
+    
+    
+}
+
+
+
+
+/*----------------------------------------------------------------------------*/
+/*                             External Functions                             */
+/*----------------------------------------------------------------------------*/
+int main( void )
+{
+    	pid_t pid, pid1;
+    	char value[512] = {'\0'};
+  	char* data =NULL;
+  	int status;
+	char commandUrl[255];
+	pid_t curl_pid;
+  
+	char * command[] = {"parodus","--hw-model=TG1682", "--hw-serial-number=Fer23u948590","--hw-manufacturer=ARRISGroup,Inc.","--hw-mac=123567892366","--hw-last-reboot-reason=unknown","--fw-name=TG1682_DEV_master_2016000000sdy","--boot-time=10","--webpa-ping-time=180","--webpa-inteface-used=eth0","--webpa-url=fabric-cd.webpa.comcast.net","--webpa-backoff-max=9", NULL};
+
+	//int size = sizeof(command)/sizeof(command[0]);
+	//int i;
+	//ParodusInfo("commad: ");
+        //for(i=0;i<size-1;i++)
+        //ParodusInfo("command:%s",command);
+
+    	ParodusInfo("Starting parodus process \n");
+	const char *s = getenv("WEBPA_AUTH_HEADER");
+
+	sprintf(commandUrl, "curl -i -H \"Authorization:Basic %s\" -H \"Accept: application/json\" -w %%{time_total} -k \"https://api-cd.webpa.comcast.net:8090/api/v2/device/mac:123567892366/iot?names=Device.DeviceInfo.Webpa.X_COMCAST-COM_SyncProtocolVersion\"", s);	
+	ParodusPrint("---------------------->>>>Executing system(commandUrl)\n");
+	
+	curl_pid = getpid();
+	ParodusPrint("child process execution with curl_pid:%d\n", curl_pid);
+	pid = fork();
+	if (pid == -1)
+	{
+		ParodusError("fork was unsuccessful for pid (errno=%d, %s)\n",errno, strerror(errno));
+		return -1;
+	}
+	else if (pid == 0)
+	{
+		int err;
+		ParodusPrint("child process created for parodus\n");
+		pid = getpid();
+		ParodusPrint("child process execution with pid:%d\n", pid);
+		
+		err = execv("../src/parodus", command);
+		if(errno == 2)
+		{
+			err = execv("./src/parodus", command);
+		}
+		ParodusError("err is %d, errno is %d\n",err, errno);		
+	
+	}
+	else if (pid > 0)
+	{
+		int link[2];
+		sleep(5);
+		
+		//Starting test suites execution in new thread
+		ParodusPrint("Creating new thread for test suite execution\n");
+	
+		pthread_t testId;
+		int err1 = 0;
+		err1 = pthread_create(&testId,NULL,handle_testsuites,(void *)&pid);
+		if(err1 != 0)
+			ParodusError("Error creating test suite thread %s\n",strerror(err1));
+		else
+			ParodusPrint("test suite thread created successfully\n");
+			
+	  	if (pipe(link)==-1)
+	  	{
+	    		ParodusError("Failed to create pipe\n");
+	  	}
+	  	else
+	  		ParodusPrint("Created pipe to read curl output\n");
+
+		pid1 = fork();
+		if (pid1 == -1)
+		{
+			ParodusError("fork was unsuccessful for pid1 (errno=%d, %s)\n",errno, strerror(errno));
+			return -1;
+		}
+		else if(pid1 == 0) 
+		{
+			while(NULL == fopen("/tmp/parodus_ready", "r"))
+			{
+				sleep(5);
+			}
+	    		dup2 (link[1], STDOUT_FILENO);
+	    		close(link[0]);
+	    		close(link[1]);
+			sleep(40);
+			system(commandUrl);			
+			ParodusInfo("\n----Executed first Curl request for downstream ------- \n");
+		}
+	
+		else if(pid1 > 0)
+		{
+			//wait fro child process to finish and read from pipe
+			waitpid(pid1, &status, 0);
+			//reading from pipe
+			ParodusPrint("parent process...:%d\n", pid1);
+			close(link[1]);
+			int nbytes = read(link[0], value, sizeof(value));
+			ParodusPrint("Read %d \n", nbytes);
+			   
+		      	if ((data = strstr(value, "message:Success")) !=NULL)
+		      	{
+		      		ParodusInfo("curl success\n");
+		      	}
+		      	else
+		      	{
+		      		ParodusError("curl failure..\n");
+		      	}
+	    		while(1);
+		}
+	}	
+return 0;
+}
+
+
+void *handle_testsuites(void* pid)
+{
+	unsigned rv = 1;
+	CU_pSuite suite = NULL;
+	pid_t pid_parodus = *((int *)pid);
+	
+	ParodusPrint("Starting handle_testsuites thread\n");
+	sleep(25);
+
+    	if( CUE_SUCCESS == CU_initialize_registry() ) 
+    	{
+		add_suites( &suite );
+		if( NULL != suite ) 
+		{
+		    CU_basic_set_mode( CU_BRM_VERBOSE );
+		    CU_basic_run_tests();
+		    ParodusPrint( "\n" );
+		    CU_basic_show_failures( CU_get_failure_list() );
+		    ParodusPrint( "\n\n" );
+		    rv = CU_get_number_of_tests_failed();
+		}
+		CU_cleanup_registry();
+    	}
+    	kill(pid_parodus, SIGKILL);
+	ParodusInfo("parodus process with pid %d is stopped\n", pid_parodus);
+		
+    	if( 0 != rv ) 
+	{
+		_exit(-1);
+	}
+	
+	_exit(0);
+}
+
+
+static void send_nanomsg_upstream(void **buf, int size)
+{
+	/**** To send nanomsg response to server ****/
+	int rv;		  
+	void *bytes;
+	int resp_size;
+	int sock;
+	int byte;
+	wrp_msg_t *message;
+	
+	ParodusInfo("Decoding downstream request received from server\n");
+	rv = wrp_to_struct(*buf, size, WRP_BYTES, &message);
+	ParodusPrint("after downstream req decode:%d\n", rv);	
+	/**** Preparing Nanomsg client response ****/
+	wrp_msg_t resp_m;	
+	resp_m.msg_type = WRP_MSG_TYPE__REQ;
+	ParodusPrint("resp_m.msg_type:%d\n", resp_m.msg_type);
+	
+        resp_m.u.req.source = message->u.req.dest;        
+        ParodusPrint("------resp_m.u.req.source is:%s\n", resp_m.u.req.source);
+        
+        resp_m.u.req.dest = message->u.req.source;
+        ParodusPrint("------resp_m.u.req.dest is:%s\n", resp_m.u.req.dest);
+        
+        resp_m.u.req.transaction_uuid = message->u.req.transaction_uuid;
+        ParodusPrint("------resp_m.u.req.transaction_uuid is:%s\n", resp_m.u.req.transaction_uuid);
+        
+        resp_m.u.req.headers = NULL;
+        resp_m.u.req.payload = "{statusCode:200,message:Success}";
+        ParodusPrint("------resp_m.u.req.payload is:%s\n", (char *)resp_m.u.req.payload);
+        resp_m.u.req.payload_size = strlen(resp_m.u.req.payload);
+        
+        resp_m.u.req.metadata = NULL;
+        resp_m.u.req.include_spans = false;
+        resp_m.u.req.spans.spans = NULL;
+        resp_m.u.req.spans.count = 0;
+     		
+	ParodusPrint("Encoding downstream response\n");
+	resp_size = wrp_struct_to( &resp_m, WRP_BYTES, &bytes );
+
+	/*** Enable this to verify downstream response by decoding ***/
+	/***
+	wrp_msg_t *message1;
+	rv = wrp_to_struct(bytes, resp_size, WRP_BYTES, &message1);
+	ParodusPrint("after downstream response decode:%d\n", rv);	
+	ParodusPrint("downstream response decoded msgType:%d\n", message1->msg_type);
+	ParodusPrint("downstream response decoded source:%s\n", message1->u.req.source);
+	ParodusPrint("downstream response decoded dest:%s\n", message1->u.req.dest);
+	ParodusPrint("downstream response decoded transaction_uuid:%s\n", message1->u.req.transaction_uuid);
+	ParodusPrint("downstream response decoded payload:%s\n", (char*)message1->u.req.payload);       
+        wrp_free_struct(message1);
+        ***/
+        
+        /**** Nanomsg client sending msgs ****/
+		
+	sock = nn_socket (AF_SP, NN_PUSH);
+	int connect = nn_connect (sock, ENDPOINT);
+	CU_ASSERT(connect >= 0);	
+	sleep(1);
+	
+	ParodusInfo("nanomsg client sending response upstream\n");
+	byte = nn_send (sock, bytes, resp_size,0);
+	ParodusInfo("----->Expected byte to be sent:%d\n", resp_size);
+	ParodusInfo("----->actual byte sent:%d\n", byte);
+	CU_ASSERT(byte==resp_size );
+	wrp_free_struct(message);
+	
+	free(bytes);
+	ParodusPrint("---- End of send_nanomsg_upstream ----\n");
+
+}
+
+

tests/simple_connection.c

@@ -59,45 +59,45 @@ void test_set_global_conn()
     set_global_conn(conn);
     CU_ASSERT(conn == get_global_conn());
     close_and_unref_connection(get_global_conn());
-    free(opts);
 }
 
 void test_set_parodus_cfg()
 {
-    ParodusCfg cfg;
+    ParodusCfg *cfg;
 
-    parStrncpy(cfg.hw_model, "TG1682", sizeof(cfg.hw_model));
-    parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-    parStrncpy(cfg.hw_manufacturer , "ARRISGroup,Inc.", sizeof(cfg.hw_manufacturer));
-    parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-    parStrncpy(cfg.hw_last_reboot_reason , "unknown", sizeof(cfg.hw_last_reboot_reason));
-    parStrncpy(cfg.fw_name , "2.364s2", sizeof(cfg.fw_name));
-    parStrncpy(cfg.webpa_path_url , "/api/v2/device", sizeof(cfg.webpa_path_url));
-    parStrncpy(cfg.webpa_url , "fabric-cd.webpa.comcast.net", sizeof(cfg.webpa_url));
-    parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-    parStrncpy(cfg.webpa_protocol , "WebPA-1.6", sizeof(cfg.webpa_protocol));
-    parStrncpy(cfg.webpa_uuid , "1234567-345456546", sizeof(cfg.webpa_uuid));
-    cfg.secureFlag = 1;
-    cfg.boot_time = 423457;
-    cfg.webpa_ping_timeout = 30;
-    cfg.webpa_backoff_max = 255;
+    cfg = (ParodusCfg*)malloc(sizeof(ParodusCfg));
+    strcpy(cfg->hw_model, "TG1682");
+    strcpy(cfg->hw_serial_number, "Fer23u948590");
+    strcpy(cfg->hw_manufacturer , "ARRISGroup,Inc.");
+    strcpy(cfg->hw_mac , "123567892366");
+    strcpy(cfg->hw_last_reboot_reason , "unknown");
+    strcpy(cfg->fw_name , "2.364s2");
+    strcpy(cfg->webpa_path_url , "/api/v2/device");
+    strcpy(cfg->webpa_url , "fabric-cd.webpa.comcast.net");
+    strcpy(cfg->webpa_interface_used , "eth0");
+    strcpy(cfg->webpa_protocol , "WebPA-1.6");
+    strcpy(cfg->webpa_uuid , "1234567-345456546");
+    cfg->secureFlag = 1;
+    cfg->boot_time = 423457;
+    cfg->webpa_ping_timeout = 30;
+    cfg->webpa_backoff_max = 255;
 
-    set_parodus_cfg(&cfg);
+    set_parodus_cfg(cfg);
 
-    CU_ASSERT_STRING_EQUAL(cfg.hw_model, get_parodus_cfg()->hw_model);
-    CU_ASSERT_STRING_EQUAL(cfg.webpa_uuid, get_parodus_cfg()->webpa_uuid);
-    CU_ASSERT_STRING_EQUAL(cfg.hw_serial_number, get_parodus_cfg()->hw_serial_number);
-    CU_ASSERT_STRING_EQUAL(cfg.hw_manufacturer , get_parodus_cfg()->hw_manufacturer);
-    CU_ASSERT_STRING_EQUAL(cfg.hw_mac, get_parodus_cfg()->hw_mac);
-    CU_ASSERT_STRING_EQUAL(cfg.hw_last_reboot_reason,get_parodus_cfg()->hw_last_reboot_reason);
-    CU_ASSERT_STRING_EQUAL(cfg.fw_name,get_parodus_cfg()->fw_name);
-    CU_ASSERT_STRING_EQUAL(cfg.webpa_url, get_parodus_cfg()->webpa_url);
-    CU_ASSERT_STRING_EQUAL(cfg.webpa_interface_used , getWebpaInterface());
-    CU_ASSERT_STRING_EQUAL(cfg.webpa_protocol, get_parodus_cfg()->webpa_protocol);
-    CU_ASSERT_EQUAL(cfg.boot_time, get_parodus_cfg()->boot_time);
-    CU_ASSERT_EQUAL(cfg.webpa_ping_timeout, get_parodus_cfg()->webpa_ping_timeout);
-    CU_ASSERT_EQUAL(cfg.webpa_backoff_max, get_parodus_cfg()->webpa_backoff_max);
-    CU_ASSERT_EQUAL(cfg.secureFlag, get_parodus_cfg()->secureFlag);
+    CU_ASSERT_STRING_EQUAL(cfg->hw_model, get_parodus_cfg()->hw_model);
+    CU_ASSERT_STRING_EQUAL(cfg->webpa_uuid, get_parodus_cfg()->webpa_uuid);
+    CU_ASSERT_STRING_EQUAL(cfg->hw_serial_number, get_parodus_cfg()->hw_serial_number);
+    CU_ASSERT_STRING_EQUAL(cfg->hw_manufacturer , get_parodus_cfg()->hw_manufacturer);
+    CU_ASSERT_STRING_EQUAL(cfg->hw_mac, get_parodus_cfg()->hw_mac);
+    CU_ASSERT_STRING_EQUAL(cfg->hw_last_reboot_reason,get_parodus_cfg()->hw_last_reboot_reason);
+    CU_ASSERT_STRING_EQUAL(cfg->fw_name,get_parodus_cfg()->fw_name);
+    CU_ASSERT_STRING_EQUAL(cfg->webpa_url, get_parodus_cfg()->webpa_url);
+    CU_ASSERT_STRING_EQUAL(cfg->webpa_interface_used , get_parodus_cfg()->webpa_interface_used);
+    CU_ASSERT_STRING_EQUAL(cfg->webpa_protocol, get_parodus_cfg()->webpa_protocol);
+    CU_ASSERT_EQUAL(cfg->boot_time, get_parodus_cfg()->boot_time);
+    CU_ASSERT_EQUAL(cfg->webpa_ping_timeout, get_parodus_cfg()->webpa_ping_timeout);
+    CU_ASSERT_EQUAL(cfg->webpa_backoff_max, get_parodus_cfg()->webpa_backoff_max);
+    CU_ASSERT_EQUAL(cfg->secureFlag, get_parodus_cfg()->secureFlag);
 }
 
 void test_getWebpaConveyHeader()
@@ -113,11 +113,10 @@ void test_getWebpaConveyHeader()
     CU_ASSERT_STRING_EQUAL(get_parodus_cfg()->hw_manufacturer, cJSON_GetObjectItem(payload, HW_MANUFACTURER)->valuestring);
     CU_ASSERT_STRING_EQUAL(get_parodus_cfg()->hw_last_reboot_reason, cJSON_GetObjectItem(payload, HW_LAST_REBOOT_REASON)->valuestring);
     CU_ASSERT_STRING_EQUAL(get_parodus_cfg()->fw_name, cJSON_GetObjectItem(payload, FIRMWARE_NAME)->valuestring);
-    CU_ASSERT_STRING_EQUAL(getWebpaInterface(), cJSON_GetObjectItem(payload, WEBPA_INTERFACE)->valuestring);
+    CU_ASSERT_STRING_EQUAL(get_parodus_cfg()->webpa_interface_used, cJSON_GetObjectItem(payload, WEBPA_INTERFACE)->valuestring);
     CU_ASSERT_STRING_EQUAL(get_parodus_cfg()->webpa_protocol, cJSON_GetObjectItem(payload, WEBPA_PROTOCOL)->valuestring);
     CU_ASSERT_EQUAL((int)get_parodus_cfg()->boot_time, cJSON_GetObjectItem(payload, BOOT_TIME)->valueint);
 
-    cJSON_Delete(payload);
 }
 
 void test_createSecureConnection()
@@ -176,7 +175,7 @@ void test_WebpaConveyHeaderWithNullValues()
     CU_ASSERT_PTR_NULL(cJSON_GetObjectItem(payload, FIRMWARE_NAME));
     CU_ASSERT_PTR_NULL(cJSON_GetObjectItem(payload, WEBPA_INTERFACE));
     free(cfg);
-    cJSON_Delete(payload);
+    
 }
 
 void add_suites( CU_pSuite *suite )

tests/test_ParodusInternal.c

@@ -39,7 +39,7 @@ bool LastReasonStatus;
 nopoll_bool nopoll_base64_encode(const char *content,int length,char *output, int *output_size)
 {
     UNUSED(content); UNUSED(length);  UNUSED(output_size);
-    parStrncpy(output, "AWYFUJHUDUDKJDDRDKUIIKORE\nSFJLIRRSHLOUTDESTDJJITTESLOIUHJGDRS\nGIUY&%WSJ", (size_t) *output_size);
+    strcpy(output, "AWYFUJHUDUDKJDDRDKUIIKORE\nSFJLIRRSHLOUTDESTDJJITTESLOIUHJGDRS\nGIUY&%WSJ");
     function_called();
     return (nopoll_bool)(intptr_t)mock();
 }
@@ -56,19 +56,19 @@ char *get_global_reconnect_reason()
 void test_getWebpaConveyHeader()
 {
     ParodusCfg cfg;
-    memset(&cfg, 0, sizeof(ParodusCfg));
-    parStrncpy(cfg.hw_model, "TG1682", sizeof(cfg.hw_model));
-    parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-    parStrncpy(cfg.hw_manufacturer , "ARRISGroup,Inc.", sizeof(cfg.hw_manufacturer));
-    parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-    parStrncpy(cfg.hw_last_reboot_reason , "unknown", sizeof(cfg.hw_last_reboot_reason));
-    parStrncpy(cfg.fw_name , "2.364s2", sizeof(cfg.fw_name));
-    parStrncpy(cfg.webpa_path_url , "/api/v2/device", sizeof(cfg.webpa_path_url));
-    parStrncpy(cfg.webpa_url , "localhost", sizeof(cfg.webpa_url));
-    parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-    parStrncpy(cfg.webpa_protocol , "WebPA-1.6", sizeof(cfg.webpa_protocol));
-    parStrncpy(cfg.webpa_uuid , "1234567-345456546", sizeof(cfg.webpa_uuid));
-    cfg.flags = 0;
+
+    strcpy(cfg.hw_model, "TG1682");
+    strcpy(cfg.hw_serial_number, "Fer23u948590");
+    strcpy(cfg.hw_manufacturer , "ARRISGroup,Inc.");
+    strcpy(cfg.hw_mac , "123567892366");
+    strcpy(cfg.hw_last_reboot_reason , "unknown");
+    strcpy(cfg.fw_name , "2.364s2");
+    strcpy(cfg.webpa_path_url , "/api/v2/device");
+    strcpy(cfg.webpa_url , "localhost");
+    strcpy(cfg.webpa_interface_used , "eth0");
+    strcpy(cfg.webpa_protocol , "WebPA-1.6");
+    strcpy(cfg.webpa_uuid , "1234567-345456546");
+    cfg.secureFlag = 1;
     cfg.boot_time = 423457;
     cfg.webpa_ping_timeout = 30;
     cfg.webpa_backoff_max = 255;
@@ -95,38 +95,6 @@ void err_getWebpaConveyHeader()
     getWebpaConveyHeader();
 }
 
-/*
-*	Test function to verify timespec_diff function
-*	Verifys when the time diff is positive ie stop time > start time
-*/
-void test_timespec_diff()
-{
-    struct timespec start, stop, diff;
-    int time_taken_ms;
-    clock_gettime(CLOCK_REALTIME, &start);
-    sleep(1);
-    clock_gettime(CLOCK_REALTIME, &stop);
-    timespec_diff(&start, &stop, &diff);
-    time_taken_ms = diff.tv_sec * 1000 + (diff.tv_nsec / 1000000);
-    assert_true(time_taken_ms >= 0);
-}
-
-/*
-*	Test function to verify timespec_diff function
-*	Verifys when the time diff is negative ie stop time < start time
-*/
-void test_timespec_diff1()
-{
-    struct timespec start, stop, diff;
-    int time_taken_ms;
-    clock_gettime(CLOCK_REALTIME, &start);
-    sleep(1);
-    clock_gettime(CLOCK_REALTIME, &stop);
-    timespec_diff(&stop, &start, &diff);
-    time_taken_ms = diff.tv_sec * 1000 + (diff.tv_nsec / 1000000);
-    assert_true(time_taken_ms <= 0);
-}
-
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -135,8 +103,6 @@ int main(void)
     const struct CMUnitTest tests[] = {
         cmocka_unit_test(test_getWebpaConveyHeader),
         cmocka_unit_test(err_getWebpaConveyHeader),
-        cmocka_unit_test(test_timespec_diff),
-        cmocka_unit_test(test_timespec_diff1),
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);

tests/test_auth_token.c

@@ -1,435 +0,0 @@
-/**
- *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-#include <assert.h>
-#include <errno.h>
-#include <pthread.h>
-#include <malloc.h>
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-
-#include <CUnit/Basic.h>
-
-#include "../src/config.h"
-#include "../src/auth_token.h"
-#include "../src/ParodusInternal.h"
-
-extern int requestNewAuthToken(char *newToken, size_t len, int r_count);
-
-/*----------------------------------------------------------------------------*/
-/*                                   Mocks                                    */
-/*----------------------------------------------------------------------------*/
-typedef void CURL;
-
-typedef enum {
-  CURLINFO_RESPONSE_CODE    = 2,
-  CURLINFO_TOTAL_TIME
-} CURLINFO;
-
-struct token_data test_data;
-
-int curl_easy_perform(CURL *curl)
-{
-	UNUSED(curl);
-	char *msg = "response";
-	int rtn;
-
-	function_called();
-	rtn = (int) mock();
-	if (0 == rtn)
-	  write_callback_fn (msg, 1, strlen(msg), &test_data);
-	return rtn;
-}
-
-extern int g_response_code;
-
-void setGlobalResponseCode (int response_code)
-{
-	g_response_code = response_code;
-}
-
-int curl_easy_getinfo(CURL *curl, CURLINFO CURLINFO_RESPONSE_CODE, long response_code)
-{
-	UNUSED(curl);
-	UNUSED(CURLINFO_RESPONSE_CODE);
-	if (0 != g_response_code)
-	{
-		response_code= g_response_code;
-		ParodusInfo("response_code is %ld\n", response_code);
-	}
-	function_called();
-	return (int) mock();
-}
-
-char* get_global_reconnect_reason()
-{
-    return "none";
-}
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-void getAuthToken_Null()
-{
-	ParodusCfg cfg;
-	memset(&cfg,0,sizeof(cfg));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-	cfg.client_cert_path = NULL;
-	getAuthToken(&cfg);
-	set_parodus_cfg(&cfg);
-	assert( cfg.client_cert_path == NULL);
-	assert_int_equal (0, (int) cfg.webpa_auth_token[0]);
-}
-
-void getAuthToken_MacNull()
-{
-    ParodusCfg cfg;
-    memset(&cfg,0,sizeof(cfg));
-    cfg.client_cert_path = NULL;
-    getAuthToken(&cfg);
-    set_parodus_cfg(&cfg);
-    assert( cfg.client_cert_path == NULL);
-    assert_int_equal (0, (int) cfg.webpa_auth_token[0]);
-}
-
-#if 0
-void test_requestNewAuthToken_init_fail ()
-{
-	char token[32];
-	ParodusCfg cfg;
-	int output = -1;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-
-	set_parodus_cfg(&cfg);
-
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, -1);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	requestNewAuthToken (token, sizeof(token), 2);
-	assert_int_equal (output, -1);
-	free(cfg.token_server_url);
-}
-#endif
-
-void test_requestNewAuthToken_failure ()
-{
-	char token[32];
-	ParodusCfg cfg;
-	int output = -1;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-	set_parodus_cfg(&cfg);
-
-	test_data.size = 0;
-	test_data.data = token;
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, -1);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	requestNewAuthToken (token, sizeof(token), 2);
-	assert_int_equal (output, -1);
-	assert_int_equal (0, (int) token[0]);
-	free(cfg.token_server_url);
-}
-
-
-void test_requestNewAuthToken ()
-{
-  char token[1024];
-  ParodusCfg cfg;
-  int output = -1;
-  memset(&cfg,0,sizeof(cfg));
-
-  cfg.token_server_url = strdup("https://dev.comcast.net/token");
-  parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-  parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-  parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-  parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-  set_parodus_cfg(&cfg);
-
-  test_data.size = 0;
-  test_data.data = token;
-  setGlobalResponseCode(200);
-  will_return (curl_easy_perform, 0);
-  expect_function_calls (curl_easy_perform, 1);
-  will_return (curl_easy_getinfo, 0);
-  expect_function_calls (curl_easy_getinfo, 1);
-
-  will_return (curl_easy_getinfo, 0);
-  expect_function_calls (curl_easy_getinfo, 1);
-
-  output = requestNewAuthToken (token, sizeof(token), 1);
-  assert_int_equal (output, 0);
-  assert_string_equal (token, "response");
-  free(cfg.token_server_url);
-}
-
-void test_getAuthToken ()
-{
-	ParodusCfg cfg;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	cfg.client_cert_path = strdup("testcert");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-	set_parodus_cfg(&cfg);
-
-	/* To test curl failure case and retry on v4 mode */
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	/* To test curl failure case and retry on v6 mode */
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	/* To test curl success case */
-	test_data.size = 0;
-	test_data.data = cfg.webpa_auth_token;
-	setGlobalResponseCode(200);
-	will_return (curl_easy_perform, 0);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	getAuthToken(&cfg);
-	assert_string_equal (cfg.webpa_auth_token, "response");
-	free(cfg.client_cert_path);
-	free(cfg.token_server_url);
-}
-
-void test_getAuthTokenFailure ()
-{
-	ParodusCfg cfg;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	cfg.client_cert_path = strdup("testcert");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-	set_parodus_cfg(&cfg);
-
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_perform, -1);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	getAuthToken(&cfg);
-
-	assert_string_equal( cfg.webpa_auth_token, "");
-
-	free(cfg.client_cert_path);
-	free(cfg.token_server_url);
-}
-
-void test_write_callback_fn ()
-{
-	ParodusCfg *cfg;
-	size_t max_data_size = sizeof (cfg->webpa_auth_token);
-	char *buffer1 = "response1";
-	size_t buf1len = strlen(buffer1);
-        char *buffer2 = "R2";
-	size_t buf2len = strlen(buffer2);
-	char buffer3[max_data_size];
-	int out_len=0;
-	struct token_data data;
-	data.size = 0;
-
-	data.data = (char *) malloc(max_data_size);
-	data.data[0] = '\0';
-
-	out_len = write_callback_fn(buffer1, 1, buf1len, &data);
-	assert_string_equal(data.data, buffer1);
-	assert_int_equal (out_len, buf1len);
-	assert_int_equal (data.size, buf1len);
-
-	out_len = write_callback_fn(buffer2, 1, buf2len, &data);
-	assert_string_equal(data.data, "response1R2");
-	assert_int_equal (out_len, buf2len);
-	assert_int_equal (data.size, buf1len+buf2len);
-
-	memset (buffer3, 'x', max_data_size);
-	out_len = write_callback_fn(buffer3, 1, max_data_size, &data);
-	assert_int_equal (out_len, 0);
-	assert_int_equal (data.size, 0);
-
-	free(data.data);
-}
-
-void test_requestNewAuthToken_non200 ()
-{
-  char token[1024];
-  ParodusCfg cfg;
-  int output;
-  memset(&cfg,0,sizeof(cfg));
-
-  cfg.token_server_url = strdup("https://dev.comcast.net/token");
-  parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-  parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-  parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-  parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-  set_parodus_cfg(&cfg);
-
-  test_data.size = 0;
-  test_data.data = token;
-  setGlobalResponseCode(404);
-  will_return (curl_easy_perform, 0);
-  expect_function_calls (curl_easy_perform, 1);
-  will_return (curl_easy_getinfo, 0);
-  expect_function_calls (curl_easy_getinfo, 1);
-
-  will_return (curl_easy_getinfo, 0);
-  expect_function_calls (curl_easy_getinfo, 1);
-
-  output = requestNewAuthToken (token, sizeof(token), 1);
-  assert_int_equal (output, -1);
-  assert_string_equal (token, "");
-  ParodusInfo("requestNewAuthToken output: %d token empty len: %lu\n", output, strlen(token));
-  free(cfg.token_server_url);
-}
-
-void test_getAuthTokenFailure_non200 ()
-{
-	ParodusCfg cfg;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	cfg.client_cert_path = strdup("testcert");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-	set_parodus_cfg(&cfg);
-
-	will_return (curl_easy_perform, 0);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_perform, 0);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_perform, 0);
-	expect_function_calls (curl_easy_perform, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-
-	will_return (curl_easy_getinfo, 0);
-	expect_function_calls (curl_easy_getinfo, 1);
-	setGlobalResponseCode(504);
-	getAuthToken(&cfg);
-
-	assert_string_equal( cfg.webpa_auth_token, "");
-
-	free(cfg.client_cert_path);
-	free(cfg.token_server_url);
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-	cmocka_unit_test(test_write_callback_fn),
-        cmocka_unit_test(test_requestNewAuthToken),
-	// cmocka_unit_test(test_requestNewAuthToken_init_fail),
-	cmocka_unit_test(test_requestNewAuthToken_failure),
-	cmocka_unit_test(getAuthToken_Null),
-	cmocka_unit_test(getAuthToken_MacNull),
-	cmocka_unit_test(test_getAuthToken),
-	cmocka_unit_test(test_getAuthTokenFailure),
-	cmocka_unit_test(test_requestNewAuthToken_non200),
-	cmocka_unit_test(test_getAuthTokenFailure_non200)
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_auth_token_more.c

@@ -1,116 +0,0 @@
-/**
- *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-#include <assert.h>
-#include <errno.h>
-#include <pthread.h>
-#include <malloc.h>
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-
-#include <CUnit/Basic.h>
-
-#include "../src/config.h"
-#include "../src/auth_token.h"
-#include "../src/ParodusInternal.h"
-
-extern int requestNewAuthToken(char *newToken, size_t len, int r_count);
-
-/*----------------------------------------------------------------------------*/
-/*                                   Mocks                                    */
-/*----------------------------------------------------------------------------*/
-typedef void CURL;
-
-typedef enum {
-  CURLINFO_RESPONSE_CODE    = 2,
-  CURLINFO_TOTAL_TIME
-} CURLINFO;
-
-struct token_data test_data;
-
-CURL *curl_easy_init  ()
-{
-	function_called();
-	return (CURL *) mock();
-}
-
-int curl_easy_perform(CURL *curl)
-{
-	UNUSED(curl);
-	char *msg = "response";
-	int rtn;
-
-	function_called();
-	rtn = (int) mock();
-	if (0 == rtn)
-	  write_callback_fn (msg, 1, strlen(msg), &test_data);
-	return rtn;
-}
-
-int curl_easy_getinfo(CURL *curl, CURLINFO CURLINFO_RESPONSE_CODE, long response_code)
-{
-	UNUSED(curl);
-	UNUSED(CURLINFO_RESPONSE_CODE);
-	UNUSED(response_code);
-	function_called();
-	return (int) mock();
-}
-
-char* get_global_reconnect_reason()
-{
-    return "none";
-}
-
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-void test_requestNewAuthToken_init_fail ()
-{
-	char token[32];
-	ParodusCfg cfg;
-	int output = -1;
-	memset(&cfg,0,sizeof(cfg));
-
-	cfg.token_server_url = strdup("https://dev.comcast.net/token");
-	parStrncpy(cfg.cert_path , "/etc/ssl/certs/ca-certificates.crt", sizeof(cfg.cert_path));
-	parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-	parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-
-	set_parodus_cfg(&cfg);
-
-	will_return (curl_easy_init, NULL);
-	expect_function_calls (curl_easy_init, 1);
-
-	requestNewAuthToken (token, sizeof(token), 2);
-	assert_int_equal (output, -1);
-	assert_int_equal (0, (int) token[0]);
-	free(cfg.token_server_url);
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-	cmocka_unit_test(test_requestNewAuthToken_init_fail)
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_client_list.c

@@ -26,14 +26,9 @@
 #define TEST_CLIENT1_URL "tcp://127.0.0.1:6677"
 #define TEST_CLIENT2_URL "tcp://127.0.0.1:6655"
 
-pthread_t test_tid;
-pthread_t test_tid2;
-
 static void *client_rcv_task();
 static void *client2_rcv_task();
 
-int numLoops;
-
 /*----------------------------------------------------------------------------*/
 /*                                   Tests                                    */
 /*----------------------------------------------------------------------------*/
@@ -63,7 +58,7 @@ void test_client_addtolist()
 	ParodusPrint("decoded service_name:%s\n", message->u.reg.service_name);
 	ParodusPrint("decoded dest:%s\n", message->u.reg.url);
 	
-	StartThread(client_rcv_task, &test_tid);
+	StartThread(client_rcv_task);
 	
 	status = addToList(&message);
 	ParodusPrint("addToList status is %d\n", status);
@@ -78,9 +73,8 @@ void test_client_addtolist()
 		CU_ASSERT_STRING_EQUAL( temp->service_name, message->u.reg.service_name );
 		CU_ASSERT_STRING_EQUAL( temp->url, message->u.reg.url );
 	}
-	release_global_node ();
+
 	wrp_free_struct(message);
-	free(bytes);
 	ParodusInfo("test_client_addtolist done..\n");	
 	
 }
@@ -92,23 +86,13 @@ static void *client_rcv_task()
 	int byte =0;
 	int rv1=0;
 	int t=25000;
-	int rc = -1;
-	int bind;
 	wrp_msg_t  *msg1;
 
 	int sock1 = nn_socket (AF_SP, NN_PULL);
-	bind = nn_bind(sock1, TEST_CLIENT1_URL);
-	if(bind < 0)
-        {
-            ParodusError("Unable to bind socket (errno=%d, %s)\n",errno, strerror(errno));
-        }
+	nn_bind(sock1, TEST_CLIENT1_URL);
 	
 	void *buf = NULL;
-	rc = nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
-	if(rc < 0)
-        {
-        	ParodusError ("Unable to set socket timeout (errno=%d, %s)\n",errno, strerror(errno));
-        }
+	nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
 	
 	ParodusPrint("Client 1 waiting for acknowledgement \n");
 	byte = nn_recv(sock1, &buf, NN_MSG, 0);
@@ -134,23 +118,13 @@ static void *client2_rcv_task()
 	int byte =0;
 	int rv1=0;
 	int t=25000;
-	int rc = -1;
-	int bind;
 	wrp_msg_t  *msg1;
 
 	int sock1 = nn_socket (AF_SP, NN_PULL);
-	bind = nn_bind(sock1, TEST_CLIENT2_URL);
-	if(bind < 0)
-        {
-            ParodusError("Unable to bind socket (errno=%d, %s)\n",errno, strerror(errno));
-        }
+	nn_bind(sock1, TEST_CLIENT2_URL);
 	
 	void *buf = NULL;
-	rc = nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
-	if(rc < 0)
-        {
-                ParodusError ("Unable to set socket timeout (errno=%d, %s)\n",errno, strerror(errno));
-        }
+	nn_setsockopt(sock1, NN_SOL_SOCKET, NN_RCVTIMEO, &t, sizeof(t));
 	
 	ParodusPrint("Client 2 waiting for acknowledgement \n");
 	byte = nn_recv(sock1, &buf, NN_MSG, 0);
@@ -194,7 +168,7 @@ void test_addtolist_multiple_clients()
 	ParodusPrint("decoded service_name:%s\n", message->u.reg.service_name);
 	ParodusPrint("decoded dest:%s\n", message->u.reg.url);
 	
-	StartThread(client2_rcv_task, &test_tid2);
+	StartThread(client2_rcv_task);
 	
 	status = addToList(&message);
 	ParodusPrint("addToList status is %d\n", status);
@@ -211,9 +185,8 @@ void test_addtolist_multiple_clients()
 		CU_ASSERT_STRING_EQUAL( temp->url, message->u.reg.url );
 		
 	}
-	release_global_node ();
+
 	wrp_free_struct(message);
-	free(bytes);
 	ParodusInfo("test_addtolist_multiple_clients done..\n");	
 	
 }

tests/test_close_retry.c

@@ -1,93 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-#include <pthread.h>
-
-#include "../src/close_retry.h"
-#include "../src/parodus_log.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-void test_close_retry() {
-	/* get close_retry initial value */
-	bool close_retry =false;
-	close_retry = get_close_retry();
-	ParodusInfo("close_retry initial value is: %d\n", close_retry);
-	assert_int_equal(close_retry, 0);
-
-	/* set close_retry value and check whether its returning modified value or not*/
-	set_close_retry();
-	close_retry = get_close_retry();
-	ParodusInfo("close_retry modified to: %d\n", close_retry);
-	assert_int_equal(close_retry,1);
-
-	/* reset close_retry */
-	reset_close_retry();
-	close_retry = get_close_retry();
-	ParodusInfo("close_retry reset to: %d\n", close_retry);
-	assert_int_equal(close_retry,0);
-}
-
-void *test_mutex_set_close_retry() {
-	set_close_retry();
-	return NULL;
-}
-
-void *test_mutex_reset_close_retry() {
-	reset_close_retry();
-	return NULL;
-}
-
-void test_mutex_close_retry() {
-	bool close_retry;
-	pthread_t thread[3];
-
-	pthread_create(&thread[0], NULL, test_mutex_set_close_retry, NULL);
-	pthread_create(&thread[1], NULL, test_mutex_set_close_retry, NULL);
-
-	pthread_join(thread[0], NULL);
-	pthread_join(thread[1], NULL);
-
-	/* After execution of threads check the value of close_retry */
-	close_retry = get_close_retry();
-	ParodusInfo("Threads execution is completed, close_retry is: %d\n", close_retry);
-	assert_int_equal(close_retry, 1);
-
-	pthread_create(&thread[2], NULL, test_mutex_reset_close_retry, NULL);
-	pthread_join(thread[2], NULL);
-
-	close_retry = get_close_retry();
-	ParodusInfo("close_retry reset to: %d\n", close_retry);
-	assert_int_equal(close_retry, 0);
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-        cmocka_unit_test(test_close_retry),
-        cmocka_unit_test(test_mutex_close_retry)
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_config.c

@@ -25,76 +25,42 @@
 #include <CUnit/Basic.h>
 
 #include "../src/config.h"
-#include "../src/auth_token.h"
-#include "../src/ParodusInternal.h"
 
-extern int parse_mac_address (char *target, const char *arg);
-extern int server_is_http (const char *full_url,
-	const char **server_ptr);
-extern int parse_webpa_url__(const char *full_url, 
-	char *server_addr, int server_addr_buflen,
-	char *port_buf, int port_buflen);
-extern int parse_webpa_url (const char *full_url,
-	char **server_addr, unsigned int *port);
-extern unsigned int get_algo_mask (const char *algo_str);
-extern unsigned int parse_num_arg (const char *arg, const char *arg_name);
+#define K_argc 15
 
 /*----------------------------------------------------------------------------*/
 /*                                   Mocks                                    */
 /*----------------------------------------------------------------------------*/
-void create_token_script(char *fname)
-{
-    char command[128] = {'\0'};
-    FILE *fp = fopen(fname, "w");
-    assert_non_null(fp);
-    fprintf(fp, "%s", "printf secure-token-$1-$2");
-    fclose(fp);
-    sprintf(command, "chmod +x %s",fname);
-    system(command);
-}
-
-char* get_global_reconnect_reason()
-{
-    return "none";
-}
 
 /*----------------------------------------------------------------------------*/
 /*                                   Tests                                    */
 /*----------------------------------------------------------------------------*/
-
 void test_setParodusConfig()
 {
     ParodusCfg cfg;
     memset(&cfg,0,sizeof(cfg));
 
-    parStrncpy(cfg.hw_model, "TG1682", sizeof(cfg.hw_model));
-    parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-    parStrncpy(cfg.hw_manufacturer , "ARRISGroup,Inc.", sizeof(cfg.hw_manufacturer));
-    parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-    parStrncpy(cfg.hw_last_reboot_reason , "unknown", sizeof(cfg.hw_last_reboot_reason));
-    parStrncpy(cfg.fw_name , "2.364s2", sizeof(cfg.fw_name));
-    parStrncpy(cfg.webpa_path_url , "/v1", sizeof(cfg.webpa_path_url));
-    parStrncpy(cfg.webpa_url , "http://127.0.0.1", sizeof(cfg.webpa_url));
-    parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-    parStrncpy(cfg.webpa_protocol , "WebPA-1.6", sizeof(cfg.webpa_protocol));
-    parStrncpy(cfg.webpa_uuid , "1234567-345456546", sizeof(cfg.webpa_uuid));
-    parStrncpy(cfg.partner_id , "mycom", sizeof(cfg.partner_id));
-#ifdef ENABLE_SESHAT
-    parStrncpy(cfg.seshat_url, "ipc://tmp/seshat_service.url", sizeof(cfg.seshat_url));
-#endif
-    cfg.flags = 0;
+    strcpy(cfg.hw_model, "TG1682");
+    strcpy(cfg.hw_serial_number, "Fer23u948590");
+    strcpy(cfg.hw_manufacturer , "ARRISGroup,Inc.");
+    strcpy(cfg.hw_mac , "123567892366");
+    strcpy(cfg.hw_last_reboot_reason , "unknown");
+    strcpy(cfg.fw_name , "2.364s2");
+    strcpy(cfg.webpa_path_url , "/v1");
+    strcpy(cfg.webpa_url , "localhost");
+    strcpy(cfg.webpa_interface_used , "eth0");
+    strcpy(cfg.webpa_protocol , "WebPA-1.6");
+    strcpy(cfg.webpa_uuid , "1234567-345456546");
+    strcpy(cfg.partner_id , "comcast");
+    strcpy(cfg.seshat_url, "ipc://tmp/seshat_service.url");
+    cfg.secureFlag = 1;
     cfg.boot_time = 423457;
     cfg.webpa_ping_timeout = 30;
     cfg.webpa_backoff_max = 255;
-#ifdef FEATURE_DNS_QUERY
-    cfg.acquire_jwt = 1;
-    parStrncpy(cfg.dns_txt_url, "test",sizeof(cfg.dns_txt_url));
-    cfg.jwt_algo = 1025;
-    parStrncpy(cfg.jwt_key, "key.txt",sizeof(cfg.jwt_key));
-#endif 
-	cfg.crud_config_file = strdup("parodus_cfg.json");
-	set_parodus_cfg(&cfg);
-	ParodusCfg *temp = get_parodus_cfg();
+    
+    set_parodus_cfg(&cfg);
+
+    ParodusCfg *temp = get_parodus_cfg();
 
     assert_string_equal(cfg.hw_model, temp->hw_model);
     assert_string_equal(cfg.hw_serial_number, temp->hw_serial_number);
@@ -103,26 +69,17 @@ void test_setParodusConfig()
     assert_string_equal(cfg.hw_last_reboot_reason, temp->hw_last_reboot_reason);
     assert_string_equal(cfg.webpa_path_url, temp->webpa_path_url);
     assert_string_equal(cfg.webpa_url, temp->webpa_url);
-    assert_string_equal(cfg.webpa_interface_used, getWebpaInterface());
+    assert_string_equal(cfg.webpa_interface_used, temp->webpa_interface_used);
     assert_string_equal(cfg.webpa_protocol, temp->webpa_protocol);
     assert_string_equal(cfg.webpa_uuid, temp->webpa_uuid);
     assert_string_equal(cfg.partner_id, temp->partner_id);
-#ifdef ENABLE_SESHAT
     assert_string_equal(cfg.seshat_url, temp->seshat_url);
-#endif
-    assert_int_equal((int) cfg.flags, (int) temp->flags);
+
+
+    assert_int_equal((int) cfg.secureFlag, (int) temp->secureFlag);
     assert_int_equal((int) cfg.boot_time, (int) temp->boot_time);
     assert_int_equal((int) cfg.webpa_ping_timeout, (int) temp->webpa_ping_timeout);
     assert_int_equal((int) cfg.webpa_backoff_max, (int) temp->webpa_backoff_max);
-#ifdef FEATURE_DNS_QUERY
-    assert_int_equal( (int) cfg.acquire_jwt, (int) temp->acquire_jwt);
-    assert_string_equal(cfg.dns_txt_url, temp->dns_txt_url);
-    assert_int_equal( (int) cfg.jwt_algo, (int) temp->jwt_algo);
-    assert_string_equal(cfg.jwt_key, temp->jwt_key);
-#endif
-	assert_string_equal(cfg.crud_config_file, temp->crud_config_file);
-
-    free(cfg.crud_config_file);
 }
 
 void test_getParodusConfig()
@@ -130,7 +87,7 @@ void test_getParodusConfig()
     ParodusCfg cfg;
     memset(&cfg,0,sizeof(cfg));
 
-    parStrncpy(cfg.hw_model, "TG1682133",sizeof(cfg.hw_model));
+    strcpy(cfg.hw_model, "TG1682133");
     set_parodus_cfg(&cfg);
 
     ParodusCfg *temp = get_parodus_cfg();
@@ -138,81 +95,34 @@ void test_getParodusConfig()
     assert_string_equal(cfg.hw_model, temp->hw_model);
 }
 
-static int open_output_file (const char *fname)
-{
-  int fd = open(fname, O_WRONLY | O_CREAT, 0666);
-  if (fd<0)
-  {
-    ParodusError ("File %s open error\n", fname);
-    abort ();
-  }
-  return fd;
-} 
-
-void write_key_to_file (const char *fname, const char *buf)
-{
-  ssize_t nbytes;
-  ssize_t buflen = strlen (buf);
-  int fd = open_output_file(fname);
-  nbytes = write(fd, buf, buflen);
-  if (nbytes < 0)
-  {
-    ParodusError ("Write file %s error\n", fname);
-    close(fd);
-    abort ();
-  }
-  close(fd);
-  ParodusInfo ("%d bytes written\n", nbytes);
-}
-
 void test_parseCommandLine()
 {
-    char expectedToken[1280] = {'\0'};
-#ifdef FEATURE_DNS_QUERY    
-	const char *jwt_key =	"AGdyuwyhwl2ow2ydsoioiygkshwdthuwd";
-#endif
+    int argc =K_argc;
+    char * command[argc+1];
+    int i = 0;
 
-    char *command[] = {"parodus",
-		"--hw-model=TG1682",
-		"--hw-serial-number=Fer23u948590",
-		"--hw-manufacturer=ARRISGroup,Inc.",
-		"--hw-mac=123567892366",
-		"--hw-last-reboot-reason=unknown",
-		"--fw-name=TG1682_DEV_master_2016000000sdy",
-		"--webpa-ping-timeout=180",
-		"--webpa-interface-used=br0",
-		"--webpa-url=http://127.0.0.1",
-		"--webpa-backoff-max=0",
-		"--boot-time=1234",
-		"--parodus-local-url=tcp://127.0.0.1:6666",
-		"--partner-id=cox",
-#ifdef ENABLE_SESHAT
-		"--seshat-url=ipc://127.0.0.1:7777",
-#endif
-		"--force-ipv4",
-		"--force-ipv6",
-		"--boot-time-retry-wait=10",
-		"--ssl-cert-path=/etc/ssl/certs/ca-certificates.crt",
-		"--client-cert-path=testcert",
-		"--token-server-url=https://dev.comcast.net/token",
-#ifdef FEATURE_DNS_QUERY
-		"--acquire-jwt=1",
-		"--dns-txt-url=mydns.mycom.net",
-		"--jwt-public-key-file=../../tests/jwt_key.tst",
-		"--jwt-algo=RS256",
-#endif
-		"--crud-config-file=parodus_cfg.json",
-		NULL
-	};
-	int argc = (sizeof (command) / sizeof (char *)) - 1;
+    command[i++] = "parodus";
+    command[i++] = "--hw-model=TG1682";
+    command[i++] = "--hw-serial-number=Fer23u948590";
+    command[i++] = "--hw-manufacturer=ARRISGroup,Inc.";
+    command[i++] = "--hw-mac=123567892366";
+    command[i++] = "--hw-last-reboot-reason=unknown";
+    command[i++] = "--fw-name=TG1682_DEV_master_2016000000sdy";
+    command[i++] = "--webpa-ping-time=180";
+    command[i++] = "--webpa-inteface-used=br0";
+    command[i++] = "--webpa-url=localhost";
+    command[i++] = "--webpa-backoff-max=0";
+    command[i++] = "--boot-time=1234";
+    command[i++] = "--parodus-local-url=tcp://127.0.0.1:6666";
+    command[i++] = "--partner-id=cox";
+    command[i++] = "--seshat-url=ipc://127.0.0.1:7777";
+    command[i] = '\0';
 
     ParodusCfg parodusCfg;
     memset(&parodusCfg,0,sizeof(parodusCfg));
-#ifdef FEATURE_DNS_QUERY
-	write_key_to_file ("../../tests/jwt_key.tst", jwt_key);
-#endif
-    create_token_script("/tmp/token.sh");
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), 0);
+
+    parseCommandLine(argc,command,&parodusCfg);
+
     assert_string_equal( parodusCfg.hw_model, "TG1682");
     assert_string_equal( parodusCfg.hw_serial_number, "Fer23u948590");
     assert_string_equal( parodusCfg.hw_manufacturer, "ARRISGroup,Inc.");
@@ -220,120 +130,57 @@ void test_parseCommandLine()
     assert_string_equal( parodusCfg.hw_last_reboot_reason, "unknown");	
     assert_string_equal( parodusCfg.fw_name, "TG1682_DEV_master_2016000000sdy");	
     assert_int_equal( (int) parodusCfg.webpa_ping_timeout,180);	
-    assert_int_equal( (int) parodusCfg.boot_retry_wait,10);
     assert_string_equal( parodusCfg.webpa_interface_used, "br0");	
-    assert_string_equal( parodusCfg.webpa_url, "http://127.0.0.1");
+    assert_string_equal( parodusCfg.webpa_url, "localhost");
     assert_int_equal( (int) parodusCfg.webpa_backoff_max,0);
     assert_int_equal( (int) parodusCfg.boot_time,1234);
     assert_string_equal(  parodusCfg.local_url,"tcp://127.0.0.1:6666");
     assert_string_equal(  parodusCfg.partner_id,"cox");
-#ifdef ENABLE_SESHAT
     assert_string_equal(  parodusCfg.seshat_url, "ipc://127.0.0.1:7777");
-#endif
-    assert_int_equal( (int) parodusCfg.flags, FLAGS_IPV6_ONLY|FLAGS_IPV4_ONLY);
-    
-    set_parodus_cfg(&parodusCfg);
-    getAuthToken(&parodusCfg);
-    assert_string_equal(  get_parodus_cfg()->webpa_auth_token,expectedToken);
-    assert_string_equal(  parodusCfg.cert_path,"/etc/ssl/certs/ca-certificates.crt");
-	assert_string_equal(  parodusCfg.client_cert_path,"testcert");
-	assert_string_equal(  parodusCfg.token_server_url,"https://dev.comcast.net/token");
-#ifdef FEATURE_DNS_QUERY
-	assert_int_equal( (int) parodusCfg.acquire_jwt, 1);
-    assert_string_equal(parodusCfg.dns_txt_url, "mydns.mycom.net");
-    assert_int_equal( (int) parodusCfg.jwt_algo, 1024);
-	assert_string_equal ( get_parodus_cfg()->jwt_key, jwt_key);
-#endif
-	assert_int_equal( (int) parodusCfg.boot_retry_wait, 10);
-	assert_string_equal(parodusCfg.crud_config_file, "parodus_cfg.json");
+
 }
 
 void test_parseCommandLineNull()
 {
-    assert_int_equal (parseCommandLine(0,NULL,NULL), -1);
+    parseCommandLine(0,NULL,NULL);
 }
 
 void err_parseCommandLine()
 {
-	int argc;
-    char *command[] = {"parodus",
-		"--hw-model=TG1682",
-		"--hw-serial-number=Fer23u948590",
-		"-Z",
-		"--nosuch",
-		"--hw-mac=123567892366",
-		"webpa",
-		NULL
-	};
-    ParodusCfg parodusCfg;
+    int argc =K_argc;
+    char * command[20]={'\0'};
 
+    command[0] = "parodus";
+    command[1] = "--hw-model=TG1682";
+    command[12] = "webpa";
+
+    ParodusCfg parodusCfg;
     memset(&parodusCfg,0,sizeof(parodusCfg));
 
-	argc = (sizeof (command) / sizeof (char *)) - 1;
-	// Missing webpa_url
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	// Bad webpa_url
-	command[5] = "--webpa-url=127.0.0.1";
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	// Bad mac address
-	command[5] = "--hw-mac=1235678923";
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	command[5] = "--webpa-ping-timeout=123x";
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	command[5] = "--webpa-backoff-max=";
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	command[5] = "--boot-time=12x";
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-#ifdef FEATURE_DNS_QUERY
-	command[5] = "--webpa-url=https://127.0.0.1";
-	command[3] = "--acquire-jwt=1";
-	command[4] = "--dns-txt-url=mydns.mycom.net";
-	// missing algo
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	command[4] = "--jwt-algo=none:RS256";
-	// disallowed alogrithm none
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	command[4] = "--jwt-algo=RS256";
-	// missing jwt public key file
-    assert_int_equal (parseCommandLine(argc,command,&parodusCfg), -1);
-	
-#endif    
+    parseCommandLine(argc,command,&parodusCfg);
+    assert_string_equal( parodusCfg.hw_model, "");
+    assert_string_equal( parodusCfg.hw_serial_number, "");
 }
 
 void test_loadParodusCfg()
 {
     ParodusCfg  tmpcfg;
-    ParodusCfg *Cfg = NULL;
-    char protocol[32] = {'\0'};
+    ParodusCfg *Cfg;
     Cfg = (ParodusCfg*)malloc(sizeof(ParodusCfg));
-    memset(Cfg, 0, sizeof(ParodusCfg));
 
-    parStrncpy(Cfg->hw_model, "TG1682", sizeof(Cfg->hw_model));
-    parStrncpy(Cfg->hw_serial_number, "Fer23u948590", sizeof(Cfg->hw_serial_number));
-    parStrncpy(Cfg->hw_manufacturer , "ARRISGroup,Inc.", sizeof(Cfg->hw_manufacturer));
-    parStrncpy(Cfg->hw_mac , "123567892366", sizeof(Cfg->hw_mac));
-    parStrncpy(Cfg->hw_last_reboot_reason , "unknown", sizeof(Cfg->hw_last_reboot_reason));
-    parStrncpy(Cfg->fw_name , "2.364s2", sizeof(Cfg->fw_name));
-    parStrncpy(Cfg->webpa_path_url , "/v1", sizeof(Cfg->webpa_path_url));
-    parStrncpy(Cfg->webpa_url , "http://127.0.0.1", sizeof(Cfg->webpa_url));
-    parStrncpy(Cfg->webpa_interface_used , "eth0", sizeof(Cfg->webpa_interface_used));
-    snprintf(protocol, sizeof(protocol), "%s-%s", PROTOCOL_VALUE, GIT_COMMIT_TAG);
-    parStrncpy(Cfg->webpa_protocol , protocol, sizeof(Cfg->webpa_protocol));
-    parStrncpy(Cfg->local_url , "tcp://10.0.0.1:6000", sizeof(Cfg->local_url));
-    parStrncpy(Cfg->partner_id , "shaw", sizeof(Cfg->partner_id));
-#ifdef FEATURE_DNS_QUERY
-	Cfg->acquire_jwt = 1;
-    parStrncpy(Cfg->dns_txt_url, "mydns",sizeof(Cfg->dns_txt_url));
-    Cfg->jwt_algo = 1025;
-    parStrncpy(Cfg->jwt_key, "AGdyuwyhwl2ow2ydsoioiygkshwdthuwd",sizeof(Cfg->jwt_key));
-#endif
-    parStrncpy(Cfg->cert_path, "/etc/ssl.crt",sizeof(Cfg->cert_path));
-#ifdef ENABLE_SESHAT
-    parStrncpy(Cfg->seshat_url, "ipc://tmp/seshat_service.url", sizeof(Cfg->seshat_url));
-#endif
-	Cfg->crud_config_file = strdup("parodus_cfg.json");
-	Cfg->client_cert_path = strdup("testcert");
-	Cfg->token_server_url = strdup("https://dev.comcast.net/token");
+    strcpy(Cfg->hw_model, "TG1682");
+    strcpy(Cfg->hw_serial_number, "Fer23u948590");
+    strcpy(Cfg->hw_manufacturer , "ARRISGroup,Inc.");
+    strcpy(Cfg->hw_mac , "123567892366");
+    strcpy(Cfg->hw_last_reboot_reason , "unknown");
+    strcpy(Cfg->fw_name , "2.364s2");
+    strcpy(Cfg->webpa_path_url , "/v1");
+    strcpy(Cfg->webpa_url , "localhost");
+    strcpy(Cfg->webpa_interface_used , "eth0");
+    strcpy(Cfg->webpa_protocol , "WebPA-1.6");
+    strcpy(Cfg->local_url , "tcp://10.0.0.1:6000");
+    strcpy(Cfg->partner_id , "shaw");
+
     memset(&tmpcfg,0,sizeof(ParodusCfg));
     loadParodusCfg(Cfg,&tmpcfg);
 
@@ -343,28 +190,6 @@ void test_loadParodusCfg()
     assert_string_equal( tmpcfg.hw_mac, "123567892366");
     assert_string_equal( tmpcfg.local_url, "tcp://10.0.0.1:6000");
     assert_string_equal( tmpcfg.partner_id, "shaw");
-    assert_string_equal( tmpcfg.webpa_protocol, protocol);
-	assert_string_equal(tmpcfg.client_cert_path, "testcert");
-	assert_string_equal(tmpcfg.token_server_url, "https://dev.comcast.net/token");
-#ifdef FEATURE_DNS_QUERY
-	assert_int_equal( (int) tmpcfg.acquire_jwt, 1);
-    assert_string_equal(tmpcfg.dns_txt_url, "mydns");
-    assert_int_equal( (int) tmpcfg.jwt_algo, 1025);
-    assert_string_equal(tmpcfg.jwt_key, "AGdyuwyhwl2ow2ydsoioiygkshwdthuwd");
-#endif
-    assert_string_equal(tmpcfg.cert_path, "/etc/ssl.crt");
-#ifdef ENABLE_SESHAT
-    assert_string_equal(tmpcfg.seshat_url, "ipc://tmp/seshat_service.url");
-#endif
-	assert_string_equal(tmpcfg.crud_config_file, "parodus_cfg.json");
-
-    free(tmpcfg.client_cert_path);
-    free(tmpcfg.token_server_url);
-    free(tmpcfg.crud_config_file);
-
-    free(Cfg->crud_config_file);
-    free(Cfg->client_cert_path);
-    free(Cfg->token_server_url);
     free(Cfg);
 }
 
@@ -381,11 +206,12 @@ void test_loadParodusCfgNull()
     assert_string_equal(temp.hw_model, "");
     assert_string_equal(temp.hw_serial_number, "");
     assert_string_equal(temp.hw_manufacturer, "");
-    assert_int_equal( (int) temp.flags,0);
+    assert_int_equal( (int) temp.secureFlag,1);	
     assert_string_equal( temp.webpa_path_url, WEBPA_PATH_URL);	
+    assert_string_equal( temp.webpa_protocol, WEBPA_PROTOCOL_VALUE);
     assert_string_equal( temp.webpa_uuid,"1234567-345456546");
     assert_string_equal( temp.local_url, PARODUS_UPSTREAM);
-	assert_null(temp.crud_config_file);
+
     free(cfg);
 }
 
@@ -395,184 +221,6 @@ void err_loadParodusCfg()
     loadParodusCfg(NULL,&cfg);
 }
 
-void test_parodusGitVersion()
-{
-   FILE *fp;
-   char version[32] = {'\0'};
-   char *command = "git describe --tags --always";
-   int n;
-   size_t len;
-   fp = popen(command,"r"); 
-   while(fgets(version, 32, fp) !=NULL)
-   {
-   	len = strlen(version);
-  	if (len > 0 && version[len-1] == '\n') 
-  	{
-    		version[--len] = '\0';
-  	}
-   }
-   pclose(fp);
-   
-   printf ("version: %s\n", version);
-   printf ("GIT_COMMIT_TAG: %s\n", GIT_COMMIT_TAG);
-   n = strcmp( version, GIT_COMMIT_TAG);
-   assert_int_equal(n, 0);
-}
-
-void test_setDefaultValuesToCfg()
-{
-    ParodusCfg *cfg = (ParodusCfg *) malloc(sizeof(ParodusCfg));
-    memset(cfg,0,sizeof(ParodusCfg));
-    setDefaultValuesToCfg(cfg);
-    assert_string_equal( cfg->local_url, PARODUS_UPSTREAM);
-#ifdef FEATURE_DNS_QUERY
-	assert_int_equal(cfg->acquire_jwt, 0);
-    assert_string_equal(cfg->dns_txt_url, DNS_TXT_URL);
-    assert_string_equal(cfg->jwt_key, "\0");
-    assert_int_equal( (int)cfg->jwt_algo, 0);
-#endif
-    assert_string_equal(cfg->cert_path, "\0");
-    assert_int_equal((int)cfg->flags, 0);
-    assert_string_equal(cfg->webpa_path_url, WEBPA_PATH_URL);
-    assert_string_equal(cfg->webpa_uuid, "1234567-345456546");
-    assert_string_equal(cfg->cloud_status, CLOUD_STATUS_OFFLINE);
-
-    free(cfg);
-}
-
-void err_setDefaultValuesToCfg()
-{
-    setDefaultValuesToCfg(NULL);
-}
-
-void test_parse_num_arg ()
-{
-	assert_int_equal (parse_num_arg ("1234", "1234"), 1234);
-	assert_int_equal (parse_num_arg ("1", "1"), 1);
-	assert_int_equal (parse_num_arg ("0", "0"), 0);
-	assert_true (parse_num_arg ("", "empty arg") == (unsigned int) -1);
-	assert_true (parse_num_arg ("0x", "non-num arg") == (unsigned int) -1);
-	
-}
-
-void test_parse_mac_address ()
-{
-	char result[14];
-	assert_int_equal (parse_mac_address (result, "aabbccddeeff"), 0);
-	assert_string_equal (result, "aabbccddeeff");
-	assert_int_equal (parse_mac_address (result, "aa:bb:cc:dd:ee:ff"), 0);
-	assert_string_equal (result, "aabbccddeeff");
-	assert_int_equal (parse_mac_address (result, "aabbccddeeff0"), -1);
-	assert_int_equal (parse_mac_address (result, "aa:bb:c:dd:ee:ff:00"), -1);
-	assert_int_equal (parse_mac_address (result, ""), -1);
-}
-
-void test_server_is_http ()
-{
-	const char *server_ptr;
-	assert_int_equal (server_is_http ("https://127.0.0.1", &server_ptr), 0);
-	assert_string_equal (server_ptr, "127.0.0.1");
-	assert_int_equal (server_is_http ("http://127.0.0.1", &server_ptr), 1);
-	assert_string_equal (server_ptr, "127.0.0.1");
-	assert_int_equal (server_is_http ("127.0.0.1", &server_ptr), -1);
-	
-}
-
-void test_parse_webpa_url__ ()
-{
-	char addr_buf[80];
-	char port_buf[8];
-	assert_int_equal (parse_webpa_url__ ("mydns.mycom.net:8080",
-		addr_buf, 80, port_buf, 8), -1);
-	assert_int_equal (parse_webpa_url__ ("https://mydns.mycom.net:8080",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "mydns.mycom.net");
-	assert_string_equal (port_buf, "8080");
-	assert_int_equal (parse_webpa_url__ ("https://mydns.mycom.net/",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "mydns.mycom.net");
-	assert_string_equal (port_buf, "443");
-	assert_int_equal (parse_webpa_url__ ("https://mydns.mycom.net/api/v2/",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "mydns.mycom.net");
-	assert_string_equal (port_buf, "443");
-	assert_int_equal (parse_webpa_url__ ("http://mydns.mycom.net:8080",
-		addr_buf, 80, port_buf, 8), 1);
-	assert_string_equal (addr_buf, "mydns.mycom.net");
-	assert_string_equal (port_buf, "8080");
-	assert_int_equal (parse_webpa_url__ ("http://mydns.mycom.net",
-		addr_buf, 80, port_buf, 8), 1);
-	assert_string_equal (addr_buf, "mydns.mycom.net");
-	assert_string_equal (port_buf, "80");
-    assert_int_equal (parse_webpa_url__ ("https://[2001:558:fc18:2:f816:3eff:fe7f:6efa]:8080",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "2001:558:fc18:2:f816:3eff:fe7f:6efa");
-	assert_string_equal (port_buf, "8080");
-    assert_int_equal (parse_webpa_url__ ("https://[2001:558:fc18:2:f816:3eff:fe7f:6efa]",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "2001:558:fc18:2:f816:3eff:fe7f:6efa");
-	assert_string_equal (port_buf, "443");
-    assert_int_equal (parse_webpa_url__ ("http://[2001:558:fc18:2:f816:3eff:fe7f:6efa]:8080",
-		addr_buf, 80, port_buf, 8), 1);
-	assert_string_equal (addr_buf, "2001:558:fc18:2:f816:3eff:fe7f:6efa");
-	assert_string_equal (port_buf, "8080");
-    assert_int_equal (parse_webpa_url__ ("http://[2001:558:fc18:2:f816:3eff:fe7f:6efa]",
-		addr_buf, 80, port_buf, 8), 1);
-	assert_string_equal (addr_buf, "2001:558:fc18:2:f816:3eff:fe7f:6efa");
-	assert_string_equal (port_buf, "80");
-    assert_int_equal (parse_webpa_url__ ("http://2001:558:fc18:2:f816:3eff:fe7f:6efa]",
-		addr_buf, 80, port_buf, 8), -1);
-    assert_int_equal (parse_webpa_url__ ("http://[2001:558:fc18:2:f816:3eff:fe7f:6efa",
-		addr_buf, 80, port_buf, 8), -1);
-    assert_int_equal (parse_webpa_url__ ("[2001:558:fc18:2:f816:3eff:fe7f:6efa",
-		addr_buf, 80, port_buf, 8), -1);
-	assert_int_equal (parse_webpa_url__ ("https://[2001:558:fc18:2:f816:3eff:fe7f:6efa]:8080/api/v2/",
-		addr_buf, 80, port_buf, 8), 0);
-	assert_string_equal (addr_buf, "2001:558:fc18:2:f816:3eff:fe7f:6efa");
-	assert_string_equal (port_buf, "8080");
-		
-}
-
-void test_parse_webpa_url ()
-{
-	char *addr;
-	unsigned int port;
-	assert_int_equal (parse_webpa_url ("mydns.mycom.net:8080",
-		&addr, &port), -1);
-	assert_int_equal (parse_webpa_url ("https://mydns.mycom.net:8080",
-		&addr, &port), 0);
-	assert_string_equal (addr, "mydns.mycom.net");
-	assert_int_equal (port, 8080);
-	free (addr);
-	assert_int_equal (parse_webpa_url ("https://mydns.mycom.net/",
-		&addr, &port), 0);
-	assert_string_equal (addr, "mydns.mycom.net");
-	assert_int_equal (port, 443);
-	free (addr);
-	assert_int_equal (parse_webpa_url ("http://mydns.mycom.net:8080",
-		&addr, &port), 1);
-	assert_string_equal (addr, "mydns.mycom.net");
-	assert_int_equal (port, 8080);
-	free (addr);
-	assert_int_equal (parse_webpa_url ("http://mydns.mycom.net",
-		&addr, &port), 1);
-	assert_string_equal (addr, "mydns.mycom.net");
-	assert_int_equal (port, 80);
-	free(addr);
-}
-
-void test_get_algo_mask ()
-{
-	assert_true (get_algo_mask ("RS256:RS512") == 5120);
-	assert_true (get_algo_mask ("none:RS256") == (unsigned int) -1);
-	assert_true (get_algo_mask ("nosuch") == (unsigned int) -1);
-#if ALLOW_NON_RSA_ALG
-	assert_true (get_algo_mask ("ES256:RS256") == 1026);
-#else
-	assert_true (get_algo_mask ("ES256:RS256") == (unsigned int) -1);
-#endif	
-}
-
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -585,18 +233,9 @@ int main(void)
         cmocka_unit_test(test_loadParodusCfg),
         cmocka_unit_test(test_loadParodusCfgNull),
         cmocka_unit_test(err_loadParodusCfg),
-        cmocka_unit_test(test_parse_num_arg),
-        cmocka_unit_test(test_parse_mac_address),
-        cmocka_unit_test(test_get_algo_mask),
-        cmocka_unit_test(test_server_is_http),
-        cmocka_unit_test(test_parse_webpa_url__),
-        cmocka_unit_test(test_parse_webpa_url),
         cmocka_unit_test(test_parseCommandLine),
         cmocka_unit_test(test_parseCommandLineNull),
         cmocka_unit_test(err_parseCommandLine),
-        //cmocka_unit_test(test_parodusGitVersion),
-        cmocka_unit_test(test_setDefaultValuesToCfg),
-        cmocka_unit_test(err_setDefaultValuesToCfg),
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);

tests/test_conn_interface.c

@@ -27,41 +27,20 @@
 #include "../src/conn_interface.h"
 #include "../src/connection.h"
 #include "../src/config.h"
-#include "../src/heartBeat.h"
-#include "../src/close_retry.h"
 
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
-static char *reconnect_reason = "webpa_process_starts";
 UpStreamMsg *UpStreamMsgQ;
 ParodusMsg *ParodusMsgQ;
-pthread_mutex_t g_mutex=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t g_cond=PTHREAD_COND_INITIALIZER;
-pthread_mutex_t nano_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t nano_con=PTHREAD_COND_INITIALIZER;
-pthread_mutex_t svc_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t svc_con=PTHREAD_COND_INITIALIZER;
-int numLoops;
-parodusOnPingStatusChangeHandler on_ping_status_change;
-
+extern bool close_retry;
+extern volatile unsigned int heartBeatTimer;
 /*----------------------------------------------------------------------------*/
 /*                                   Mocks                                    */
 /*----------------------------------------------------------------------------*/
-void set_server_list_null (server_list_t *server_list)
+int createNopollConnection(noPollCtx *ctx)
 {
-	UNUSED(server_list);
-}
-
-int find_servers (server_list_t *server_list)
-{
-	UNUSED(server_list);
-	return FIND_SUCCESS;
-}
-
-int createNopollConnection(noPollCtx *ctx, server_list_t *server_list)
-{
-    UNUSED(ctx); UNUSED(server_list);
+    UNUSED(ctx);
     function_called();
     return (int) mock();
 }
@@ -87,75 +66,12 @@ noPollMutexUnlock 	mutex_unlock
     UNUSED(mutex_create); UNUSED(mutex_destroy); UNUSED(mutex_lock); UNUSED(mutex_unlock);
     function_called();
 }
-
-char *get_global_reconnect_reason()
-{
-    return reconnect_reason;
-}
-
-char *get_global_shutdown_reason()
-{
-    return SHUTDOWN_REASON_PARODUS_STOP;
-}
-
-void set_global_shutdown_reason(char *reason)
-{
-    UNUSED(reason);
-}
-
-int getDeviceId(char **device_id, size_t *device_id_len)
-{
-	UNUSED(device_id); UNUSED(device_id_len);
-	return 0;
-}
-void start_conn_in_progress (unsigned long start_time)
-{
-	UNUSED(start_time);
-}   
-
-void stop_conn_in_progress (void)
-{
-}   
-
-void reset_interface_down_event (void)
-{
-}
-
-bool get_interface_down_event (void)
-{
-	return false;
-}
-
-void set_interface_down_event (void)
-{
-}
-
-int wait_while_interface_down (void)
-{
-	return 0;
-}
-
-void terminate_backoff_delay (void)
-{
-}
-
 void packMetaData()
 {
     function_called();
 }
 
 
-int get_cloud_disconnect_time(void)
-{
-    function_called();
-    return (int) (intptr_t)mock();
-}
-
-void set_cloud_disconnect_time(int Time)
-{
-    UNUSED(Time);
-    function_called();
-}
 
 void *handle_upstream()
 {
@@ -172,21 +88,9 @@ void *messageHandlerTask()
     return NULL;
 }
 
-int serviceAliveTask()
+void *serviceAliveTask()
 {
-    return 0;
-}
-
-int validate_partner_id(wrp_msg_t *msg, partners_t **partnerIds)
-{
-	UNUSED(msg); UNUSED(partnerIds);
-	return 0;
-}
-
-int sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
-{
-	UNUSED(resp_bytes); UNUSED(resp_size);
-	return 0;
+    return NULL;
 }
 
 int nopoll_loop_wait(noPollCtx * ctx,long timeout)
@@ -202,25 +106,12 @@ void set_global_reconnect_reason(char *reason)
     function_called();
 }
 
-void set_global_reconnect_status(bool status)
+void close_and_unref_connection(noPollConn *conn)
 {
-    (void)status;
+    UNUSED(conn);
     function_called();
 }
 
-void close_and_unref_connection(noPollConn *conn, bool is_shutting_down)
-{
-    UNUSED(conn); UNUSED(is_shutting_down);
-    function_called();
-}
-
-int readFromFile(const char *file_name, char **data)
-{
-	UNUSED(file_name);
-	*data = strdup ("parodus_stopping");
-	return 1;
-}
-
 void nopoll_cleanup_library	()	
 {
     function_called();
@@ -244,18 +135,12 @@ void set_global_conn(noPollConn *conn)
     function_called();
 }
 
-void StartThread(void *(*start_routine) (void *), pthread_t *threadId)
+void StartThread(void *(*start_routine) (void *))
 {
     UNUSED(start_routine);
-    UNUSED(threadId);
     function_called(); 
 }
 
-void JoinThread (pthread_t threadId)
-{
-    UNUSED(threadId);
-}
-
 noPollCtx* nopoll_ctx_new(void)
 {
     function_called();
@@ -265,51 +150,6 @@ void initKeypress()
 {
     function_called();
 }
-
-UpStreamMsg * get_global_UpStreamMsgQ(void)
-{
-    return UpStreamMsgQ;
-}
-
-void set_global_UpStreamMsgQ(UpStreamMsg * UpStreamQ)
-{
-    UpStreamMsgQ = UpStreamQ;
-}
-
-pthread_cond_t *get_global_nano_con(void)
-{
-    return &nano_con;
-}
-
-pthread_mutex_t *get_global_nano_mut(void)
-{
-    return &nano_mut;
-}
-
-pthread_cond_t *get_global_svc_con(void)
-{
-    return &svc_con;
-}
-
-pthread_mutex_t *get_global_svc_mut(void)
-{
-    return &svc_mut;
-}
-
-/*
-* Mock func to calculate time diff between start and stop time
-* This timespec_diff retuns 1 sec as diff time
-*/
-void timespec_diff(struct timespec *start, struct timespec *stop,
-                   struct timespec *diff)
-{
-   UNUSED(start);
-   UNUSED(stop);
-   diff->tv_sec = 1;
-   diff->tv_nsec = 1000;
-}
-
-
 /*----------------------------------------------------------------------------*/
 /*                                   Tests                                    */
 /*----------------------------------------------------------------------------*/
@@ -319,7 +159,8 @@ void test_createSocketConnection()
     noPollCtx *ctx;
     ParodusCfg cfg;
     memset(&cfg,0,sizeof(ParodusCfg));
-    reset_close_retry();
+    
+    close_retry = false;
     expect_function_call(nopoll_thread_handlers);
     
     will_return(nopoll_ctx_new, (intptr_t)&ctx);
@@ -329,14 +170,13 @@ void test_createSocketConnection()
     expect_function_call(createNopollConnection);
     expect_function_call(packMetaData);
 
-    expect_function_calls(StartThread, 5);
+    expect_function_calls(StartThread, 4);
     expect_function_call(initKeypress);
     will_return(nopoll_loop_wait, 1);
     expect_function_call(nopoll_loop_wait);
     
     expect_function_call(set_global_reconnect_reason);
     will_return(get_global_conn, (intptr_t)NULL);
-    expect_function_call(set_global_reconnect_status);
     expect_function_call(get_global_conn);
     expect_function_call(close_and_unref_connection);
     expect_function_call(set_global_conn);
@@ -347,16 +187,15 @@ void test_createSocketConnection()
     expect_function_call(close_and_unref_connection);
     expect_function_call(nopoll_ctx_unref);
     expect_function_call(nopoll_cleanup_library);
-    createSocketConnection(initKeypress);
+    createSocketConnection(&cfg,initKeypress);
 }
 
 void test_createSocketConnection1()
 {
-    numLoops =0;
     noPollCtx *ctx;
     ParodusCfg cfg;
     memset(&cfg,0, sizeof(ParodusCfg));
-    set_close_retry();
+    close_retry = true;
     expect_function_call(nopoll_thread_handlers);
     
     will_return(nopoll_ctx_new, (intptr_t)&ctx);
@@ -366,7 +205,7 @@ void test_createSocketConnection1()
     expect_function_call(createNopollConnection);
     expect_function_call(packMetaData);
 
-    expect_function_calls(StartThread, 5);
+    expect_function_calls(StartThread, 4);
     will_return(nopoll_loop_wait, 1);
     expect_function_call(nopoll_loop_wait);
     
@@ -381,30 +220,29 @@ void test_createSocketConnection1()
     expect_function_call(close_and_unref_connection);
     expect_function_call(nopoll_ctx_unref);
     expect_function_call(nopoll_cleanup_library);
-    createSocketConnection(NULL);
+    createSocketConnection(&cfg,NULL);
+    
 }
 
-void test_PingMissIntervalTime()
+void test_createSocketConnection2()
 {
-    numLoops = 6;
     noPollCtx *ctx;
     ParodusCfg cfg;
     memset(&cfg,0,sizeof(ParodusCfg));
-    parStrncpy(cfg.hw_model, "TG1682", sizeof(cfg.hw_model));
-    parStrncpy(cfg.hw_serial_number, "Fer23u948590", sizeof(cfg.hw_serial_number));
-    parStrncpy(cfg.hw_manufacturer , "ARRISGroup,Inc.", sizeof(cfg.hw_manufacturer));
-    parStrncpy(cfg.hw_mac , "123567892366", sizeof(cfg.hw_mac));
-    parStrncpy(cfg.hw_last_reboot_reason , "unknown", sizeof(cfg.hw_last_reboot_reason));
-    parStrncpy(cfg.fw_name , "2.364s2", sizeof(cfg.fw_name));
-    parStrncpy(cfg.webpa_path_url , "/v1", sizeof(cfg.webpa_path_url));
-    parStrncpy(cfg.webpa_url , "localhost", sizeof(cfg.webpa_url));
-    parStrncpy(cfg.webpa_interface_used , "eth0", sizeof(cfg.webpa_interface_used));
-    parStrncpy(cfg.webpa_protocol , "WebPA-1.6", sizeof(cfg.webpa_protocol));
-    parStrncpy(cfg.webpa_uuid , "1234567-345456546", sizeof(cfg.webpa_uuid));
-    //Max ping timeout is 6 sec
-    cfg.webpa_ping_timeout = 6;
-    set_parodus_cfg(&cfg);
-    reset_close_retry();
+    strcpy(cfg.hw_model, "TG1682");
+    strcpy(cfg.hw_serial_number, "Fer23u948590");
+    strcpy(cfg.hw_manufacturer , "ARRISGroup,Inc.");
+    strcpy(cfg.hw_mac , "123567892366");
+    strcpy(cfg.hw_last_reboot_reason , "unknown");
+    strcpy(cfg.fw_name , "2.364s2");
+    strcpy(cfg.webpa_path_url , "/v1");
+    strcpy(cfg.webpa_url , "localhost");
+    strcpy(cfg.webpa_interface_used , "eth0");
+    strcpy(cfg.webpa_protocol , "WebPA-1.6");
+    strcpy(cfg.webpa_uuid , "1234567-345456546");
+    cfg.webpa_ping_timeout = 1;
+    
+    close_retry = false;
     expect_function_call(nopoll_thread_handlers);
     
     will_return(nopoll_ctx_new, (intptr_t)&ctx);
@@ -414,8 +252,7 @@ void test_PingMissIntervalTime()
     expect_function_call(createNopollConnection);
     expect_function_call(packMetaData);
 
-    expect_function_calls(StartThread, 5);
-    //Increment ping interval time to 1 sec for each nopoll_loop_wait call
+    expect_function_calls(StartThread, 4);
     will_return(nopoll_loop_wait, 1);
     will_return(nopoll_loop_wait, 1);
     will_return(nopoll_loop_wait, 1);
@@ -424,10 +261,9 @@ void test_PingMissIntervalTime()
     will_return(nopoll_loop_wait, 1);
     will_return(nopoll_loop_wait, 1);
     expect_function_calls(nopoll_loop_wait, 7);
-    //Expecting Ping miss after 6 sec
+    
     expect_function_call(set_global_reconnect_reason);
     will_return(get_global_conn, (intptr_t)NULL);
-    expect_function_call(set_global_reconnect_status);
     expect_function_call(get_global_conn);
     expect_function_call(close_and_unref_connection);
     expect_function_call(set_global_conn);
@@ -438,14 +274,13 @@ void test_PingMissIntervalTime()
     expect_function_call(close_and_unref_connection);
     expect_function_call(nopoll_ctx_unref);
     expect_function_call(nopoll_cleanup_library);
-    createSocketConnection(NULL);
+    createSocketConnection(&cfg,NULL);
 }
 
 void err_createSocketConnection()
 {
-    numLoops =0;
-    set_close_retry();
-    reset_heartBeatTimer();
+    close_retry = true;
+    heartBeatTimer = 0;
     expect_function_call(nopoll_thread_handlers);
     
     will_return(nopoll_ctx_new, (intptr_t)NULL);
@@ -455,7 +290,7 @@ void err_createSocketConnection()
     expect_function_call(createNopollConnection);
     expect_function_call(packMetaData);
 
-    expect_function_calls(StartThread, 5);
+    expect_function_calls(StartThread, 4);
     will_return(nopoll_loop_wait, 1);
     expect_function_call(nopoll_loop_wait);
     
@@ -470,55 +305,7 @@ void err_createSocketConnection()
     expect_function_call(close_and_unref_connection);
     expect_function_call(nopoll_ctx_unref);
     expect_function_call(nopoll_cleanup_library);
-    createSocketConnection(NULL);
-}
-
-
-void test_createSocketConnection_cloud_disconn()
-{
-        numLoops =0;
-	ParodusCfg cfg;
-	memset(&cfg,0,sizeof(ParodusCfg));
-	cfg.cloud_disconnect = strdup("XPC");
-	set_parodus_cfg(&cfg);
-
-	set_close_retry();
-	reset_heartBeatTimer();
-	expect_function_call(nopoll_thread_handlers);
-
-	will_return(nopoll_ctx_new, (intptr_t)NULL);
-	expect_function_call(nopoll_ctx_new);
-	expect_function_call(nopoll_log_set_handler);
-	will_return(createNopollConnection, nopoll_true);
-	expect_function_call(createNopollConnection);
-	expect_function_call(packMetaData);
-
-	expect_function_calls(StartThread, 5);
-	will_return(nopoll_loop_wait, 1);
-	expect_function_call(nopoll_loop_wait);
-
-	will_return(get_global_conn, (intptr_t)NULL);
-	expect_function_call(get_global_conn);
-	expect_function_call(close_and_unref_connection);
-	expect_function_call(set_global_conn);
-
-
-	expect_function_call(set_cloud_disconnect_time);
-	will_return(get_cloud_disconnect_time, 0);
-	expect_function_call(get_cloud_disconnect_time);
-	will_return(get_cloud_disconnect_time, 0);
-	expect_function_call(get_cloud_disconnect_time);
-	will_return(get_cloud_disconnect_time, 0);
-	expect_function_call(get_cloud_disconnect_time);
-
-	will_return(createNopollConnection, nopoll_true);
-	expect_function_call(createNopollConnection);
-	will_return(get_global_conn, (intptr_t)NULL);
-	expect_function_call(get_global_conn);
-	expect_function_call(close_and_unref_connection);
-	expect_function_call(nopoll_ctx_unref);
-	expect_function_call(nopoll_cleanup_library);
-	createSocketConnection(NULL);
+    createSocketConnection(NULL,NULL);
 }
 
 /*----------------------------------------------------------------------------*/
@@ -530,9 +317,8 @@ int main(void)
     const struct CMUnitTest tests[] = {
         cmocka_unit_test(test_createSocketConnection),
         cmocka_unit_test(test_createSocketConnection1),
-        cmocka_unit_test(test_PingMissIntervalTime),
+        cmocka_unit_test(test_createSocketConnection2),
         cmocka_unit_test(err_createSocketConnection),
-        cmocka_unit_test(test_createSocketConnection_cloud_disconn)
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);

tests/test_crud_interface.c

@@ -1,401 +0,0 @@
-/**
- *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-#include <assert.h>
-#include <errno.h>
-#include <pthread.h>
-#include <malloc.h>
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-#include <string.h> 
-#include <unistd.h> 
-
-#include <wrp-c.h>
-#include "../src/crud_interface.h"
-#include "../src/config.h"
-#include "../src/client_list.h"
-#include "../src/ParodusInternal.h"
-#include "../src/partners_check.h"
-
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-bool g_shutdown  = false;
-extern CrudMsg *crudMsgQ;
-int numLoops = 1;
-wrp_msg_t *temp = NULL;
-
-/*----------------------------------------------------------------------------*/
-/*                                   Mocks                                    */
-/*----------------------------------------------------------------------------*/
-
-char * get_global_UpStreamMsgQ(void)
-{
-    function_called();
-    return (char *)mock();
-}
-
-int set_global_UpStreamMsgQ(void)
-{
-    function_called();
-    return (int)mock();
-}
-
-int get_global_nano_con(void)
-{
-    function_called();
-    return (int)mock();
-}
-
-int get_global_nano_mut(void)
-{
-    function_called();
-    return (int)mock();
-}
-
-char *get_global_reconnect_reason()
-{
-    function_called();
-    return (char *)(intptr_t)mock();
-}	
-
-ParodusCfg *get_parodus_cfg(void)
-{
-    function_called();
-    return (ParodusCfg*) (intptr_t)mock();
-}
-
-int pthread_mutex_lock(pthread_mutex_t *restrict mutex)
-{
-    UNUSED(mutex);
-    function_called();
-    return (int)mock();
-}
-
-int pthread_mutex_unlock(pthread_mutex_t *restrict mutex)
-{
-    UNUSED(mutex);
-    function_called();
-    return (int)mock();
-}
-
-int pthread_cond_signal(pthread_cond_t *restrict cond)
-{
-    UNUSED(cond); 
-    function_called();
-    return (int)mock();
-}
-
-int pthread_cond_wait(pthread_cond_t *restrict cond, pthread_mutex_t *restrict mutex)
-{
-    UNUSED(cond); UNUSED(mutex);
-    function_called();
-    return (int)mock();
-}
-
-
-int processCrudRequest(wrp_msg_t *reqMsg, wrp_msg_t **responseMsg )
-{
-	UNUSED(reqMsg);
-	wrp_msg_t *resp_msg = NULL;
-    resp_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(resp_msg, 0, sizeof(wrp_msg_t));
-    
-    resp_msg->msg_type = 5;
-    resp_msg->u.crud.transaction_uuid = strdup("1234");
-    resp_msg->u.crud.source = strdup("tag-update");
-    resp_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    *responseMsg = resp_msg;
-	function_called();
-	return (int)mock();
-}
-
-char* getWebpaInterface(void)
-{
-   return NULL;
-}
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-
-void test_addCRUDmsgToQueue()
-{
-
-	wrp_msg_t *crud_msg = NULL;
-	crud_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-	memset(crud_msg, 0, sizeof(wrp_msg_t));
-
-	crud_msg->msg_type = 5;
-	crud_msg->u.crud.transaction_uuid = strdup("bd4ad2d1-5c9c-486f-8e25-52c242b38f71");
-    crud_msg->u.crud.source = strdup("tag-update");
-    crud_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-	
-    will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-    crudMsgQ = (CrudMsg *)malloc(sizeof(CrudMsg));
-	crudMsgQ->msg = crud_msg;
-	
-	crudMsgQ->next = (CrudMsg *) malloc(sizeof(CrudMsg));
-    crudMsgQ->next->msg = crud_msg;
-    crudMsgQ->next->next = NULL;
-    
-	addCRUDmsgToQueue(crud_msg);
-	
-	free(crudMsgQ->next);
-    free(crudMsgQ);
-    crudMsgQ = NULL;
-    
-    wrp_free_struct(crud_msg);
-	
-}
-
-
-void test_addCRUDmsgToQueueNULL()
-{
-	wrp_msg_t *crud_msg = NULL;
-	crud_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-	memset(crud_msg, 0, sizeof(wrp_msg_t));
-
-	crud_msg->msg_type = 5;
-	crud_msg->u.crud.transaction_uuid = strdup("bd4ad2d1-5c9c-486f-8e25-52c242b38f71");
-    crud_msg->u.crud.source = strdup("tag-update");
-    crud_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-	
-    will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(pthread_cond_signal, 0);
-    expect_function_call(pthread_cond_signal);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-	addCRUDmsgToQueue(crud_msg);
-	
-	free(crudMsgQ->next);
-    free(crudMsgQ);
-    crudMsgQ = NULL;
-    wrp_free_struct(crud_msg);
-	
-}
-
-void err_CRUDHandlerTask()
-{
-    numLoops = 1;
-    crudMsgQ = NULL;
-    
-    will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(pthread_cond_wait, 0);
-    expect_function_call(pthread_cond_wait);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-    CRUDHandlerTask();
-}
-
-
-void test_CRUDHandlerTask()
-{
-	numLoops = 1;
-	wrp_msg_t *crud_msg = NULL;
-	crud_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-	memset(crud_msg, 0, sizeof(wrp_msg_t));
-
-	crud_msg->msg_type = 5;
-	crud_msg->u.crud.transaction_uuid = strdup("bd4ad2d1-5c9c-486f-8e25-52c242b38f71");
-    crud_msg->u.crud.source = strdup("tag-update");
-    crud_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    
-    crudMsgQ = (CrudMsg *)malloc(sizeof(CrudMsg));
-	crudMsgQ->msg = crud_msg;
-	crudMsgQ->next = NULL;
-	
-	will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-    will_return(processCrudRequest, 0);
-    expect_function_call(processCrudRequest);
-    
-    will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-    
-    will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(get_global_UpStreamMsgQ, NULL);
-    expect_function_call(get_global_UpStreamMsgQ);
-    
-    will_return(set_global_UpStreamMsgQ, 0);
-    expect_function_call(set_global_UpStreamMsgQ);
-    
-    will_return(get_global_nano_con, 0);
-    expect_function_call(get_global_nano_con);
-    
-    will_return(pthread_cond_signal, 0);
-    expect_function_call(pthread_cond_signal);
-    
-    will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-	CRUDHandlerTask();
-	
-    free(crudMsgQ);
-	
-}
-
-void test_CRUDHandlerTaskFailure()
-{
-	numLoops = 1;
-	wrp_msg_t *crud_msg = NULL;
-	
-	crud_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-	memset(crud_msg, 0, sizeof(wrp_msg_t));
-
-	crud_msg->msg_type = 5;
-	crud_msg->u.crud.transaction_uuid = strdup("bd4ad2d1-5c9c-486f-8e25-52c242b38f71");
-    crud_msg->u.crud.source = strdup("tag-update");
-    crud_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    
-    crudMsgQ = (CrudMsg *)malloc(sizeof(CrudMsg));
-	crudMsgQ->msg = crud_msg;
-	crudMsgQ->next = NULL;
-	
-	will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-    will_return(processCrudRequest, -1);
-    expect_function_call(processCrudRequest);
-    
-    
-    will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-	
-	will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(get_global_UpStreamMsgQ, 0);
-    expect_function_call(get_global_UpStreamMsgQ);
-    
-    will_return(set_global_UpStreamMsgQ, 0);
-    expect_function_call(set_global_UpStreamMsgQ);
-    
-    will_return(get_global_nano_con, 0);
-    expect_function_call(get_global_nano_con);
-    
-    will_return(pthread_cond_signal, 0);
-    expect_function_call(pthread_cond_signal);
-    
-    will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-    
-	CRUDHandlerTask();
-	
-	free(crudMsgQ);
-	
-}
-
-void test_addCRUDresponseToUpstreamQ()
-{
-	numLoops = 1;
-	ssize_t resp_size = 0;
-	void *resp_bytes;
-	
-	wrp_msg_t *resp_msg = NULL;
-    resp_msg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(resp_msg, 0, sizeof(wrp_msg_t));
-    
-    resp_msg->msg_type = 5;
-    resp_msg->u.crud.transaction_uuid = strdup("1234");
-    resp_msg->u.crud.source = strdup("tag-update");
-    resp_msg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    
-    resp_size = wrp_struct_to( resp_msg, WRP_BYTES, &resp_bytes );
-	
-	will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-	
-	will_return(pthread_mutex_lock, 0);
-    expect_function_call(pthread_mutex_lock);
-    
-    will_return(get_global_UpStreamMsgQ, 0);
-    expect_function_call(get_global_UpStreamMsgQ);
-    
-    will_return(set_global_UpStreamMsgQ, 0);
-    expect_function_call(set_global_UpStreamMsgQ);
-    
-    will_return(get_global_nano_con, 0);
-    expect_function_call(get_global_nano_con);
-    
-    will_return(pthread_cond_signal, 0);
-    expect_function_call(pthread_cond_signal);
-    
-    will_return(get_global_nano_mut, 0);
-    expect_function_call(get_global_nano_mut);
-    
-    will_return(pthread_mutex_unlock, 0);
-    expect_function_call(pthread_mutex_unlock);
-    
-	addCRUDresponseToUpstreamQ(resp_bytes, resp_size);
-	
-    wrp_free_struct(resp_msg);
-	
-}
-
-
-void test_addCRUDmsgToQueueAllocation()
-{
-	addCRUDmsgToQueue(NULL);
-}
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-        cmocka_unit_test(test_addCRUDmsgToQueueNULL),
-        cmocka_unit_test(test_addCRUDmsgToQueue),
-        cmocka_unit_test(test_addCRUDmsgToQueueAllocation),
-        cmocka_unit_test(err_CRUDHandlerTask),
-        cmocka_unit_test(test_CRUDHandlerTask),
-        cmocka_unit_test(test_CRUDHandlerTaskFailure),
-        cmocka_unit_test(test_addCRUDresponseToUpstreamQ)
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_crud_tasks.c

@@ -1,283 +0,0 @@
-/**
- *  Copyright 2010-2016 Comcast Cable Communications Management, LLC
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-#include <assert.h>
-#include <errno.h>
-#include <pthread.h>
-#include <malloc.h>
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-#include <string.h> 
-#include <unistd.h> 
-
-#include <wrp-c.h>
-#include "../src/crud_tasks.h"
-#include "../src/config.h"
-#include "../src/client_list.h"
-#include "../src/ParodusInternal.h"
-#include "../src/partners_check.h"
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-wrp_msg_t *response = NULL;
-/*----------------------------------------------------------------------------*/
-/*                                   Mocks                                    */
-/*----------------------------------------------------------------------------*/
-
-cJSON * cJSON_Parse(const char *payload)
-{
-	UNUSED(payload);
-    function_called();
-    return (cJSON *) mock();
-}
-
-int createObject(wrp_msg_t *reqMsg , wrp_msg_t **response)
-{
-    UNUSED(reqMsg); UNUSED(response); 
-    function_called();
-    return (int) mock();
-}
-
-int retrieveObject(wrp_msg_t *reqMsg , wrp_msg_t **response)
-{
-    UNUSED(reqMsg); UNUSED(response);
-    function_called();
-    return (int) mock();
-}
-
-int updateObject(wrp_msg_t *reqMsg , wrp_msg_t **response)
-{
-    UNUSED(reqMsg); UNUSED(response);
-    function_called();
-    return (int) mock();
-}
-
-int deleteObject(wrp_msg_t *reqMsg , wrp_msg_t **response)
-{
-    UNUSED(reqMsg); UNUSED(response);
-    function_called();
-    return (int) mock();
-}
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-
-void test_processCrudRequestCreate()
-{
-	int ret = -1;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 5;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(createObject, 0);
-    expect_function_call(createObject);
-    
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, 0);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestCreateFailure()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 5;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(createObject, -1);
-    expect_function_call(createObject);
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, -1);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestRetrieve()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 6;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(retrieveObject, 0);
-    expect_function_call(retrieveObject);
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, 0);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestRetrieveFailure()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 6;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(retrieveObject, -1);
-    expect_function_call(retrieveObject);
-    
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, -1);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestUpdate()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 7;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(updateObject, 0);
-    expect_function_call(updateObject);
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, 0);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestUpdateFailure()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 7;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(updateObject, -1);
-    expect_function_call(updateObject);
-    
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, -1);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestDelete()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 8;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(deleteObject, 0);
-    expect_function_call(deleteObject);
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, 0);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestDeleteFailure()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 8;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    will_return(deleteObject, -1);
-    expect_function_call(deleteObject);
-    
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, -1);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-void test_processCrudRequestFailure()
-{
-	int ret = -2;
-	wrp_msg_t *reqMsg = NULL;
-    reqMsg = ( wrp_msg_t *)malloc( sizeof( wrp_msg_t ) );  
-    memset(reqMsg, 0, sizeof(wrp_msg_t));
-    
-    reqMsg->msg_type = 3;
-    reqMsg->u.crud.transaction_uuid = strdup("1234");
-    reqMsg->u.crud.source = strdup("tag-update");
-    reqMsg->u.crud.dest = strdup("mac:14xxx/parodus/tags");
-    
-    ret = processCrudRequest(reqMsg, &response);
-    assert_int_equal(ret, 0);
-
-	wrp_free_struct(reqMsg);
-
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-        cmocka_unit_test(test_processCrudRequestCreate),
-        cmocka_unit_test(test_processCrudRequestCreateFailure),
-        cmocka_unit_test(test_processCrudRequestRetrieve),
-        cmocka_unit_test(test_processCrudRequestRetrieveFailure),
-        cmocka_unit_test(test_processCrudRequestUpdate),
-        cmocka_unit_test(test_processCrudRequestUpdateFailure),
-        cmocka_unit_test(test_processCrudRequestDelete),
-        cmocka_unit_test(test_processCrudRequestDeleteFailure),
-        cmocka_unit_test(test_processCrudRequestFailure),
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_downstream.c

@@ -21,7 +21,6 @@
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>
-#include <wrp-c.h>
 
 #include "../src/downstream.h"
 #include "../src/ParodusInternal.h"
@@ -33,16 +32,9 @@
 ParodusMsg *ParodusMsgQ;
 pthread_mutex_t g_mutex;
 pthread_cond_t g_cond;
-int crud_test = 0;
 /*----------------------------------------------------------------------------*/
 /*                                   Mocks                                    */
 /*----------------------------------------------------------------------------*/
-void addCRUDmsgToQueue(wrp_msg_t *crudMsg)
-{
-	UNUSED(crudMsg) ;
-	function_called();
-}
-
 void sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
 {
     UNUSED(resp_bytes); UNUSED(resp_size);
@@ -61,10 +53,6 @@ reg_list_item_t * get_global_node(void)
     return mock_ptr_type(reg_list_item_t *);
 }
 
-void release_global_node (void)
-{
-}
-
 ssize_t wrp_to_struct( const void *bytes, const size_t length,
                        const enum wrp_format fmt, wrp_msg_t **msg )
 {
@@ -72,22 +60,13 @@ ssize_t wrp_to_struct( const void *bytes, const size_t length,
     function_called();
     *msg = (wrp_msg_t*) malloc(sizeof(wrp_msg_t));
     memset(*msg, 0, sizeof(wrp_msg_t));
-	(*msg)->msg_type = WRP_MSG_TYPE__REQ;   
-	(*msg)->u.req.dest = (char *) malloc(sizeof(char) *100);
-	(*msg)->u.req.partner_ids = (partners_t *) malloc(sizeof(partners_t));
-	(*msg)->u.req.partner_ids->count = 1;
-	(*msg)->u.req.partner_ids->partner_ids[0] = (char *) malloc(sizeof(char) *64);
-	parStrncpy((*msg)->u.req.dest,"mac:1122334455/iot", 100);
-	parStrncpy((*msg)->u.req.partner_ids->partner_ids[0],"comcast", 64);
-	if(crud_test)
-	{
-			(*msg)->msg_type = WRP_MSG_TYPE__CREATE;
-			parStrncpy((*msg)->u.crud.dest,"mac:1122334455/parodus", 100);
-                        (*msg)->u.crud.source = (char *) malloc(sizeof(char) *40);
-			parStrncpy ((*msg)->u.crud.source, "tag-update", 40);
-                        (*msg)->u.crud.transaction_uuid = (char *) malloc(sizeof(char) *40);
-			parStrncpy ((*msg)->u.crud.transaction_uuid, "1234", 40);
-	}
+    (*msg)->msg_type = WRP_MSG_TYPE__REQ;
+    (*msg)->u.req.dest = (char *) malloc(sizeof(char) *100);
+    (*msg)->u.req.partner_ids = (partners_t *) malloc(sizeof(partners_t));
+    (*msg)->u.req.partner_ids->count = 1;
+    (*msg)->u.req.partner_ids->partner_ids[0] = (char *) malloc(sizeof(char) *64);
+    strcpy((*msg)->u.req.dest,"mac:1122334455/iot");
+    strcpy((*msg)->u.req.partner_ids->partner_ids[0],"comcast");
     return (ssize_t) mock();
 }
 
@@ -114,8 +93,8 @@ void test_listenerOnMessage()
     expect_function_calls(wrp_to_struct, 1);
     reg_list_item_t *head = (reg_list_item_t *) malloc(sizeof(reg_list_item_t));
     memset(head, 0, sizeof(reg_list_item_t));
-    parStrncpy(head->service_name, "iot", sizeof(head->service_name));
-    parStrncpy(head->url, "tcp://10.0.0.1:6600", sizeof(head->url));
+    strcpy(head->service_name, "iot");
+    strcpy(head->url, "tcp://10.0.0.1:6600");
 
     will_return(get_numOfClients, 1);
     expect_function_call(get_numOfClients);
@@ -137,19 +116,19 @@ void test_listenerOnMessageMultipleClients()
 
     reg_list_item_t *head2 = (reg_list_item_t *) malloc(sizeof(reg_list_item_t));
     memset(head2, 0, sizeof(reg_list_item_t));
-    parStrncpy(head2->service_name, "iot", sizeof(head2->service_name));
-    parStrncpy(head2->url, "tcp://10.0.0.1:6622", sizeof(head2->url));
+    strcpy(head2->service_name, "iot");
+    strcpy(head2->url, "tcp://10.0.0.1:6622");
     
     reg_list_item_t *head1 = (reg_list_item_t *) malloc(sizeof(reg_list_item_t));
     memset(head1, 0, sizeof(reg_list_item_t));
-    parStrncpy(head1->service_name, "lmlite", sizeof(head1->service_name));
-    parStrncpy(head1->url, "tcp://10.0.0.1:6611", sizeof(head1->url));
+    strcpy(head1->service_name, "lmlite");
+    strcpy(head1->url, "tcp://10.0.0.1:6611");
     head1->next = head2;
     
     reg_list_item_t *head = (reg_list_item_t *) malloc(sizeof(reg_list_item_t));
     memset(head, 0, sizeof(reg_list_item_t));
-    parStrncpy(head->service_name, "config", sizeof(head->service_name));
-    parStrncpy(head->url, "tcp://10.0.0.1:6600", sizeof(head->url));
+    strcpy(head->service_name, "config");
+    strcpy(head->url, "tcp://10.0.0.1:6600");
     head->next = head1;
     
     will_return(get_numOfClients, 3);
@@ -210,23 +189,6 @@ void err_listenerOnMessageAllNull()
     listenerOnMessage(NULL, 0);
 }
 
-
-void test_listenerOnMessageCRUD()
-{
-	crud_test = 1;
-    will_return(wrp_to_struct, 2);
-    expect_function_calls(wrp_to_struct, 1);
-
-    will_return(get_numOfClients, 0);
-    expect_function_call(get_numOfClients);
-    will_return(validate_partner_id, 0);
-    expect_function_call(validate_partner_id);
-    will_return(get_global_node, (intptr_t)NULL);
-    expect_function_call(get_global_node);
-    expect_function_call(addCRUDmsgToQueue);
-    listenerOnMessage("Hello", 6);
-}
-
 /*----------------------------------------------------------------------------*/
 /*                             External Functions                             */
 /*----------------------------------------------------------------------------*/
@@ -240,7 +202,6 @@ int main(void)
         cmocka_unit_test(err_listenerOnMessageServiceUnavailable),
         cmocka_unit_test(err_listenerOnMessageInvalidPartnerId),
         cmocka_unit_test(err_listenerOnMessageAllNull),
-        cmocka_unit_test(test_listenerOnMessageCRUD),
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);

tests/test_downstream_more.c

@@ -1,325 +0,0 @@
-/**
- *  Copyright 2017 Comcast Cable Communications Management, LLC
- *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- */
-#include <assert.h>
-#include <stdarg.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdbool.h>
-#include <wrp-c.h>
-
-#include <CUnit/Basic.h>
-
-#include "../src/downstream.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Macros                                   */
-/*----------------------------------------------------------------------------*/
-/* none */
-
-/*----------------------------------------------------------------------------*/
-/*                               Data Structures                              */
-/*----------------------------------------------------------------------------*/
-typedef struct {
-    wrp_msg_t s;
-    wrp_msg_t r;
-} test_t;
-
-/*----------------------------------------------------------------------------*/
-/*                            File Scoped Variables                           */
-/*----------------------------------------------------------------------------*/
-static test_t tests[] = {
-        {
-            .s.msg_type = WRP_MSG_TYPE__CREATE,
-            .s.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .s.u.crud.source = "fake-server1",
-            .s.u.crud.dest = "fake-client1/iot",
-            .s.u.crud.partner_ids = NULL,
-            .s.u.crud.headers = NULL,
-            .s.u.crud.metadata = NULL,
-            .s.u.crud.include_spans = false,
-            .s.u.crud.spans.spans = NULL,
-            .s.u.crud.spans.count = 0,
-            .s.u.crud.path = "Some path",
-            .s.u.crud.payload = "Some binary",
-            .s.u.crud.payload_size = 11,
-
-            .r.msg_type = WRP_MSG_TYPE__CREATE,
-            .r.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .r.u.crud.source = "fake-client1/iot",
-            .r.u.crud.dest = "fake-server1",
-            .r.u.crud.partner_ids = NULL,
-            .r.u.crud.headers = NULL,
-            .r.u.crud.metadata = NULL,
-            .r.u.crud.include_spans = false,
-            .r.u.crud.spans.spans = NULL,
-            .r.u.crud.spans.count = 0,
-            .r.u.crud.path = "Some path",
-            .r.u.crud.payload = "{\"statusCode\":531,\"message\":\"Service Unavailable\"}",
-            .r.u.crud.payload_size = 50,
-        },
-
-        {
-            .s.msg_type = WRP_MSG_TYPE__RETREIVE,
-            .s.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .s.u.crud.source = "fake-server2",
-            .s.u.crud.dest = "fake-client2/iot",
-            .s.u.crud.partner_ids = NULL,
-            .s.u.crud.headers = NULL,
-            .s.u.crud.metadata = NULL,
-            .s.u.crud.include_spans = false,
-            .s.u.crud.spans.spans = NULL,
-            .s.u.crud.spans.count = 0,
-            .s.u.crud.path = "Some path",
-            .s.u.crud.payload = NULL,
-            .s.u.crud.payload_size = 0,
-
-            .r.msg_type = WRP_MSG_TYPE__RETREIVE,
-            .r.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .r.u.crud.source = "fake-client2/iot",
-            .r.u.crud.dest = "fake-server2",
-            .r.u.crud.partner_ids = NULL,
-            .r.u.crud.headers = NULL,
-            .r.u.crud.metadata = NULL,
-            .r.u.crud.include_spans = false,
-            .r.u.crud.spans.spans = NULL,
-            .r.u.crud.spans.count = 0,
-            .r.u.crud.path = "Some path",
-            .r.u.crud.payload = "{\"statusCode\":531,\"message\":\"Service Unavailable\"}",
-            .r.u.crud.payload_size = 50,
-        },
-
-        {
-            .s.msg_type = WRP_MSG_TYPE__UPDATE,
-            .s.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .s.u.crud.source = "fake-server3",
-            .s.u.crud.dest = "fake-client3/iot",
-            .s.u.crud.partner_ids = NULL,
-            .s.u.crud.headers = NULL,
-            .s.u.crud.metadata = NULL,
-            .s.u.crud.include_spans = false,
-            .s.u.crud.spans.spans = NULL,
-            .s.u.crud.spans.count = 0,
-            .s.u.crud.path = "Some path",
-            .s.u.crud.payload = NULL,
-            .s.u.crud.payload_size = 0,
-
-            .r.msg_type = WRP_MSG_TYPE__UPDATE,
-            .r.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .r.u.crud.source = "fake-client3/iot",
-            .r.u.crud.dest = "fake-server3",
-            .r.u.crud.partner_ids = NULL,
-            .r.u.crud.headers = NULL,
-            .r.u.crud.metadata = NULL,
-            .r.u.crud.include_spans = false,
-            .r.u.crud.spans.spans = NULL,
-            .r.u.crud.spans.count = 0,
-            .r.u.crud.path = "Some path",
-            .r.u.crud.payload = "{\"statusCode\":531,\"message\":\"Service Unavailable\"}",
-            .r.u.crud.payload_size = 50,
-        },
-
-        {
-            .s.msg_type = WRP_MSG_TYPE__DELETE,
-            .s.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .s.u.crud.source = "fake-server4",
-            .s.u.crud.dest = "fake-client4/iot",
-            .s.u.crud.partner_ids = NULL,
-            .s.u.crud.headers = NULL,
-            .s.u.crud.metadata = NULL,
-            .s.u.crud.include_spans = false,
-            .s.u.crud.spans.spans = NULL,
-            .s.u.crud.spans.count = 0,
-            .s.u.crud.path = "Some path",
-            .s.u.crud.payload = NULL,
-            .s.u.crud.payload_size = 0,
-
-            .r.msg_type = WRP_MSG_TYPE__DELETE,
-            .r.u.crud.transaction_uuid = "c2bb1f16-09c8-11e7-93ae-92361f002671",
-            .r.u.crud.source = "fake-client4/iot",
-            .r.u.crud.dest = "fake-server4",
-            .r.u.crud.partner_ids = NULL,
-            .r.u.crud.headers = NULL,
-            .r.u.crud.metadata = NULL,
-            .r.u.crud.include_spans = false,
-            .r.u.crud.spans.spans = NULL,
-            .r.u.crud.spans.count = 0,
-            .r.u.crud.path = "Some path",
-            .r.u.crud.payload = "{\"statusCode\":531,\"message\":\"Service Unavailable\"}",
-            .r.u.crud.payload_size = 50,
-        },
-
-        {
-            .s.msg_type = WRP_MSG_TYPE__EVENT,
-            .s.u.event.source = "fake-server5",
-            .s.u.event.dest = "fake-client5/iot",
-            .s.u.event.partner_ids = NULL,
-            .s.u.event.headers = NULL,
-            .s.u.event.metadata = NULL,
-            .s.u.event.payload = NULL,
-            .s.u.event.payload_size = 0,
-
-            .r = {0},
-        },
-    };
-
-static uint8_t i;
-
-/*----------------------------------------------------------------------------*/
-/*                                   Mocks                                    */
-/*----------------------------------------------------------------------------*/
-void addCRUDmsgToQueue(wrp_msg_t *crudMsg)
-{
-	(void)crudMsg;
-	return;
-}
-
-int validate_partner_id(wrp_msg_t *msg, partners_t **partnerIds)
-{
-    (void) msg; (void) partnerIds;
-    return 1;
-}
-
-ssize_t wrp_to_struct( const void *bytes, const size_t length, const enum wrp_format fmt,
-                       wrp_msg_t **msg )
-{
-    (void) bytes; (void) length; (void) fmt;
-    *msg = (wrp_msg_t*) malloc(sizeof(wrp_msg_t));
-    (*msg)->msg_type = tests[i].s.msg_type;
-    if( WRP_MSG_TYPE__EVENT == tests[i].s.msg_type ) {
-        (*msg)->u.event.source = strdup(tests[i].s.u.event.source);
-        (*msg)->u.event.dest = strdup(tests[i].s.u.event.dest);
-    }
-    else
-    {
-        (*msg)->u.crud.source = strdup(tests[i].s.u.crud.source);
-        (*msg)->u.crud.dest = strdup(tests[i].s.u.crud.dest);
-        (*msg)->u.crud.transaction_uuid = strdup(tests[i].s.u.crud.transaction_uuid);
-        (*msg)->u.crud.path = strdup(tests[i].s.u.crud.path);
-    }
-    return (ssize_t) sizeof(tests[i].s);
-}
-
-ssize_t wrp_struct_to( const wrp_msg_t *msg, const enum wrp_format fmt, void **bytes )
-{
-    (void) fmt; 
-    *bytes = malloc(1);
-    CU_ASSERT(WRP_MSG_TYPE__EVENT != msg->msg_type);
-    CU_ASSERT(tests[i].r.msg_type == msg->msg_type);
-    CU_ASSERT_STRING_EQUAL(tests[i].r.u.crud.transaction_uuid, msg->u.crud.transaction_uuid);
-    printf("tests[%d].r.u.crud.source = %s, msg->u.crud.source = %s\n", i, tests[i].r.u.crud.source, msg->u.crud.source);
-    CU_ASSERT_STRING_EQUAL(tests[i].r.u.crud.source, msg->u.crud.source);
-    CU_ASSERT_STRING_EQUAL(tests[i].r.u.crud.dest, msg->u.crud.dest);
-    CU_ASSERT_STRING_EQUAL(tests[i].r.u.crud.path, msg->u.crud.path);
-    CU_ASSERT(tests[i].r.u.crud.payload_size == msg->u.crud.payload_size);
-    CU_ASSERT(0 == memcmp(tests[i].r.u.crud.payload, msg->u.crud.payload, msg->u.crud.payload_size));
-
-    return 1;
-}
-
-void sendUpstreamMsgToServer(void **resp_bytes, size_t resp_size)
-{
-    (void) resp_bytes; (void) resp_size;    
-}
-
-int get_numOfClients()
-{
-    return 0;
-}
-
-reg_list_item_t *get_global_node(void)
-{
-    return NULL;
-}
-
-void release_global_node (void)
-{
-}
-
-void wrp_free_struct( wrp_msg_t *msg )
-{
-    if( WRP_MSG_TYPE__EVENT == tests[i].s.msg_type ) {
-        if( NULL != msg->u.event.source) {
-            free(msg->u.event.source);
-        }
-        if( NULL != msg->u.event.dest) {
-            free(msg->u.event.dest);
-        }
-    }
-    else
-    {
-        if( NULL != msg->u.crud.source) {
-            free(msg->u.crud.source);
-        }
-        if( NULL != msg->u.crud.dest) {
-            free(msg->u.crud.dest);
-        }
-        if( NULL != msg->u.crud.transaction_uuid) {
-            free(msg->u.crud.transaction_uuid);
-        }
-        if( NULL != msg->u.crud.path) {
-            free(msg->u.crud.path);
-        }
-    }    
-}
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-void test_listenerOnMessage()
-{
-    size_t t_size = sizeof(tests)/sizeof(test_t);
-    void *msg = malloc(1);
-
-    for( i = 0; i < t_size; i++ ) {
-        listenerOnMessage(msg, 0);
-    }
-    free(msg);
-}
-
-void add_suites( CU_pSuite *suite )
-{
-    printf("--------Start of Test Cases Execution ---------\n");
-    *suite = CU_add_suite( "tests", NULL, NULL );
-    CU_add_test( *suite, "Test 1", test_listenerOnMessage );
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-int main( void )
-{
-    unsigned rv = 1;
-    CU_pSuite suite = NULL;
-
-    if( CUE_SUCCESS == CU_initialize_registry() ) {
-        add_suites( &suite );
-
-        if( NULL != suite ) {
-            CU_basic_set_mode( CU_BRM_VERBOSE );
-            CU_basic_run_tests();
-            printf( "\n" );
-            CU_basic_show_failures( CU_get_failure_list() );
-            printf( "\n\n" );
-            rv = CU_get_number_of_tests_failed();
-        }
-
-        CU_cleanup_registry();
-
-    }
-
-    return rv;
-}
-

tests/test_heartBeatTimer.c

@@ -1,94 +0,0 @@
-/**
- * Copyright 2018 Comcast Cable Communications Management, LLC
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <cmocka.h>
-#include <pthread.h>
-
-#include "../src/heartBeat.h"
-#include "../src/parodus_log.h"
-
-/*----------------------------------------------------------------------------*/
-/*                                   Tests                                    */
-/*----------------------------------------------------------------------------*/
-void test_heartBeatTimer() {
-	/* get heartBeat timer's initial value */
-	unsigned int heartBeatTimer =5;
-	heartBeatTimer = get_heartBeatTimer();
-	ParodusInfo("heartBeatTimer initial vaule is: %d\n", heartBeatTimer);
-	assert_int_equal(heartBeatTimer, 0);
-
-	/* increment heartbeat timer value and check whether its returning modified value or not*/
-	unsigned int inc_time_ms =5;
-	increment_heartBeatTimer(inc_time_ms);
-	heartBeatTimer = get_heartBeatTimer();
-	ParodusInfo("heartBeatTimer incremented to: %d\n", heartBeatTimer);
-	assert_int_equal(heartBeatTimer,5);
-
-	/* reset heartBeat timer to 0 */
-	reset_heartBeatTimer();
-	heartBeatTimer = get_heartBeatTimer();
-	ParodusInfo("heartBeatTimer reset to: %d\n", heartBeatTimer);
-	assert_int_equal(heartBeatTimer,0);
-}
-
-void *test_mutexIncrementTimer() {
-	unsigned int inc_time_ms =5;
-	increment_heartBeatTimer(inc_time_ms);
-	return NULL;
-}
-
-void *test_mutexResetTimer() {
-	reset_heartBeatTimer();
-	return NULL;
-}
-void test_mutexHeartBeatTimer() {
-	unsigned int heartBeatTimer;
-	pthread_t thread[3];
-
-	pthread_create(&thread[0], NULL, test_mutexIncrementTimer, NULL);
-	pthread_create(&thread[1], NULL, test_mutexIncrementTimer, NULL);
-
-	pthread_join(thread[0], NULL);
-	pthread_join(thread[1], NULL);
-
-	/* After execution of both the threads check the value of timer */
-	heartBeatTimer = get_heartBeatTimer();
-	ParodusInfo("Threads execution is completed, heartBeatTimer is: %d\n", heartBeatTimer);
-	assert_int_equal(heartBeatTimer, 10);
-
-	pthread_create(&thread[2], NULL, test_mutexResetTimer, NULL);
-	pthread_join(thread[2], NULL);
-
-	heartBeatTimer = get_heartBeatTimer();
-	ParodusInfo("heartBeatTimer reset to: %d\n", heartBeatTimer);
-	assert_int_equal(heartBeatTimer, 0);
-}
-
-/*----------------------------------------------------------------------------*/
-/*                             External Functions                             */
-/*----------------------------------------------------------------------------*/
-int main(void)
-{
-    const struct CMUnitTest tests[] = {
-        cmocka_unit_test(test_heartBeatTimer),
-        cmocka_unit_test(test_mutexHeartBeatTimer),
-    };
-
-    return cmocka_run_group_tests(tests, NULL, NULL);
-}

tests/test_mutex.c

@@ -54,7 +54,9 @@ void* a(void *in)
 
     lockMutex(data->mutex);
     data->number++;
+    sleep(1);
     data->number++;
+    sleep(1);
     data->number++;
     unlockMutex(data->mutex);
 
@@ -67,7 +69,9 @@ void* b(void *in)
 
     lockMutex(data->mutex);
     data->number+=10;
+    sleep(1);
     data->number+=10;
+    sleep(1);
     data->number+=10;
     unlockMutex(data->mutex);
 
@@ -96,16 +100,15 @@ void test_Mutex()
 
 void err_mutex()
 {
-    static pthread_mutex_t mtx = PTHREAD_MUTEX_INITIALIZER;
-    noPollPtr mutex = &mtx;
+    noPollPtr mutex = (pthread_mutex_t*) malloc(sizeof(pthread_mutex_t));
 
     will_return(pthread_mutex_destroy, -1);
     destroyMutex(mutex);
 
     will_return(pthread_mutex_init, -1);
     mutex = createMutex();
-    destroyMutex(mutex);
-    
+
+    free(mutex);
 }
 
 void err_mutexNull()

tests/test_networking.c

@@ -44,7 +44,7 @@
 /*----------------------------------------------------------------------------*/
 void test_checkHostIp()
 {
-    CU_ASSERT_EQUAL(0, checkHostIp("www.python.org"))
+    CU_ASSERT_EQUAL(0, checkHostIp("fabric.webpa.comcast.net"))
 }
 
 void add_suites( CU_pSuite *suite )

tests/test_nopoll_handlers.c

@@ -21,18 +21,16 @@
 #include <nopoll_private.h>
 #include <pthread.h>
 
-#include "../src/ParodusInternal.h"
 #include "../src/nopoll_handlers.h"
 #include "../src/parodus_log.h"
 
 /*----------------------------------------------------------------------------*/
 /*                            File Scoped Variables                           */
 /*----------------------------------------------------------------------------*/
+volatile unsigned int heartBeatTimer;
 bool LastReasonStatus;
-bool interface_down_event = false;
-int closeReason = 0;
-pthread_mutex_t interface_down_mut=PTHREAD_MUTEX_INITIALIZER;
-pthread_cond_t interface_down_con=PTHREAD_COND_INITIALIZER;
+pthread_mutex_t close_mut;
+bool close_retry;
 /*----------------------------------------------------------------------------*/
 /*                                   Mocks                                    */
 /*----------------------------------------------------------------------------*/
@@ -42,34 +40,6 @@ void set_global_reconnect_reason(char *reason)
     (void) reason;
 }
 
-bool get_global_reconnect_status()
-{
-    return LastReasonStatus;
-}
-
-void set_interface_down_event()
-{
-        interface_down_event = true;
-}
-
-void reset_interface_down_event() 
-{
-	pthread_mutex_lock (&interface_down_mut);
-	interface_down_event = false;
-	pthread_cond_signal(&interface_down_con);
-	pthread_mutex_unlock (&interface_down_mut);
-}
-
-bool get_interface_down_event() 
-{
-	return interface_down_event;
-}
-
-void set_global_reconnect_status(bool status)
-{
-    (void) status ;
-}
-
 const unsigned char *nopoll_msg_get_payload(noPollMsg *msg)
 {
     if( NULL != msg ) {
@@ -89,27 +59,12 @@ noPollOpCode nopoll_msg_opcode (noPollMsg * msg)
     return NOPOLL_UNKNOWN_OP_CODE;
 }
 
-nopoll_bool nopoll_msg_is_fragment(noPollMsg *msg)
-{
-    (void) msg;
-    return nopoll_false;
-}
-
 int nopoll_msg_get_payload_size(noPollMsg *msg)
 {
     (void) msg;
     return 1;
 }
 
-int nopoll_conn_get_close_status (noPollConn * conn)
-{
-	(void) conn;
-	if(closeReason)
-		return 1006;
-	else
-		return 0;
-}
-
 int nopoll_conn_send_frame (noPollConn * conn, nopoll_bool fin, nopoll_bool masked,
                             noPollOpCode op_code, long length, noPollPtr content, long sleep_in_header)
 
@@ -161,16 +116,16 @@ void *a1(void *in)
     char str[] = "SSL_Socket_Close";
     (void) in;
 
-    set_global_reconnect_status(false);
+    LastReasonStatus = false;
     listenerOnCloseMessage(NULL, NULL, NULL);
     
-    set_global_reconnect_status(false);
+    LastReasonStatus = false;
     listenerOnCloseMessage(NULL, NULL, (noPollPtr) str);
 
-    set_global_reconnect_status(true);
+    LastReasonStatus = true;
     listenerOnCloseMessage(NULL, NULL, NULL);
-    closeReason = 1;
-    set_global_reconnect_status(true);
+
+    LastReasonStatus = true;
     listenerOnCloseMessage(NULL, NULL, (noPollPtr) str);
 
     pthread_exit(0);
@@ -198,30 +153,6 @@ void test_listenerOnPingMessage()
     listenerOnPingMessage(NULL, NULL, NULL, NULL);
 }
 
-void test_getInterfaceDownEvent()
-{   
-    set_interface_down_event();
-    CU_ASSERT_TRUE(get_interface_down_event());
-}
-
-void test_interfaceDownEvent()
-{
-    char str[] = "SSL_Socket_Close";
-    set_global_reconnect_status(true);
-    set_interface_down_event();
-    listenerOnCloseMessage(NULL, NULL, (noPollPtr) str);
-    
-}
-
-void test_noInterfaceDownEvent()
-{
-    char str[] = "SSL_Socket_Close";
-    set_global_reconnect_status(true);
-    reset_interface_down_event();
-    listenerOnCloseMessage(NULL, NULL, (noPollPtr) str);
-}
-
-
 void add_suites( CU_pSuite *suite )
 {
     ParodusInfo("--------Start of Test Cases Execution ---------\n");
@@ -229,9 +160,6 @@ void add_suites( CU_pSuite *suite )
     CU_add_test( *suite, "Test 1", test_listenerOnMessage_queue );
     CU_add_test( *suite, "Test 2", test_listenerOnCloseMessage );
     CU_add_test( *suite, "Test 3", test_listenerOnPingMessage );
-    CU_add_test( *suite, "Test 4", test_getInterfaceDownEvent );
-    CU_add_test( *suite, "Test 5", test_interfaceDownEvent );
-    CU_add_test( *suite, "Test 6", test_noInterfaceDownEvent );
 }
 
 /*----------------------------------------------------------------------------*/