scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-30 18:41:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

lm4: Add debug output for overlapping HCs.

Browse Source 
Currently, when a host command is received which would overlap with an
ongoing host command, we ignore it silently.  This commit simply logs a
line to the EC console stating that we are ignoring the overlapping host
command.

BRANCH=None
BUG=chrome-os-partner:23806
TEST=make -j buildall tests
TEST=Build, flash, and boot samus. Using ectool, read 64K from flash
while also querying the current EC switch positions.  Observe the log
message being printed to the EC console.

Change-Id: Ic0d249ccec2efb9600bcf8567392add1ee6295d9
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/290545
Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
This commit is contained in:
Aseda Aboagye
2015-08-04 18:05:50 -07:00
committed by ChromeOS Commit Bot
parent feea8de21b
commit 01e36e0fee
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
chip/lm4/lpc.c
View File

@@ -492,7 +492,10 @@ static void handle_acpi_write(int is_cmd)
static void handle_host_write(int is_cmd)
{
/* Ignore data writes or overlapping commands from host */
if (!is_cmd || (LM4_LPC_ST(LPC_CH_CMD) & LM4_LPC_ST_BUSY)) {
uint32_t is_overlapping = LM4_LPC_ST(LPC_CH_CMD) & LM4_LPC_ST_BUSY;
if (!is_cmd || is_overlapping) {
if (is_overlapping)
CPRINTS("LPC Ignoring overlapping HC");
LM4_LPC_ST(LPC_CH_CMD) &= ~LM4_LPC_ST_FRMH;
return;
}