scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-30 18:41:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

rma_reset: fix board ID ordering and add the missing break

Browse Source 
The Board ID is stored in Cr50 in reversed byte order, make sure it is
used in the challenge calculation in the same form.

BRANCH=none
BUG=b:37952913
TEST=verified that the proper byte order is used when challenge source
     is created.

Change-Id: I6c6b46431005ce9438a4be9aa43aafed30a645aa
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/693615
Reviewed-by: Michael Tang <ntang@chromium.org>
This commit is contained in:
Vadim Bendebury
2017-09-29 18:59:37 -07:00
committed by chrome-bot
parent f1084d6a73
commit 474dbe4ded
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extra/rma_reset/rma_reset.c
View File

@@ -94,6 +94,7 @@ int rma_create_challenge(void)
uint8_t secret[32];
struct rma_challenge c;
uint8_t *cptr = (uint8_t *)&c;
uint32_t bid;
/* Clear the current challenge and authcode, if any */
memset(challenge, 0, sizeof(challenge));
@@ -103,7 +104,10 @@ int rma_create_challenge(void)
c.version_key_id = RMA_CHALLENGE_VKID_BYTE(
RMA_CHALLENGE_VERSION, server_key_id);
memcpy(c.board_id, board_id, sizeof(c.board_id));
memcpy(&bid, board_id, sizeof(bid));
bid = be32toh(bid);
memcpy(c.board_id, &bid, sizeof(c.board_id));
memcpy(c.device_id, device_id, sizeof(c.device_id));
/* Calculate a new ephemeral key pair */
@@ -356,6 +360,7 @@ int main(int argc, char **argv)
return 1;
}
w_flag = 1;
break;
case 'h':
usage();
return 0;