scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-11 02:15:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: Comments about PMU powerinfo module

Browse Source 
Document some Pit-platform-specific assumptions.

No code changes.

BUG=none
BRANCH=none
TEST=build pit

Change-Id: I601ca4a57645ba45e7db01e271556a30d334f9cd
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174056
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
This commit is contained in:
Randall Spangler
2013-10-22 12:52:46 -07:00
committed by chrome-internal-fetch
parent a27fb9cfdc
commit 5f26987366
2 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
common/pmu_tps65090_powerinfo.c
View File

@@ -12,8 +12,9 @@
#include "pmu_tpschrome.h"
#include "util.h"
/* FIXME: move all the constants to pmu_tpschrome, make
* dcdc3, fet output name configurable.
/*
* All these constants are specific to the Pit board. If we reuse this command
* on other boards, we'll need to move the table to board.c.
*/
static const struct {
const char *name;
@@ -33,6 +34,7 @@ static const struct {
{"p1350", 1350, 5000},
};
/* These constants may be Pit-specific as well. */
static const int pmu_voltage_range_mv = 17000;
static const int pmu_ac_sense_range_mv = 33;
static const int pmu_bat_sense_range_mv = 40;
@@ -113,6 +115,15 @@ DECLARE_CONSOLE_COMMAND(powerinfo, command_powerinfo,
"Show PMU power info",
NULL);
/**
* Host command to get power info from PMU
*
* This reuses the same EC_CMD_POWER_INFO host command as Spring, but doesn't
* provide the full set of information because Pit doesn't take power over USB.
*
* Note that Spring *also* uses the TPS65090 PMU, but it can't use this common
* code because it implements the same host command differently...
*/
static int power_command_info(struct host_cmd_handler_args *args)
{
int bat_charging_current;

6
include/config.h
View File

@@ -540,7 +540,11 @@
/* Support TPS65090 PMU */
#undef CONFIG_PMU_TPS65090
/* Support PMU powerinfo host and console commands */
/*
* Support PMU powerinfo host and console commands. Note that the
* implementation is currently specific to the Pit board, so don't blindly
* enable this for another board without fixing that first.
*/
#undef CONFIG_PMU_POWERINFO
/*****************************************************************************/