scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-10 17:41:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

ectool: read max outsize/insize from ec during comm_init

Browse Source 
Current ectool uses max outsize / insize from protocol v2
even if we have a v3 protocol ec. This makes some command
not working when actual size supported by ec is less than
max size from protocol v2.

This CL uses protoinfo command to read max size from ec
during the initialization process to correctly set max size
for ec with protocol v3+. For ec with protocol v2, protoinfo
command won't exist, hence ectool won't modify the max size
and used the size that we set when init the protocol.

BRANCH=none
BUG=chrome-os-partner:31660
TEST=Run 'ectool flashread 0 0x1000 /tmp/fr' in ryu

Change-Id: I226b6c2fb2f7e9be73032f2c5146d2710939b293
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/214838
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Puthikorn Voravootivat
2014-08-28 14:03:11 -07:00
committed by chrome-internal-fetch
parent dcb9bb6026
commit 61f2327f07
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
util/comm-host.c
View File

@@ -6,6 +6,7 @@
#include <errno.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "comm-host.h"
@@ -76,6 +77,8 @@ int ec_command(int command, int version,
int comm_init(int interfaces)
{
struct ec_response_get_protocol_info info;
/* Default memmap access */
ec_readmem = fake_readmem;
@@ -104,6 +107,23 @@ int comm_init(int interfaces)
return 1;
}
/* read max request / response size from ec for protocol v3+ */
if (ec_command(EC_CMD_GET_PROTOCOL_INFO, 0, NULL, 0, &info,
sizeof(info)) == sizeof(info)) {
ec_max_outsize = info.max_request_packet_size -
sizeof(struct ec_host_request);
ec_max_insize = info.max_response_packet_size -
sizeof(struct ec_host_response);
ec_outbuf = realloc(ec_outbuf, ec_max_outsize);
ec_inbuf = realloc(ec_inbuf, ec_max_insize);
if (!ec_outbuf || !ec_inbuf) {
fprintf(stderr, "Unable to reallocate buffers\n");
return 1;
}
}
return 0;
}