scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-03 21:49:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

pit: pulse AP_RESET_L when resetting EC or forcing AP shutdown

Browse Source 
If the AP is suspended, it consumes little enough power that just
shutting its rails off doesn't cause it to reset to a known state.
This caused a problem where suspending the AP then rebooting the EC
would wedge the system; the EC would think the AP was on (since
XPSHOLD was asserted), but wouldn't be able to figure out how to turn
it back off.  Silego reset wouldn't help, because that again just
reset the EC.  Even setting PMIC_RESET to brown out the system
wouldn't drop power for long enough.

Simply pulsing AP_RESET_L low for 1 ms at EC boot (when not sysjump)
or AP force-shutdown forces the AP into a good state.

BUG=chrome-os-partner:22233
BRANCH=pit
TEST=from root shell, 'powerd_dbus_suspend'
     from ec console 'reboot' - or just power+refresh
     system should power on normally

Change-Id: I65f1239b5f6766f1c093c3064bce323df4acaf7d
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/167355
Reviewed-by: Doug Anderson <dianders@chromium.org>
Commit-Queue: Doug Anderson <dianders@chromium.org>
This commit is contained in:
Randall Spangler
2013-08-28 14:17:58 -07:00
committed by Caroline Tice
parent 3f4899b6b0
commit 6ecda4b0f1
1 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
common/chipset_gaia.c
View File

@@ -309,6 +309,21 @@ static int gaia_power_init(void)
auto_power_on = 1;
}
#ifdef BOARD_pit
/*
* Force the AP into reset unless we're doing a sysjump. Otherwise a
* suspended AP may still be in a strange state from the last reboot,
* and will hold XPSHOLD for a long time if it's in a low power state.
* See crosbug.com/p/22233.
*/
if (!(system_get_reset_flags() & RESET_FLAG_SYSJUMP)) {
CPRINTF("[%T not sysjump; forcing AP reset]\n");
gpio_set_level(GPIO_AP_RESET_L, 0);
udelay(1000);
gpio_set_level(GPIO_AP_RESET_L, 1);
}
#endif
return EC_SUCCESS;
}
@@ -375,6 +390,16 @@ void chipset_force_shutdown(void)
#ifndef BOARD_kirby
gpio_set_level(GPIO_EN_PP5000, 0);
#endif
#ifdef BOARD_pit
/*
* Force the AP into reset. Otherwise it will hold XPSHOLD for a long
* time if it's in a low power state. See crosbug.com/p/22233.
*/
gpio_set_level(GPIO_AP_RESET_L, 0);
udelay(1000);
gpio_set_level(GPIO_AP_RESET_L, 1);
#endif
}
/*****************************************************************************/