mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2026-01-11 18:35:28 +00:00
image_signing: use sparse partition extraction
Often the partitions we extract have extra space in them, but the dd utility will still write out the excess zeros. That can mean we write out hundreds of megs of data which could otherwise be skipped. We thus waste a good amount of I/O and storage. For now, only use this flag when extracting a partition to a new file as this should be safe (there's no pre-existing data to clobber/merge). BUG=chromium:530730 TEST=`./signing_unittests.py` passes BRANCH=None Change-Id: Ic32665cf7c38fc0a5efc3f8b227fa8ff408ca9e3 Reviewed-on: https://chromium-review.googlesource.com/299450 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org>
This commit is contained in:
committed by
chrome-bot
parent
df9bf4eef3
commit
82dec09bd5
@@ -229,7 +229,7 @@ extract_image_partition() {
|
||||
local offset=$(partoffset "$image" "$partnum")
|
||||
local size=$(partsize "$image" "$partnum")
|
||||
dd if=$image of=$output_file bs=512 skip=$offset count=$size \
|
||||
conv=notrunc 2>/dev/null
|
||||
conv=notrunc,sparse 2>/dev/null
|
||||
}
|
||||
|
||||
# Replace a partition in an image from file
|
||||
|
||||
Reference in New Issue
Block a user