scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-29 18:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

ccd: fix scan-admin warnings

Browse Source 
Automated code scanner highlighted a few problems in the recent ode
additions. This patch fixes the problems.

BRANCH=cr50
BUG=none
TEST=none

Change-Id: I1f199eb5d2af992384ab04f3010b4b646464a70f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/897993
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
This commit is contained in:
Vadim Bendebury
2018-02-01 11:00:40 -08:00
committed by chrome-bot
parent 69b592426c
commit 8dba841b4e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/ccd_config.c
View File

@@ -878,7 +878,8 @@ static int ccd_command_wrapper(int argc, char *password,
* error code is the first byte after the header.
*/
return_code = be32toh(vch->tpm_header.command_code);
if (return_code && (return_code != VENDOR_RC_IN_PROGRESS)) {
if ((return_code != EC_SUCCESS) &&
(return_code != VENDOR_RC_IN_PROGRESS)) {
rv = vch->ccd_subcommand;
} else {
rv = EC_SUCCESS;
@@ -1457,7 +1458,7 @@ static enum vendor_cmd_rc ccd_vendor(enum vendor_cmd_cc code,
size_t input_size,
size_t *response_size)
{
enum vendor_cmd_rc (*handler)(void *x, size_t y, size_t *t);
enum vendor_cmd_rc (*handler)(void *x, size_t y, size_t *t) = NULL;
char *buffer;
enum vendor_cmd_rc rc;
@@ -1523,7 +1524,7 @@ static enum vendor_cmd_rc ccd_disable_rma(enum vendor_cmd_cc code,
size_t input_size,
size_t *response_size)
{
int rv;
int rv = EC_SUCCESS;
int error_line;
do {
@@ -1555,6 +1556,7 @@ static enum vendor_cmd_rc ccd_disable_rma(enum vendor_cmd_cc code,
CPRINTF("Capability %d is not present\n",
required_capabilities[i]);
error_line = __LINE__;
rv = EC_ERROR_ACCESS_DENIED;
break;
}
}