scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-10 17:41:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Keyborg: do not trim response before sending back to master

Browse Source 
ADC sampling is slower than SPI communication. If we spend more CPU
cycle trimming the response, we are just wasting time and letting SPI
bus sit idle.

BUG=None
TEST=Build and boot. Check scanning rate.
BRANCH=None

Change-Id: I9a4ece28a29ffd3205931ea71958cbc73642be6b
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200673
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
This commit is contained in:
Vic Yang
2014-05-20 15:47:11 -07:00
committed by chrome-internal-fetch
parent 64e5cc33d9
commit 98d78db982
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
board/keyborg/touch_scan.c
View File

@@ -162,10 +162,7 @@ void touch_scan_slave_start(void)
resp->data[ROW_COUNT - 1 - i] = v;
}
/* Trim trailing zeros. */
for (i = 0; i < ROW_COUNT; ++i)
if (resp->data[i] >= THRESHOLD)
resp->size = i + 1;
resp->size = ROW_COUNT;
/* Flush the last response */
if (col != 0)
@@ -220,9 +217,7 @@ int touch_scan_full_matrix(void)
resp = spi_master_wait_response_done();
if (resp == NULL)
return EC_ERROR_UNKNOWN;
memcpy(last_dptr, resp->data, resp->size);
memset(last_dptr + resp->size, 0,
ROW_COUNT - resp->size);
memcpy(last_dptr, resp->data, ROW_COUNT);
encode_add_column(last_dptr);
}
@@ -242,8 +237,7 @@ int touch_scan_full_matrix(void)
resp = spi_master_wait_response_done();
if (resp == NULL)
return EC_ERROR_UNKNOWN;
memcpy(last_dptr, resp->data, resp->size);
memset(last_dptr + resp->size, 0, ROW_COUNT - resp->size);
memcpy(last_dptr, resp->data, ROW_COUNT);
encode_add_column(last_dptr);
master_slave_sync(20);