scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-09 00:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

g: remove sleep disable/enable in rdd

Browse Source 
Enabling and disabling sleep in the rdd interrupt is redundant because
USB already takes care of that. When USB is initialized it will disable
sleep. If it is released or suspended then it will re-enable sleep. This
change removes the sleep enable and disable from the rdd interrupt. With
this change now sleep can be enabled while suzyq is still plugged in
using the command 'ccd disable'.

BUG=none
BRANCH=none
TEST=manual
	The consoles still work

	Updating the EC, AP and Cr50 still works

	After running 'reboot ap-off' in the EC console and 'ccd
	disable' in the Cr50 console Cr50 will go to sleep.

Change-Id: Ie8e6201e9fd611c514e93bc70d298d3b0d228611
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/413606
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
This commit is contained in:
Mary Ruthven
2016-11-22 13:39:51 -08:00
committed by chrome-bot
parent ed194f7a9a
commit a285debf1f
2 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
chip/g/rdd.c
View File

@@ -40,8 +40,6 @@ void rdd_interrupt(void)
is_debug = debug_cable_is_attached();
if (is_debug) {
disable_sleep(SLEEP_MASK_RDD);
CPRINTS("Debug Accessory connected");
/* Detect when debug cable is disconnected */
@@ -57,7 +55,6 @@ void rdd_interrupt(void)
rdd_detached();
cflush();
enable_sleep(SLEEP_MASK_RDD);
}
/* Clear interrupt */

2
include/system.h
View File

@@ -341,8 +341,6 @@ enum {
SLEEP_MASK_I2C_SLAVE = (1 << 7), /* I2C slave communication ongoing */
SLEEP_MASK_FAN = (1 << 8), /* Fan control loop ongoing */
SLEEP_MASK_USB_DEVICE = (1 << 9), /* Generic USB device in use */
SLEEP_MASK_RDD = (1 << 10),/* RDD ongoing */
SLEEP_MASK_FORCE_NO_DSLEEP = (1 << 15), /* Force disable. */