npcx: lpc: Fix SMI generation

The check for whether or not to send an SMI needs to check the
same status bit that it is using to indicate that it is going
to send an SMI.  The SMIE bit is enabled in lpc_init() so it is
always set.

BUG=chrome-os-partner:58666
BRANCH=none
TEST=shutdown with lid close event at developer screen

Change-Id: I9a0f34025c4fa11175fca7be34224ec680bffbef
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/400033
Reviewed-by: Shawn N <shawnn@chromium.org>
This commit is contained in:
Duncan Laurie
2016-10-17 13:49:14 -07:00
committed by chrome-bot
parent b8050224e5
commit a45ba126d6

View File

@@ -321,7 +321,7 @@ static void update_host_event_status(void)
lpc_task_disable_irq();
if (host_events & event_mask[LPC_HOST_EVENT_SMI]) {
/* Only generate SMI for first event */
if (!(NPCX_HIPMIE(PMC_ACPI) & NPCX_HIPMIE_SMIE))
if (!(NPCX_HIPMST(PMC_ACPI) & NPCX_HIPMST_ST2))
need_smi = 1;
SET_BIT(NPCX_HIPMST(PMC_ACPI), NPCX_HIPMST_ST2);
} else