scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-15 08:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

npcx: CEC: Get/set logical address

Browse Source 
Logical address selection is best done from the AP since
it depends on what kind of CEC device type we want to be.

Signed-off-by: Stefan Adolfsson <sadolfsson@chromium.org>

BUG=b:76467407
BRANCH=none
TEST=Set address to different values and verify that it
only receives messages on that address (or broadcast)
CQ-DEPEND=CL:1030229

Change-Id: Ia5ef182b22f2345831caaa7f29cc9f009f932c99
Reviewed-on: https://chromium-review.googlesource.com/1030370
Commit-Ready: Stefan Adolfsson <sadolfsson@chromium.org>
Tested-by: Stefan Adolfsson <sadolfsson@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Stefan Adolfsson
2018-05-04 05:17:40 +02:00
committed by chrome-bot
parent edac0b1924
commit ad01d0518b
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
chip/npcx/cec.c
View File

@@ -259,9 +259,8 @@ static int cap_charge;
* However, the AP is responsible for writing the initiator address
* on writes. UINT32_MAX means means that the address hasn't been
* set by the AP yet.
* TODO(sadolfsson): Make it possible to change this using cecset
*/
static uint8_t cec_addr = 5;
static uint8_t cec_addr = UINT8_MAX;
/* Events to send to AP */
static uint32_t cec_events;
@@ -1045,6 +1044,17 @@ static int cec_set_enable(uint8_t enable)
return EC_RES_SUCCESS;
}
static int cec_set_logical_addr(uint8_t logical_addr)
{
if (logical_addr >= CEC_BROADCAST_ADDR)
return EC_RES_INVALID_PARAM;
cec_addr = logical_addr;
CPRINTF("CEC address set to: %u\n", cec_addr);
return EC_RES_SUCCESS;
}
static int hc_cec_set(struct host_cmd_handler_args *args)
{
const struct ec_params_cec_set *params = args->params;
@@ -1052,6 +1062,8 @@ static int hc_cec_set(struct host_cmd_handler_args *args)
switch (params->cmd) {
case CEC_CMD_ENABLE:
return cec_set_enable(params->val);
case CEC_CMD_LOGICAL_ADDRESS:
return cec_set_logical_addr(params->val);
}
return EC_RES_INVALID_PARAM;
@@ -1068,6 +1080,9 @@ static int hc_cec_get(struct host_cmd_handler_args *args)
case CEC_CMD_ENABLE:
response->val = cec_state == CEC_STATE_DISABLED ? 0 : 1;
break;
case CEC_CMD_LOGICAL_ADDRESS:
response->val = cec_addr;
break;
default:
return EC_RES_INVALID_PARAM;
}