scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-12 19:04:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

charge_state_v2: Hibernate base in S5 with no AC

Browse Source 
Tell the base to hibernate when we are in S5, and no AC is connected.
Also, wake the base when AC status changes (S5), and when the system
transistions out of S5.

BRANCH=none
BUG=b:71874971
TEST=1. Lid EC console: apshutdown => Check that Base EC hibernates
     2.a. Lid EC console: powerb; => Check that base reconnects
     2.b. Connect/disconnect adapter: check that base disconnects
          and reconnects

Change-Id: I5e9a4afc64a07ad92f37d171a78a914d26f07c8e
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/958814
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Nicolas Boichat
2018-03-13 16:04:53 +08:00
committed by chrome-bot
parent 8fb18f174c
commit b3ecc19cb3
3 changed files with 43 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
board/poppy/base_detect_lux.c
View File

@@ -11,6 +11,7 @@
#include "chipset.h"
#include "common.h"
#include "console.h"
#include "extpower.h"
#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
@@ -196,6 +197,13 @@ void base_detect_interrupt(enum gpio_signal signal)
base_detect_debounce_time = time_now + BASE_DETECT_DEBOUNCE_US;
}
void board_base_reset(void)
{
CPRINTS("Resetting base.");
base_detect_change(BASE_UNKNOWN);
hook_call_deferred(&base_detect_deferred_data, BASE_DETECT_RETRY_US);
}
static void base_init(void)
{
/*

34
common/charge_state_v2.c
View File

@@ -393,7 +393,7 @@ static void set_base_lid_current(int current_base, int allow_charge_base,
* Make sure cross-power is enabled (it might not be enabled right after
* plugging the base, or when an adapter just got connected).
*/
if (base_connected)
if (base_connected && current_base != 0)
board_enable_base_power(1);
}
@@ -500,15 +500,30 @@ static void charge_allocate_input_current_limit(void)
}
/*
* System is suspended/off, let the lid and base run on their
* System is off, cut power to the base. We'll reset the base
* when system restarts, or when AC is plugged.
*/
if (chipset_in_state(CHIPSET_STATE_ANY_OFF)) {
set_base_lid_current(0, 0, 0, 0);
if (base_responsive) {
/* Base still responsive, put it to sleep. */
CPRINTF("Hibernating base\n");
ec_ec_master_hibernate();
base_responsive = 0;
board_enable_base_power(0);
}
return;
}
/*
* System is suspended, let the lid and base run on their
* own power. However, if the base battery is critically low, we
* still want to provide power to the base, to make sure it
* stays alive to be able to wake the system on keyboard or
* touchpad events.
*/
if (chipset_in_state(CHIPSET_STATE_ANY_OFF) ||
(chipset_in_state(CHIPSET_STATE_ANY_SUSPEND) &&
!base_critical)) {
if (chipset_in_state(CHIPSET_STATE_ANY_SUSPEND) &&
!base_critical) {
set_base_lid_current(0, 0, 0, 0);
return;
}
@@ -1337,6 +1352,10 @@ static void charge_wakeup(void)
DECLARE_HOOK(HOOK_CHIPSET_RESUME, charge_wakeup, HOOK_PRIO_DEFAULT);
DECLARE_HOOK(HOOK_AC_CHANGE, charge_wakeup, HOOK_PRIO_DEFAULT);
#ifdef CONFIG_EC_EC_COMM_BATTERY_MASTER
/* Reset the base on S5->S0 transition. */
DECLARE_HOOK(HOOK_CHIPSET_STARTUP, board_base_reset, HOOK_PRIO_DEFAULT);
#endif
static int get_desired_input_current(enum battery_present batt_present,
const struct charger_info * const info)
@@ -1406,6 +1425,11 @@ void charger_task(void *u)
*/
if (base_responsive && prev_current_base < 0)
curr.ac = 0;
/* System is off: if AC gets connected, reset the base. */
if (chipset_in_state(CHIPSET_STATE_ANY_OFF) &&
!prev_ac && curr.ac)
board_base_reset();
#endif
if (curr.ac != prev_ac) {
if (curr.ac) {

6
include/charge_state_v2.h
View File

@@ -89,5 +89,11 @@ int board_is_base_connected(void);
*/
void board_enable_base_power(int enable);
/**
* Board-specific routine to reset the base (in case it is unresponsive, e.g.
* if we told it to hibernate).
*/
void board_base_reset(void);
#endif /* __CROS_EC_CHARGE_STATE_V2_H */