scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-27 18:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

stm32: Wait for UART Tx to complete before entering STOP mode

Browse Source 
Before entering STOP mode, we need to ensure UART Tx has completed.
Otherwise, we may lose some characters or some bits within a character.
For Tx DMA mode, this is already done as we wait until TC (Tx complete)
is set before disabling Tx. However, when not using DMA, we enable sleep
when TXE is set. At this moment, the last character is still in the
shift register and going into sleep causes loss of the whole or part of
the last character.

To avoid this, let's enable TC interrupt and enable sleep only if we
have no more characters to send and TC is set.

BRANCH=None
BUG=chrome-os-partner:33219
TEST=Enable low power mode on Ryu P2. Type when the EC is in STOP mode
and check there is no broken character.

Change-Id: Ife42671882b7f1d1d17734d7d20fb4ba7dffb371
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/225283
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
This commit is contained in:
Vic Yang
2014-10-23 16:49:49 -07:00
committed by chrome-internal-fetch
parent 0dd653292c
commit bf8335a0a3
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
chip/stm32/uart.c
View File

@@ -68,7 +68,8 @@ void uart_tx_start(void)
disable_sleep(SLEEP_MASK_UART);
should_stop = 0;
STM32_USART_CR1(UARTN_BASE) |= UART_TX_INT_ENABLE;
STM32_USART_CR1(UARTN_BASE) |= UART_TX_INT_ENABLE |
STM32_USART_CR1_TCIE;
task_trigger_irq(STM32_IRQ_USART(UARTN));
}
@@ -76,7 +77,9 @@ void uart_tx_stop(void)
{
STM32_USART_CR1(UARTN_BASE) &= ~UART_TX_INT_ENABLE;
should_stop = 1;
#ifdef CONFIG_UART_TX_DMA
enable_sleep(SLEEP_MASK_UART);
#endif
}
void uart_tx_flush(void)
@@ -163,6 +166,22 @@ void uart_enable_interrupt(void)
/* Interrupt handler for console USART */
void uart_interrupt(void)
{
#ifndef CONFIG_UART_TX_DMA
/*
* When trasmission completes, enable sleep if we are done with Tx.
* After that, proceed if there is other interrupt to handle.
*/
if (STM32_USART_SR(UARTN_BASE) & STM32_USART_SR_TC) {
if (should_stop) {
STM32_USART_CR1(UARTN_BASE) &= ~STM32_USART_CR1_TCIE;
enable_sleep(SLEEP_MASK_UART);
}
STM32_USART_ICR(UARTN_BASE) |= STM32_USART_SR_TC;
if (!(STM32_USART_SR(UARTN_BASE) & ~STM32_USART_SR_TC))
return;
}
#endif
#ifdef CONFIG_UART_TX_DMA
/* Disable transmission complete interrupt if DMA done */
if (STM32_USART_SR(UARTN_BASE) & STM32_USART_SR_TC)