scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-14 00:26:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

npcx/fan: Avoid turning on disabled fans

Browse Source 
Fan enable state is controlled in common/fan.c. This patch prevents
npcx fan driver from enabling it.

BUG=b:73127788
BRANCH=none
TEST=Verify no 'Fan 0 stalled' is printed in S3 and S5. Verify the
fan spins in S0.

Change-Id: I549253a64c91d8a23bb793c3506b5daf1f7642be
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/937941
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
This commit is contained in:
Daisuke Nojiri
2018-02-22 14:50:51 -08:00
committed by chrome-bot
parent ab706d65fd
commit c6f5fe6d30
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
chip/npcx/fan.c
View File

@@ -346,8 +346,11 @@ void fan_tick_func(void)
/* Make sure rpm mode is enabled */
if (p_status->fan_mode != TACHO_FAN_RPM) {
p_status->auto_status = FAN_STATUS_STOPPED;
/* Why isn't this 'continue'? */
return;
}
if (!fan_get_enabled(ch))
continue;
/* Get actual rpm */
p_status->rpm_actual = mft_fan_rpm(ch);
/* Do smart fan stuff */