scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-08 16:41:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: presubmit_check.sh: Fix check for ec3po.

Browse Source 
The presubmit check would nag at the user to run the EC-3PO unit
tests, even if they hadn't modified any EC-3PO files.  This was not my
intention.  This commit fixes the presubmit check to only check for
unit test success if a EC-3PO file is modified.

BUG=chromium:575032
BRANCH=None
TEST=Remove util/ec3po/.tests-passed; Modify a non-ec3po file, commit,
and try to upload.  Verify that no nag message is presented.
TEST=Remove util/ec3po/.tests-passed; Modify a ec3po file, commit, and
try to upload.  Verify that a nag message to run unit tests is
presented.

Change-Id: I86e9f325329b7ad1a4c7c5971b7851e9024e7750
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/320831
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
This commit is contained in:
Aseda Aboagye
2016-01-07 10:02:47 -08:00
committed by chrome-bot
parent a48945568e
commit c7c04e673e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
util/presubmit_check.sh
View File

@@ -20,7 +20,7 @@ if [[ -n "${changed}" ]]; then
exit 1
fi
if [[ ! -e util/ec3po/.tests-passed ]]; then
if [[ ! -e util/ec3po/.tests-passed ]] && [[ -n "${ec3po_files}" ]]; then
echo 'Unit tests have not passed. Please run "util/ec3po/run_tests.sh".'
exit 1
fi