scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-11 18:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: Re-enable keyboard console channel for ARM boards

Browse Source 
Originally, the ARM boards printed the keyboard scan matrix whenever
it changed.  This generated a lot of output, so we filtered that at
the console channel level.  When we refactored the keyboard scan
module, that changed so that the scan matrix was not printed by
default, and the 'ksstate' debug command was used to enable printing
it.  But on ARM boards, 'ksstate on' wouldn't do anything without ALSO
using 'chan -1' to turn the keyboard console channel back on.  And
without the scan matrix printing by default, there's no reason to keep
the keyboard channel off by default.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all boards
     bang on keyboard on pit and don't see much debug output
     ksstate on
     now bang on keyboard and see matrix changes

Change-Id: I554b42e7582d507530cdecad7b35df71ca0e634f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174373
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
This commit is contained in:
Randall Spangler
2013-10-23 14:28:01 -07:00
committed by chrome-internal-fetch
parent 5e19f9c5d5
commit c8bcc57aac
9 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
board/daisy/board.h
View File

@@ -40,9 +40,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_B, GPIO_C

3
board/discovery/board.h
View File

@@ -26,9 +26,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Timer selection */
#define TIM_CLOCK_MSB 3
#define TIM_CLOCK_LSB 4

3
board/kirby/board.h
View File

@@ -40,9 +40,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_D

3
board/mccroskey/board.h
View File

@@ -38,9 +38,6 @@ enum module_id {
MODULE_UART,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL)
/* Keyboard output ports */
#define KB_OUT_PORT_LIST GPIO_C

3
board/nyan/board.h
View File

@@ -32,9 +32,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C

3
board/pit/board.h
View File

@@ -37,9 +37,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C

3
board/puppy/board.h
View File

@@ -35,9 +35,6 @@ enum module_id {
MODULE_CHIPSET,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C

3
board/snow/board.h
View File

@@ -44,9 +44,6 @@ enum module_id {
MODULE_UART,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output ports */
#define KB_OUT_PORT_LIST GPIO_B, GPIO_C

3
board/spring/board.h
View File

@@ -45,9 +45,6 @@ enum module_id {
MODULE_EXTPOWER_USB,
};
/* By default, enable all console messages except keyboard */
#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN))
/* Keyboard output port list */
#define KB_OUT_PORT_LIST GPIO_B, GPIO_C