scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-14 08:36:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

gsctool: fix Board ID retrieval function

Browse Source 
The function used to read or write Board ID value, when invoked for
reading, reports the value on the console, but does not save the read
value in the passed in structure.

Let's always save it in the structure so that the caller of this
function has access to the retrieved value.

BRANCH=none
BUG=chromium:812880
TEST=verified that 'gsctool -i' still operates as expected.

Change-Id: I9bc713386758ca6701e6b853e042652e2f392871
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/925692
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Vadim Bendebury
2018-02-19 13:12:40 -08:00
committed by chrome-bot
parent 77fe675d75
commit cd76cde217
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extra/usb_updater/gsctool.c
View File

@@ -1719,19 +1719,17 @@ static void process_bid(struct transfer_descriptor *td,
size_t response_size;
if (bid_action == bid_get) {
struct board_id bid;
response_size = sizeof(bid);
response_size = sizeof(*bid);
send_vendor_command(td, VENDOR_CC_GET_BOARD_ID,
&bid, sizeof(bid),
&bid, &response_size);
bid, sizeof(*bid),
bid, &response_size);
if (response_size == sizeof(bid)) {
if (response_size == sizeof(*bid)) {
printf("Board ID space: %08x:%08x:%08x\n",
be32toh(bid.type), be32toh(bid.type_inv),
be32toh(bid.flags));
be32toh(bid->type), be32toh(bid->type_inv),
be32toh(bid->flags));
return;
}
fprintf(stderr, "Error reading board ID: response size %zd,"
" first byte %#02x\n", response_size,