scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-31 02:51:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

I2C: Remove raw mode mutex

Browse Source 
The raw mode mutex is no longer needed as the return to I2C mode is now
done per pin, and not for the entire I2C module.

Signed-off-by: Anton Staaf <robotboy@chromium.org>

BRANCH=None
BUG=None
TEST=make buildall -j

Change-Id: Ibe9b1acb8bf89cadb3f3a3ab4c70dc06969f48b0
Reviewed-on: https://chromium-review.googlesource.com/321458
Commit-Ready: Anton Staaf <robotboy@chromium.org>
Tested-by: Anton Staaf <robotboy@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Anton Staaf
2016-01-13 13:52:33 -08:00
committed by chrome-bot
parent 7b89bb029e
commit d5ae5bc370
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
common/i2c.c
View File

@@ -303,7 +303,6 @@ void i2c_raw_set_sda(int port, int level)
int i2c_raw_mode(int port, int enable)
{
enum gpio_signal sda, scl;
static struct mutex raw_mode_mutex;
/* Get the SDA and SCL pins for this port. If none, then return. */
if (get_sda_from_i2c_port(port, &sda) != EC_SUCCESS)
@@ -312,15 +311,6 @@ int i2c_raw_mode(int port, int enable)
return EC_ERROR_INVAL;
if (enable) {
/*
* Lock access to raw mode functionality. Note, this is
* necessary because when we exit raw mode, we put all I2C
* ports into normal mode. This means that if another port
* is using the raw mode capabilities, that port will be
* re-configured from underneath it.
*/
mutex_lock(&raw_mode_mutex);
/*
* To enable raw mode, take out of alternate function mode and
* set the flags to open drain output.
@@ -343,8 +333,6 @@ int i2c_raw_mode(int port, int enable)
ret_scl = gpio_config_pins(MODULE_I2C, gpio_list[scl].port,
gpio_list[scl].mask, 1);
/* Unlock mutex, allow other I2C busses to use raw mode. */
mutex_unlock(&raw_mode_mutex);
return ret_sda == EC_SUCCESS ? ret_scl : ret_sda;
}