scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-29 18:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

ccd: add distinct return code to indicate that password is required

Browse Source 
When user is trying to execute 'ccd open' or 'ccd unlock' and password
is set, the return error code does not allow to tell the reason for
the command failure.

Let's add a distinct return code to indicate this condition so that
the user can supply password.

BRANCH=cr50
BUG=b:62537474
TEST=verified along with the accompanying gsctool modifications.

Change-Id: I286f87ab12114cd7dd7ebcdf0e321f7a24723367
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/861208
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Vadim Bendebury
2018-01-10 19:00:49 -08:00
committed by chrome-bot
parent d9831e6015
commit d99e680b3c
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/ccd_config.c
View File

@@ -910,7 +910,7 @@ static enum vendor_cmd_rc ccd_open(void *buf,
if (!input_size) {
*response_size = 1;
buffer[0] = EC_ERROR_PARAM_COUNT;
return VENDOR_RC_INTERNAL_ERROR;
return VENDOR_RC_PASSWORD_REQUIRED;
}
/*
@@ -995,7 +995,7 @@ static enum vendor_cmd_rc ccd_unlock(void *buf,
if (!input_size) {
*response_size = 1;
buffer[0] = EC_ERROR_PARAM_COUNT;
return VENDOR_RC_INTERNAL_ERROR;
return VENDOR_RC_PASSWORD_REQUIRED;
}
/*

1
include/tpm_vendor_cmds.h
View File

@@ -74,6 +74,7 @@ enum vendor_cmd_rc {
VENDOR_RC_NOT_ALLOWED = 7,
VENDOR_RC_NO_SUCH_SUBCOMMAND = 8,
VENDOR_RC_IN_PROGRESS = 9,
VENDOR_RC_PASSWORD_REQUIRED = 10,
/* Only 7 bits available; max is 127 */
VENDOR_RC_NO_SUCH_COMMAND = 127,