scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-29 18:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

skylake: Add workaround for boards that cannot save reset flags

Browse Source 
Some hardware has an issue where the reset flags are lost on power cycle
because the EC backup ram loses power.  This causes the flag to not power
on the AP (ap-off) to be lost.

In order to pass FAFT it is required that boards support this flag, so
this commit adds a workaround where the skylake chipset code will call into
the board to ask if it has working reset flags and if not it will skip the
PMIC reset if the "ap-off" flag has been set.

The "ap-off" flag is purely for testing, it is not possible for users to
do this without having access to the EC console.  (which is currently not
possible at all with CCD unless you can also build a debug cr50 image)

BUG=b:38187362,b:35585876
BRANCH=none
TEST=manual testing on Eve: execute 'reboot ap-off' and ensure that the
AP does not power on.  Also ensure that 'dut-control power_state:rec' works
as expected and does not power off at the recovery screen due to a power
button press.

Change-Id: If11e17179e9173509b9a6ae1ef0d94a50ba181d0
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://chromium-review.googlesource.com/514503
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
This commit is contained in:
Duncan Laurie
2017-05-24 13:08:05 -07:00
committed by chrome-bot
parent e69058a7a5
commit dcedeab2cc
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
power/skylake.c
View File

@@ -127,6 +127,12 @@ enum power_state power_handle_state(enum power_state state)
return new_state;
}
/* Workaround for flags getting lost with power cycle */
__attribute__((weak)) int board_has_working_reset_flags(void)
{
return 1;
}
#ifdef CONFIG_CHIPSET_HAS_PLATFORM_PMIC_RESET
static void chipset_handle_reboot(void)
{
@@ -147,8 +153,15 @@ static void chipset_handle_reboot(void)
return;
/* Preserve AP off request. */
if (flags & RESET_FLAG_AP_OFF)
if (flags & RESET_FLAG_AP_OFF) {
/* Do not issue PMIC reset if board cannot save reset flags */
if (!board_has_working_reset_flags()) {
ccprintf("Skip PMIC reset due to board issue.\n");
cflush();
return;
}
chip_save_reset_flags(RESET_FLAG_AP_OFF);
}
ccprintf("Restarting system with PMIC.\n");
/* Flush console */

6
power/skylake.h
View File

@@ -33,4 +33,10 @@
#define CHARGER_INITIALIZED_DELAY_MS 100
#define CHARGER_INITIALIZED_TRIES 40
/*
* Board can define this function to indicate to the skylake
* power code that it does not have working reset flags.
*/
int board_has_working_reset_flags(void);
#endif /* __CROS_EC_SKYLAKE_H */