scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-02 13:14:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update message protocol length byte to include postamble

Browse Source 
This simply changes the constant '4' to MSG_PROTO_BYTES, which
includes the postamble. This helps reduce magic constant values
used in processing a packet.

BUG=chrome-os-partner:8975
TEST=tested on daisy (with kernel mkbp driver change)

Signed-off-by: David Hendricks <dhendrix@chromium.org>
Change-Id: Id4634076ad63f45783354179dfebea4fd450fc1e
This commit is contained in:
David Hendricks
2012-04-20 17:06:24 -07:00
parent 66fa2685f0
commit e56ba2e689
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/message.c
View File

@@ -69,7 +69,7 @@ int message_process_cmd(int cmd, uint8_t *out_msg, int max_len)
*/
if (msg_len + MSG_PROTO_BYTES > max_len)
msg_len = max_len - MSG_PROTO_BYTES;
len = msg_len + 4;
len = msg_len + MSG_PROTO_BYTES;
ASSERT(msg_len >= 0 && msg_len < 0xffff);
need_copy = msg != out_msg + MSG_HEADER_BYTES;
ASSERT(!need_copy ||

4
include/message.h
View File

@@ -46,8 +46,8 @@ enum message_cmd_t {
* The hdr byte is just a tag to indicate that the real message follows. It
* signals the end of any preamble required by the interface.
*
* The 16-bit length includes the length of the header, len bytes, message
* and checksum, but not the final preamble byte.
* The 16-bit length is the entire packet size, including the header, length
* bytes, message payload, checksum, and postamble byte.
*
* The checksum is calculated as the sum of the header, len byte and message.
*