scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-12 19:04:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: TODOs in ec_commands.h

Browse Source 
Comment changes only; no code changes.

BUG=chrome-os-partner:11223
BRANCH=none
TEST=build all boards; pass unit tests

Change-Id: I8f6f57514886dd1fda0e44cae1b036c22be481f8
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/175228
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
This commit is contained in:
Randall Spangler
2013-10-31 09:50:42 -07:00
committed by chrome-internal-fetch
parent af8d3f9536
commit ea188ffdb7
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
common/host_command.c
View File

@@ -372,6 +372,7 @@ void host_command_task(void)
/*****************************************************************************/
/* Host commands */
/* TODO(crosbug.com/p/11223): Remove this once the kernel no longer cares */
static int host_command_proto_version(struct host_cmd_handler_args *args)
{
struct ec_response_proto_version *r = args->response;

13
include/ec_commands.h
View File

@@ -8,8 +8,13 @@
#ifndef __CROS_EC_COMMANDS_H
#define __CROS_EC_COMMANDS_H
/* Current version of this protocol */
/* TODO: This is effectively useless; protocol is determined in other ways */
/*
* Current version of this protocol
*
* TODO(crosbug.com/p/11223): This is effectively useless; protocol is
* determined in other ways. Remove this once the kernel code no longer
* depends on it.
*/
#define EC_PROTO_VERSION 0x00000002
/* Command version mask */
@@ -1764,8 +1769,8 @@ struct ec_params_sb_wr_block {
/* System commands */
/*
* TODO: this is a confusing name, since it doesn't necessarily reboot the EC.
* Rename to "set image" or something similar.
* TODO(crosbug.com/p/23747): This is a confusing name, since it doesn't
* necessarily reboot the EC. Rename to "image" or something similar?
*/
#define EC_CMD_REBOOT_EC 0xd2