scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2025-12-30 02:20:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

cr50: Update TODO comments with new bug numbers

Browse Source 
Just changing comments, no code.

BUG=chrome-os-partner:33432
BRANCH=none
TEST=make buildall -j

Change-Id: Ibffda40bff23a8c685feaef30a85e19157566245
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/229860
Reviewed-by: Randall Spangler <rspangler@chromium.org>
This commit is contained in:
Bill Richardson
2014-11-14 11:09:10 -08:00
committed by chrome-internal-fetch
parent ae55a28dfc
commit f154a8b95d
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
board/cr50/board.c
View File

@@ -14,7 +14,7 @@
/* Initialize board. */
static void board_init(void)
{
/* TODO(crosbug.com/p/33432): Try enabling this */
/* TODO(crosbug.com/p/33812): Try enabling this */
/* gpio_enable_interrupt(GPIO_CAMO0_BREACH_INT); */
}
DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);

2
board/cr50/gpio.inc
View File

@@ -5,7 +5,7 @@
*/
/* Inputs with interrupt handlers are first for efficiency */
/* TODO(crosbug.com/p/33432): try enabling this */
/* TODO(crosbug.com/p/33816): try enabling this */
/* GPIO(CAMO0_BREACH_INT, A, 0, GPIO_INT_BOTH, button_event) */
/* Outputs */

2
chip/g/clock.c
View File

@@ -302,7 +302,7 @@ static void switch_osc_to_xtl(void)
void clock_init(void)
{
/*
* TODO(crosbug.com/p/33432): The following comment was in the example
* TODO(crosbug.com/p/33813): The following comment was in the example
* code, but the function that's called doesn't match what it says.
* Investigate further.
*/

2
chip/g/config_chip.h
View File

@@ -19,7 +19,7 @@
#define CONFIG_FLASH_BASE 0x40000
#define CONFIG_FLASH_PHYSICAL_SIZE (512 * 1024)
/* flash chip specifics */
/* TODO(crosbug.com/p/33432): These are probably wrong. Don't use them yet. */
/* TODO(crosbug.com/p/33815): These are probably wrong. Don't use them yet. */
#define CONFIG_FLASH_BANK_SIZE 0x00000800 /* protect bank size */
#define CONFIG_FLASH_ERASE_SIZE 0x00000400 /* erase bank size */
#define CONFIG_FLASH_WRITE_SIZE 0x00000004 /* minimum write size */

2
chip/g/gpio.c
View File

@@ -7,7 +7,7 @@
#include "gpio.h"
#include "hooks.h"
/* TODO(crosbug.com/p/33432): We don't have any GPIOs defined yet! */
/* TODO(crosbug.com/p/33816): We don't have any GPIOs defined yet! */
test_mockable int gpio_get_level(enum gpio_signal signal)
{

4
chip/g/system.c
View File

@@ -11,7 +11,7 @@ void system_pre_init(void)
}
/* TODO(crosbug.com/p/33432): How do we force a reset? */
/* TODO(crosbug.com/p/33818): How do we force a reset? */
void system_reset(int flags)
{
@@ -32,7 +32,7 @@ const char *system_get_chip_revision(void)
return G_REVISION_STR;
}
/* TODO(crosbug.com/p/33432): Where can we store stuff persistently? */
/* TODO(crosbug.com/p/33822): Where can we store stuff persistently? */
int system_get_vbnvcontext(uint8_t *block)
{

2
chip/g/uart.c
View File

@@ -33,7 +33,7 @@ void uart_tx_start(void)
* UART where the FIFO only triggers the interrupt when its
* threshold is _crossed_, not just met.
*/
/* TODO(crosbug.com/p/33432): Do we need this hack here? Find out. */
/* TODO(crosbug.com/p/33819): Do we need this hack here? Find out. */
REG_WRITE_MASK(G_UART_ICTRL(0), 0x01, 0x01, 0);
task_trigger_irq(G_IRQNUM_UART0_TXINT);
}