scottk/OpenCellular
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/OpenCellular.git synced 2026-01-08 16:41:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

upgrade_fw: fw_upgrade_command_handler: fix cmd_size check

Browse Source 
body_size is unsigned so the comparison was always false

BUG=None
BRANCH=none
TEST=tested the update process on CR50 board using the usb_updater

Change-Id: I004ee94653656449ae6f8699f06422e925d9e1b6
Signed-off-by: Lucian Cojocar <cojocar@google.com>
Reviewed-on: https://chromium-review.googlesource.com/362082
Commit-Ready: Dan Shi <dshi@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
This commit is contained in:
Lucian Cojocar
2016-07-20 10:34:04 -07:00
committed by chrome-bot
parent 3d4c4ffdfa
commit fac4f79fc5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
chip/g/upgrade_fw.c
View File

@@ -102,12 +102,12 @@ void fw_upgrade_command_handler(void *body,
*/
*response_size = sizeof(*rv);
body_size = cmd_size - offsetof(struct upgrade_command, block_body);
if (body_size < 0) {
if (cmd_size < offsetof(struct upgrade_command, block_body)) {
CPRINTF("%s:%d\n", __func__, __LINE__);
*rv = UPGRADE_GEN_ERROR;
return;
}
body_size = cmd_size - offsetof(struct upgrade_command, block_body);
if (!cmd_body->block_base && !body_size) {
/*