mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2026-01-05 06:21:53 +00:00
9ca2b4c775
x86 devices use TPM_RST_L to detect the AP state, so we set device_states[DETECT_AP].detect to GPIO_TPM_RST_L on those boards. board_update_device_state uses this signal to poll the AP state once a second to detect if the device is off. If for some reason TPM_RST_L is deasserted, but the tpm reset handler has not yet set the state to 'on', we will catch it when we poll the AP state with board_update_device_state. It will call device_state_on with TPM_RST_L. In that case device_state_on used to silently disable the TPM_RST_L interrupt and not change the AP state. This change modifies device_state_on to notify the tpm reset handler and prevent it from disabling the tpm reset interrupt. BUG=chrome-os-partner:62748 BRANCH=none TEST=disable the deferred_tpm_rst_isr call in configure_board_specific_gpios. Close the lid and wait 5 minutes. Open the lid. Verify cr50 prints "device_state_on: tpm_rst_isr hasn't set the AP state to 'on'" and the system boots normally. Change-Id: I6e5b722fab6e7b0acb91dda0e5207e4411e97363 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/439816 Reviewed-by: Aaron Durbin <adurbin@chromium.org>
For an overview of the Embedded Controller firmware, refer to http://www.chromium.org/chromium-os/2014-firmware-summit For instructions on building from source, refer to http://www.chromium.org/chromium-os/ec-development/getting-started-building-ec-images-quickly