Shawn Nematbakhsh e4deceba8d charger: Prevent SET access to EC_CMD_CHARGE_STATE on locked systems ...

The SET sub-command of EC_CMD_CHARGE_STATE sets charger current /
voltage parameters to arbitrary values and should be locked down.
EC_CMD_CHARGE_CONTROL, on the other hand, switches between several safe
operation modes, and should be allowed.

BUG=None
TEST=On kevin, set force_locked, plug zinger, and verify:
ectool chargestate param 4 3 <-- ACCESS_DENIED
ectool chargestate show <-- prints params
ectool chargecontrol idle <-- stops charging battery
ectool chargecontrol normal <-- battery charges again
BRANCH=None

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I5503f07bb196d023a9bcd2e33f2e247f061f05e5
Reviewed-on: https://chromium-review.googlesource.com/757237
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

2017-11-09 16:43:54 -08:00

..

vboot

Fizz: Show critical error on LED for recovery request

2017-09-29 11:24:37 -07:00

acpi.c

host_event: Move host events and mask handling into common code

2017-10-17 23:14:19 -07:00

adc.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

als.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

ap_hang_detect.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

backlight_lid.c

Support backlight control via lid only

2013-09-27 23:07:21 +00:00

base32.c

common: Substitute modified CRC8 with CRC-5-USB

2017-09-12 16:17:03 -07:00

battery.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

bluetooth_le.c

btle: Cleanup: Moved constants, renamed functions

2016-08-11 14:46:33 -07:00

btle_hci_controller.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

btle_ll.c

btle_ll.c: Initialize variables to fix GCC warnings

2016-11-16 19:04:31 -08:00

build.mk

cleanup: Use CONFIG_BATTERY to indicate whether a board has a battery

2017-10-13 14:45:16 -07:00

button.c

common/button: Ensure debug mode exits on timeout

2017-08-07 13:50:47 -07:00

capsense.c

Deferred: Use deferred_data instead of function pointer

2016-04-18 17:32:40 -07:00

ccd_config.c

ccd: pass 'ccd password' execution through tpm task context

2017-10-27 16:14:16 -07:00

charge_manager.c

charge_manager: Enter safe mode at boot

2017-11-02 23:21:52 -07:00

charge_ramp_sw.c

chg_ramp: Add charge_is_consuming_full_input_current().

2017-11-01 16:47:21 -07:00

charge_ramp.c

charge_ramp: Ramp USB-C DTS sources

2017-10-19 12:56:42 -07:00

charge_state_v2.c

charger: Prevent SET access to EC_CMD_CHARGE_STATE on locked systems

2017-11-09 16:43:54 -08:00

charger_profile_override.c

charger_profile: support multiple battery voltage range thresholds

2017-02-10 19:02:55 -08:00

charger.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

chipset.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

clz.c

Add option to enable GCC LTO

2015-05-19 02:46:27 +00:00

console_output.c

Cr50: The chan command is not safe.

2016-10-01 03:13:43 +00:00

console.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

crc8.c

crc8: Support crc calculation across non-contiguous data

2016-03-18 22:16:53 -07:00

crc.c

Move software CRC implementation to common

2014-08-08 03:11:38 +00:00

curve25519-generic.c

core/cortex-m0/curve25519: Integrate fast curve25519 implementation

2017-07-03 21:44:34 -07:00

curve25519.c

core/cortex-m0/curve25519: Integrate fast curve25519 implementation

2017-07-03 21:44:34 -07:00

device_event.c

Add support for reporting device events

2017-06-30 03:08:42 -07:00

device_state.c

cr50: Clean up device state code

2017-08-08 17:34:09 -07:00

dptf.c

eve: Move DPTF tablet mode support to common code

2017-02-14 14:50:36 -08:00

ec_features.c

host_event_commands: Add support for always reporting masks

2017-10-18 23:14:18 -07:00

ec.libsharedobjs.ld

build-infr: Add support for shared RO library.

2015-07-17 03:17:50 +00:00

event_log.c

pd_log: Make PD logging more generic for general purpose logging

2017-08-02 15:02:34 -07:00

extension.c

cr50: handle board ID mismatch gracefully

2017-06-16 21:10:54 -07:00

extpower_gpio.c

extpower: Allow board to override signal debounce time

2016-09-02 07:11:33 -07:00

fan.c

Fizz: Modify thermal table

2017-11-06 13:48:38 -08:00

firmware_image.lds.S

npcx: Build RW_B and support sysjump to it

2017-07-13 19:45:57 -07:00

firmware_image.S

npcx: Build RW_B and support sysjump to it

2017-07-13 19:45:57 -07:00

flash.c

EFS: Switch active slot when current slot is invalid

2017-09-21 01:07:55 -07:00

fmap.c

Fizz: Add EC_RW_B in FMAP

2017-10-17 13:02:49 -07:00

gesture.c

Fix various misspellings in comments

2016-11-15 17:41:53 -08:00

gpio_commands.c

Cr50: Mark several console commands as safe

2016-08-31 17:20:26 +00:00

gpio.c

gpio: Move gpio_get_ternary to common gpio functions

2017-06-11 23:17:19 -07:00

hooks.c

Clean up CONFIG_CASE_CLOSED_DEBUG usage

2017-09-01 16:41:55 -07:00

host_command_master.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

host_command_pd.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

host_command.c

host_command: Add flags1 to host_command_get_features

2017-10-18 23:14:17 -07:00

host_event_commands.c

lpc: Add and use lpc_resume_clear_masks

2017-10-31 13:04:58 -07:00

i2c_master.c

i2c: rand of i2ctest console command is unsigned

2017-09-13 19:28:30 -07:00

i2c_slave.c

i2c: separate slave and master code

2017-04-26 13:37:04 -07:00

i2c_wedge.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

i2cs_tpm.c

tpm: provide means of shutting down comms layer while in reset

2017-11-07 17:52:15 -08:00

inductive_charging.c

Deferred: Use deferred_data instead of function pointer

2016-04-18 17:32:40 -07:00

keyboard_8042_sharedlib.c

keyboard_8042: Allow scancode sets to be mutable

2017-05-18 18:07:29 -07:00

keyboard_8042.c

Fix keyboard in systemd-boot

2017-10-19 14:56:09 -07:00

keyboard_mkbp.c

MKBP: Add kbpress for boards w/o keyscan tasks.

2017-07-28 17:45:14 -07:00

keyboard_scan.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

keyboard_test.c

Move keyboard dimension and key constants to keyboard_config.h

2013-03-22 11:24:29 -07:00

lb_common.c

cleanup: Remove 'ryu' board

2017-09-11 11:14:24 -07:00

led_common.c

common/led_common: Add API for controlling LED state

2017-05-02 17:45:16 -07:00

led_policy_std.c

led_policy_std: turn off power led when system shutdown

2017-04-13 12:55:33 -07:00

lid_angle.c

oak: enable lid angle update

2016-03-02 13:39:47 -08:00

lid_switch.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

lightbar.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

mag_cal.c

common: Add magnetometer online calibration.

2015-10-13 05:28:54 -07:00

main.c

host_event: Perform lpc_init_mask before keyboard/button init

2017-10-24 12:57:45 -07:00

mat33.c

common: Add magnetometer online calibration.

2015-10-13 05:28:54 -07:00

mat44.c

common: Add magnetometer online calibration.

2015-10-13 05:28:54 -07:00

math_util.c

math_util: Use HW instruction for int_sqrtf when available

2017-06-19 15:33:09 -07:00

memory_commands.c

Add more CONFIG_CMD_* options for console commands

2016-10-01 00:02:01 -07:00

mkbp_event.c

power: Allow host to request higher-power wakeable S3

2017-07-28 15:04:24 -07:00

motion_lid.c

motion_lid: Increase precision in noisy mag check.

2017-07-13 08:32:58 -07:00

motion_sense.c

sensors: Support device with only one accelerometer

2017-08-30 03:58:29 -07:00

nvcounter.c

Add non-volatile flash counter

2017-06-02 10:38:57 -07:00

nvmem_vars.c

cr50: Store console lock state in NvMem vars.

2017-02-27 18:50:12 -08:00

nvmem.c

cr50: Make sure TPM wipe only clears TPM data.

2017-02-23 01:19:07 -08:00

onewire.c

Move onewire bus support from chip/lm4 to common

2013-08-02 18:22:57 -07:00

panic_output.c

Cr50: The panicinfo command is not safe

2016-10-01 03:14:07 +00:00

pd_log.c

pd_log: Make PD logging more generic for general purpose logging

2017-08-02 15:02:34 -07:00

physical_presence.c

pp: remove superfluous newline character

2017-09-12 16:17:05 -07:00

port80.c

port80: Clean up macros

2017-10-31 13:04:59 -07:00

power_button_x86.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

power_button.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

printf.c

console: Add non-verbose print config option

2017-02-11 13:06:38 -08:00

pstore_commands.c

pstore: Fix issue with block calculation for pstore blocks

2017-01-03 15:13:58 -08:00

pwm_kblight.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

pwm.c

pwm: PWM is disabled when duty is set to max value

2016-09-08 17:57:51 -07:00

queue_policies.c

Stream: Remove in_stream/out_stream interface

2015-06-11 00:08:49 +00:00

queue.c

Queue: Add ability to modify contiguous units inplace

2015-07-15 21:57:36 +00:00

rma_auth.c

rma: process proper auth code

2017-10-24 12:57:45 -07:00

rollback.c

rollback: Add function to fetch secret

2017-06-14 01:19:31 -07:00

rsa.c

common/rsa: Add support for exponent 3 RSA keys

2016-11-10 21:28:28 -08:00

rtc.c

rtc: Add functions and tests for time conversion

2017-09-26 18:24:07 -07:00

rwsig.c

Fix inconsistent task function declarations

2017-08-08 14:56:13 -07:00

sensor_common.c

console: Add non-verbose print config option

2017-02-11 13:06:38 -08:00

sha1.c

Add SHA-1 hash

2014-05-17 20:14:17 +00:00

sha256.c

common/sha256: agressive SHA-256 unrolling as an option

2017-09-11 04:42:59 -07:00

shared_mem.c

Cr50: Mark several console commands as safe

2016-08-31 17:20:26 +00:00

shmalloc.c

common: introduce malloc/free implementation

2017-01-05 21:13:09 -08:00

smbus.c

smbus: Re-write smbus driver

2016-03-21 16:35:33 -07:00

spi_commands.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

spi_flash_reg.c

npcx: flash: Add write-protect support for internal flash of npcx7 ec

2017-05-12 20:58:09 -07:00

spi_flash.c

Enable spi_flash_read to read > SPI_FLASH_MAX_READ_SIZE

2016-10-05 20:58:37 -07:00

spi_nor.c

common/spi_nor: Differential erase support

2017-02-09 05:04:56 +00:00

switch.c

Allow lid-less configuration

2017-05-09 23:20:07 -07:00

system.c

EFS: Sysjump to active copy

2017-10-17 13:02:49 -07:00

tablet_mode.c

motion: Disable tablet mode if one accel is broken

2017-01-04 18:07:12 -08:00

temp_sensor.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

test_util.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

thermal.c

Fizz: Modify thermal table

2017-11-06 13:48:38 -08:00

throttle_ap.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00

timer.c

timer: Add note about forcetime command being unsafe

2017-09-01 14:41:52 -07:00

tpm_log.c

tpm: Add optional event logging

2017-08-10 22:47:24 -07:00

tpm_registers.c

cr50: fix event definition collision

2017-11-07 17:52:15 -08:00

u2f.c

g: use deterministic k for individual attestation certificate ECDSA

2017-08-03 19:23:22 -07:00

uart_buffering.c

uart: fix compile warning when !defined CONFIG_CONSOLE_ENABLE_READ_V1

2017-05-12 13:09:54 -07:00

update_fw.c

update_fw: Store complete touchpad FW hash

2017-09-15 10:50:27 -07:00

usb_charger.c

bd99955: Improve interrupt / USB charger task wake scheme

2016-06-16 12:27:42 -07:00

usb_i2c.c

usb_i2c: Fail if board I2C bridge is disabled

2017-07-31 21:39:39 -07:00

usb_pd_policy.c

PD: Make current USB PD Stack REV 3 compliant

2017-10-24 15:30:15 -07:00

usb_pd_protocol.c

pd: Add pd_capable() to check PD capability of partner port

2017-11-07 12:17:44 -08:00

usb_pd_tcpc.c

PD: Make current USB PD Stack REV 3 compliant

2017-10-24 15:30:15 -07:00

usb_port_power_dumb.c

usb_port_power: Allow variable number of ports

2017-05-01 21:54:10 -07:00

usb_port_power_smart.c

usb_port_power_smart: Add CDP/SDP only option.

2017-08-28 15:24:10 -07:00

usb_update.c

update_fw: Store complete touchpad FW hash

2017-09-15 10:50:27 -07:00

util.c

common: Use SVr4/4.3BSD/C89/C99 prototype for strlen

2017-08-18 14:27:23 -07:00

vboot_hash.c

vboot: Add error message in hash command

2017-09-29 23:25:38 -07:00

vec3.c

common: Add magnetometer online calibration.

2015-10-13 05:28:54 -07:00

version.c

common/rollback: Add support for rollback protection

2017-04-06 03:29:38 -07:00

virtual_battery.c

virtual_battery: Avoid unexpected batt_mode_cache refreshing

2017-09-25 21:06:52 -07:00

vstore.c

ec: Add temporary secure storage for the host during boot

2016-01-25 21:46:48 -08:00

webusb_desc.c

Add WebUSB descriptor support

2017-09-22 10:18:50 -07:00

wireless.c

cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

2016-08-24 16:30:10 +00:00