mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-28 02:35:28 +00:00
eb70d3cda7
The struct lightbar_params used to communicate lightbar settings between the AP and the EC uses just "int" for some of its fields. The AP currently uses 32-bit values for "int" in both 64-bit and 32-bit mode, but that's just luck since C only requires that "int" be at least 16 bits. This change makes the size explicit. BUG=none BRANCH=none TEST=manual There should be no visible change. ectool lightbar params > /tmp/foo ectool lightbar params /tmp/foo Change-Id: I4d77c16b3c68e179292b824938d2d012e917ad13 Signed-off-by: Bill Richardson <wfrichar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/176364 Reviewed-by: Yung-chieh Lo <yjlou@chromium.org>
In the most general case, the flash layout looks something like this: +---------------------+ | Reserved for EC use | +---------------------+ +---------------------+ | Vblock B | +---------------------+ | RW firmware B | +---------------------+ +---------------------+ | Vblock A | +---------------------+ | RW firmware A | +---------------------+ +---------------------+ | FMAP | +---------------------+ | Public root key | +---------------------+ | Read-only firmware | +---------------------+ BIOS firmware (and kernel) put the vblock info at the start of each image where it's easy to find. The Blizzard EC expects the firmware vector table to come first, so we have to put the vblock at the end. This means we have to know where to look for it, but that's built into the FMAP and the RO firmware anyway, so that's not an issue. The RO firmware doesn't need a vblock of course, but it does need some reserved space for vboot-related things. Using SHA256/RSA4096, the vblock is 2468 bytes (0x9a4), while the public root key is 1064 bytes (0x428) and the current FMAP is 644 bytes (0x284). If we reserve 4K at the top of each FW image, that should give us plenty of room for vboot-related stuff.