mirror of
https://github.com/Telecominfraproject/OpenCellular.git
synced 2025-12-28 02:35:28 +00:00
ec5c396b47
word_in_value shouldn't be able to be used without being initialized, so just initialize it to make GCC 5.3 happy. It's configured separately in the (last_write_pointer & 3) and (!(last_write_pointer & 3)) paths, so it can't actually slip through uninitialized. There is probably a way to rwrite this that won't confuse GCC as much, but I haven't found it yet. The solutions I did try generally ended up increasing the binary size, so I'm falling back to just initializing the variable. chip/g/i2cs.c: In function '_i2cs_write_complete_int': chip/g/i2cs.c:178:19: error: 'word_in_value' may be used uninitialized in this function [-Werror=maybe-uninitialized] This does not change the size of any ec.*.flat file. BRANCH=none BUG=none TEST=build succeeds under GCC 4.9.2, 5.3 and 6.2 Change-Id: Iaf8641b3d252c494ad13fbeb8ad8ece3cdfe6e76 Signed-off-by: Martin Roth <martinroth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/403504 Reviewed-by: Shawn N <shawnn@chromium.org>
For an overview of the Embedded Controller firmware, refer to http://www.chromium.org/chromium-os/2014-firmware-summit For instructions on building from source, refer to http://www.chromium.org/chromium-os/ec-development/getting-started-building-ec-images-quickly